- 06 Apr, 2018 40 commits
-
-
Daniel Bratell authored
In jumbo build experiments the presence of two different OnCheckIsDefaultBrowserFinished functions meant that Bind didn't know which one to bind and it didn't compile. This patch renames one OnCheckIsDefaultBrowserFinished to OpenURLAfterCheckIsDefaultBrowser which seems like a good name for that function. Bug: 803406 Change-Id: I056e613b7e3d55c0b2dbde68db8d75d3e2c55876 Reviewed-on: https://chromium-review.googlesource.com/998152Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548712}
-
Daniel Bratell authored
In jumbo build experiments (no jumbo for chromium/browser/ui yet) two GetProfileFromWebContents ended up in the same translation unit. Each of them was only used once. This inlines them both. I dropped the null check from the GetProfileFromWebContents() in account_chooser_dialog_view.cc because if that helper returned null, then the code would already crash inside GetDefaultStoragePartition() (GetStoragePartitionFromConfig() will call browser_context->IsOffTheRecord() without any null check). Bug: 803406 Change-Id: I0200eb42c0a54b674eaec6122e1193c931dd2344 Reviewed-on: https://chromium-review.googlesource.com/997793Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548711}
-
Darren Shen authored
Test consistently failing on Mac10.11 and flaky on Mac10.10. TBR=nednguyen@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: 829161 Change-Id: I89fc7186a5c3c76853ec666bca57409e76950d73 Reviewed-on: https://chromium-review.googlesource.com/999232 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#548710}
-
Gauthier Ambard authored
This CL change the navigation history menu to be the new navigation menu by default when the UI Refresh flag is enabled. Bug: 804779, 828771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib0bc001275102400538d989f1e7af744a8e1d18a Reviewed-on: https://chromium-review.googlesource.com/995441 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#548709}
-
Kenichi Ishibashi authored
Before this CL, DeleteSoon() could be called twice when a connection error happens on |url_loader_binding_|. - ServiceWorkerSubresourceLoader sets DeleteSoon() as the connection error handler. - The class also calls DeleteSoon() when the loader is no longer needed. For example, it delete itself when a request falls back to network. After this CL we just call delete directly as needed. Existing DeleteSoon() is renamed to OnConnectionError() as it is only used as the connection error handler. Bug: 828257 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I85737d0d6c33b747a4f70f5156b2b3b4b512f873 Reviewed-on: https://chromium-review.googlesource.com/997256 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#548708}
-
Koji Ishii authored
Following bot results are included. 4591 4592 4593 4595 4597 4599 4602 4606 4607 6 lines were removed and 18 lines were deflaked by consecutive results since 4542. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9f5e4be8dfc280e99d9a78e0808c26488944a093 Reviewed-on: https://chromium-review.googlesource.com/997321 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548707}
-
https://skia.googlesource.com/skia.git/+log/bf74a460814a..7768fa17b795 $ git log bf74a4608..7768fa17b --date=short --no-merges --format='%ad %ae %s' 2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ dd196e0bc..c3755fc56 (5 commits) 2018-04-05 caryclark remove SK_IGNORE_TO_STRING 2018-03-29 bungeman Distinguish between glyphs with empty path and no path. 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 6959d4597..24c91d143 (1 commit) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d75edb2e3..6959d4597 (1 commit) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ a7974d9f6..d75edb2e3 (1 commit) 2018-04-05 fmalita Clip SlideDir slides to their declared dimensions 2018-04-05 bungeman Mac to better serialize OTTO fonts. 2018-04-05 robertphillips Revert "Remove deprectated GrContext::MakeGL overloads that take raw ptr" 2018-04-05 bsalomon Remove SK_DISABLE_TEXTURE_OP_AA 2018-04-05 fmalita [viewer] Consolidate external slide loading 2018-04-05 liyuqian Flush before snap SkThreadedBMPDevice 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 3cb9ba6ae..a7974d9f6 (3 commits) 2018-04-04 bryct Update 'Working in a Chromium repo' documentation. 2018-04-05 kjlubick Avoid nonsortable rects in drawRect/drawOval 2018-04-04 bsalomon Remove deprectated GrContext::MakeGL overloads that take raw ptr 2018-04-05 bsalomon Add maxTextureSize()/maxRenderTargetSize() to GrContext 2018-04-05 fmalita Viewer SVG support 2018-04-04 bungeman Via*::draw to finish before checking. 2018-04-05 reed replace size-alignment assert with round-down 2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ bc54342bf..dd196e0bc (14 commits) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d26d270c8..3cb9ba6ae (7 commits) 2018-04-02 halcanary SkPDF: implement xheight for type3 fonts 2018-04-05 robertphillips Add GrBackendTexture/RenderTarget accessors to SkSurface 2018-04-05 robertphillips Add SK_API to SkSurfaceCharacterization 2018-04-03 halcanary experimental/tools: minor code cleanup 2018-04-04 brianosman Workaround for lack of ESSL3 external image extension on older Samsung devices 2018-04-05 caryclark tweak SkImage documentation 2018-04-05 robertphillips Fix iOS bot in Chrome CQ 2018-04-05 update-docs Update markdown files 2018-04-04 bsalomon Avoid calling glGetString(GL_EXTENSIONS) on core profiles 2018-04-04 bsalomon Stop using clear-as-draw workaround on newer Intel drivers on macOS 2018-04-04 liyuqian Ensure that pointers/arrays are valid until flush in threaded backend 2018-04-04 benjaminwagner Add loongson3a Build jobs. 2018-04-04 robertphillips Add GrBackendTexture accessor to SkImage (take 2) 2018-04-04 reed move SkIPoint16 to private header 2018-04-04 benjaminwagner Update mips64el_toolchain_linux to GCC 7 2018-04-04 fmalita Fix SkLocalMatrixShader nesting semantics 2018-04-04 egdaniel Make sure we set the origin when initDescForDstCopy fails 2018-04-04 fmalita Banish SkShaderBase::isRasterPipelineOnly() Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I8a5d0c4e84954bcebd8fc4e09327cc0cb009975a Reviewed-on: https://chromium-review.googlesource.com/998395Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548706}
-
Darren Shen authored
We cannot support background-repeat and background-position yet because they are both implemented as shorthands in Blink, but are not shorthands in the spec. We'd need to refactor the existing code to allow shorthands to reify as proper Typed OM objects. There are also some tricky bits to support styleMap.set with shorthands given a proper Typed OM object. Bug: 820299 Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f Reviewed-on: https://chromium-review.googlesource.com/994593 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548705}
-
Xiaohan Wang authored
This CL adds DeferredDestroyStrongBindingSet such that mojom::Foo impl will only be destroyed when: - mojom::Foo connection error happens, AND FooImpl calls the DestroyCallback, or - DeferredDestroyStrongBindingSet is destroyed. This helps solve tricky lifetime issues where we do not want destroy the implementation immediately. For example, currently when connection error on mojom::CdmFactory happens, CdmFactoryImpl will be destroyed, which will also destroy all CDMs owned by CdmFactoryImpl. However, this could happen before MojoCdm is stopped in the render process, causing unexpected behavior. See the bug for more details. This CL also fixes the CdmFactoryImpl lifetime issue by using the DeferredDestroyStrongBindingSet, and let CdmFactoryImpl only call the DestroyCallback when no outstanding CDMs exist. For historical context, mojo::StrongBindingSet was originally added also to solve lifetime issues around media::mojom::InterfaceFactory, the predecessor of media::mojom::CdmFactory. See https://codereview.chromium.org/2530613003/. Bug: 821171 Test: Added new BindingSetTest cases. Change-Id: I24a660e8b62720f7fd772db1bafb9499cb71428c Reviewed-on: https://chromium-review.googlesource.com/969655 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#548704}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 825684 Change-Id: Ie54a02067aa896ec6ff386cfd6283f482217a238 Reviewed-on: https://chromium-review.googlesource.com/997194 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548703}
-
https://chromium.googlesource.com/angle/angle.git/+log/00af463e03ef..c3755fc56611 $ git log 00af463e0..c3755fc56 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 jmadill Vulkan: Move Streaming data to VertexArrayVk. 2018-04-05 jmadill Context: Release surface first in onDestroy. 2018-04-05 jani.hautakangas GLIBC fix: size_t requires include <stddef.h> 2018-04-05 lucferron Vulkan: Bugfix in depth/stencil clearing 2018-04-04 oetuaho Guard traversers used during parsing against stack overflow 2018-04-04 lucferron Vulkan: Implement color mask and depth mask bits 2018-04-04 oetuaho Identify functions by unique id in BuiltInFunctionEmulator 2018-03-31 jmadill Vulkan: Rename StreamingBuffer to DynamicBuffer. Created with: roll-dep src/third_party/angle BUG=chromium:823856 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I6c11e330653afa936d5ffe006c0d30515b0e6219 Reviewed-on: https://chromium-review.googlesource.com/999005Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548702}
-
Ramin Halavati authored
README.md files in tools/traffic_annotation are updated. Bug: 690323 Change-Id: Ida0be2dac2f19465650407385d0da66d71277fc1 Reviewed-on: https://chromium-review.googlesource.com/964145 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#548701}
-
Makoto Shimazu authored
Previously we use network::MojoToNetIOBuffer, and it ensures CompleteRead() is called when its destruction. However, CompleteRead() may be called again when a SWCacheWriter gets destructed after a write has done and ReleaseHandle() has been called. This CL avoids that by using WrappedIOBuffer instead of MojoToNetIOBuffer. TEST=content_unittests '--gtest_filter=ServiceWorkerNewScript*' with patching crrev.com/c/957918 Bug: 820540 Change-Id: I3419feaca83aca277a4216970104bceeb423506a Reviewed-on: https://chromium-review.googlesource.com/991626Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548700}
-
Chandan Padhi authored
MediaStreamTrack's clone should have the same state. This CL ensures that MediaStreamTrack.clone().readyState returns the same value as MediaStreamTrack.readyState. Bug: 669212 Change-Id: I7547aff039ecdef5fb6d059957ea3566c798d86f Reviewed-on: https://chromium-review.googlesource.com/996837 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#548699}
-
Kunihiko Sakamoto authored
These metrics were added to collect peak memory stats during page load. These have been disabled on Windows due to performance regression, but have non-negligible overhead on other platforms too. We have collected enough data for our experiment, so let's remove them. Bug: 825081 Change-Id: I2cedc5982538127074b6e2c271b4d51aef14ad4f Reviewed-on: https://chromium-review.googlesource.com/961982Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#548698}
-
Darren Shen authored
border-radius-* tests are failing because the computed value should always be a pair of values, but Blink currently returns a CSSValuePair with kDropIdenticalValue, so we sometimes compute to a single value. Fixing this requires either changing computed border-radius-* to use kKeepIdenticalValue, or overriding the computed value just for Typed OM [1] [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229 Bug: 820299 Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8 Reviewed-on: https://chromium-review.googlesource.com/994433 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/4c9b3c840df3..19aab2ee7c6b $ git log 4c9b3c840..19aab2ee7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:812974,chromium:827080,chromium:None,chromium:794210,chromium:825524 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If6b26fb8305b2e0d8c796358684d52a63d181a77 Reviewed-on: https://chromium-review.googlesource.com/999352Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548696}
-
Xiaocheng Hu authored
The function accepts |caret_offset| at either left or right edge of |inline_box|. This patch adds DCHECKs to ensure it. Bug: 822575 Change-Id: I247361097f37f0cd9922442ea8c050f88136d9fc Reviewed-on: https://chromium-review.googlesource.com/999021Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit 30d1f4de. Reason for revert: appears to be causing capacity issues, see https://crbug.com/829187 Original change's description: > Re-enable viz_browser_tests on Windows > > Previously we disabled the viz_browser_tests on Windows due to a large volume of flaky timeouts. We've disabled those tests via a filter file, and our FYI bots have stabilized. > > This change re-enables them on the Windows configurations. > > Change-Id: I5976ea8ad0cb2738e884878a7502eaabf0801bde > Reviewed-on: https://chromium-review.googlesource.com/960592 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546310} TBR=dpranke@chromium.org,jonross@chromium.org Change-Id: I58fc2675990338160221e7de49333db464740831 Bug: 829569 Reviewed-on: https://chromium-review.googlesource.com/998398 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#548694}
-
Ramya Nagarajan authored
The label is updated for Mac, to be in line with the native menu label. For more details, see http://go/chrome-emojisertion. Bug: 827404 Change-Id: Iafd9ee104fd1d46d6b4141d313e427fbeabc64b5 Reviewed-on: https://chromium-review.googlesource.com/999008 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
-
Kent Tamura authored
also, add test cases. Bug: 825684 Change-Id: I0ce0bbbd5b4c218042f934264ab4de288eba9dae Reviewed-on: https://chromium-review.googlesource.com/997316Reviewed-by:
-
David Benjamin authored
Having the logic in the SSLConnectJob, while easier on the socket pools, interacts badly with the proxy tunneling logic, which bypasses the SSLConnectJob layer and so we lose the state on whether we were retrying. The end result is, if the origin always resets the connection, we retry without bound. This doesn't cause connections that would otherwise succeeded to fail, but it's still not great. Instead, go back to our tried and true mechanism of trying at HttpNetworkTransaction, at the cost of more socket pool bifurcation. Note this comes with a slight change in metrics, due to things shifting around: Net.SSL_Connection_Error will report the original error code (e.g. ERR_CONNECTION_RESET) rather than ERR_SSL_VERSION_INTERFERENCE. Net.ErrorCodesForMainFrame and user-visible errors remain the same. Additionally, rather than do a lot of work to plumb Net.SSLVersionInterferenceDetails's information up, I've just removed that metric. It was useful when we were developing the protocol workarounds for the various non-compliant enterprise middleboxes, but now that the workarounds are applied, we don't need it anymore. On the test side of things, the existing ERR_SSL_VERSION_INTERFERENCE tests were sufficiently high-level that they cover this new implementation too. I've additionally added a regression test to cover this particular issue. Bug: 823387 Change-Id: Ia0b5b18c4cfa65fed55f7c1d937623ab37ff741d Reviewed-on: https://chromium-review.googlesource.com/990812Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#548691}
-
Andrey Lushnikov authored
This patch introduces a new Page.navigatedWithinDocument event that is fired whenever a same-document navigation happens. Same-document navigation might happen due to History API usages or due to a call to Page.navigate that changes only anchor. R=dgozman, pfeldman Change-Id: I1e702606a97f26511806a0d7328490613dc46246 Reviewed-on: https://chromium-review.googlesource.com/999115 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#548690}
-
Esmael El-Moslimany authored
Bug: 711156 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2847a86c7ec3671db79e524a25fa15c08193455 Reviewed-on: https://chromium-review.googlesource.com/996768Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#548689}
-
https://chromium.googlesource.com/catapult.git/+log/7b821dff5984..aaeb23e97cd1 $ git log 7b821dff5..aaeb23e97 --date=short --no-merges --format='%ad %ae %s' 2018-04-06 shend Disable testAwaitedEventIsConfigurable on Mac due to consistent failure Created with: roll-dep src/third_party/catapult BUG=chromium:829346 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Icd104ba687f402acf89f74e17ff83db43c0a1e4c Reviewed-on: https://chromium-review.googlesource.com/999180 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548688}
-
Ramin Halavati authored
Updates docs/network_traffic_annotations.md Bug: 656607 Change-Id: Ib9381a89f0458bbb99134a976ea96fdad12a3959 Reviewed-on: https://chromium-review.googlesource.com/966222 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch refactors the function by wrapping certain logic into IsEndOfDifferentDirection(), so that the remaining function body is symmetric for left and right edge of |inline_box|. This allows further refactoring, and also eases implementation of NG version of bidi adjustment. Bug: 822575 Change-Id: I40874a50fd07592d42afe6f596bc3481b41b9932 Reviewed-on: https://chromium-review.googlesource.com/997135Reviewed-by:
-
Charlie Harrison authored
This CL also adds a TODO to fix subframe transition metrics, but does not actually fix them yet. Bug: 827592 Change-Id: I95835ad2911046b402a41d3e5dcedf7b7735911a Reviewed-on: https://chromium-review.googlesource.com/992392Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#548685}
-
Fabrice de Gans-Riberi authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/3748a2a90871..10d701fce52d $ git log 3748a2a90..10d701fce --date=short --no-merges --format='%ad %ae %s' 2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep src/buildtools TBR=glider@chromium.org Bug: 812974 Change-Id: I69ab175249b68a0b3bc9a1982556ba0305d8a3a4 Reviewed-on: https://chromium-review.googlesource.com/996481Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548684}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I6b4d582ba9e1d53dfddebacc8baec199eb311271 Reviewed-on: https://chromium-review.googlesource.com/985995 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#548683}
-
https://pdfium.googlesource.com/pdfium.git/+log/14f8897509d9..4862705090a7 $ git log 14f889750..486270509 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 tsepez Make Internal field usage in cfxjs_engine match README.doc 2018-04-05 thestig Combine if/else blocks in CPDF_DIBSource::TranslateScanline24bpp(). 2018-04-05 thestig Split CPDF_DIBSource::TranslateScanline24bpp(). 2018-04-05 thestig Fix const casts in CPDF_Encryptor. 2018-04-05 thestig Get rid of a const_cast in CPDF_FlateEncoder. 2018-04-05 thestig Remove some const_casts in CPDF_Creator. 2018-04-05 dsinclair Make CXFA_Document::m_rgGlobalBinding private 2018-04-05 dsinclair Remove unused param. 2018-04-05 dsinclair Move document data merge code into CXFA_Document file 2018-04-05 rharrison Remove unused XFA Widget API methods 2018-04-05 thestig Ignore bad data in the shared object hint table. 2018-04-05 thestig Roll pdfium/third_party/freetype/src/ 7109495c5..26ad1acbc (2 commits) Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9f57c5782c3ec5ccaf49232d714bff5308f2cbd9 Reviewed-on: https://chromium-review.googlesource.com/999011Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548682}
-
chaopeng authored
This patch is for set the scroll_event_phase_ kNone as default in ctor. It hits DCHECK in MakeWebMouseWheelEventFromUiEvent() if the field not set. Bug: 647140 Change-Id: I3fd523bd84788957d0d05770fa70503be619e4ad Reviewed-on: https://chromium-review.googlesource.com/998755Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548681}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5e02fa85..3e5f91d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I85a5e025f2aefecd425af0e9c287eb3a3653d89f Reviewed-on: https://chromium-review.googlesource.com/998935Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#548680}
-
Ramin Halavati authored
Fix traffic annotation auditor bug, when no path filter was provided and --no-filtering switch was passed, no file was processed. Bug: 690323 Change-Id: I0235a4c30cf985cf68d7f05080c64bc26f4a29d8 Reviewed-on: https://chromium-review.googlesource.com/958503Reviewed-by:
-
Xiaohan Wang authored
- Remove InitializeRenderer_InvalidConfig, which causes deserialization error and test timeout. - Reenable tests now that http://crbug.com/594977 is fixed. - Disable InitializeCdm* tests on Android. See Bug. Bug: 829233 Test: Various test fixes. Change-Id: Iaa4ac72a8e60a88559fa198e9f3c1da16aa0beb4 Reviewed-on: https://chromium-review.googlesource.com/996959 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#548678}
-
Emily Stark authored
This shows the CT compliance status in the Certificate Transparency section of the Security Panel origin details view. Showing the SCTs themselves isn't sufficient because a site could have e.g. not enough SCTs or SCTs from an insufficent set of logs, and thus might not be CT-compliance even though it has SCTs. I also added a message about when a resource was loaded from cache to the origin details view. This is useful beacuse not all security details are stored in the cache, so it can explain why some security details (including SCTs and CT compliance status) can be missing in this view sometimes. Bug: 695610 Change-Id: Ib9c8b0af5a08dbc5eefcf778fc030c045622505e Reviewed-on: https://chromium-review.googlesource.com/998445 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548677}
-
Xiaohan Wang authored
Bug: 828940 Test: Manually tested. See Bug for repro steps. Change-Id: Id138ebc26ed5dc0b075cc18a67c651b3832077a9 Reviewed-on: https://chromium-review.googlesource.com/999122Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548676}
-
Jennifer Apacible authored
This is a reland of a776bce4 This updates the utils filepath so the new test passes. Original change's description: > [Picture in Picture] Add modern media control. > > Currently, there is only a PiP button for the legacy / non-modern > set of media controls. This adds and enables the modern version. > > BUG: 726619 823109 > Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f > Reviewed-on: https://chromium-review.googlesource.com/966980 > Commit-Queue: apacible <apacible@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548358} TBR=mlamouri@chromium.org,steimel@chromium.org BUG: 726619 823109 Change-Id: I311c137f70b8e5f2ee2681ac8ffd022f2a272d8a Reviewed-on: https://chromium-review.googlesource.com/998078Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#548675}
-
Changwan Ryu authored
This should be called after native library has been loaded. Also, using a sparse histogram to avoid having to provide a max value. In doing so, histogram name 'WebView' is replaced by 'Android.WebView' to be consistent. BUG=827653 Change-Id: I5a03415c342e50ff900e0c4e47f5dd8c17e8a2bc Reviewed-on: https://chromium-review.googlesource.com/987193Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548674}
-
Ken Rockot authored
This is a reland of r548137 which now includes a whitelist to allow print preview WebUI to fetch cloud print device information directly from the network. See https://crbug.com/829218 for additional context. Original CL description follows. == Re-enables this test with the Network Service enabled. This test did some things which the Network Service does not support and does not need to support, or which otherwise made testing with the Network Service more complex than necessary. The following changes have been made: * We no longer attempt to load a network resource from a WebUI renderer. This will not be supported with Network Service and is no longer desirable to have working in production anyway. There should no longer be any WebUI pages making network requests. * Use http instead of https for the clients1.google.com requests. This allows such requests to be handled by the EmbeddedTestServer which already exists in BrowserTestBase, which is itself not configured to handle HTTPS requests. Since these requests are filtered by hostname, the scheme doesn't matter. * Switch the test to use a SimpleURLLoader instead of a FakeURLFetcher. This allows the test code to exercise the same behavior with or without the Network Service enabled. TBR=karandeepb@chromium.org Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I57bf66dfd7e7e0726ac98c9571f7fa031243e328 Reviewed-on: https://chromium-review.googlesource.com/998449Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
