GitLab

This reverts commit 107a4e3e.

Reason for revert: <INSERT REASONING HERE>

==20541==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x557884d1cbb9 in ClickToCallIconView::Update() ./../../chrome/browser/ui/views/sharing/click_to_call/click_to_call_icon_view.cc:80:7

https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/18323

The real issue indeed lies in click_to_call_icon_view.h

Original change's description:
> Integration tests for click to call
> 
> Bug: 982229
> Change-Id: I3d0f19b55dc6dc07c6ad427d670aaa2db0a9af2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718410
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682242}

TBR=peter@chromium.org,knollr@chromium.org,himanshujaju@chromium.org

Change-Id: Ic56b5b5bd151f42992ba4bc8d9e13e73dd135983
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 982229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727231Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682405}

This class will contain the Android-specific unwinding implementation,
which will rely on libunwindstack. libunwindstack will be pulled in as a
dynamic feature module (DFM).

Having a stub version of this class will allow us to create
StackSamplerAndroid. (StackSamplerAndroid will need to create a
StackSamplerImpl, which accepts an Unwinder as a constructor parameter.)

TBR=gab@chromium.org
R=wittman@chromium.org

Bug: 988574
Change-Id: Id929731e94232f457add7914eb426ebcdb0bf0f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726829Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682404}

FIDL defines that only messages with a response should have a non-zero
transaction Id set, and recent changes to FIDL C++ bindings actually
verify & enforce that.

Update the FIDL/JS generator to omit Ids from one-way messages.

Bug: FIDL-764
Change-Id: I5ab6b94283fae2e67bb92a8f856e143f5d82a75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726612
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682403}

Bug: 980748
Change-Id: I10965a3f20ca5ba8fdaabaeeda31bccd40c91ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726234
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682402}

This change adds service startup logic based on the already landed
kCrosVmCupsProxy feature flag, disabled by default.

Bug: chromium:945409
Test: manually confirmed correct flag behavior
Change-Id: I6198cfcf4011c557b09d74d33f241cc61629d4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713237
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682401}

Previously, clipboard messages were capped at the default safe size of
64KiB. This patchset raises the limit when the session descriptor
indicates that a larger size is supported.

Bug: 988865
Change-Id: I651c4e0a5aa96b84950eb4fa8f798af7579eff85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726277
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Auto-Submit: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682400}

PepperTCPSocketMessageFilter could be released on IO thread
with an outstanding |firewall_hole_| and indirectly calls
dbus code on IO thread. The CL makes sure |firewall_hole_|
is deleted on UI thread.

Bug: 989072
Change-Id: I9266c21a96fa5b931f81d25bc6c8e91293a5e9a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726235Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682399}

BUG=790761

Change-Id: Id33e2f4362637bd5871b8d4e63a070b02dff8912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724515Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682398}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/11c60ffe..781babd0

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie982a274c53c3ac4fbf116c9f601d0f99233493c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726432Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682397}

Change-Id: I5a1156b00535832bdbe186be8d8407c4e5c341e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726714Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682396}

This patch validates that whenever the kHitTestAsk bit gets set, the
async_hit_test_reasons is also set and vice versa.

Bug: 985786
Change-Id: I424053f3ed62eb3f65b4116de9630bd437b0e1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710845
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682395}

Add the new NTP team owner (dbeam@), and remove the old team (jkrcal@).

Change-Id: I56e4436091ff1e98d68a23afc61530442579e0b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723300Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682394}

UIThreadExtensionFunction was merged into ExtensionFunction in
http://crrev.com/c/1718990. This removes the stub
UIThreadExtensionFunction class and renames all the references from
UIThreadExtensionFunction to ExtensionFunction.

This CL was generated with the command:
  git grep --name-only UIThreadExtensionFunction | \
    xargs sed -i 's/UIThreadExtensionFunction/ExtensionFunction/g'

Bug: 980774
Change-Id: Ie1772044041517b88e9f8a625a2b941913aae9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721876Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682393}

The logic here is easier if the unsupported cases are rejected first.

Change-Id: I231935618dea789972934e7cd09ec3616744b9e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725209Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682392}

If a RenderWidget is started as hidden, it should generate a local
surface Id when it's shown. On Webview, the delegated_frame_host_
is null, which was preventing this from happening. Change the
conditional to still generate the local surface ID.

We got by with this bug because RenderWidgets for RenderFrames are
always started as visible, then hidden with a method call to the
RenderWidgetHostView. Future CLs remove this ping-ponging of visibility
states.

R=boliu@chromium.org

Bug: 419087, 745091
Change-Id: I7c7ffb49fde75c94b68ffb4e72b3a7676ac6d429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726872Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682391}

The Files app, as well as other apps, if they're evicted due to
being occluded by other windows, will show as empty for a second or
more in overview until reloaded.

This CL makes them behave the same way as browser windows, that is
they show stale contents until reloaded.

BUG=986085, 866622
TEST=Manually, follow steps on bug, and note the issue no longer shows.

Change-Id: If9a2b26b914fe55672d15d4b560cbe6d7e996591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711843Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682390}

https://android.googlesource.com/platform/external/perfetto.git/+log/968d1d819bc0..d5acde64a3a5


git log 968d1d819bc0..d5acde64a3a5 --date=short --no-merges --format='%ad %ae %s'
2019-07-30 lalitm@google.com trace_processor: rename NumericColumn -> NumericStorageColumn


Created with:
  gclient setdep -r src/third_party/perfetto@d5acde64a3a5

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: Ie3b3b183ac9aa648b2696c70cc99e15f0f9610e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726810Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682389}

Due to lack of use, and because we never started using a different
version number since the initial launch.

Bug: 975127
Change-Id: Id0dfb75ee065d8fffc87f289a09d58c149cad930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720748
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682388}

Expose IsThirdPartyInitialized() so it can be used instead of
blacklist::IsBlacklistInitialized while setting up the beacon.

Bug: 986926
Change-Id: Ib8fce7d60a5ac1a9b61324d7fd040263e8e62aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719290
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682387}

Currently, the direct share icon content descriptions are set to the
application name. This causes issues if an app has multiple activities
that can be used to share. E.g. The Drive app has "Save to Drive" and
"Copy to clipboard," but TalkBack reads them both as "share via Drive."

As a fix, this CL changes ShareHelper#getShareableIconAndName to return
the activity label instead of the app label. If the activity label is
null, the app label is returned by default.

Bug: 986545
Change-Id: I1174ca962deb9efbe25c432967c60f68ea855e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721854Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#682386}

The REST endpoint for the spelling service is ready to be fully launched.
It has been enabled at 1% of stable for 2 weeks now, and between control
and enabled on Dev/Canary/Beta/Stable:
- HTTP status code metrics have been stable, though we have noticed
  between 0.5% and 0.9% of requests give a 403. We will need to keep an
  eye on those, but they do not warrant delaying the endpoint migration.
- Proportion of failed requests has gone slightly down.
- Mean latency (ms) of requests has gone slightly down.

For those reasons, we are ready to fully migrate the spelling service to
the new REST endpoint. Code cleanup will follow shortly, once we've
confirmed that things are stable.

Bug: 943108
Change-Id: I19d394bed58db178dde682ffe168e651ee9e5125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724666Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#682385}

We might create child frames, and those frames will need to create
a URL loader factory. Since we override the factory before we actually
parse and create child frames, we can't set it directly on all possible
children. Instead, when asked to create a factory and we don't have
an override, navigate the ancestor chain and check if any of the
ancestors have an override.

This also adds a Clone function, since we need to be able to retain
multiple copies of the override (one for each of the child frames,
and one for self).

R=yhirano@chromium.org

Bug: 986050
Change-Id: I5d1023379eb4b7c305e3b07640ee6a4d31a2d9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717677Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682384}

This fixes a minor layout error in the Contextual Search Bar
when a Definition is shown in an RTL language.

BUG=989121

Change-Id: Ifc5a198155e7726710f26f78bbc6387492d411cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726200
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682383}

Add enum for |full_text_| properties and convert ElideBehavior,
Shadows, and HorizontalAlignment.

Change-Id: I6d5263f380010906844b6a46c3003ece8126bfde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715727Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#682382}

This is part of EG1 to EG2 migration, which involves moving
EarlGrey code from app-side helpers into test code.
EarlGrey2 has multiprocess architecture,
where Chrome Test and Chrome App are separate processes.

These matchers are currently used in 10+ tests,
convert them to compile under EG2.

Bug:922813

Change-Id: Ia5439922119d456446071c4c747a4230bb7a9ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725333Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682381}

Change-Id: Iaf08c1356f929605bef59a5e6e9a1829e9b868ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721293Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#682380}

This caused ANGLE's symbols to not be generated and uploaded with
official builds.

BUG=988958,988444

Change-Id: I428e5664755bb969fbe771c2a9d303f90d26a017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724840
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682379}

Using wpt-import in Chromium 8cf27f85.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I504480a3ebfe6815f295613ccef1e38af4d79885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724646Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682378}

Also, verified that such function is visible.

Bug: b/131411395
Test: With internal CLs, build on one device and cast a youtube page.
Change-Id: I55ae72fa2ae71ab6495e7b32c16150a678086773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721555
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682377}

We should not have supported getting a child tree sibling.
Child trees are always considered to be an "only child."

This change removes the ability to traverse to a child
tree using PlatformGet*Sibling, as valid usage of that
method requires a sibling to exist.

PlatformGetChild will now return nullptr if the node has a
child tree and the specified child index is not 0

Updated test.

Bug: 987472
Change-Id: I5b69e169531f3448a317f7b8d698cea5857b7ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717912
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682376}

Change-Id: I908f618d809e4d6414d85a8867156a676cc8c032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721352Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#682375}

Bug: 934009
Change-Id: I0994c106955ba9961cfed1fa2814bd4b7745fd3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724507
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682374}

The Monorail component for code coverage was renamed from:
Tools>CodeCoverage to Infra>Test>CodeCoverage, and this CL updates the
references.

Change-Id: I886422c5b8f839570ade415354fe2c122ee35ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726371Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682373}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42f9ab2813ad..da76f1d1887d


Created with:
  gclient setdep -r src-internal@da76f1d1887d

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I05992fef64d27b780a35063cc3e994f28d029b62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724405Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682372}

Remove some SBDownloadFeedback metrics that weren't being used, and where
we don't have any near-term plans for them.

Bug: 984184, 984209
Change-Id: I35c5e77f20170ec4e8b8bba71b811f12c1d9899f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725161
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682371}

Updates XRRigidTransform's constructor to throw a TypeError if it
receives a Position with a w component assigned to anything other than 1
and an InvalidStateError if the length of the Orientation component is 0

Bug: 977703
Change-Id: Ie75ddff1e1bafd55ea58844c074751aedf11fcdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725319
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682370}

Change-Id: I76b80b77cf72e91d83b89a002c598e8447f9f1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723307Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Sofiya Semenova <sofiyase@google.com>
Cr-Commit-Position: refs/heads/master@{#682369}

Change-Id: I2d2e633ef1867a55a23d27a733454f519af5a4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721184Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#682368}

Currently when user clicks to add a new tab in TabGridDialog, we try to
create a new tab which takes the last tab in this group as parent.
However, this can be problematic when all tabs are closed in this group.
This CL fixes this issue.

Bug: 987885
Change-Id: I1a6c83f9bfe8e55669ed5424cb7f096e277a91e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726413Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682367}

https://skia.googlesource.com/skia.git/+log/4da34bf74723..8cbf662b296a


git log 4da34bf74723..8cbf662b296a --date=short --no-merges --format='%ad %ae %s'
2019-07-30 bsalomon@google.com Always set GL_[UN]PACK_ALIGNMENT to 1.
2019-07-30 senorblanco@chromium.org Dawn backend: add asserts for unimplemented functionality.
2019-07-30 halcanary@google.com experimental/editor : handle word-left and word-right
2019-07-30 reed@google.com simplify canvas after looper's demise
2019-07-30 mtklein@google.com small refactors


Created with:
  gclient setdep -r src/third_party/skia@8cbf662b296a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=benjaminwagner@google.com

Bug: None
Change-Id: Iee6b80f1fd0d773c5222fd27b5ac0baef26bba68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726280Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682366}