GitLab

at least one of these extensions:
- GL_ANGLE_framebuffer_multisample
- GL_APPLE_framebuffer_multisample
- GL_EXT_framebuffer_multisample
- GL_EXT_multisampled_render_to_texture
- GL_NV_framebuffer_multisample

Otherwise it generates GL_INVALID_ENUM.

It does not lead to any problem except that gl error is set
by this time. At least it avoids getting an error message
when Mesa logging is enabled.

BUG=564066

R=bajones@chromium.org, kbr@chromium.org, zmo@chromium.org

TEST= export MESA_DEBUG

Review URL: https://codereview.chromium.org/1481523003

Review URL: https://codereview.chromium.org/1481523003

Cr-Commit-Position: refs/heads/master@{#363072}

Review URL: https://codereview.chromium.org/1490753005

Cr-Commit-Position: refs/heads/master@{#363071}

We can't sign the app_mode_loader bundle because it's altered at runtime
as new app mode loader stubs are created. We can sign just the
executable. The resulting executable won't validate in its bundle
normally, and spctl won't like it, but it can be verified with
--ignore-resources, or in isolation from its bundle.

BUG=550972

Review URL: https://codereview.chromium.org/1486863003

Cr-Commit-Position: refs/heads/master@{#363070}

Ideal we would like to throw an exception in this case. But since the
API for these two methods does not have RaiseException, this CL handles
this case the same way as the case when ImageData is null.

BUG=564846

Review URL: https://codereview.chromium.org/1498603002

Cr-Commit-Position: refs/heads/master@{#363069}

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359

Review URL: https://codereview.chromium.org/1493803003

Cr-Commit-Position: refs/heads/master@{#363068}

BUG=424751

Review URL: https://codereview.chromium.org/1488923002

Cr-Commit-Position: refs/heads/master@{#363067}

BUG=561821

Review URL: https://codereview.chromium.org/1486363002

Cr-Commit-Position: refs/heads/master@{#363066}

This function returns a Node*, not an Element*. The callsites are a
little confusing, currently.

BUG=None

Review URL: https://codereview.chromium.org/1495053002

Cr-Commit-Position: refs/heads/master@{#363065}

This CL adds a new preference called
"windows_desktop_search_redirection", that controls whether Windows
desktop searches should be redirected to the default search engine.

The preference can be enabled, disabled or unset. Enabled and disabled
mean that redirection of desktop searches has been explicitly enabled
or disabled. Unset means no value has been explicitly set and that the
browser should ask the user whether they want to use the feature
(prompt + checkbox to edit the preference from chrome://settings will
be implemented in an upcoming CL).

BUG=539963

Review URL: https://codereview.chromium.org/1477783004

Cr-Commit-Position: refs/heads/master@{#363064}

TaskSetFinishedTaskImpl was casted to its sibling,
cc::RasterTask instead of a base class, cc::TileTask.

This is a follow up to https://codereview.chromium.org/1470113002 which introduced this bad cast.

BUG=565515,464797
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1494273002

Cr-Commit-Position: refs/heads/master@{#363063}

This ensures that the next frame will remove any extra render surfaces
that were created to handle the copy request. Persisting extra render
surfaces would cause extra GPU work and prevent using overlays.

BUG=564832
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1493013002

Cr-Commit-Position: refs/heads/master@{#363062}

to make more evident which file is in which platform,
plus they get automatically removed from build lists
in the appropriate way.

BUG=

TBR=avi@chromium.org for the changes not covered by
sandersd@ and posciak@ :
- content/common/BUILD.gn
- content/common/sandbox_mac.mm
- content/gpugpu_main.cc
 (those are just renaming of the appropriate files).

Review URL: https://codereview.chromium.org/1474823002

Cr-Commit-Position: refs/heads/master@{#363061}

This will allow benchmarks to make longer scroll actions.

BUG=565306

Review URL: https://codereview.chromium.org/1492363002

Cr-Commit-Position: refs/heads/master@{#363060}

Review URL: https://codereview.chromium.org/1493673004

Cr-Commit-Position: refs/heads/master@{#363059}

Does not allow the related tests to pass yet, needs some command buffer work for
that. That will come in a follow up patch.

BUG=563613

Review URL: https://codereview.chromium.org/1490043002

Cr-Commit-Position: refs/heads/master@{#363058}

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594

Review URL: https://codereview.chromium.org/1486633002

Cr-Commit-Position: refs/heads/master@{#363057}

CommandLine and FilePath are being passed by reference, so they can be
forward declared and their header includes be moved to the source file
instead.

BUG=None
TEST=gn gen + gn_unittests
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1492813002

Cr-Commit-Position: refs/heads/master@{#363056}

PlatformWindowAndroid and PlatformImeControllerAndroid were using is_empty()
to check if a JavaObjectWeakGlobalRef is null, which is incorrect. The right
way to check is to get a ScopedJavaLocalRef reference (by calling get()) and
check that instead.

BUG=NONE

Review URL: https://codereview.chromium.org/1487123002

Cr-Commit-Position: refs/heads/master@{#363055}

Replaces temporary string allocations with StringPiece.

BUG=

Review URL: https://codereview.chromium.org/1494613002

Cr-Commit-Position: refs/heads/master@{#363054}

BUG=564869

Review URL: https://codereview.chromium.org/1493043002

Cr-Commit-Position: refs/heads/master@{#363053}

[Autofill] Respect the autocomplete=off attribute on desktop for non credit card related fields and forms.

BUG=468153

Review URL: https://codereview.chromium.org/1473733008

Cr-Commit-Position: refs/heads/master@{#363052}

BUG=551067

Review URL: https://codereview.chromium.org/1432663002

Cr-Commit-Position: refs/heads/master@{#363051}

BUG=564530

Review URL: https://codereview.chromium.org/1494543002

Cr-Commit-Position: refs/heads/master@{#363050}

BUG=539572

Review URL: https://codereview.chromium.org/1492093003

Cr-Commit-Position: refs/heads/master@{#363049}

This lets us more correctly identify the site, in particular for
window.open/about:blank, and blob URLs.

BUG=498580
TEST=SiteDetailsBrowserTest

Review URL: https://codereview.chromium.org/1487933002

Cr-Commit-Position: refs/heads/master@{#363048}

This CL adds the field and initializes it to 0. It has no other effect. This is
probably going to cause some assertions to fail, due to interactions with
third-party software. See the associated bugs for more details.

BUG=527588, 493414

Review URL: https://codereview.chromium.org/1500453002

Cr-Commit-Position: refs/heads/master@{#363047}

This CL adds an IPAddress class intended to replace the current IPAddressNumber typedef. The class wraps a std::vector<uint8_t> containing the actual IP address and exposes a couple of helper methods. This CL only introduces the new class and related tests.

BUG=496258

Review URL: https://codereview.chromium.org/1408803010

Cr-Commit-Position: refs/heads/master@{#363046}

Discardable shared memory no longer relies on a POSIX fd backed shared memory
region, as it no longer uses ftruncate.

BUG=547239

Review URL: https://codereview.chromium.org/1497843002

Cr-Commit-Position: refs/heads/master@{#363045}

Refactor both dialogs such that CSS styles can be shared
between them (see reset_page_dialog.css).

BUG=546840

Review URL: https://codereview.chromium.org/1482573002

Cr-Commit-Position: refs/heads/master@{#363044}

BUG=skia:2545
TBR=phajdan

Review URL: https://codereview.chromium.org/1493913005

Cr-Commit-Position: refs/heads/master@{#363043}

On Aura Android the Screen instance may not be set yet when
ResourceBundle::InitSharedInstance is executed. Instead of using the Screen
instance to determine the scale factor, just use the available static methods
in gfx::Display and gfx::DeviceDisplayInfo.

BUG=507792

Review URL: https://codereview.chromium.org/1474873002

Cr-Commit-Position: refs/heads/master@{#363042}

This deletes four user actions that were added long ago and are no
longer used:
 - MobileFirstEditInOmnibox
 - MobileFocusedFakeboxOnNtp
 - MobileFocusedOmniboxOnNtp
 - MobileFocusedOmniboxNotOnNtp

This also starts recording the FocusLocation user action when the omnibox is
focused; this essentially combines MobileFocusedFakeboxOnNtp,
MobileFocusedOmniboxOnNtp, and MobileFocusedOmniboxNotOnNtp into a single
action.

BUG=408176

Review URL: https://codereview.chromium.org/1491393002

Cr-Commit-Position: refs/heads/master@{#363041}

This CL adds two Chrome OS specific histograms:
* UpdateEngine.CertificateCheck.Download
* UpdateEngine.CertificateCheck.UpdateCheck

BUG=563800

Review URL: https://codereview.chromium.org/1490643002

Cr-Commit-Position: refs/heads/master@{#363040}

BUG=537070

Review URL: https://codereview.chromium.org/1491123002

Cr-Commit-Position: refs/heads/master@{#363039}

Add a test case for verifying launching app with updating a shared module to the new version.

Re-packaged several testing apps downloaded from webstore to remove the update url from their manifest files.

BUG=555083

Review URL: https://codereview.chromium.org/1488393002

Cr-Commit-Position: refs/heads/master@{#363038}

BUG=

Review URL: https://codereview.chromium.org/1481383005

Cr-Commit-Position: refs/heads/master@{#363037}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/baf869df..42acdb73

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1499603003

Cr-Commit-Position: refs/heads/master@{#363036}

frame_ID.

PacketKey was originally generated by combining capture_time, ssrc,
and packet_id. This key may not necessarily be unique. Two or more
frames with the same cpature_time had the same key and may cause one
to be evicted from the list. This, in turn, will cause a receiver to
become blocked waiting on a frame that the PacedSender will never
attempt to send.

BUG=373560

Review URL: https://codereview.chromium.org/1487223002

Cr-Commit-Position: refs/heads/master@{#363035}

It's going to be very difficult to enable this for production code as any code can leak message pipes. It'll also be hard to implement correctly with multiplexing. This was added for a test, but I just changed the test instead so that it quits after it sends a lot of reply messages.

BUG=556259

Review URL: https://codereview.chromium.org/1492943005

Cr-Commit-Position: refs/heads/master@{#363034}

This patch improves the handling of importer profile creation to remove
reliance on bare pointers. It also wraps created importer objects in a
scoped_refptr which is what the pointer is assigned to in the caller.

BUG=539746

Review URL: https://codereview.chromium.org/1492663006

Cr-Commit-Position: refs/heads/master@{#363033}