GitLab

Offline pages metadata store:
* Creates interface for the store
* The following actions are available on the store:
  - AddOfflinePage,
  - RemoveOfflinePage,
  - Load,
* Updates to the components_unittests to include offline
  pages

BUG=491352

Review URL: https://codereview.chromium.org/1160283003

Cr-Commit-Position: refs/heads/master@{#333697}

Revert of content: Single process support for native GpuMemoryBuffers. (patchset #8 id:140001 of https://codereview.chromium.org/1120873002/)

Reason for revert:
Breaks Mac10.6 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3331

Original issue's description:
> content: Single process support for native GpuMemoryBuffers.
>
> This adds single process support for IOSurface and
> SurfaceTexture backed GpuMemoryBuffers.
>
> Also makes the SurfaceTexture code more consistent
> with IOSurface code by using a singleton instead of
> leaking a raw pointer.
>
> BUG=497559
> TEST=content_browsertests --gtest_filter=ChildThreadImplGpuMemoryBufferBrowserTests/*
>
> Committed: https://crrev.com/d5395d05e7f006ef9d1efaf8ec84030d24fb9fef
> Cr-Commit-Position: refs/heads/master@{#333625}

TBR=avi@chromium.org,dcastagna@chromium.org,reveman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497559

Review URL: https://codereview.chromium.org/1171293005

Cr-Commit-Position: refs/heads/master@{#333696}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ae3f140..fb3cca5

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1171203006

Cr-Commit-Position: refs/heads/master@{#333695}

Revert of Combine 'pssh' parsing routines. (patchset #8 id:140001 of https://codereview.chromium.org/1149023002/)

Reason for revert:
Breaks compile on 'Google Chrome Win' bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/1066

Original issue's description:
> Combine CENC 'pssh' box parsing routines.
>
> Also update the routines to ignore 'pssh' boxes with version 2 or
> later.
>
> BUG=460359, 460360
> TEST=new unittests pass
>
> Committed: https://crrev.com/b666d7874efac44b359a95329f0cb890e97671df
> Cr-Commit-Position: refs/heads/master@{#333556}
>
> Committed: https://crrev.com/7a84443597e92a03f90806712f8629df40bf408e
> Cr-Commit-Position: refs/heads/master@{#333611}

TBR=sandersd@chromium.org,ddorwin@chromium.org,xhwang@chromium.org,jrummell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460359, 460360

Review URL: https://codereview.chromium.org/1165313003

Cr-Commit-Position: refs/heads/master@{#333694}

Cr-Commit-Position: refs/heads/master@{#333693}

Currently, the variable containing ViewsDelegate singleton object can be
set by anyone and there are cases (at least in tests) where it is freely
replaced without properly deleting the old one which can lead to
situations where multiple ViewsDelegate objects are in existence. This
patch tries to ensure that there is at most one instance available at
each time.

Also, cleaned up some ViewsDelegate related includes.

BUG=492991

Review URL: https://codereview.chromium.org/1159033008

Cr-Commit-Position: refs/heads/master@{#333692}

device_command_screenshot_job.cc:132:70: warning: 'result_code' may be used uninitialized in this function [-Wmaybe-uninitialized]

Review URL: https://codereview.chromium.org/1159163006

Cr-Commit-Position: refs/heads/master@{#333691}

Avoid depending on (or including) extensions related code when enable_extensions
gyp/gn flag is not set. This fixes 'gn gen' for android with toolkit_views turned
on.

BUG=488576

Review URL: https://codereview.chromium.org/1160773004

Cr-Commit-Position: refs/heads/master@{#333690}

BUG=none
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1172803003

Cr-Commit-Position: refs/heads/master@{#333689}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/75eb674..ae3f140

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1172683004

Cr-Commit-Position: refs/heads/master@{#333688}

This parameter is always passed "false", and it doesn't do anything
sensible if you pass "true". It purports to be processing bidi text for
a URL, but it does not do anything of the sort.

Specifically, if the overall text direction of the string is RTL, it
tells ICU to use the UBIDI_REORDER_RUNS_ONLY algorithm, which disables
the bidi algorithm and places all strong characters (LTR and RTL) at
Level 0. This is not designed to produce a display ordering and has
nothing to do with the formatting requirements for a URL. It might have
made sense back when BiDiLineIterator was solely used by
AutocompleteResultView in 2008 (it did some sort of post processing on
the reversed runs), but I don't want this misleading parameter to stay
around now.

BUG=351639

Review URL: https://codereview.chromium.org/1144303004

Cr-Commit-Position: refs/heads/master@{#333687}

BUG=

Review URL: https://codereview.chromium.org/1168793002

Cr-Commit-Position: refs/heads/master@{#333686}

To prevent MediaStreamPermissionTest* flakiness:
(1) Instead of relying on the old infobar notification system, switch to
    the new infobar responder. (As per crbug.com/354380, observers are now
    preferred to notifications.)
(2) Instead of relying on mock permission bubbles, switch to the new
    PermissionBubbleManager responder.
(3) Remove the polling and timeouts.

To satisfy the requirements of the media test cases, I also updated the
InfoBarResponder. It now can handle infobar replacement and dismissing an
infobar without making a choice.

BUG=295723
R=tommi@chromium.org

Committed: https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb
Cr-Commit-Position: refs/heads/master@{#333360}

Review URL: https://codereview.chromium.org/1161153003

Cr-Commit-Position: refs/heads/master@{#333685}

AudioRendererHost was calling AudioMirroringManager::RemoveDiverter()
just before AudioOutputController::Close().  This caused AOC to re-start
the default audio output stream (to the user's speakers) for 0-50+
milliseconds before closing and shutting down.  This change fixes the
problem by moving the RemoveDiverter() call to a point after AOC has
completed its close operation, which results in no new streams starting
up during this shutdown process.

BUG=474432

Review URL: https://codereview.chromium.org/1172883003

Cr-Commit-Position: refs/heads/master@{#333684}

Revert of Gallery: Add toolbar at the top of window. (patchset #1 id:1 of https://codereview.chromium.org/1145893010/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: Add toolbar at the top of window.
>
> BUG=488227
> TEST=Manually tested.
>
> Committed: https://crrev.com/abd18063e7b78bc50db62c1914aa729cb0daa40f
> Cr-Commit-Position: refs/heads/master@{#332346}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1170403005

Cr-Commit-Position: refs/heads/master@{#333683}

BUG=Bisect bot no longer works.

TBR=prasadv@chromium.org, aiolos@chromium.org

TEST=https://codereview.chromium.org/1177623004

Review URL: https://codereview.chromium.org/1169413003

Cr-Commit-Position: refs/heads/master@{#333682}

Revert of Move overwrite original checkbox and saved label to bottom toolbar. (patchset #2 id:20001 of https://codereview.chromium.org/1167533004/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Move overwrite original checkbox and saved label to bottom toolbar.
>
> BUG=488227
> TEST=none
>
> Committed: https://crrev.com/689d5020bb670e8c63feb20b47fedb2112eee05f
> Cr-Commit-Position: refs/heads/master@{#332545}

TBR=mtomasz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1173863004

Cr-Commit-Position: refs/heads/master@{#333681}

This reverts commit 6a31c05f.

TBR=fukino@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1173863003.

Cr-Commit-Position: refs/heads/master@{#333680}

Picks up https://codereview.chromium.org/1171203002
to add |isReferenceCounted| to the converter data structure.

BUG=465175
TEST=see the bug
TBR=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/1171283003

Cr-Commit-Position: refs/heads/master@{#333679}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9237715..75eb674

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1171353002

Cr-Commit-Position: refs/heads/master@{#333678}

This reverts commit 76ab89d6.

TBR=fukino@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1172883005.

Cr-Commit-Position: refs/heads/master@{#333677}

Review URL: https://codereview.chromium.org/1176583003

Cr-Commit-Position: refs/heads/master@{#333676}

This reverts commit d1e34310.

TBR=mtomasz@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1174853002.

Cr-Commit-Position: refs/heads/master@{#333675}

Another platform will have image processor. Change the device
name of image processor to more generic.

BUG=chrome-os-partner:38980
TEST=Test apprtc loopback on peach pit.

Review URL: https://codereview.chromium.org/1156803004

Cr-Commit-Position: refs/heads/master@{#333674}

Revert of Gallery: capture escape key in full screen by adding a permission. (patchset #2 id:20001 of https://codereview.chromium.org/1149323006/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: capture escape key in full screen by adding a permission.
>
> BUG=497011
> TEST=manually tested; Maximize Gallery and press slideshow button. Confirm that it goes to slideshow mode. After it, press escape key and confirm that it goes back to the original mode.
>
> Committed: https://crrev.com/7d1560ccb3dfee3c9f1510b035f67261b0b88d8f
> Cr-Commit-Position: refs/heads/master@{#333246}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497011

Review URL: https://codereview.chromium.org/1174733005

Cr-Commit-Position: refs/heads/master@{#333673}

The current approach doesn't account for expired frames when resuming
after underflow, which means we may resume and then immediately fail
again; these frames are also out of sync with the audio playing out.
Fixing this requires several changes to the pipeline:

- TimeSource::ConvertMediaTimestamps() will now always convert timestamps,
even when time is stopped.  When time is stopped the converted values are
based on the last known media wall clock time.

- TimeSource::ConvertMediaTimestamps() will now return the current media
wall clock time when an empty timestamps vector is given; this value is
used to figure out which video frames have been played out already.

- Introduce AudioClock::CompensateForSuspendedWrites() to ensure the audio
delay value is correctly used when return the current wall clock time.

- Introduce |was_time_moving_| to VideoRendererAlgorithm to ensure the
|last_deadline_max_| value, used by RemoveExpiredFrames, is only changed
when time is ticking; otherwise the value given to RemoveExpiredFrames is
overwritten by Render() calls and EffectiveFramesQueued() will vary.

- Modifies VideoRendererImpl::FrameReady() to remove expired frames based
on the last known media wall clock time during underflow states.

Combined these changes lead to a noticeable improvement in audio/video sync
during underflow as well as a greatly reduced number of underflow events.

BUG=498525
TEST=lots of new tests.

Review URL: https://codereview.chromium.org/1160853006

Cr-Commit-Position: refs/heads/master@{#333672}

This cl implements ServiceWorkerHandler::ActivateTarget() to focus the tab which is controlled by ServiceWorker.

Screenshot: https://code.google.com/p/chromium/issues/detail?id=466871#c65

1/5 chromium: This cl.
2/5 blink: https://codereview.chromium.org/1151993003/
3/5 chromium: https://codereview.chromium.org/1149383004/
4/5 blink: https://codereview.chromium.org/1164583002/
5/5 chromium: https://codereview.chromium.org/1143363009/

BUG=466871

Review URL: https://codereview.chromium.org/1160133002

Cr-Commit-Position: refs/heads/master@{#333671}

This measures time spent in ExecuteJavaScript() in DomDistiller. It
includes JavaScript code transmission through IPC, parsing, compilation,
execution, and returning the JSON back through IPC.

We already have DomDistiller.Time.DistillationTotal, but it is measured
within JavaScript.

In DomDistiller.Time.*, DistillationTotal < RunJavaScript < DistillPage.

BUG=497430

Review URL: https://codereview.chromium.org/1143173009

Cr-Commit-Position: refs/heads/master@{#333670}

I had hoped to bump the deployment target to 10.7 instead, but the nacl bots
still build on 10.6 :-(

Also, pass commands as a single string to subprocess when
shell=True (else, 2nd cmd entry and onward are treated as
shell parameters, not as part of the command).

BUG=494442

Review URL: https://codereview.chromium.org/1169353002

Cr-Commit-Position: refs/heads/master@{#333669}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b23e6aa..5195805

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1175823003

Cr-Commit-Position: refs/heads/master@{#333668}

This is for debugging purposes only and will be reverted
soon.

BUG=495650
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1175703004

Cr-Commit-Position: refs/heads/master@{#333667}

Cr-Commit-Position: refs/heads/master@{#333666}

Added 'blob' scheme in Navigation.MainFrameScheme and Navigation.MainFrameSchemeDifferentPage histograms.
Added it in the end, before the scheme_max so that scheme_max contains the number of schemes.

BUG=492773

Review URL: https://codereview.chromium.org/1167403002

Cr-Commit-Position: refs/heads/master@{#333665}

Move perf_tests_helper.py to
telemetry/util/perf_tests_helper.py

BUG=497905

Review URL: https://codereview.chromium.org/1171803003

Cr-Commit-Position: refs/heads/master@{#333664}

After clicking the "Allow" button in the infobars, Chrome will request
the permission if required from Android.

BUG=496447

Review URL: https://codereview.chromium.org/1164973003

Cr-Commit-Position: refs/heads/master@{#333663}

BUG=498040

Review URL: https://codereview.chromium.org/1174743002

Cr-Commit-Position: refs/heads/master@{#333662}

BUG=498149

Review URL: https://codereview.chromium.org/1176723002

Cr-Commit-Position: refs/heads/master@{#333661}

We're left with the following:
. Embed(ViewManagerClientPtr client)
. EmbedAllowingReembed(mojo::URLRequestPtr request): this variant
  walks the frame tree for the first ancestor marked as an embed root
  and asks it for the ViewManagerclient to embed.

BUG=497855
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1166123005

Cr-Commit-Position: refs/heads/master@{#333660}

Revert of Gallery: use shadow dom with Polymer. (patchset #1 id:1 of https://codereview.chromium.org/1168333002/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: use shadow dom with Polymer.
>
> BUG=488227
> TEST=none
>
> Committed: https://crrev.com/f17dc18bc3dd133d2be1c92d2f4e3c0b05d4d9b1
> Cr-Commit-Position: refs/heads/master@{#333449}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1172533003

Cr-Commit-Position: refs/heads/master@{#333659}

TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesRecordInAllTaskSwitchHistogram

BUG=487745

Review URL: https://codereview.chromium.org/1148723006

Cr-Commit-Position: refs/heads/master@{#333658}