- 20 Aug, 2018 40 commits
-
-
Matt Falkenhagen authored
This adds tests that won't pass yet for a smaller CL. Split off of https://chromium-review.googlesource.com/c/chromium/src/+/1174204 Tests that: - FetchEventForNavigationHasThrottledRequest: The service worker fetch event observes headers modified by a throttle during navigation. This is valid in both NetworkService and S13nServiceWorker. - RedirectOccursBeforeFetchEvent: The service worker only sees the post-redirect request when a throttle redirects. This is valid in both NetworkService and S13nServiceWorker. - NavigationHasThrottledRequestHeadersAfterNetworkFallback: After a service worker falls back to network, the request contains the headers modified by throttles during navigation. This is only valid for NetworkService. Headers are not propagated to the network request in the S13nServiceWorker case. - NavigationPreloadHasThrottledRequestHeaders: When navigation preload is enabled, the navigation preload request contains the headers modified by throttles during navigation. This is valid for both NetworkService and S13nServiceWorker. Bug: 873575 Change-Id: Id7d74a9cf7f0a4f15eebe06882039a108e176263 Reviewed-on: https://chromium-review.googlesource.com/1180832Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584394}
-
Balazs Engedy authored
String no longer contains a placeholder, do not try to substitute one. Bug: 875531 Change-Id: I53acc969a58a270ed14011b37177329bbcaaf644 TBR: hongjunchoi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1180898Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584393}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9923353600ea..c7ca7b19c714 git log 9923353600ea..c7ca7b19c714 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 phoglund@webrtc.org Revert "Temporarily skip linux_internal on autoroller tryjobs." Created with: gclient setdep -r src/third_party/webrtc@c7ca7b19c714 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I892f6f7ccb491346ca1723f3cf40da7590b168c0 Reviewed-on: https://chromium-review.googlesource.com/1180847Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584392}
-
Jan Wilken Doerrie authored
This change implements pairing on WinRT and adds appropriate tests. In order to encapsulate the implementation, a new BluetoothPairingWinrt helper class is introduced. For now only pairing via PIN code is supported. Bug: 821766 Change-Id: Ic0a64b4e79dd38f9c0ac86a25c0a878f1f70192c Reviewed-on: https://chromium-review.googlesource.com/1177741 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584391}
-
Yoshifumi Inoue authored
This reverts commit 2a82d4ff. Reason for revert: This patch still causes the crash with the CL[1]. [1] [1] http://crrev.com/c/1123018 [CI] Cleanup paint invalidation flags Original change's description: > Destroy paint fragment tree before destroying descendant layout objects > > This patch introduces |LayoutNGMixin::WillBeDestroyed()| and changes > |LayoutBlockFlow::DeleteLineBoxTree()| to destroy paint fragment tree before > destroying descendant layout objects to allow |NGPaintFragment| destructor can > access its associated |LayoutObject|. > > Before this patch, |NGAbstrctInlineTextBox::WillDestroy()|, which is called from > |NGPaintFragment| destructor, uses dead |LayoutText| == |NGPaintFragment| lives > longer than |LayoutText|. > > After this patch, |LayoutText| lives longer than |NGPaintFragment|. > > Bug: 874588 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Iade5c8a51a57da2e855a194caa098e90222a7804 > Reviewed-on: https://chromium-review.googlesource.com/1180828 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584385} TBR=yosin@chromium.org,kojii@chromium.org Change-Id: I0fb21ceab9c1b30bbc9b2cc4d0081c04108a3db1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874588 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1180902Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584390}
-
Benoit L authored
This reverts commit 3033b341. Reason for revert: Suspected culprit for crbug.com/875713 (broken official bots). Original change's description: > Add isolate-everything command to mb.py > > The command generates a .isolate for every compatible gn target. > > This will be used by the deterministic builder to check that all isolates > dependencies are identical between two builds. > > Change-Id: I4f6a515e49f9cc207dd2f54c796531d12dfeb771 > Bug: 870731 > Reviewed-on: https://chromium-review.googlesource.com/1176441 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584268} TBR=maruel@chromium.org,dpranke@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870731, 875713 Change-Id: I5110467272abbffc96bdfa8a11261822dd96a065 Reviewed-on: https://chromium-review.googlesource.com/1179862Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584389}
-
Fredrik Söderquist authored
TBR=schenney@chromium.org BUG=875411 Change-Id: I83c6386435a1d519359e41b9a38bb37d8c646900 Reviewed-on: https://chromium-review.googlesource.com/1180890Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584388}
-
Tanja Gornak authored
Bug: 867334, 801985 Change-Id: I306bb35f1788acdfd83b772c428fd718ee13b61a Reviewed-on: https://chromium-review.googlesource.com/1154983 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#584387}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb65db10aa31..2c687ea6e0a9 git log fb65db10aa31..2c687ea6e0a9 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5055fba5692f..f26b27e29535 (1 commits) Created with: gclient setdep -r src/third_party/skia@2c687ea6e0a9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I9c646fc0b3b2404b443115fccec424472066cd35 Reviewed-on: https://chromium-review.googlesource.com/1180845Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584386}
-
Yoshifumi Inoue authored
This patch introduces |LayoutNGMixin::WillBeDestroyed()| and changes |LayoutBlockFlow::DeleteLineBoxTree()| to destroy paint fragment tree before destroying descendant layout objects to allow |NGPaintFragment| destructor can access its associated |LayoutObject|. Before this patch, |NGAbstrctInlineTextBox::WillDestroy()|, which is called from |NGPaintFragment| destructor, uses dead |LayoutText| == |NGPaintFragment| lives longer than |LayoutText|. After this patch, |LayoutText| lives longer than |NGPaintFragment|. Bug: 874588 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iade5c8a51a57da2e855a194caa098e90222a7804 Reviewed-on: https://chromium-review.googlesource.com/1180828Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584385}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8993d8b01c9..9923353600ea git log c8993d8b01c9..9923353600ea --date=short --no-merges --format='%ad %ae %s' 2018-08-20 phoglund@webrtc.org Make ensure webcam script do nothing on linux. 2018-08-19 peah@webrtc.org AEC3: Loosen the echo removal requirements in conservative mode 2018-08-17 buildbot@webrtc.org Roll chromium_revision 77bf1926..63fab7f6 (584099:584203) 2018-08-17 peah@webrtc.org AEC3: Added parameters for bypassing the suppressor Created with: gclient setdep -r src/third_party/webrtc@9923353600ea The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:875611,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I120d428033ba4318196ad043d88619445d150d26 Reviewed-on: https://chromium-review.googlesource.com/1180044Reviewed-by:
-
Andrew Wilson authored
Bug: none Change-Id: I0504191f5ca6b16c36660a2d6de278d3205fc898 Reviewed-on: https://chromium-review.googlesource.com/1179822Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584383}
-
Cathy Li authored
Bug: 867488 Change-Id: I886f26467826aa4c2beda38785bd4961f375e338 Reviewed-on: https://chromium-review.googlesource.com/1174699Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#584382}
-
Matt Falkenhagen authored
This reverts commit 7ec7b146. Reason for revert: The crash has now been fixed, really, by r580102 and r580149. Original change's description: > Revert "service worker: Remove instrumentation for ServiceWorkerObjectHost crash." > > This reverts commit bdff024c. > > Reason for revert: > It turns out the crash was still happening up to 70.0.3501.2, before > this was committed. The crash went away since 70.0.3502.0, but it's > unclear whether that was because the instrumentation was removed or > the "quick fix" was removed at the same time (r577435). > > I'm removing the instrumentation to see if the crashes will return. > > Original change's description: > > service worker: Remove instrumentation for ServiceWorkerObjectHost crash. > > > > Remove the instrumentation from issue 854993 (and duped issue 838410) as > > it is now fixed. > > > > This is mostly a straight revert of the CLs, but it retains some > > checks as DCHECKs and other improvements like adding constness. > > > > Bug: 866769, 854993 > > Change-Id: Id617e06e85e2b947258ba5f80c1d7aa0396888af > > Reviewed-on: https://chromium-review.googlesource.com/1147888 > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577430} > > TBR=falken@chromium.org,kinuko@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 866769, 854993 > Change-Id: I169f6c894d862008f4cfb0b778cd6f657b8351c0 > Reviewed-on: https://chromium-review.googlesource.com/1154740 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579004} TBR=falken@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866769, 854993 Change-Id: Ifacb8a30b851dc0d9808b26e01fecbd3dbbdb45d Reviewed-on: https://chromium-review.googlesource.com/1180901Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5055fba5692f..f26b27e29535 git log 5055fba5692f..f26b27e29535 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 oetuaho@nvidia.com Add some shared utilities for multiview tests Created with: gclient setdep -r src/third_party/angle@f26b27e29535 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie0b6d003ad7e4e3a845a972d4a35cabfa5ae70d6 Reviewed-on: https://chromium-review.googlesource.com/1180043Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584380}
-
Ramin Halavati authored
Language preferences are removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia013aaf468aa29b2efcfcb670003f09535e2a060 Reviewed-on: https://chromium-review.googlesource.com/1174118Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584379}
-
Richard Li authored
This CL is the 5th step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 2nd step: https://chromium-review.googlesource.com/c/chromium/src/+/1149706 3rd step: https://chromium-review.googlesource.com/c/chromium/src/+/1155999 4th step: https://chromium-review.googlesource.com/c/chromium/src/+/1164848 5th step: (this CL) - Remove content::ServiceWorkerResponse Bug=789854 Change-Id: I527f76f79f8614acafd7e414f4c1044d8a7be64e Reviewed-on: https://chromium-review.googlesource.com/1180738Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584378}
-
Alexander Dunaev authored
TabLifecycleUnitSource checked for an instance of PageSignalReceiver both when subscribing and unsubscribing to/from it. The PageSignalReceiver::GetInstance() called its static IsEnabled() method first; the latter returned false if content::ServiceManagerConnection::GetForProcess() returned nullptr. Normally, PageSignalReceiver is a static singleton with NoDestructor wrapper, and TabLifecycleUnitSource is owned by the browser process, so the above chain might result in that TabLifecycleUnitSource would not unsubscribe because ServiceManagerConnection for process was already destroyed. The bug is subtle and fires sporadically in random unit tests. R=haraken@chromium.org Change-Id: I34827b3a598f39f38a05c8d68cb3953009454aac Reviewed-on: https://chromium-review.googlesource.com/1180216Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#584377}
-
Matt Falkenhagen authored
Bug: 795989 Change-Id: Ieb5267a87b43f14a6ae3f3bc29b14402afd2e3ab Reviewed-on: https://chromium-review.googlesource.com/1166277 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This patch moves IDBRequest::did_throw_in_event_handler_ to Event::legacy_did_listeners_throw_flag_, which corresponds to legacyOutputDidListenersThrowFlag in DOM standard: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke (See "Note: The legacyOutputDidListenersThrowFlag is only used by Indexed Database API.") There is no behavioral change. This is a small refactoring. The reason is that it's smarter (and less fragile) to have a bit flag inside Event to indicate exceptions than letting each EventTarget maintain the flag. It's guaranteed that each Event resets the bit flag, no dependency to EventTarget, ability to detect whether any of listeners throws an exception, etc. Change-Id: Ie37f9def9e37ac220ea755b1483656f922edfc37 Reviewed-on: https://chromium-review.googlesource.com/1179729Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#584375}
-
Hiroshige Hayashizaki authored
In order to make "GetSource() == nullptr" the single source of truth for whether "the script's script is null". Bug: 686281 Change-Id: I517c22c38e0b2851722a1cb9211654216d459f13 Reviewed-on: https://chromium-review.googlesource.com/1179558 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#584374}
-
Alexey Baskakov authored
It will be needed in BMO's TabHelper to start installation. It is similar to extensions::IsValidBookmarkAppUrl but: - Doesn't use extensions/common/url_pattern.h - Reports chrome-extension:// url scheme as invalid. - Reports filesystem: and any inner URL schemes as invalid. Bug: 875698 Change-Id: I627a8e47593c698ef7acfc286cc310181b095685 Reviewed-on: https://chromium-review.googlesource.com/1180825 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584373}
-
Giovanni Ortuño Urquidi authored
Use BookmarkAppHelper to perform all necessary steps to install a Bookmark App based on a WebContents. Bug: 864904 Change-Id: I3c243714236caf2b93c93adfc8c62e5ee0e69ae9 Reviewed-on: https://chromium-review.googlesource.com/1163417 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for https://chromium-review.googlesource.com/1179488, this CL stops creating ClassicScript when ErrorOccurred() is true. Instead of setting |error_occurred| bool, this CL makes PendingScript::GetSource() return nullptr if an error occurred. This is consistent with the spec: - GetSource() corresponds to "the script's script". - GetSource() == nullptr (previously |error_occurred| == true) corresponds to "the script's script is null". Bug: 875153, 686281 Change-Id: I08d891ce2207894b4a8f8a2d1171f9912c79b8ce Reviewed-on: https://chromium-review.googlesource.com/1179557Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Tab stats metrics preferences are moved to the persistent storage list for incognito mode. This CL does not make any behavioral change. Bug: 861722 Change-Id: I052c8a62d4818a31451ff19baf815848bd3e3294 Reviewed-on: https://chromium-review.googlesource.com/1179145 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#584370}
-
Ramin Halavati authored
kCrossDevicePromo* preferences are removed. Bug: 861722 Change-Id: Ica9b5aa7c0002479c57321aedde3e20ab33e25ca Reviewed-on: https://chromium-review.googlesource.com/1179148Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584369}
-
Anand K. Mistry authored
BUG=873903 Change-Id: I2682b57782944dd61365d8f1b698aa53a604fb5c Reviewed-on: https://chromium-review.googlesource.com/1177208 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#584368}
-
Ramin Halavati authored
Windows promotion preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I2c806b403ecbcf25ce0aab7984e6c313dbc81912 Reviewed-on: https://chromium-review.googlesource.com/1179146Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584367}
-
Alan Cutter authored
This CL adds the HostedAppButtonContainer to GlassBrowserFrameView's hit detection to ensure the correct mouse signal is sent to the OS. This fixes a bug in Windows 10 causing certain mouse movements to deactivate the page info dialog. See screencasts. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=352755&signed_aid=IbjUxm1YHiMINVDpeUwCXQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=352756&signed_aid=-NF8jWWjNwiA1KrUMeuVkQ==&inline=1 Bug: 864386 Change-Id: Ic706784026431d603b44c1a80302fe0f92ee5868 Reviewed-on: https://chromium-review.googlesource.com/1170664 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584366}
-
Ramin Halavati authored
Media Router preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ice965ba421945c6408b6c13b248acafe4181c76f Reviewed-on: https://chromium-review.googlesource.com/1179147 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#584365}
-
tzik authored
clang-cl's diagnostics messages are different to clang++ or gcc. That is not very convenient for the editor support like Emacs compilation mode. This CL adds a configuration flag, use_clang_diagnostics_format, to use clang/gcc style diagnostics. Change-Id: I92599c6025d36af7eff74454d58e2f74e516c627 Reviewed-on: https://chromium-review.googlesource.com/1061034 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584364}
-
Christopher Cameron authored
The function BridgedNativeWidget::SetBounds calls back into the NativeWidgetMac to determine - the minimum content size - if the widget's position should be relative to the parent or the screen (and the offset to do that computation) - if the widget is a modal sheet This call will eventually be running in the app shim process, where these values will not be available (without adding a synchronous IPC). Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl:: SetBounds, and have that function pre-compute the required parameters, - minimum content size - offset necessary to be applied to compensate for position being relative to the parent or the screen - (but not if the widget is a modal sheet, that's coming later) and pass these as parameters to BridgedNativeWidget::SetBounds. Split out the SetBounds calls made during initialization from being within BridgedNativeWidget::Init to being made by its caller, BridgedNativeWidgetHostImpl::InitWindow, to allow the additional parameters to be passed in. This is a re-land of crrev.com/584327 (reverted in crrev.com/584339) with the logic for initial bounds setting separated out into the BridgedNativeWidget::SetInitialBounds (merging the behaviors was too ambitious). TBR=ellyjones (original reviewer) Bug: 859152 Change-Id: I98b6a5d419e586fb2697ef3b45fdc19c73f9c619 Reviewed-on: https://chromium-review.googlesource.com/1180715Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#584363}
-
Tetsui Ohkubo authored
This CL fixes a reentrancy issue in MessagePopupCollection that might cause crash on devices with small screen height. We should set |is_updating_| to true when we call MessagePopupView:: UpdateContents(). Updating contents can change its height, and it might cause the popup to be dismissed because the screen height might not be enough to show the notification. The popup should be closed after the update is finished, but we didn't set |is_updating_| to true, so the popup could accidentally close during UpdateContents(). We didn't catch this until a11y related change https://crrev.com/c/1166231 because |message_view_| was not used after NotifyPopupResized() in MessagePopupView::UpdateContents(). TEST=MessagePopupCollection.UpdateContentsCausesPopupClose BUG=874777 Change-Id: I29cfffec7e967254da0d880667e38805d0cded5a Reviewed-on: https://chromium-review.googlesource.com/1179506 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#584362}
-
Wenzhao Zang authored
There are three places that use |IDS_CONTROLLED_SETTING_POLICY|, but AFAIK there's no need to change the other two places (arc_support_host.cc and extensions_ui.cc). Bug: 873946 Change-Id: I34e9fb0a20139b0aaca6380e949248745f50ed58 Reviewed-on: https://chromium-review.googlesource.com/1180526Reviewed-by:
-
Toni Barzic authored
Have DemoModeResourcesRemover keep track of amount of time the user is interacting with the device (using UserActivityDetector), and once the total amount of active usage is over 8 hours, attempt demo mode resources removal - substantial amount of active usage should be a good signal that the device has been owned by a real user. BUG=827368 TEST=unittests Change-Id: Ib7b90da7da41bdcebbead0f0239579e727f07ae8 Reviewed-on: https://chromium-review.googlesource.com/1180603Reviewed-by:
-
Kentaro Hara authored
This test has been flaky on Mac10.13 Tests TBR=weili@chromium.org Bug: 875707 Change-Id: I71e1f70fb1e7628ba810dccf603d4d58885abb9c Reviewed-on: https://chromium-review.googlesource.com/1180798Reviewed-by:
-
Hwanseung Lee authored
When PreDispatchEventHandler is called, Event object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 871637 Change-Id: Id8f1b05c51024e6418eaf2e7517f6dfb2ec70699 Reviewed-on: https://chromium-review.googlesource.com/1179520Reviewed-by:
-
Timothy Gu authored
This brings us into alignment with the Fetch Standard as well as Firefox and Edge. Bug: 165083, 874536 Change-Id: Id06d07d301aeae8bd0c48bfe94df68cf1ed68db9 Reviewed-on: https://chromium-review.googlesource.com/1176263Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iccd919105fd31fbe83b75d87f15f206e5ad30d36 Reviewed-on: https://chromium-review.googlesource.com/1179514 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
Change-Id: I7d9700f70be42f30239d0b6c5a73a0c852ae416c Reviewed-on: https://chromium-review.googlesource.com/1179723Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
