- 06 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4fbc755cc6bf..a3b840037dfd git log 4fbc755cc6bf..a3b840037dfd --date=short --no-merges --format='%ad %ae %s' 2019-02-06 rmhasan@google.com Fixes issue for tests that are skipped via calling self.skipTest() Created with: gclient setdep -r src/third_party/catapult@a3b840037dfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923494 TBR=sullivan@chromium.org Change-Id: I8c58625e605316c58c7d1a7514dc0952b5aa2571 Reviewed-on: https://chromium-review.googlesource.com/c/1455756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629465}
-
Matt Falkenhagen authored
The UpdateJobTestHelper had a complex start worker sequence. Those operations don't need to be done directly in the start worker IPC mock. This is a small cleanup to help make a big cleanup of the unit test harness to use Mojo. It also cleans up linter warnings along the way. Bug: 927651 Change-Id: Ib3b1a5b698ea6ae2b074863008dcc7f26e01fdd6 Reviewed-on: https://chromium-review.googlesource.com/c/1454337Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629464}
-
Sam McNally authored
Step by step mode doesn't support concurrent remoteCall calls. Each call overwrites window.step with its own function to continue the call. This is error-prone and can be hard to get right. Avoid this by serializing the remoteCall calls when step by step mode is enabled. Bug: 909056 Change-Id: I8970da4bd56eb9df3f03fdf061e7ba19deb5cc61 Reviewed-on: https://chromium-review.googlesource.com/c/1454208Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629463}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b11ecd3564d6..5830d87cf137 git log b11ecd3564d6..5830d87cf137 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 thestig@chromium.org Change CXFA_ContentLayoutItem::GetIndex() to return size_t. Created with: gclient setdep -r src/third_party/pdfium@5830d87cf137 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6f27fe6bdb51c4c6765a3d886169c7af805ab07 Reviewed-on: https://chromium-review.googlesource.com/c/1455371Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I89ec35664f817895065623bb5a1d18b3d65b1953 Reviewed-on: https://chromium-review.googlesource.com/c/1455667Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629461}
-
Sorin Jianu authored
The code is calling into //components/update_client. The code fails at this time because the network is not initialized yet. Bug: 926236 Change-Id: Ib5b6f6b98bb6054bc9b9dbbc64533201c791057d Reviewed-on: https://chromium-review.googlesource.com/c/1452465 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#629460}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I877d45ff9945a02323ce412497241dcf82f23a03 Reviewed-on: https://chromium-review.googlesource.com/c/1455369Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67d70d26b08e..484d74fa21a5 git log 67d70d26b08e..484d74fa21a5 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 mmoss@google.com Add 'chromeos' as one of the DEPS_OS_CHOICES. Created with: gclient setdep -r src/third_party/depot_tools@484d74fa21a5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:928829 TBR=agable@chromium.org Change-Id: I38ca6cd92c076cc0ffe567e138ec2e225ad4b2bd Reviewed-on: https://chromium-review.googlesource.com/c/1455375Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL: - Adds wpt/upgrade-insecure-requests and worker-related subdirectories of wpt/mixed-content. - Fixes the runtime flags for external/wpt/referrer-policy. - Merges multiple README.txt into a single top-level README.md. - Updates README.md to mention classic shared workers. Bug: 835717, 924041 Change-Id: Ifbafe9ca89a0c45d99e23d295430df89125d71ce Reviewed-on: https://chromium-review.googlesource.com/c/1389639Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#629457}
-
David Staessens authored
This CL adds a test that measures VDA performance. Currently only decode FPS is captured by measuring uncapped performance. Future performance tests will also measure capped performance. TEST=ran new VDA tests on nocturne BUG=925714 Change-Id: Ia9f65adba4ca077e85bac03727c2bd11cbbcafee Reviewed-on: https://chromium-review.googlesource.com/c/1429306Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#629456}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7192fd51f570..e0b10f3e2c36 git log 7192fd51f570..e0b10f3e2c36 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 dgarrett@google.com workspace_stage: Add WorkspaceUnitTestStage. Created with: gclient setdep -r src/third_party/chromite@e0b10f3e2c36 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I24deb6338102d6e960005e8440a732b06d227709 Reviewed-on: https://chromium-review.googlesource.com/c/1455600Reviewed-by:
-
Noel Gordon authored
appWindow.fakeKeyDown is async these days so we should await it. Mark audioTimeLeapForward async therefore. Bug: 909056 Change-Id: Iaf72e60a92b3d6c5d9da25410df3768dfb4a6c96 Reviewed-on: https://chromium-review.googlesource.com/c/1454107Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629454}
-
Bailey Berro authored
- Previously the assertion logic in SmbCredentialDialog treated 0 as an invalid mount_id. Since 0 is a valid mount_id, we want to ensure that the assert is only verifying that mount_id is a number. Bug: 928933 Change-Id: I165f6696252265a66af7de488a624d6fc41e5d22 Reviewed-on: https://chromium-review.googlesource.com/c/1455498 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629453}
-
khmel@chromium.org authored
This remove runtime dependencies for the ARC++ settings section creation. Not it is created or not created based on ARC++ availibility for the profile. Runtime conditions now controlls hidden state of the ARC++ settings section. TEST=Manually, AOSP mode, new user sign-in, default settings. BUG=915158 Change-Id: I70fd89c710416514675086ae8982b3643ff64c31 Reviewed-on: https://chromium-review.googlesource.com/c/1455056 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629452}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/09a91e48c066..a69ca6050e3e git log 09a91e48c066..a69ca6050e3e --date=short --no-merges --format='%ad %ae %s' 2019-02-06 capn@google.com Add SPIRV-Tools to the Vulkan build. 2019-02-06 capn@google.com Add Visual Studio project files for SPIRV-Tools. 2019-02-06 capn@google.com Switch to SPIRV-Headers from subtree. 2019-02-06 capn@google.com Suppress Clang warning for unsupported warning. Created with: gclient setdep -r src/third_party/swiftshader@a69ca6050e3e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I7601f4c69b20599a4446418455dae375308f8141 Reviewed-on: https://chromium-review.googlesource.com/c/1455601Reviewed-by:
-
Brandon Wylie authored
Specifics: +66,344 bytes main lib size +512,496 bytes main dex size +822,623 bytes normalized apk size InstallSize: +312,894 bytes APK size +912,514 bytes Estimated installed size (Android Go) +2,383,378 bytes Estimated installed size InstallBreakdown (+2,382,524 bytes): +3,030 bytes unwind_cfi (dev and canary only) size +2,624 bytes Non-compiled Android resources size +66,344 bytes Native code size +563 bytes Package metadata size +2,293,275 bytes Java code size +16,688 bytes Compiled Android resources size Dex: +2,613 entries fields +3,671 entries methods +836 entries types +1,838 entries strings Change-Id: Ia1445c58c65e19a1e65e848a6e2fc68b2e9bdbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1455676Reviewed-by:Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#629450}
-
Eliot Courtney authored
Currently, it does it based on the current position, which means the restore bounds will be set wrongly for flings. Bug: 923210 Test: unit test + test manually with flinging the PIP window Change-Id: I0a8523c3ae70e52d5417ab7f9df51155ececf070 Reviewed-on: https://chromium-review.googlesource.com/c/1454198Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#629449}
-
Emircan Uysaler authored
This CL adds a WebRTC browser tests that sets up a peer connection between two tabs and sends video with a high target bitrate. The target is set as 80 Mbps. To accomodate for this, call is hooked up to a fake codec that does not really do work and can produce these rates from any input. What we expect from this test is to track send_rate/receive_rate stats, which are expected to be below 80 Mbps, and look for regressions or improvements in perf bots. Note that this CL depends on WebRTC Cl below to land first: https://webrtc-review.googlesource.com/c/src/+/97185 Bug: 879723 Change-Id: I1b4b62db4b040d284efc1e7aac7fc6b43517a08c Reviewed-on: https://chromium-review.googlesource.com/c/1198531 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629448}
-
Sunny Sachanandani authored
These tests are flaky so lets disable them until flakiness is resolved. One example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_optional_gpu_tests_rel/14945 https://chromium-swarm.appspot.com/task?id=42d8abfb3443dd10&refresh=10&show_raw=1 [55/61] gpu_tests.trace_integration_test.TraceIntegrationTest.VideoTraceTest_DirectComposition_Underlay failed unexpectedly 7.7090s: ... Swap chain presentation stats collection failed: 0x887a000bL Traceback (most recent call last): _RunGpuTest at content\test\gpu\gpu_tests\gpu_integration_test.py:178 self.RunActualGpuTest(url, *args) RunActualGpuTest at content\test\gpu\gpu_tests\trace_integration_test.py:182 test_result = getattr(self, prefixed_func_name)(category, event_iter) _EvaluateSuccess_CheckVideoMode at content\test\gpu\gpu_tests\trace_integration_test.py:286 no_overlay=False) _CheckVideoModeHelper at content\test\gpu\gpu_tests\trace_integration_test.py:360 presentation_mode_history))) fail at .swarming_module\bin\Lib\unittest\case.py:410 raise self.failureException(msg) AssertionError: SwapChain presentation mode mismatch, expected OVERLAY got [NONE] Bug: 928166 Change-Id: I9c75fa35a884522a3be6d00ca3b2f2258da9d803 Reviewed-on: https://chromium-review.googlesource.com/c/1455664 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629447}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24d1f1a73beb..0c12f92a4b03 git log 24d1f1a73beb..0c12f92a4b03 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 herb@google.com Remove fPreBlendForFilter 2019-02-05 halcanary@google.com third_party/icu: use upstream 2019-02-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-05 ethannicholas@google.com Revert "SkSL is now pickier about type conversions" 2019-02-05 bungeman@google.com s/geTestSVGTypeface/getTestSVGTypeface 2019-02-05 ethannicholas@google.com SkSL is now pickier about type conversions 2019-02-05 herb@google.com Move luminace calculation to the SkScalerContext ctor. 2019-02-05 bsalomon@google.com Remove fIntendedType from GrMtlBuffer. Add accessor to base class 2019-02-05 egdaniel@google.com Make sure the vulkan gpu is done work before we deleting objects in VkHardwareBufferTest. 2019-02-05 egdaniel@google.com Fill in missing GrMtlCaps functions and fix for 0 buffer alloc. 2019-02-05 bungeman@google.com Add a 'correct' shaper. Created with: gclient setdep -r src/third_party/skia@0c12f92a4b03 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: If4f850b8fcb405f8e1553d0f8a587ff3c9e9abbc Reviewed-on: https://chromium-review.googlesource.com/c/1455364Reviewed-by:
-
Ken Russell authored
It's intermittently receiving 'DIRECT' on the Win/Intel bots, which would cause the test to fail. Bug: 927883 Change-Id: I53f2461759d38ddd13bff5a36ea72c6a422c0401 Reviewed-on: https://chromium-review.googlesource.com/c/1455627Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629445}
-
Reka Norman authored
This CL creates a new dom-switch element which ensures that only one element out of a group of elements is attached to the DOM at a time. This is used for switching between different views in the app management page, so that views are detached when not being displayed, and therefore don't evalute meaningless Polymer bindings. Bug: 906508 Change-Id: I7efe91d4087eb17de3e8a5cbe2a8adb870fc6360 Reviewed-on: https://chromium-review.googlesource.com/c/1449959 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#629444}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f662c004270..bf5dbd8d67fe git log 5f662c004270..bf5dbd8d67fe --date=short --no-merges --format='%ad %ae %s' 2019-02-05 jmadill@chromium.org Skip WhitelistMatchesSupport test on Android. Created with: gclient setdep -r src/third_party/angle@bf5dbd8d67fe The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I1622977857607cc7207f0a9902dc24fb706fcd9b Reviewed-on: https://chromium-review.googlesource.com/c/1455370Reviewed-by:
-
Kenneth Russell authored
Seen flaky on Mac/AMD. Bug: 928989 Change-Id: I14b72acfd05867caede48d5c37beeb5cb156df5d Tbr: enne@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1455654Reviewed-by:
-
Takuto Ikuta authored
I replaced mojom.h header in files used for compiling browser_process_impl.cc with mojom-forward.h as many as possible. To fix build failure, I added mojo header files in some cc files too. This CL improved compile time of browser_process_impl.cc from 14.5s to 13.1s on Linux. TBR=rockot@google.com, thakis@chromium.org Bug: 922875 Change-Id: I5311b82f66e97aa7baf5e7a41d2e6358dd670ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1451603 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629441}
-
dpapad authored
Specifically removing from: - chrome://crashes - chrome://dom-distiller - chrome://gpu - chrome://net-internals - chrome://policy-tool - chrome://safe-browsing Bug: 677338 Change-Id: Ib5b35e3eede6c56ecbe192fda6b2e711ce997437 Reviewed-on: https://chromium-review.googlesource.com/c/1449161 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629440}
-
Nigel Tao authored
BUG=826982 Change-Id: Iccaafd0066d536f3557990aead1c41c5e06578fe Reviewed-on: https://chromium-review.googlesource.com/c/1448081Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#629439}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bc6617a165bf..67d70d26b08e git log bc6617a165bf..67d70d26b08e --date=short --no-merges --format='%ad %ae %s' 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@67d70d26b08e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1968d6b49859473b17f1ea584da18ce20e8adfc Reviewed-on: https://chromium-review.googlesource.com/c/1455368Reviewed-by:
-
Suman Kancherla authored
Earlier iteration of the UI had 'VR presentation info' row taller than the rest of the rows. The issue was that the button had a preferred height greater than those of the rest of the controls. The fix was to eat into the top/bottom insets as much as possible to provide a uniform row height. Fixed dialog snapshot - http://bit.ly/pageinfo-vr-row-fixed Compare the height of "VR presentation" row with an existing one - http://bit.ly/pageinfo-vr-row-highlighted VS http://bit.ly/pageinfo-site-settings-row-highlighted Bug: 925150 Change-Id: Ib96af8b5aa09d77d33ebf8a1102c52a85b476844 Reviewed-on: https://chromium-review.googlesource.com/c/1449212Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#629437}
-
Pavel Feldman authored
Bug: 924675 Change-Id: Ice079929fa6764fb12e5e9d9f314c89efdc12ef7 Reviewed-on: https://chromium-review.googlesource.com/c/1453544 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629436}
-
Peter Collingbourne authored
I chose not to make is_hwasan imply ADDRESS_SANITIZER for now because it was unclear how many of the uses of ADDRESS_SANITIZER are about memory error detection in general versus being specific to the ASan implementation. Once we have more of the browser working with hwasan we should revisit this decision. Bug: 916828 Change-Id: I9e26f7e92ffb1f52623cf36980bc5f38cc18f738 Reviewed-on: https://chromium-review.googlesource.com/c/1455104 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629435}
-
Manu Cornet authored
Consolidate "OnShelfAlignmentChanged" behavior by letting the ShelfView be a direct ShellObserver. This needs to be submitted after CL 1454066e (adding the strings). Bug: 890944 Change-Id: Icd98e920e4b6532cc456526b09991ca9161d5522 Reviewed-on: https://chromium-review.googlesource.com/c/1454067 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#629434}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/759afdb33fc6..377617c6c0d9 Created with: gclient setdep -r src-internal@377617c6c0d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I19f6391b1ea0fd8519b0daf516c4b0eccd3a55f1 Reviewed-on: https://chromium-review.googlesource.com/c/1455599Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629433}
-
Thomas Anderson authored
This reverts commit c5a20e34. Reason for revert: Suspected cause of breakage on Google Chrome Mac: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/41147 Original change's description: > Refactor crashpad_handler binary on macOS > > In order to define custom UserStreamDataSources, we need a > chromium-built crashpad_handler binary. This change refactors the > crashpad_handler executable to be built within chromium as > chrome_crashpad_handler and moved into it's final destination under the > original 'crashpad_handler' name. > > Bug: 912286 > Change-Id: I0f52028ae4c149823b30747589e2dd94225694c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1449330 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629394} TBR=thestig@chromium.org,peter@chromium.org,pfeldman@chromium.org,mark@chromium.org,vtsyrklevich@chromium.org Change-Id: I3ef4f33f3ac73c56c1baf3e61287373c308ea364 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912286 Reviewed-on: https://chromium-review.googlesource.com/c/1455655Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#629432}
-
Dale Curtis authored
Both of these shell structs need to have their references released AND then have their allocation deleted. I.e., just releasing the references does not delete the attached memory. While looking into this I noticed that it could be possible to get into a state where a DecoderBuffer is lost, so a DCHECK has been added to call attention to that. BUG=928662,928692 TEST=no more memory leaks. R=liberato Change-Id: Iae06812f1efaef3c1628e2594594cf4e7529a89a Reviewed-on: https://chromium-review.googlesource.com/c/1455663 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#629431}
-
Tao Bai authored
This patch added CaptureContent method in LayerTreeHost to capture the on-screen text content. RTree search is used to get all on-screen PaintOp, and the NodeHolder from the DrawTextBlobPaintOp are returned. Also add unittest for CaptureContent. Bug: 924681 Change-Id: Icfaf5e9dcd3bcdee17acc1afb96034a46ea4572c Reviewed-on: https://chromium-review.googlesource.com/c/1449071 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629430}
-
Kenneth Russell authored
Test has been observed flaky on the commit queue. Bug: 870856 Change-Id: I3840495ea0350417b0aa445c4bb969e05f3edc53 Tbr: enne@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1455619 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Sergey Berezin authored
Bug: 917346 Change-Id: Ia942e7d4da31f8c620c0609a240a1d6534e99eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1455275 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#629428}
-
Caleb Rouleau authored
Bug: 928928 Change-Id: Ie5483356efd7c60925b797a464515103d1b3a101 Reviewed-on: https://chromium-review.googlesource.com/c/1455466 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629427}
-
Christopher Lam authored
AppShortcutLauncherItemController::GetRunningApplications doesn't use any members aside from app id and refocus_url. This CL makes it a static helper function which prevents a full construction of an AppShortcutLauncherItemController. Bug: 836128 Change-Id: I29e2027c1278303108f95b17445ba90ed8f375b1 Reviewed-on: https://chromium-review.googlesource.com/c/1453399 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
