GitLab

At a fundamental level, TrustTokenPersister requires that all of its
url::Origin arguments have meaningful serializations, in order to key
persistent state by their serializations. It currently enforces this by
requiring that all of its operations' origin parameters be non-opaque and
either HTTP or HTTPS.

SuitableTrustTokenOrigin is a url::Origin wrapper encoding closely
related preconditions (IsPotentiallyTrustworthy and HTTP or HTTPS) under
which an origin is suitable for use in a Trust Tokens operation.

This change modifies TrustTokenPersister's interface to take
SuitableTrustTokenOrigins rather than url::Origins.

SuitableTrustTokenOrigin's properties are somewhat stricter than what
TrustTokenPersister needs to require in order to satisfy its contract
(put in state keyed to an origin, get out state corresponding to the
same origin), but all use to of the persister is expected to be of
origins that satisfy SuitableTrustTokenOrigin's requirements in any
case, so the difference between the preconditions it enforces and
TrustTokenPersister's current interface is mostly academic.

This change makes the interface much simpler (not to mention safer) as
preconditions can now be enforced implicitly rather than through method
comments and DCHECKs.

R=csharrison

Bug: 1042962
Change-Id: I5b8db80546b8b2a276d0bebd88d24e18e42581ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134600
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757683}

This reverts commit a42ef137.

Reason for revert: Surprising impact to rendering.mobile/queueing_durations

https://bugs.chromium.org/p/chromium/issues/detail?id=1067937

Original change's description:
> Migrate SensorProviderProxy to use GC mojo wrappers.
> 
> No behavior change. This CL reduces potential risks of use-after-free bugs.
> 
> Bug: 1049056
> Change-Id: Ie9d5865ff5be6203eadb71687a37b501cea51540
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109576
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755272}

TBR=haraken@chromium.org,kouhei@chromium.org,johannkoenig@google.com,talp@chromium.org,chikamune@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1049056
Change-Id: I2cf441cde80a0e1246423879d519ccc14373e20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143011Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757682}

Using wpt-import in Chromium 5c6bfa26.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT"
7920b6e8 "Treat any HTML element with a tabindex attribute as interactive content"
29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT"
83ac7b15 "[css-flexbox] Move relpos-with-percentage-top.html test to WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Iac996c8badba2f7d9da4091a95de8b3a487eac43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142991Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757681}

Previously fuchsia.media.AudioConsumer was used to render output audio
stream only when enabled with a command line flag. Now it's always
used, the flag is no longer required.

Bug: 1027048
Change-Id: I43614e6e40738a5e02d11412fc6906c0eb75f45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117065Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757680}

Refactor tests in dnr_manifest_unittest.cc to use TestRulesetInfo. This
makes them flexible for future changes to the Ruleset schema.

Also for ease of writing tests, provide a copy constructor for
TestRulesetInfo.

BUG=754526

Change-Id: I8a759b9e7f429fb9edfb2aacae7c9b0eb69f028c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141203
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757679}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3a42b258eda..3c1ff62f4cca

git log e3a42b258eda..3c1ff62f4cca --date=short --first-parent --format='%ad %ae %s'
2020-04-08 robertocn@google.com [lucicfg] Update v1.13.0 -> v1.13.1
2020-04-08 wnwen@chromium.org Add brucedawson@ to own post_build_ninja_summary.py

Created with:
  gclient setdep -r src/third_party/depot_tools@3c1ff62f4cca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1027762
Tbr: agable@chromium.org
Change-Id: I8f2935b839164b9e1c3a64caeadacf0a8f60fe04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142972Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757678}

Original patch: https://crrev.com/c/2141209
Revert: https://crrev.com/c/2142334
 Reason for revert:
 ErrorProne usage of array.toString() blocks compilation.

Reason for reland:
 The error get fixed.
 Before: array.toString()
 After: Arrays.toString(array)

Change-Id: Id669ad925c980584911809d83dd10506e0fa9e27
Bug: 1064740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141244Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757677}

Marked histograms as obsolete and removed code referring to them.

Bug: 984217, 975662
Change-Id: I0e3faff4a31cdc775791d582d7d6f6a8421bf595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136125Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757676}

https://chromium-review.googlesource.com/c/chromium/src/+/2123961 had no
unit tests because network::WebSocket has no unit tests, and creating
them would be difficult. Add a browser test instead.

Bug: 1066729
Change-Id: I93b04e4e1f0f7b106530a21bbae8d81478d28a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135669
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757675}

Remove unused methods and inline others in
permission_message_test_util.*. This is a first step; I expect there
may be more - which may be better surfaced through codesearch
after a day to update cross-references.

Bug: None
Change-Id: I08db855f9ae98874bd7c1e6d0ae34341a7ac3475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141835Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757674}

This test was disabled on all platforms but is no longer flaky.
I tested 3000 iterations without any flakes on Linux, ChromeOS,
and Windows.

Bug: 172750
Change-Id: Ib880dea17b77fc6bb79d557f67302e8999072c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142402Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757673}

Add an option to the three dotted menu to report a WebView Bug via
monorail using WebView bug template and Via-WebView-DevTools label.

Rename the menu from nav_menu to options menu since it's no longer
used in navigation through the UI.

Bug: 1051549
Test: Press the option and make sure it redirects to WebView template after logging in
Change-Id: Ie5f379cd9078a9ac83360f51d514bb23c8ecd7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142233
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757672}

This CL adds the toggle button the Views omnibox popup header
implementation.

It's not functional yet, more work needs to be done there, but at least
this puts the control into place with the correct icons.

Bug: 1052522
Change-Id: I792fe426f3474f74de4f03e841e9e13b76af14b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142573
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757671}

This CL adds a method called ReadData() that returns a data pipe
consumer handle. The producer of the data pipe supplies the content of
a service worker script from storage. See [1] for the detail of the
proposal.

The internal implementation is almost the same as
ServiceWorkerInstalledScriptReader. Once ServiceWorkerStorage is
migrated to the storage service, we could stop using
ServiceWorkerInstalledScriptReader and pass the data pipe directly to
renderers.

This CL also moves ReadDataPipe() which was defined in
service_worker_installed_scripts_sender_unittest.cc to
service_worker_test_utils.cc as the function is useful to test
ServiceWorkerStorageControlImpl.

[1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit#heading=h.z6754cqqpv4k

Bug: 1055677
Change-Id: I05aa5a27fabde65102ae3e34781ea1cf39e8b8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138677
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757670}

This CL needs to be reverted because it will impact the way Marketing parses arguments. Ignoring board name from Query URL will happen server side.

Revert "Remove board name from Release Notes query URL."

This reverts commit 412a7947.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove board name from Release Notes query URL.
> 
> Bug: 1068756
> Change-Id: I68fa01f5e16fac4d981b1d26fab6f2d6ba94e7e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141127
> Commit-Queue: Yulun Wu <yulunwu@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757345}

TBR=ellyjones@chromium.org,pkasting@chromium.org,yulunwu@chromium.org

Change-Id: I8af156038f43ede0d26e6c284298f20e4ba5c619
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142720Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757669}

Just adding one tiny link for consistency.

Change-Id: I947f79de292a5156faa92d0b05ff0e460eba1a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141069
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757668}

Service Worker-based extensions.

The previous attempt at doing this use a unified code
path for all extensions. This broke some extensions,
since the new code path doesn't support images in SVG
format.

This iteration keeps the old code path and only uses the
new code path for SW-based extensions. A separate bug
(1064671) is tracking support for SVG images in the new
code path.

Bug: 1015136
Change-Id: I2bceab41742da89980190aab851575d9e085360d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121040
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757667}

This CL moves chromeOS strings for apps section page  from
settings_strings.grdp to chromeos_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Change-Id: I4ba027d4fec6efc5c12f6116e1313d67da790dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142581
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757666}

- Plumb actions from FeedStreamSurface over to MetricsReporter
- Port EngagementType reporting from FeedLoggingBridge to
  work with feed v2.

Bug: 1044139
Change-Id: Ia6478ddcfa25445c15a8874aad20bfccf9fcaad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137854
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757665}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2a74de9d52b..8b2eec58cc7e


Created with:
  gclient setdep -r src-internal@8b2eec58cc7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:790886
Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com
Change-Id: I6248fb2cd4cc9e4d2db34b3302915da400268ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142701Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757664}

Now that the kNonModalDialogs flag has been enabled for multiple
releases, we can remove the legacy dialog implementation and the flag.

Bug: 1068418
Change-Id: I687ca85f004e675e1d462c11cc745887ce1e285d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140776
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757663}

Dragging over cross-site sibling frames is already also tested in
DragAndDropBrowserTest.CrossSiteDrag[1], and more generally in
drag_and_drop_interactive_uitest.cc[2], so trying to do so from
web tests as well is no longer necessary.

This web test was previously disabled due to lack of OOPIF support in
eventSender, and as this support won't be added in the foreseeable
future, this test won't be usable in the foreseeable future anyways.

Note that DragAndDropBrowserTest.CrossSiteDrag[1] and its larger
test suite doesn't cover MacOS and Android, and many tests do not
cover Windows. For more information, see the linked bug and [3].

[1]: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc;drc=37470a6d05cfc50013acde00be27bb7723b1febf;l=1323
[2]: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
[3]: https://chromium-review.googlesource.com/c/chromium/src/+/2142735/2#message-4a4534f4cc55ca581be8ed55a07cabfa0db7631f

Bug: 665058
Change-Id: Iec6b51af03b2edc72fa1fd3ee2c9c6097dc00b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142735
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757662}

In http://crrev.com/c/2121083, LauncherShortcutActivity was modified to
only add the "New incognito tab" shortcut if it hadn't been added
previously. This doesn't work when the device locale changes since the
label text needs to be updated.

This CL backs out that part of the previous change and adds a test to
prevent future regressions.

BUG=1068847

Change-Id: Id6669120687a4fc1f86322c843abb0fe0b4b6056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142733
Commit-Queue: Theresa  <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757661}

CacheStrategy enum is added to the CachedImageMetadataProto to control
the life cycle of cached image files.

Also we plumb the expiration_interval to metadata leveldb. When this
optional has value, the CachedImageMetadataProto will use
CacheStrategy::HOLD_UNTIL_EXPIRED, otherwise use the default
BEST_EFFORT.

Test coverage is added in *ImageMetadataStoreLevelDBTest.Save().

TBR=jianli@chromium.org

Bug: 1067049,1058534
Change-Id: I97080fcc85e3851868ee4c33e2c4b9fca2507744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141132
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757660}

Bug: 1067057
Change-Id: I7acd9f439aa90c0e2f46d28ccc560b165ebe85a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140194
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757659}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: If151197f5e3061aa1e46484e5720892041367b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137200
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757658}

For saved password reuses, the page info bubble
should show the check passwords button and
the mark site as legitimate button. Removed
DCHECK as it's inclusive of all password reuses.

screenshot:
https://screenshot.googleplex.com/S0941Sh1Lo3

Bug: 1068396
Change-Id: I981115cab89ed550dc98285db40745b92acfaef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138509Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757657}

If the ResourceContext has been torn down before we bind the
SafeBrowsing mojo interface, it's possible to create a UaF. This was
fixed for desktop Chrome in
https://chromium-review.googlesource.com/c/chromium/src/+/1972168
by checking that the RenderProcessHost is still active before binding
the interface.

Bug: 1055933
Change-Id: I19633b669a64383cd00d0f999929ff2c37c293fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140065
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757656}

This CL migrates filter-region-transformed-child[-expected].html
tests from css3/filters to external/wpt/css/filter-effects with
WPT styles, adding links to the relevant specs, and test
description.

Additionally, this test is renamed to
filter-region-transformed-child-001[-ref].html to be align with
existing test naming style.

Bug: 1063749
Change-Id: I0b56f85a800bdcbe682e090285098668cd79d743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141569Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#757655}

This CL changes
FromProgrammaticContentScript_PermissionToAllUrls_FileUrls so that it
uses XHR instead of fetch API, because fetch API fails because it
doesn't support file: URLs (and not because CORS blocks the response as
expected by the test).

Bug: 1051594
Change-Id: I3d6c58ce09e3c5fc7d4436c5a78659623006dd24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135380
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757654}

This CL adds IsCrossOrigin, IsTopFrame and IsAdFrame info to
Media.EME.RequestMediaKeySystemAccess UKM.

Bug: 1068642
Change-Id: I103e1fdd11f0a01868b21d2f8a4d9340ac4e1a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139994
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757653}

Add HighlightDisplay() to CrosDisplayConfigController mojo interface.
The new method is used to specify which display
DisplayHighlightController should render the highlights on.

Bind CrosDisplayConfig interface to OSSettingsUI to support setting
selected display from Displays Settings page.

Bug: 1068252
Change-Id: Ie077eff838d79d6774f4a03a0998af201bfc43e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111752Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Su Hong Koo <sukoo@google.com>
Cr-Commit-Position: refs/heads/master@{#757652}

Bug: 1026426
Change-Id: I328de7bfaf6d6f5501e0fc386dd64e901fa387e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141129
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757651}

State updates from Android side is valid only if an ARC app is
focused.
This CL factors out the check to a separate method to avoid having the
repeated comments.
This should not cause any behaviour change.

Bug: 1063740
Test: components_unittests
Change-Id: I56a558d2fbc5478a58b917a10768620f66d3d510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142071Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757650}

This standardizes visitors by making sure all nodes have them
where it makes sense, and also making them have a return value
(useful for many simple cases).

It additionally adds a RenderFrameHostProxy, so all node types
now have a corresponding PM->UI thread WeakPtr like mechanism.

Change-Id: I17da13fd5ec42500b3a0034e0fa58898c5e51805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141043
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757649}

Migrated iOS bots that use the Chromium recipe have the
xcode build version set by the GN template.

This required the user to look at two locations to migrate
the version. This change deprecates the xcode version set in
GN files, and moves it to //testing/buildbot alongside the
xcode cache set for the Swarming task.

Xcode 11c29 is still passed to the test runner, and should not
have any overall change.

Bug: 1055164,912681
Change-Id: I67695a18a3cbfb1fde2f57ed9ae6efb41ae4089d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135835
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757648}

NewTabPageCustomizeDialogTest was disabled due to flakiness, e.g.
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8884313005389563392
From this run it appears that the scroll border tests are causing the
flakiness. This CL re-enables the NewTabPageCustomizeDialogTest and
disables the scroll border tests to at least re-gain coverage of the
other NewTabPageCustomizeDialogTests.

Bug: 1066459
Change-Id: I6477efb6763ce80ec84d581dcb9e73907850cdd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142731
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757647}

https://webrtc.googlesource.com/src.git/+log/5185df5cad73..8d8bae65e67d

git log 5185df5cad73..8d8bae65e67d --date=short --first-parent --format='%ad %ae %s'
2020-04-08 kthelgason@webrtc.org Migrate to modern selector syntax for ObjcVideoEncoderFactory.

Created with:
  gclient setdep -r src/third_party/webrtc@8d8bae65e67d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iba40fd254925712a6fa5c6a523dc5668fb5726d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142698Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757646}

This allows users to experiment with
webviews via touch.

Bug: 1011977
Test: Run client, experiment.
Change-Id: Iffbb528e5858ad8e6fbab122633ee14d25428d02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122912Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#757645}

This is an experimental tool which will inject a thread into a Chrome
process (tested on the browser and GPU process) and run code to call
HeapSetInformation with HEAP_OPTIMIZE_RESOURCES_CURRENT_VERSION. This
tells Windows to trim unnecessary memory from the heaps in that process.

This tool uses sketchy techniques such as copying memory from one
executable to another (only works if the code is relocatable and has no
external references), VirtualAllocEx, and CreateRemoteThread. This is
not for production use.

To build run build.bat
To run either run it manually (passing the PIDs of the processes of
interest) or run trim_loop.bat (passing the PIDs of the processes of
interest) to run it every five minutes in a loop.

While it sometimes frees non-trivial amounts of memory the savings are
not persistent.

Bug: 1050059, 982452
Change-Id: I646c515e59598c2c3003500419c154bacd34aeda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139127
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@google.com>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757644}