- 13 Apr, 2019 22 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e064014eb2b..065f8dc35f9d git log 1e064014eb2b..065f8dc35f9d --date=short --no-merges --format='%ad %ae %s' 2019-04-12 timvp@google.com Vulkan: Set appropriate GL conformant bit for returned configs 2019-04-12 courtneygo@google.com Always enable NPOT for Vulkan backend Created with: gclient setdep -r src/third_party/angle@065f8dc35f9d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibaae8448a10a43e42d3a363ce9aa93116024af80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650553}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/7035af5fc366..5a2a472741f3 $ git log 7035af5fc..5a2a47274 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 cmumford Fixed missing std namespaces and make_unique. 2019-04-11 cmumford Simplify issue320_test. 2019-04-11 cmumford Fix formatting of recent snapshot compaction fix. 2019-04-11 cmumford Fixed typo in comment in version_set.h. 2019-04-01 costan Align version/soversion CMake setup closer with other repositories. 2016-01-24 richcole Fix snapshot compaction bug 2019-04-01 no-reply Restore soname versioning with CMake build 2019-03-29 cmumford Update the version to 1.21 in preparation for a new release. 2019-03-29 no-reply Project import generated by Copybara. 2019-03-28 costan leveldb: Register in copybara whitelist. 2019-03-27 costan leveldb: Minor cleanup in ports. 2019-03-26 costan leveldb: Silence unused argument warnings in MSVC. 2019-03-21 costan leveldb: Add tests for empty keys and values. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: Iad3900f3c659b40a8137514b25ab8f5ce99a1c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566355 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#650552}
-
David Dorwin authored
The index of the object does not change when newly_connected so we can set it once upon creation. Change-Id: I15eaedad1b299b0ff6cc840496eb9cef5828e42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566458 Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#650551}
-
Alexander Alekseev authored
Bug: 692364 Change-Id: Ib42c71c66094088d4c0644ba3b151700e110351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565710 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#650550}
-
Tommy Steimel authored
This CL adds a check to delay emitting signals until the service has started. This prevents a race condition where an MprisService user (e.g. MediaKeysListenerManager) would cause signals to be emitted before the service was ready. Bug: 952113 Change-Id: I2fecfbb5507e9ab25700263e1972bc80a606a3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566625Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#650549}
-
Tom Anderson authored
BUG=923166 R=thestig Change-Id: I05eb7dbfe270fce342295a569728b34be3a3f77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566354 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#650548}
-
Hiroki Nakagawa authored
This getter was introduced by the following change but it is never used. https://chromium-review.googlesource.com/c/chromium/src/+/1178811 Bug: n/a Change-Id: If5f0181216e45ec3f5290c5ae327d6603e7a7f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558556 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#650547}
-
Alexander Timin authored
Shutdown tracing doesn't work for Perfetto due to complications around the shutdown sequence for the services. In order to make startup tracing usable with perfetto, disable shutdown tracing for it and just finalize the startup tracing when we have a chance. R=eseckler@chromium.org,oysteine@chromium.org Bug: 944107 Change-Id: I34a1fc6517e2cd633e9f8704fb742d5c7816e61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550431 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#650546}
-
Yuwei Huang authored
This CL make FtlSignalingPlayground uses WebRtcTransport so that it can do candidate exchange using WebRTC protocol. Bug: 947337 Change-Id: If597d020f244e144bfde23c3cbea8a41e39c93c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566421 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#650545}
-
Ryan Hansberry authored
When MultiDeviceSetupClient was integrated, a subtle bug was also introduced. Its default state for all features is kProhibitedByPolicy, which made the initial call to IsAllowed() in EasyUnlockService::UpdateAppState() return false, since MultiDeviceSetupClient is still being initialized when this call is made. EasyUnlockService remained not fully set up because of this issue, preventing its PowerManager from being instantiated. This CL simply informs the base class when MultiDeviceSetupClient is fully initialized, in order to complete EasyUnlockService initialization. Bug: 952496, 950758 Change-Id: Ibb5741c3dc9d3ec0fd5fc8d1cac78275ea0fb2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564327 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#650544}
-
yilkal authored
Bug: 944118 Change-Id: I6ac8ce83c6037a6c6db3b15a111414c68707c8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548567 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#650543}
-
Jimmy Gong authored
- PpdResolution holds the state of active PpdReference resolutions. - Will be incorporated in a later class, PpdReferenceTracker. - Adds unit test for this class. Bug: 932202 Test: --gtest_filter=PpdResolutionStateTest.* Change-Id: I9135e24fd883ae06cb483dc7c12ae7d996564bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565377 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#650542}
-
Xianzhu Wang authored
The code was needed before we painted collapsed borders using table row as the display item client. Bug: 663208 Change-Id: I0ee5033da9405f7a1b4c94ca52b71c88578b3d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566613Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650541}
-
chrome://reset-passwordBettina authored
Bug: 949584 Change-Id: I10b682f9f0f9a7b558c2a9bf31eaf122a38c62e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565388Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#650540}
-
Vlad Tsyrklevich authored
Currently, the allocation and deallocation stack traces are stored in separate 200 byte buffers. This change stores them together in a single 400-byte buffer so that deallocations can use any unused space from the allocation. This improves memory density for deallocations (which is usually what we care most about in UAFs) and does not affect allocations. Bug: 951410 Change-Id: I6fa36a80a605b16eb2d92919b3fd4a5ff60dfc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566455 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#650539}
-
Xiaoqian Dai authored
This is an initial CL to allow dragging overview window to snap to splitview in clamshell mode. - Add a feature flag "DragToSnapInClamshellMode" - In clamshell mode, split view mode behaviors are very different with that in tablet mode. Split view mode is only active during an overview session. Once the user has selected two windows to snap to both side of the screen, split view mode is no longer active. See https://drive.google.com/open?id=15A2CSJxxRfewbPzMvlhe5SmpST1TGJTC for demo. Bug: 890029 Change-Id: Iac9cc8f80b28df1d15b761fbb38e30b6a48c3214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559113 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#650538}
-
Sinan Sahin authored
Bug: 951095 Change-Id: I7c0b4fcf529bddff9f8918d57ab707a860e7d505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562729Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#650537}
-
Matt Reynolds authored
When the network location provider is in use, Chrome periodically scans for nearby WiFi access points. The MAC addresses of these access points are sent to a Google service, which returns a position estimate. To limit network traffic when a device is not moving, a cache of recent position estimates is maintained. If the set of MAC addresses exactly matches a previous query, the cached estimate is used instead. This adds metrics for recording whether a cached value was used. It also records how many items were in the cache when the cache is queried. BUG=944320 Change-Id: I385e1f76099207dd9276edc258a958959945058f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532255 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#650536}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/9e84364c1893..546cc453efd0 $ git log 9e84364c1..546cc453e --date=short --no-merges --format='%ad %ae %s' 2019-04-12 zhongyi Add new methods to QuicFramer for controlling decrypters Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie3637d319e7a674dad8482f4ae3ab49732e15360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566714 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#650535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd92a27aa122..0d6826ff6cd9 Created with: gclient setdep -r src-internal@0d6826ff6cd9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:925042,chromium:932622,chromium:952397 TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I3ca87012827f0aef705302fce0f9704f9d6f6519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650534}
-
Ehsan Karamad authored
The actual data type was removed in https://crrev.com/c/1555075. This CL removes the aliases SandboxFlag and SandboxFlags and uses WebSandboxFlags everywhere. This is purely mechanical and should not change any code behavior. TBR=haraken@chromium.org Bug: None Change-Id: Ia8f43ecbd4508ff2da2b8883e0f52f0de412bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565180Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#650533}
-
Daniel Rubery authored
Javascript can only be invoked from the UI thread, so call over to the UI thread before sending CRSBLOG messages to the WebUI. This also fixes a bug where, if messages were sent before the WebUI had fully initialized, we would fail to execute the Javascript, causing a CHECK failure. Bug: 952333 Change-Id: I0b3a5eb90f8993c6e19d52179b727e8784139bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566618Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#650532}
-
- 12 Apr, 2019 18 commits
-
-
Regan Hsu authored
This CL copies the settings-menu and settings-ui polymer components used by the currently combined OS and Browser settings page to the future exclusive OS settings page. Bug: 950007 Change-Id: Iae62bae39b89c841f53c1eca8a942ab8ee51c580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564804Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650531}
-
Jonathan Metzman authored
This reverts commit 3b8a3ffc. Reason for revert: Breaks bots. Original change's description: > Don't build seed corpora in most configs and delete duplicated config > > Only build seed corpora where it is necessary, in order to reduce > build sizes. > > Bug: 952412 > Change-Id: I6e529226d4ba51fd547c1869525a9f094fdcd998 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566454 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650506} TBR=dpranke@chromium.org,mbarbella@chromium.org,mmoroz@chromium.org,bpastene@chromium.org,metzman@chromium.org Change-Id: I1f826c43ced0959d6ef86a657d6b5ac2bdcc0110 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566728Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#650530}
-
Esmael El-Moslimany authored
Bug: 736891 Change-Id: I0f0aaa2450fc430aeab26b7322447b9c00a35046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565244 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#650529}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/09591b87bdf1..7d867277f805 git log 09591b87bdf1..7d867277f805 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 capn@google.com Implement basic SPIR-V texture sampling 2019-04-12 chrisforbes@google.com Adjust matrix addressing to account for RowMajor/ColMajor 2019-04-12 chrisforbes@google.com Capture RowMajor/ColMajor decorations 2019-04-12 chrisforbes@google.com Fix handling of loads/stores of explicitly-laid-out objects Created with: gclient setdep -r src/third_party/swiftshader@7d867277f805 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128690261,chromium:b/128690261,chromium:b/128690261 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I58d2954c508e4889e48f49ae14fa95104886363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650528}
-
Jimmy Gong authored
- Previous implementation of detected_printer_ppd_references_ used UniquePtrs to simulate optional PpdReference values to a map. - This change changes the UniquePtr to base::Optional. Bug: 932202 Test: browser_tests --gtest_filter=CrSettingsPrinting* Change-Id: I9131bef5140ea0c3cb115c489975fae959bea21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560494 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#650527}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/330fbee5d870..3af5c4c3547b git log 330fbee5d870..3af5c4c3547b --date=short --no-merges --format='%ad %ae %s' 2019-04-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f1e8910d..9ba7465f (650313:650428) Created with: gclient setdep -r src/third_party/webrtc@3af5c4c3547b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I35878a0243232c894a2115771c420fee8e3c61c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650526}
-
Yusuf Ozuysal authored
This is a UMA action that was added for HTS, but is missing from GTS. It triggers when the user creates a group via the "Create Group" button inside the tab switcher. BUG=952478 Change-Id: Ic5a7b090906ac979da77e633a6c9fd9afc2e8c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566718Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#650525}
-
Evan Stade authored
CreateWindowResizer was unintentionally aborting early, before calling CreateWindowResizerForTabletMode. Thus it applied the resizable check to windows that shouldn't have gotten it, such as non-resizable ARC windows in tablet mode. Bug: 947769 Change-Id: If0863936c8bdb43513fd4b3d8ba39d597275d604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565355 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#650524}
-
danakj authored
Remove caching of the OverscrollBehavior in OverscrollController, and then stop plumbing it through DidOverscroll, when RenderWidget can access the last set behaviour on its own. The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. R=dcheng@chromium.org Bug: 912193 Change-Id: Ib501ade7e2563dbfb856f3b7295038546cbc8915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554644 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#650523}
-
Cliff Smolinsky authored
This change adds LoadSystemLibrary to NativeLibrary to allow usage of the NativeLibrary abstraction when loading system dlls and prevent dll loading attacks. This change also moves ScopedNativeLibrary to base off of ScopedGeneric so that the scoped class gets all the benefits of ScopedGeneric without having to re-invent. Bug: 1551709 Change-Id: I17a14678687bd7d167ab0dad1cff5dbce53c3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560294 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#650522}
-
Peter Kasting authored
Bug: 951038 Change-Id: I7f4c327d42f1f9a6f99b03f5f51e0f4684916656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562518 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#650521}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=none Change-Id: I9f2b04096548aeac6aac029ba1a02094b4fbc10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566678 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#650520}
-
Peter Boström authored
This makes the Extensions menu use a standard title and close-x. The footer entry is easier to notice and understand. Removes work that's been done for custom headers. First-iteration work is not looking to introduce panes to this dialog. Bug: chromium:943702 Change-Id: Ic42fa05953be92f0a53448dc1a7f1c628a511dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566619 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#650519}
-
Simon Que authored
These categories are based on which version of the RBE backend the builders use. R=dpranke@chromium.org, hinoka@chromium.org, jbudorick@chromium.org Bug: 947436 Change-Id: I95540e17b6ff72f58f38e1943aa4b7f14b6588eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564286Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#650518}
-
David Bienvenu authored
This reverts commit a394b883. Reason for revert: Caused a regression restoring minimized windows. crbug.com/952142 Original change's description: > Restore browser windows to correct desktop on Win10 > > Bug: 873414 > Change-Id: Iaffc14914d658866e9d1c7e1e794a8754a5ce9a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559168 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649726} TBR=bsep@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873414 Change-Id: Ib475a3d98147b0b6f90e43619640768e0d226dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566617Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650517}
-
Xiyuan Xia authored
Add an assert to catch the case where the derived tests forgot to call PerformanceTest::SetUpOnMainThread to start tracing. Bug: 945709 Change-Id: Id3a659f172f5fde09220003b7a3fc57f18c832fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566610 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#650516}
-
Natalie Chouinard authored
leveldb_proto databases will soon be migrated from unique LevelDB instances to a single shared underlying database. Because of this, we need to migrate to the new API to construct and initialize the database. Bug: 941796 Change-Id: Ic0462828c5dc1c026ffb08c2cec236f023b4478b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559699Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#650515}
-
Chris Harrelson authored
A synthetic mask layer is not needed if there is no content under it which draws. This patch implements that optimization, and also adds a new optimization to CompositedLayerMapping to set DrawsContent to false for layers which have empty size. The patch also removes one unused method from cc::Layer. Bug: 947715 Change-Id: I7625fc251a3dc04ce5319edc56a9dc5fccf27564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566029 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650514}
-