- 19 Feb, 2020 40 commits
-
-
Felicia Lim authored
Tested media/test/data/opus-trimming-test.ogg/webm/opus-trimming-test.ogg playback in a chrome session (see https://bugs.chromium.org/p/chromium/issues/detail?id=1051111#c6) Bug: 1051111 Change-Id: Ib9a4b3a91d09720939286f9101c5ac61048b1dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057642Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742784}
-
Xiaohui Chen authored
Bug: 149759085 Test: run integration tests Change-Id: Ib6ef5db411f7e1eb6571ca5568178536e726b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062685 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742783}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, the route list of settings subpage routes in isOSSettingsSubPage was incomplete. The CL adds chromeOS routes that were missing. ChromeOs pages which can be opened by android intents are added to the ChromePage enum. Originally this listed was curated and only whitelisted chrome pages could be added. This was because of security concerns. https://chromium-review.googlesource.com/c/chromium/src/+/750501/. In https://chromium-review.googlesource.com/c/chromium/src/+/784396/ whitelisting was removed and all settings URLs where now accessible to android intents. Bug: 982445 Change-Id: I67a1bb665f4705fe5a379f7da920878732606628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036935Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#742782}
-
Long Cheng authored
This is a reland of ace0df39 Original change's description: > Fix default page break for Krane devices. > > Adding default page break too early will cause the default page break > gets deleted immediately. > > Now move the installation of default page break after ChromeOS settings > app is installed. > > Bug: 1031410 > Test: Manual > > Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Long Cheng <lgcheng@google.com> > Cr-Commit-Position: refs/heads/master@{#742304} Bug: 1031410 Change-Id: I6367b3ae44a05f85a014723078c6718ac4832c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064601 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
-
Sven Zheng authored
Fix test failure when binary built with --dcheck_always_on=true. Bug: 958242 Change-Id: Ic4645e517c0f29169e444fb1b6d3b1b2921720d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063223 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742780}
-
Piotr Bialecki authored
Bug: https://crbug.com/1054042 Change-Id: I5b3009997f76ec79f9ffc6abb1ba669f3f010ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063671 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742779}
-
Xiaoqian Dai authored
- The back gesture contextual nudge ui will appear when a user navigates to the second page within any Chrome apps in tablet mode. Show frequency: * It only shows once per active day for over 3 days per user * and the user hasn't been done back gesture successfully for 7 times Bug: 1009005b Change-Id: Ide2dbf46be1dfcd0963d4466448f5a6ff5d62f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062917 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
There have been a few major refactors of Switch Access recently. This change looks at AutoScanManager and cleans up things that are now overly complex, or need adjusting. Bug: None Change-Id: Ic77fb49a143ce91ff90099f773f613bd2f9e55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056502Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#742777}
-
Jose Lopes authored
This is a repeating callback because the field: EncryptedMediaInitDataCB encrypted_media_init_data_cb_ defined in: https://cs.chromium.org/chromium/src/media/filters/chunk_demuxer.h?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=477 binds in: https://cs.chromium.org/chromium/src/media/filters/chunk_demuxer.cc?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=674 against a base::RepeatingCallback declared in: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=152 to a type alias defined in: https://cs.chromium.org/chromium/src/media/base/stream_parser.h?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=108 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I393047264102bc9b847e6603f8e79913acd6d009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036062Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#742776}
-
Jose Lopes authored
I accidentally hit submit on a CL with an open comment asking to replace reset with make_unique. So I am sending another CL with that change. Bug: 714018 Change-Id: I147f54feafd86c970096f6385273a7fa57e96227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062402Reviewed-by:
-
Alison Maher authored
Add support for fieldset fragmentation. This change assumes that fieldset content (including the legend) is monolithic. Follow up CLs will handle the fragmentation for fieldset content. Tests added to NGFieldsetLayoutAlgorithmTest. Bug: 875235 Change-Id: I08c30d1a99715d3a326b9c2064166a82385048f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057584 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#742774}
-
liberato@chromium.org authored
TextureWrapper::ProcessTexture is now given the d3d texture, array slice directly. By decoupling the decoder and copy / bind steps, it makes it easier to build the standalone TextureImporter to handle the latter. Change-Id: I9c4261172e8d2c868f34751831b1e7b184c67c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003077 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#742773}
-
Will Harris authored
BrowserRenderProcessHost.OnChannelError Removed because it was not being used. Windows.GetVersionExVersion Windows.PatchLevel Expires never, because used to determine Windows population for security mitigations and other features/deprecations. CrashExitCodes.Extension CrashExitCodes.Renderer Both of these are critical stability metrics for analysing stability spikes. ChildProcess.Crashed2 ChildProcess.Killed2 Used to determine spikes in child process terminations. BUG=1053238,1053188,1052955,1052945 Change-Id: Ie73b80c98ba7724a59207511580c40f9aa8699d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062757Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#742772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f1ad0dc47b5..28abea51fa9b git log 5f1ad0dc47b5..28abea51fa9b --date=short --first-parent --format='%ad %ae %s' 2020-02-19 mtklein@google.com dip our toes into c++11 style [[attributes]] 2020-02-19 cwallez@chromium.org Fix compilation of Dawn backend after GrMesh/GrPrimitiveType change 2020-02-19 jlavrova@google.com layout/relayout with different widths and justification 2020-02-19 csmartdalton@google.com Improve the mechanism to suppress warning messages during testing 2020-02-19 jvanverth@google.com Reland "Manage renderCmdEncoder over lifetime of GrMtlOpsRenderPass." Created with: gclient setdep -r src/third_party/skia@28abea51fa9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I4cecfc2adefd03d8aba203d2a506a352962f4c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742771}
-
Paul Moy authored
Add current, technology and status to the battery metrics already collected by DeviceStatusCollector. Of these three, only technology is expected to change infrequently, so sample current and status more frequently. CrosHealthdServiceConnectionTest.ProbeTelemetryInfo Bug: chromium:1053755 Test: DeviceStatusCollectorTest.TestCrosHealthdInfo and Change-Id: I30f7abfcdd35e71972ce4f053b9433ba61f71cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064458Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Johannes Henkel authored
... in https://bugs.chromium.org/p/chromium/issues/detail?id=1044989 Change-Id: I8ee0c982f0770e76dd23df3a84749af98bf8c2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063851Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742769}
-
Matt Jones authored
The current set of experiments are not slated for launch, this patch updates the field trial config to match that expectation. Change-Id: I0299edbcc9cc38f49e55f725c31c67dbdf4ef951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057153 Auto-Submit: Matthew Jones <mdjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742768}
-
Michael Sun authored
Unlike most keyboards, which have a single Play/Pause toggle key, Bluetooth devices with AVRCP (Audio/Video Remote Control Profile) generate separate Play and Pause key events based on the media status. This patch adds handling for the Play media key. BUG=b/147364135 Change-Id: Ie3cbc4c02ceab8e317f79d089eb8b163aa3ed658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062941Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742767}
-
Evan Stade authored
The shared parts of TabModalPresenter, which include layout inflation, animations, and some accessibility, are moved into //components. Chrome-specific specialization is delegated via abstract methods. Bug: 1045499, 1025256 Change-Id: I2e37561338344495c6ee5cf5e0606c0f76e2c6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048846 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742766}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/36133b04c0d3..55f2e4a0a80d $ git log 36133b04c..55f2e4a0a --date=short --no-merges --format='%ad %ae %s' 2020-02-18 marpan vp9-rtc: Increase partition threshold to 8x8 for high Q 2020-02-18 jianj Cap delta_q_uv to -15..15 2020-02-18 marpan vp9-rtc: Set enable_adaptive_subpel_force_stop to 0 2020-02-14 jzern vp8_decode: add missing vpx_clear_system_state 2020-02-14 jzern vp8,GetSigned: silence unsigned int overflow warning 2020-02-14 jzern move common attribute defs to compiler_attributes.h 2020-01-27 chengchen Add a unit test to check partition info 2020-02-10 chengchen Set mv to zero if the second ref does not exist 2020-02-10 angiebird Do save/restore_encode_params when rate_ctrl is on 2020-02-06 angiebird Replace NULL by nullptr in simple_encode.c/h 2020-02-06 angiebird Sync simple_encode.h 2020-02-06 angiebird Rename inverse_vpx_rational to invert_vpx_rational 2020-02-02 chengchen Consistency test for motion vector info 2020-02-02 chengchen Pass motion vector info to encode frame result 2020-02-03 angiebird Let SimpleEncode be able to output bitstream 2020-01-23 angiebird Add coded_frame to EncodeFrameResults 2020-01-27 chengchen Store frame motion vector info Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ia40bb8ec844923e9a5452ca45a5042d72c303b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063907Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#742765}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3db377c1c2ae..920836be70be Created with: gclient setdep -r src-internal@920836be70be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8f711183a1edff873cf985dcd32d997b33a380f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064455Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742764}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/21e5074dcdb8..b330ea6b491e git log 21e5074dcdb8..b330ea6b491e --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Roll third_party/swiftshader/ e7ce4e539..8def9063c (283 commits) Created with: gclient setdep -r src/third_party/dawn@b330ea6b491e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia04d57229d468d8ad677ae38bcb6ed63bfe01c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064456Reviewed-by:
-
Tommy Steimel authored
Bug: 1046682 Change-Id: Iec63e55c5f8c9797b135f5bbe4c0099fa2b9b66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057097Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e68978417ac4..9e2a2ae74ddf git log e68978417ac4..9e2a2ae74ddf --date=short --first-parent --format='%ad %ae %s' 2020-02-19 kahinds@microsoft.com Fix high contrast colors for toolbar links and items Created with: gclient setdep -r src/third_party/devtools-frontend/src@9e2a2ae74ddf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I18f968846c2cce1e88d10109c673763fa41333c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064438Reviewed-by:
-
Robert Sesek authored
Bug: 710376 Change-Id: I91314e43fee06ebdbb1e813f38f1ec00504a31f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051186Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742760}
-
Robert Sesek authored
Bug: 778317 Change-Id: Ia5bd54efcc427b93ebb78f6a4b2f3960f3fae217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063911Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742759}
-
Xianzhu Wang authored
- Adjust CHECK and DCHECKs - Let LinkHighlightImpl not hold Persistent<Node> - Fix the test added in crrev.com/c/2063770. Change-Id: Icfd99c5d9ebd5f2b09eb0d7ee619014fb80564ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060821Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742758}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72b091b4. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia79c43baf16621a5d6ef8429120dd31da33dba91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064470Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742757}
-
Lei Zhang authored
Consistently expire them in M90. Bug: 1036986 Change-Id: Ic1270ac0228dc5045d1e9222d24a8f6603e58c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055561Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742756}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e63268dc86c..638948939287 git log 7e63268dc86c..638948939287 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 treehugger-gerrit@google.com Merge "Remove inaccurate information from log." 2020-02-19 taylori@google.com Merge "perfetto-ui: Fix stale heap profile viewing option" 2020-02-19 treehugger-gerrit@google.com Merge "cts: add perf profiler e2e tests for apps" Created with: gclient setdep -r src/third_party/perfetto@638948939287 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I818ea3073929ad351a9484d7290796dc89fd0a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064434Reviewed-by:
-
Robert Ogden authored
Checks that the user has allowed pre* actions before prefetching a link. Bug: 1023486 Change-Id: Ie1f6c2315124c3cfcdc13f41ae9cf1d126fa733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064462Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#742754}
-
Peter Wen authored
Speeds up java compilation. According to go/project-turbo's metrics, updating dagger speeds up compilation from 55.6s to 54.1s (by 1.5s). This speedup comes purely from reduction of annotation processing time previously used by dagger, which is O(seconds), thus it is an impressive feat by the dagger team. Bug: 906803 Change-Id: I792e5cdaf879112c6822dacd3f228ed01460df9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050741 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Conley Owens <cco3@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742753}
-
Yue Zhang authored
Since fixes http://crrev.com/c/2036874 and http://crrev.com/c/2048988 don't eliminate all crashes caused by recycling detached item in popup tab strip, this CL block the crashing path by disabling the item animation for Duet-TabStrip integration to get rid of the crash. Note that this CL is a band-aid fix in sacrifice of animation. Bug: 1045944 Change-Id: I3301deed92e40f4fe2306d1ef1ff5ceadc3edbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064453 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742752}
-
Daniel Clark authored
When accessibility is enabled, the date/time picker popup icon inside of a date/datetime-local/week/month/time control is focusable (this dates back to https://codereview.chromium.org/577553002). However, the refreshed controls were not drawing a focus rect for the icon. With this change we now draw a focus rect. The change moves some of the padding-inline-start for these icons to margin-inline-start so that the focus rect is centered instead of surrounding a bunch of empty space to the left of the icon. This padding difference affects the appearance of the controls in high-contrast mode -- see the images baseline updates with this change -- but I believe these differences are reasonable. I haven't been able to include a test here because PickerIndicatorElement::DidNotifySubtreeInsertionsToDocument() has an early return before applying focusability to the icon when running in a test environment. Fixing this is outside of the scope of this bugfix but I've filed crbug.com/1054048 to follow up. Bug: 1053326 Change-Id: I2e3a2b42398b04187eeddd94d28ffafdd745d260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062679 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742751}
-
Clark DuVall authored
This required moving all the strings and icons that are referenced in PermissionRequestImpl as well. kProductIcon which is used for the PROTECTED_MEDIA_IDENTIFIER on ChromeOS was left in //chrome since kProductIcon is different depending on chrome branding. The IDR_* resources used on Android were moved in a way that still works with chrome's ResourceMapper. WebLayer will need a similar system to map the native IDR_* constants to Android drawable resources. Bug: 1025609 Change-Id: I21724ce14a006b89e30f027971165a40fce85177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055888Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742750}
-
Luke Zielinski authored
Previously we'd ask typ for all "Skip" expectations and then loop over all tests to look up their baselines. In a future CL we'll need to look at other (non-Skip) expectations for all tests as well, and since we're already looping over tests to find baselines we might as well query the expectations at the same time. This also changes the return type of "get_tests_needing_metadata" into a dict (rather than list of pairs), which makes it easier to attach new more statuses to a test as we process more input. This change should functionally be a no-op. Tested: built metadata with and without this change and recursively diffed. Validated that changes make sense. Bug: 937369 Change-Id: I80c68c6326f20c864c4b1c6334116c5d2c0498ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024457 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#742749}
-
Monica Basta authored
This CL contributes to changing the API to get the primary account from the identity manager to be consent-aware. |HasUnconsentedPrimaryAccount| is replaced with |HasPrimaryAccount(ConsentLevel::kNotRequired)| TBR=droger@chromium.org Bug: 1046746 Change-Id: I2bfe2a79e78752a58cf40011db75a8e50fb2aae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064649Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#742748}
-
Michael Crouse authored
This change records any requested/used model feature supported by the client and requested to be used by a prediction model. Bug: 1052435 Change-Id: I16e8e7b9cab39b173bdc0be5e329fb181853d656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057121 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742747}
-
Maksym Onufriienko authored
Changes in this cl: - added test_apps(Gtest and EGtests) to reduce code duplication ( filling xctest_run files for EG1 and EG2 tests, filtering tests, creating commands to run tests). -Removes shard_xctest method and other EG sharding code from test_runner because shards only use in xcodebuild_runner. - updated *runner.py to support test_apps - replaced `iossim` with `xcodebuild` command. In following cls: 1. iossim parameter will be removed in all test-runners and unittests and then 2. ios/api.py remove iossim. Bug: 1011498 Change-Id: I9966ba1152eabeee56457fa8db3b6e9f585df3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961166 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#742746}
-
Aga Wronska authored
We were showing paused dialog for every app that was stopped when time limit was reached. This was resulting in bad user experience when Chrome was reaching the limit, because all installed web apps are paused then and user was seeing multiple dialogs (one per every web app). Now we show the dialog only for active app. When web app is active there will be one dialog displayed. When Chrome is active there will be no dialog, but the interstitial page. This should not change anything for ARC++ apps. Bug: 1052040 Change-Id: If4b4827ffb6dd7d022170c6503bf8e109c4bfb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063219 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#742745}
-
