- 26 Oct, 2020 40 commits
-
-
Meilin Wang authored
This CL polishes the Phone Hub panel including: - Relayouts the continue browsing chip. - Removes the separators. Screenshot: https://screenshot.googleplex.com/8uHj96SrADLFmAc.png Misc: removes unused headers. BUG=1106937,1126208 Change-Id: I0c1c2bef1883c6a8a188fde7c287a0a1bddbdf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494023 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820965}
-
Martin Robinson authored
This value was exposed via the name "AXHasPopupValue", while WebKit exposes this value via "AXPopupValue." Fix the attribute name, which in turn fixes an issue with how popup buttons are announced in VoiceOver. Bug: 1129678 Change-Id: Iede26b2fd6ddb9d7717fcb47fd1dd1cce5b74075 AX-Relnotes: Fix an issue with the announcement of popup buttons in VoiceOver. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489985 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820964}
-
Rakib M. Hasan authored
Android expectations files This will remove developer pain while we work on setting up permanent builders that run WPT on Android and figure out a more concrete solution for crbug.com/1141061. Bug: 1141061 Change-Id: I19b8a65d0c5a4753013f57026f69fef9b5038247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499176Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#820963}
-
Alex Moshchuk authored
Currently, if a sad frame becomes visible on a tab that's being reloaded, the sad frame is recorded as kShownAfterCrashing. Since we mark hidden tabs for reload if they contain a sad frame, activating that reload when the user switches to such a tab, and since the tab reload is going to wipe out the old document along with the sad frame, it's misleading to count that sad frame in that category, since it's going to disappear momentarily and thus has a lower impact on user experience. Instead, count such sad frames in a new category, kShownWhileAncestorIsLoading. This category is used whenever there's a pending cross-document navigation in an ancestor frame which would wipe out the sad frame that was just shown. Bug: 1132938 Change-Id: Ibd32919af28f8a1545cbbb3e2964a19e921e8f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482425Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820962}
-
Jon Mann authored
Previously when details on the active row changed, users with a screenreader were not notified. This change allows the screenreader to announce changes as they happen. In order to determine which row is focused, this also adds an an isFocused property to FocusRowBehavior. Bug: 720274 Change-Id: I3ba1d41200c0fdd1383ec548870ec71e395b2edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489959Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iacfa17c939b8ccddb5ed49cbc4eb39689753f7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820960}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f9b1bfd4849..c54539538ed6 2020-10-26 chanli@chromium.org [depot_tools] Roll led to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141272 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I215bacbfcb335ebf6a0701f81d96161dd1f03d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498852Reviewed-by:
-
David Tseng authored
Scenario: - TtsService calls GoogleTtsInitBuffered/GoogleTtsReadBuffered and an error is returned - TtsService communicates this error to the component extension via mojo TtsEventObserver.onError - in js, the onError handler calls window.close (yet to be sent out for review) - the non-persistent background page closes - in TtsService, mojo::PendingReceiver<mojom::TtsStream> is disconnected, causing the process to exit - on the next call to speak() from any client api (extension, web speech), the component extension is re-awakened by the extension system - in js, a new TtsStream connection is requested/established kicking off the rest of the initialization in TtsEngineExtensionObserver - before re-launching the service, ref keep alive counting logic gets called (accounting for the presence of ChromeVox or STS) to keep the newly opened background page alive - the TtsService process is re-launched R=dmazzoni@chromium.org Test: force TtsService to call onError after 20 utterances after calling GoogleTtsInitBuffered. Observe tts restarts and keeps working with ChromeVox. Change-Id: Id54db152fc5aa1e069ae9de8a603ee41435c1059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496287Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820958}
-
Tommy Nyquist authored
fgorski@chromium.org has shown over a long time that they're able and willing to be a steward of //chrome. Bug: None Change-Id: Ic13fe9ce75b27dd34d77cf26e518d4bbf11eb2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485046Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#820957}
-
Lei Zhang authored
It has been #ifdef'd out for several years. Bug: 662501 Change-Id: Id3c36148e2cc07e084e8280493e5c5da28149973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496501 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
minch authored
Screenshot for IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENRECORD was used before. Bug: 1142099 Change-Id: Ia54a7b34a23ce412f73b9e08a71cc377ec579b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499802 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#820955}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1bafdc3c45e7..57694c8dab3c 2020-10-26 rharrison@chromium.org Change test terminology to reflect WebGPU spec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I13656e89d74d3f278a921a265fdab1efbd52aa6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499701Reviewed-by:
-
Etienne Pierre-doray authored
Ablation study to evaluate impact of Jobs API. This CL splits job specific behavior in several features: - worker wake up strategy (with additional serial strategy) - yield - fair scheduling - priority update Additional study specific to Jobs: wakeup after getwork: This has the potential benefit of reducing lock contention when workers wakeup. Bug: 1139440 Change-Id: I5397977352650ee30557dc8972f32df34798b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481522 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#820953}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5dafe107a36e..5d0458fa5c2d 2020-10-26 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation support 2020-10-26 jmadill@chromium.org Capture/Replay: Test improvements. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) 2020-10-26 geofflang@google.com GL: Use ANGLE_GL_TRY for draw calls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I8e32ca8fdc3dc3c8151055f13bf166c499e1c867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499601Reviewed-by:
-
tby authored
Right now, the search providers for apps and arc apps create a single ChromeSearchResult object for each search result. This result is given the display type kTile, which then shows up in the app tiles and the suggestion chips. We want to apply different scoring and ranking logic to these two UI surfaces, so we can do things like incorporate files into the suggestion chips. However to do this, we need to be able to assign different scores to results destined for the app tiles or chips. This requires we create two independent ChromeSearchResult objects. This CL: 1. Changes the meaning of ash::SearchResultDisplayType::kTile to refer to only the app tiles, not both the app tiles and suggestion chips. kChip continues to refer to just the chips. 2. Modifies the SuggestionChipContainerView to filter on only kChip. 3. Make the AppSearchProvider and ArcPlaystoreSearchProvider create two objects for each result, with a display type of kTile and kChip. 4. Increase the max results of the providers to account for double the number of results (nb. max result limits are going to be removed soon). Bug: 1028447 Change-Id: Ifd261cba9c03fdc31d4bc38964b3101df20cf841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474081Reviewed-by:Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#820951}
-
Mohsen Izadi authored
It is possible to have nested event loops (e.g. in html <select> tag window.print() dialog). Therefore, EventsMetricsManager should support nested scoped monitors to be able to handle nested event loops. Luckily, this hasn't caused an issue because a nested event loop is normally initiated after an event handling causes an update and by the point the nested event loop starts, EventsMetricsManager has already copied the active metrics object due to that update. However, since we want to postpone this copying until the event processing has ended, this will cause issues in future. Bug: 1054009 Change-Id: I8fb160ce0140cdda35071946d470f884d00a3e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491935Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820950}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0fe38b2..af722073 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7468cd3604eaa81955fb492e0feba65e92040ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499325Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820949}
-
Patrick Noland authored
Bug: 1142576 Change-Id: I412849d1be5f0545b94987f468f4890184e7a394 TBR: yusufo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499624Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820948}
-
Dirk Pranke authored
We're removing the relative_cwd and command support in isolate files in swarming as part of moving to the RBE-CAS backend. //tools/run-swarmed.py currently depends on that to work. This CL extends mb.py to be able to easily extract the command line that the target would use in the isolate, and modifies run-swarmed.py to use that to pass the command (and the relative_cwd) to the task instead. Bug: 1119643 Change-Id: Icf81faa1c1293ffbf13160e4d3ee1b7f2d636797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495797Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#820947}
-
Moe Ahmadi authored
- Shows the search loupe icon not only for repeatable query tiles, but all query tiles including query custom links when repeatable queries are enabled. This is for UI consistency when a repeatable query tile becomes a shortcut and the info about the source of the tile is lost. - Does not show the toast buttons when a query tile is removed unless it is a custom link. Removal is not reversible for non custom link query tiles. Also disables Ctrl+Z when toast buttons are not showing. Bug: 1138578 Change-Id: Ib26ad07ce8d12da70c7916f2aaf79f65fabc3dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491991Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820946}
-
Sky Malice authored
The previous policy of CCTToSDialogEnabled assumed a default of true to show the ToS. It was intended to only disable the ToS when specifically intended. However, we believe some UEMs are setting all booleans to false by default, which caused significantly undesirable behavior for this policy. To address this, replaced the boolean policy with an int-enum policy. Then make sure the default value of 0 is mapped to the old behavior. Note that this only changes only updates the policy and pref code. All of the FRE logic in Java code is still using the old boolean and is-enabled nomenclature. This is effectively tech debt, and could be cleaned up, but if we decided to do so, should be as a follow up. Bug: 1141198 Change-Id: I4b9792e6bb111d334a78e9a979d40aaf462f00b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491405 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820945}
-
Daniel Libby authored
When adding out-of-flow results to a fragmentainer, we currently are not setting up the break token sequence number on the NGBoxFragmentBuilder for the NGSimplifiedOOFLayoutAlgorithm. This results in painting different fragments with the same fragmentainer identifier in NGBoxFragmentPainter::PaintBlockChildren, which causes a DCHECK in display item caching code. Instead, use the previous fragment's BreakToken when creating the NGSimplifiedOOFLayoutAlgorithm. This gets the sequence numbers correct, whether we replace or create new fragments (for the former we could just use the existing break token/sequence number). This adds a WPT test for the unit test that exposed this issue: NGOutOfFlowLayoutPartTest::PositionedFragmentationWithOverflow Bug: 1134763 Change-Id: I48a230f8153b8ea63c3a376629c645656423fc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490209 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820944}
-
Bruce Dawson authored
During local testing of minidump_unittests occasional timeouts were seen so this change increases the timeout on Navigate from 5 to 10 seconds. It also adds logging on the RestartBrowser call to make it clearer in interactive testing that the browser is, in fact, not restarting. Finally a couple of missing spaces are added to logging commands. Bug: 1084931 Change-Id: Idc43b9c551effc99b8888491c680c949f1a1c170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496285 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#820943}
-
Piotr Bialecki authored
Change-Id: I3e5327e70bc910f3eaa7b33eea1c0f1ddeda2fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495970Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#820942}
-
Daniel Hosseinian authored
Currently, there is only one instance of a PluginController at a time, but references to it only live inside PDFViewerBaseElement and derived classes. Therefore, descendants of the <pdf-viewer> element fire an event handled by the PDFViewerElement. Making the controller a singleton allows other elements to directly access the controller using PluginController.getInstance(). In making PluginController a singleton, the body of the constructor is moved to an init() method, because getInstance() creates a new object using the default constructor. Consumers of the PluginController would need to make sure the singleton has been initialized before using it. Eventually, InkController will also be altered to be a singleton, similarly to PluginController. Bug: 1134208 Change-Id: I5f8a6b565e6fd565e67c41d841ab92fec43e46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495504Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#820941}
-
Sky Malice authored
When this in product help bubble is displayed, if the user immediately clicks on the tab switcher, then the new tab page button on the overview mode will be temporarily highlighted as well. This should have no effect when there is no tab switcher button on the top toolbar, like on tablets. Bug: 1130752 Change-Id: I88475d9f5330ed430a9182b0f3e90620f75ea737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450809 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Hoch Hochkeppel authored
Centralizing the logic for checking for supported environments for Windows Share related functionality. Also a small refactor to the scoped_fake_data_transfer_manager_interop to make its initialization explicit. Bug: 1035527 Change-Id: Idee6f647745f95d415325a44856f09c5ff959af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495397Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820939}
-
Avi Drissman authored
If a distribution has no brand code, the created package should work. Fixed: 11142512 Change-Id: I6f8d939f97f91ac2607ac343aa700eec1f0edf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498105 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#820938}
-
Mark Yacoub authored
1. Improve Crtc Commit Request to contain everything it needs for a CRTC to be modeset/disabled. 2. Perform a Modeset Test of all displays together to check if the device can support the requested layout altogether. On success of all, modeset each display individually. BUG=1082882,979736 TEST=displays succeed to modeset. Bad modes fail at test and don't get a full modeset. Change-Id: I0f14d5b0bde37a476af6e2ba755a102f5eb4ae38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431614Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#820937}
-
Joe DeBlasio authored
This CL updates the field trial testing config to match that of the M87 launch. Even though ToT is M88, Finch would like the M87 config prior to stable launch. See https://blog.chromium.org/2020/02/protecting-users-from-insecure.html for full public launch plan. Change-Id: I07c29f253eb117abd6654284656325c0b5b38d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488705 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#820936}
-
Avi Drissman authored
This adds asserts that ensure that the Chromes that are generated are self-consistent and will correctly function. Bug: 1142508 Change-Id: Ic827df20741b4d3255667957a64247c8f903efb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499343Reviewed-by:
-
Mike Wittman authored
Restores a separate representation of the V8 embedded code range as compared to runtime-generated code ranges, now that V8 provides access to this state in the API. This distinction was made in an earlier version of the V8 unwind API but the current version did not previously expose the necessary information. Representing the embedded code range allows profiling of JavaScript builtins which live within the range. Along the way fixes a bug in StackSamplerImpl where the unwinder's AddInitialModules was invoked twice if the unwinder was added before profiling started. Fixed: 1136256 Change-Id: I6ec1433fcf5b7704cb9022781edc423d027b8da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476626 Commit-Queue: Mike Wittman <wittman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#820934}
-
Chong Gu authored
This reverts commit 1fa9702a. Reason for revert: Angle issue causing this failure has been addressed. Original change's description: > [Fuchsia] Filter broken webgl test > > Bug: 1141040 > Change-Id: I80a3482481762231b35a7cba82bb3781f6706b1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490331 > Auto-Submit: Chong Gu <chonggu@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Chong Gu <chonggu@google.com> > Cr-Commit-Position: refs/heads/master@{#819655} TBR=bsheedy@chromium.org,chonggu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1141040 Change-Id: I214974d3dcdb9c552f3353726741d9f1a8d178c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499581Reviewed-by:
-
Mark Pearson authored
These: History.WeeklyVisitCount History.VisitTableCount The latter is useful to understanding how large the table typically is. The former is somewhat useful for understanding engagement and also for validating other histograms. BUG=1139966 Change-Id: Ice25e5fcfbdee25a488287ba81c692725d231e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499404Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#820932}
-
Jongmok Kim authored
- GetNewTabButtonIdealX seems not used. Change-Id: I01f27b70dcfd23b76ba1b3b70c083576143cf8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494441 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820931}
-
Daniel Cheng authored
Bug: 958675 Change-Id: I6a4e15214c7b33fc117e34c7f7e6daa7c25a36c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498651Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820930}
-
Jacques Newman authored
This change adds implementation and testing to place grid items in a densely packed grid. Bug: 1045599 Change-Id: I7640fc12e7cc1c1f284848eb01ca949d6a041261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493828 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#820929}
-
Lukasz Anforowicz authored
This CL opportunistically uses the |typeWithEmbeddedFieldDecl| matcher introduced in a previous CL (in https://crrev.com/c/2492464) to fix the "union" filtering rule, so that it not only covers pointers stored directly as union fields, but also covers pointers stored in structs that are nested as a union field. This is motivated by the following examples: - flags_ui::FeatureEntry::(anonymous union)::(anonymous struct)::feature - ui::NativeTheme::MenuSeparatorExtraParams::paint_rect (MenuSeparatorExtraParams struct is embedded as a field of ExtraParams union). (the two examples above are currently excluded via manual-fields-to-ignore.txt) Bug: 1069567 Change-Id: I05fd59d0c93b7954321b375bce40d5325e3eab7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495822 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820928}
-
Sergey Poromov authored
This is a reland of aa433c9b Original change's description: > DLP: Do not start screen capture for restricted content. > > During creation of a screen capture (desktop, window or tab) it needs to > be checked whether the captured area contains any DLP > (Data Leak Prevention) restricted content. > The corresponding MediaAccessHandlers should do this check on Chrome OS. > > Bug: 1134566 > Change-Id: Id77739a9b6df9f3ed946e563d508c43df83b5580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446329 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820713} Cq-Include-Trybots: luci.chromium.try:mac10.15-blink-rel,mac_chromium_10.15_rel_ng Bug: 1134566 Change-Id: Ie1bdd637d9364cc7e75248627c7393438353e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497450Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820927}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I5956a417161c45d12a933637576f462b4d5d215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490865 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820926}
-
