- 08 Feb, 2019 1 commit
-
-
Sammie Quon authored
[1] changed overview to release overview session and then pass that object to its observers. Splitview was querying overview controller for overview session which would be null, so it wouldnt remove the snap window from overview list, which would cause its animation to be supressed. This cl change splitview to remove the window in OnOverviewEnded and use the overview session object before snapping. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1406169 Test: manual Bug: 929658 Change-Id: Iabab38034bea49cdafd1a3ad24310298ca8826de Reviewed-on: https://chromium-review.googlesource.com/c/1459066Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#630106}
-
- 07 Feb, 2019 39 commits
-
-
manuk authored
Previously, reverting the omnibox's selected match (e.g. by pressing escape) when the default match is in keyword mode resulted in incorrect behavior regarding the user text, autocomplete text, and text styling: (1) The user text has its first word removed for each time keyword mode was entered. If the results popup included a navigation result, pressing up/down to select the navigation result leaves keyword mode. Pressing up/down to select a search result or pressing escape to revert the omnibox text reenters keyword mode. Each time keyword mode is entered, the user text drops the first word. E.g. if the 2nd result is a navigation result, and the third result is a search result, pressing <down><down><up><escape> would enter keyword mode twice, and drop the first two words of the user text. (2) The user text would be styled as a URL (grey font color) if the result selected before reverting was a URL result. (3) The autocomplete text is not restored. This CL addresses (1) and (3). (2) is partially addressed as well; for cases where the default match has autocomplete text, restoring it correctly also restores the user text styling. The fix is 2 part: (1) Before, the first word of the user text was stripped upon entering keyword mode because we assumed the first word must be the keyword word. However, this assumption is only true when accepting a keyword (e.g. pressing <space> or <tab>), and not when entering keyword mode by reverting the omnibox's selected match (e.g. pressing <escape>). This CL moves the stripping call from OmniboxEditModel::OnPopupDataChanged, which is called in both cases, to OmniboxEditModel::OnCurrentMatchChanged, which is only called in the first case. (2) Before, the cursor was reset to the beginning of the user text when entering keyword mode while the default match was either already selected or becoming selected. The first occurs when (a) inserting a space between a keyword name and a search string, while the latter occurs when (b) reverting the omnibox's selected match. This was desired behavior in case (a), but undesired in case (b). We incorrectly assumed it was ok to do this in case (b) because we would be reverting the text anyways. However, the revert happens prior to this, resulting in incorrect autocomplete selection. This CL conditions the cursor reset on not having autocomplete text. Bug: 702867 Change-Id: Iac0bdae7e17c86b3e0feb3075dd916d85e5d7e39 Reviewed-on: https://chromium-review.googlesource.com/c/1458697 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#630105}
-
ssid authored
Do not check for uptime to be less than 10. Process could be running longer in the test. This does not fix the failure due to missing uptime value. BUG=731466 Change-Id: I0b176da810dd8f3bc90ad4b94386bc46e68fa1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1338954Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630104}
-
Yoshifumi Inoue authored
This patch gets rid of unused class |SearchBuffer| and related files for improving code health. Since the CL[1], nobody use this class. [1] http://crrev.com/c/1451697: Make FindStringBetweenPositions use FindBuffer and activate invisible matches Change-Id: I36589acdc8e00d89f7fc2cc6d028a84e2389ea2f Reviewed-on: https://chromium-review.googlesource.com/c/1457702 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#630103}
-
David Bienvenu authored
Bug: 813093 Change-Id: I8e4779551cb75d88f1f07c069cd7e5d7793da5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1455094 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#630102}
-
Zhenyao Mo authored
This test was commented out due to flakiness, but we found out the failures are limited to two bots only where overlay cap is DIRECT instead of SCALING. So we removed these two bots from swarming pool so we can add back this test. However, this time we split it into its own test. BUG=929469 TEST=Win/Intel GPU bots R=kbr@chromium.org Change-Id: Ibe0402996709fbdaceee6f9431b8b58d05f59d33 Reviewed-on: https://chromium-review.googlesource.com/c/1457664Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630101}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I345b5acb91681b795125dc7dcf627c9534d5cec7 Reviewed-on: https://chromium-review.googlesource.com/c/1459376Reviewed-by:
-
Dominik Röttsches authored
Preparation for background scheduling of font unique name table construction at browser startup. In a forthcoming CL, threading primitives are added to support scheduling the font lookup table construction at startup. For now, move the existing code to a separate singleton class. Bug: 889864 Change-Id: Idaa0bdf4cd7128e42cdc36d409eab37ae83c1d1a Reviewed-on: https://chromium-review.googlesource.com/c/1458186 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#630099}
-
Boris Sazonov authored
This CL implements bottom bar with "Cancel" and "Confirm" buttons in SyncAndServicesPreferences. This bottom bar is only shown when the user opens SyncAndServicesPreferences screen from the sign-in screen. Bug: 914056 Change-Id: I3f5f2002ab7bcd566f3305fd2344a79069bb82fb Reviewed-on: https://chromium-review.googlesource.com/c/1435276Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#630098}
-
Avi Drissman authored
BUG=none Change-Id: I04b897dca22734caa56abd08acda1d5182d2fcd3 Reviewed-on: https://chromium-review.googlesource.com/c/1456289 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change FileSelection to receive VolumeManager to be able to get location info and determine if the selection contains any read-only entry. Change logic to hide delete button to check read-only from the file selection and the special case for /Downloads folder inside MyFiles. Remove test checkDownloadsContextMenu with MyFilesVolume flag disabled because the delete button behaves differently and the flag is enabled by default. Bug: 921483 Change-Id: I731624948606f6b7ccb6617dd424617d97b0020e Reviewed-on: https://chromium-review.googlesource.com/c/1457884 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630096}
-
Sky Malice authored
DEPS rolled out of sequence for performance improvement when processing network response. Specifics: +66,344 bytes main lib size +514,628 bytes main dex size +825,244 bytes normalized apk size InstallSize: +312,903 bytes APK size +915,017 bytes Estimated installed size (Android Go) +2,392,000 bytes Estimated installed size InstallBreakdown (+2,392,205 bytes): +3,006 bytes unwind_cfi (dev and canary only) size +2,650 bytes Non-compiled Android resources size +66,344 bytes Native code size +570 bytes Package metadata size +2,302,943 bytes Java code size +16,692 bytes Compiled Android resources size Dex: +2,632 entries fields +3,684 entries methods +841 entries types +1,852 entries strings Bug: 916791 Change-Id: I8dd17fa9ad20ec924dcaa5801e2f7fe85686f244 Reviewed-on: https://chromium-review.googlesource.com/c/1459321Reviewed-by:Gang Wu <gangwu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#630095}
-
Kenneth Russell authored
This reverts commit c1086af0. Reason for revert: broke the Windows build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/10872 Original change's description: > Reland "Add build file for PFFFT" > > This is a reland of 8e4cf155 > > This CL includes the following changes: > 1. when fuzzing, PFFFT is compiled disabling SIMD > 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__ > 3. unit test to validate the output of PFFFT (compared against that of FFTPACK) > > The first change fixes the problem due to which the original CL has been reverted; > however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used. > > Similarly, the second change is a temporary solution to allow landing this CL. > SIMD will be re-enabled in a follow-up CL. > > Original change's description: > > Add build file for PFFFT > > > > - fuzzer corpus generator and fuzzer targets > > - fftpack isolated as private test only target (only needed for the benchmark) > > > > Bug: webrtc:9577 > > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84 > > Reviewed-on: https://chromium-review.googlesource.com/c/1452000 > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#629627} > > Bug: webrtc:9577 > Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea > Reviewed-on: https://chromium-review.googlesource.com/c/1458076 > Commit-Queue: Ale Bzk <alessiob@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630085} TBR=thakis@chromium.org,mmoroz@chromium.org,olka@chromium.org,maxmorin@chromium.org,alessiob@chromium.org Change-Id: I64b43c1003b2c21e5227e030d5b14a20ce5643f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577 Reviewed-on: https://chromium-review.googlesource.com/c/1459926Reviewed-by:
-
Antonio Gomes authored
[1], [2] and [3] all have "fake" implementations of network::mojom::CookieManager, mostly stubbed out. This CL provides a simple implementation of this interface located in //services/network/test/test_cookie_manager.cc|h that can be either used as is (eg by [1] and [2]) or have the relevant methods overridden (eg in [3]). [1] //services/identity/public/cpp/identity_manager_unittests.cc, [2] //components/signin/core/browser/test_signin_client.cc [3] //c/b/chromeos/android_sms/android_sms_app_setup_controller_impl_unittest.cc For consistency, the newly added class is named TestCookieManager. This is a follow up of [4]. [4] https://crrev.com/c/1452816/1/services/identity/public/cpp/identity_manager_unittest.cc#96 BUG=926890 Change-Id: Ie1b7b7e3dd6e432f61b91b310614645409294d89 Reviewed-on: https://chromium-review.googlesource.com/c/1456916 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#630093}
-
Daniel Rubery authored
This reverts commit c453ae08. Reason for revert: As previously noted here (https://bugs.chromium.org/p/chromium/issues/detail?id=929040) this CL creates a flaky test. My fix for the flaky test just got reverted, so this CL needs to be reverted too. Original change's description: > SafeBrowsing: Send FULL_PINGs for PDF downloads. > > Bug: 927515 > Change-Id: Id50577de69b38df4d99bec89228eb6e8f98cbed0 > Reviewed-on: https://chromium-review.googlesource.com/c/1458919 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630074} TBR=vakh@chromium.org,drubery@chromium.org Change-Id: Ia1cd02022dffe19610d1e9c9dad84dbf0015545b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927515 Reviewed-on: https://chromium-review.googlesource.com/c/1460064Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#630092}
-
Fan Yang authored
In QUIC, when processing timestamps in ACK frame, close connection if delta_from_largest_observed is too high. Merge internal change: 232664362 R=rch@chromium.org Bug: 928821 Change-Id: Ie3efa2514b40aa20797717cb23deeaef8d238670 Reviewed-on: https://chromium-review.googlesource.com/c/1459064Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630091}
-
Findit authored
This reverts commit 053ca6cc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 630043 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDUzY2E2Y2M2ZjJhZTZhNGE3M2E5YzczZDgxNDNlYjlmMWYxNzFiMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/33780 Sample Failed Step: unit_tests on (none) GPU on Mac on Mac-10.11 Sample Flaky Test: DownloadProtectionServiceTest.DoesNotSendPingForCancelledDownloads Original change's description: > Don't send download pings if the download is cancelled > > There's a small race condition where, if the download is cancelled > before we send a download ping, when we notify the > IncidentReportingService, we'll fail a DCHECK, since the > IncidentReportingService expects us to only send pings for IN_PROGRESS > or COMPLETED downloads. > > Change-Id: If9e5647f2e60f19f0469f51709990ae8226cd5ee > Reviewed-on: https://chromium-review.googlesource.com/c/1457672 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630043} Change-Id: I6c21ce34cdebe86bbf7c877f774e9d3f2ff0f59e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1459794 Cr-Commit-Position: refs/heads/master@{#630090}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/93c01741f610..f2c1116f97a6 git log 93c01741f610..f2c1116f97a6 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 dgarrett@google.com workspace_stages: Create WorkspaceDebugSymbolsStage stage. Created with: gclient setdep -r src/third_party/chromite@f2c1116f97a6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf0bbcfeb6e06f992844fd7e730c4caebecbfa6e Reviewed-on: https://chromium-review.googlesource.com/c/1458426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630089}
-
John Rummell authored
Rather than relying on an empty origin ID to indicate failure to initialize, return a bool parameter that specifies it properly. This will allow future changes that support pre-provisioned origin IDs to handle the case where an empty origin ID is used temporarily. BUG=917527 TEST=components_unittests pass Change-Id: I1ee06f60af49ffa08dc16ed0d5def5fc0be7351e Reviewed-on: https://chromium-review.googlesource.com/c/1453100 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#630088}
-
Weidong Guo authored
Changes: Use ax::mojom::Event::kFocus instead of ax::mojom::Event::kSelection since the latter will trigger duplicate vox announcement. Bug: 929762 Change-Id: I6757daa139cefac303f607de0346a70cb3138d08 Reviewed-on: https://chromium-review.googlesource.com/c/1459056Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630087}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/710f3d3e4483..59ab1cf08196 git log 710f3d3e4483..59ab1cf08196 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 nisse@webrtc.org Move ownership of RTPSenderVideo and RTPSenderAudio one level up 2019-02-07 nisse@webrtc.org Add owned data buffer to EncodedImage 2019-02-07 titovartem@google.com Add missing operator= and extra methods to the SamplesStatsCounter. Created with: gclient setdep -r src/third_party/webrtc@59ab1cf08196 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib7c76197ecfdcb460a6b454c9a3160c0952c8a69 Reviewed-on: https://chromium-review.googlesource.com/c/1458424Reviewed-by:
-
Alessio Bazzica authored
This is a reland of 8e4cf155 This CL includes the following changes: 1. when fuzzing, PFFFT is compiled disabling SIMD 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__ 3. unit test to validate the output of PFFFT (compared against that of FFTPACK) The first change fixes the problem due to which the original CL has been reverted; however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used. Similarly, the second change is a temporary solution to allow landing this CL. SIMD will be re-enabled in a follow-up CL. Original change's description: > Add build file for PFFFT > > - fuzzer corpus generator and fuzzer targets > - fftpack isolated as private test only target (only needed for the benchmark) > > Bug: webrtc:9577 > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84 > Reviewed-on: https://chromium-review.googlesource.com/c/1452000 > Commit-Queue: Ale Bzk <alessiob@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629627} Bug: webrtc:9577 Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea Reviewed-on: https://chromium-review.googlesource.com/c/1458076 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630085}
-
Raphael Kubo da Costa authored
This fixes the GCC build. GCC seems to be stricter with the position of the linkage specification, so just swap the terms to prevent an error that looks like: In file included from ../../base/allocator/allocator_shim.cc:333: ../../base/allocator/allocator_shim_override_cpp_symbols.h:39:30: error: expected unqualified-id before string constant #define ALIGN_LINKAGE extern "C" ^~~ ../../base/allocator/allocator_shim_override_cpp_symbols.h:99:20: note: in expansion of macro ‘ALIGN_LINKAGE’ SHIM_ALWAYS_EXPORT ALIGN_LINKAGE void* ALIGN_NEW(std::size_t size, ^~~~~~~~~~~~~ Bug: 819294 Change-Id: I0aa16ea88cead42e83796a1c86afad8b447ddc50 Reviewed-on: https://chromium-review.googlesource.com/c/1458256 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#630084}
-
Austin Eng authored
The gles2_cmd_decoder receives untrusted commands from the client and must validate that the MultiDrawManager is always used with a valid sequence of commands. Bug: 923282 Change-Id: Ic61e8d61fce61431d7aa939261608f5f4f06792d Reviewed-on: https://chromium-review.googlesource.com/c/1423422 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
Caroline Rising authored
Create a logarithmic scaled delay based on tab width for tab hover cards to show. Bug: 910739 Change-Id: I00b4d4de57cea75b837b7cadc81dea4bb5023c6e Reviewed-on: https://chromium-review.googlesource.com/c/1455057 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#630082}
-
Ahmed Fakhry authored
The removed DCHECK didn't make sense. User could hit Ctrl+Tab to switch tabs while scrolling is in progress. TBR=emaxx@chromium.org BUG=929784 Change-Id: Icd9c26a3650cec610de8c61499e32595347e2e4d Reviewed-on: https://chromium-review.googlesource.com/c/1459517Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630081}
-
Yi Gu authored
Prior to crrev.com/c/1409844 we have one global scope per animator and the animator's name gets synced to main thread upon registration. With the support of multiple global scopes, the sync should be done only when the name is registered on both global scopes. Change-Id: If2b1768fbafda96c92084db45c0ba3e14a5bb01c Reviewed-on: https://chromium-review.googlesource.com/c/1440502 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#630080}
-
Jan Wilken Dörrie authored
This change adds a base::Feature for editing passwords in the Desktop settings. This feature will be disabled by default until the Polymer implementation is completed. Bug: 377140 Change-Id: Iff7289f6dc0889c2ba3aee6c98899d4f21dfa3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1458194Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630079}
-
Stephen Martinis authored
Bot is being deleted, but was deleted from some repos too quickly. TBR=jbudorick NOTRY=true Bug: 893662 Change-Id: I479a6a55b45a23fec796c4bdc14805bbce1bce56 Reviewed-on: https://chromium-review.googlesource.com/c/1459980Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630078}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/82105494f27a..762247be1246 git log 82105494f27a..762247be1246 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 thestig@chromium.org Move most CPWL_Wnd::CreateParams member initialization to the header. Created with: gclient setdep -r src/third_party/pdfium@762247be1246 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I583caa7267d7e08692aafad7393806ca77d01b1e Reviewed-on: https://chromium-review.googlesource.com/c/1458425Reviewed-by:
-
Sebastien Marchand authored
Bug: 771478 Change-Id: I4454ca4a174775647546432c69bf213bc1b69789 Reviewed-on: https://chromium-review.googlesource.com/c/1455337Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#630076}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c877ea265759..a29dd9d0cb8b git log c877ea265759..a29dd9d0cb8b --date=short --no-merges --format='%ad %ae %s' 2019-02-07 bsalomon@google.com Pin the quad index buffer in GrResourceProvider. 2019-02-07 reed@google.com Revert "Hide setDrawLooper -- deprecate loopers" 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 brianosman@google.com Remove duplicate entry in harfbuzz GN file 2019-02-07 bsalomon@google.com Use different classes for client side arrays and GPU buffer objects. 2019-02-07 abarth@google.com [fuchsia] Update path to fuchsia.fonts 2019-02-07 robertphillips@google.com Add support for Mtl backend to DeferredDisplayListTest 2019-02-07 fmalita@chromium.org [skshaper] Add per-line callback 2019-02-07 jvanverth@google.com Set correct uniform size for Metal. 2019-02-07 fmalita@chromium.org [skottie] Use SkShaper for text 2019-02-07 mtklein@google.com move Reporter::reportFailedWithContext() out of line 2019-02-07 benjaminwagner@google.com Upgrade NVIDIA driver on Ubuntu18 QuadroP400 bots. 2019-02-07 egdaniel@google.com Add support for importing AHardwareBuffers into SkSurfaces. 2019-02-07 scroggo@google.com SkWuffsCodec: Initialize memory when incomplete 2019-02-07 kjlubick@google.com Add a k8s cheat sheet to trooper docs Created with: gclient setdep -r src/third_party/skia@a29dd9d0cb8b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ic4d1ea606b693170c1b7d37c10b9c9015edae0bb Reviewed-on: https://chromium-review.googlesource.com/c/1459199Reviewed-by:
-
Daniel Rubery authored
Bug: 927515 Change-Id: Id50577de69b38df4d99bec89228eb6e8f98cbed0 Reviewed-on: https://chromium-review.googlesource.com/c/1458919 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be531eda4378..ff3805a63456 Created with: gclient setdep -r src-internal@ff3805a63456 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: I37a948c429007f14825cbbca6d87d63db5b399bf Reviewed-on: https://chromium-review.googlesource.com/c/1459198Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630073}
-
Lambros Lambrou authored
This tool stopped working when comments ({#..#}) were added to the manifest Jinja templates. Change-Id: I54a0fce1907b55671787a9dd57f62d2f2e958d2e Reviewed-on: https://chromium-review.googlesource.com/c/1459062 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#630072}
-
Danan S authored
Records apps that have been launched by a user using the device during Demo mode. The sample is recorded when each app is launched. For any given app id, the metric is recorded only once. Also: - Fixed bug where kBrowser enum wasn't resolved from its app id. - Fixed description of when the UniqueAppsLaunched metric is recorded. Bug: 900261 Change-Id: Icee9c834a4e76432184307433aa96e54cc9df832 Reviewed-on: https://chromium-review.googlesource.com/c/1444694 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630071}
-
wutao authored
This patch modifies the behavior that Back() from assistant_page should be to the search_result_page. Bug: 924624 Test: manual Change-Id: Iba644fee5426ab8b36f47ad4b2e459b1286bd50d Reviewed-on: https://chromium-review.googlesource.com/c/1455519Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#630070}
-
Daniel Bratell authored
Change-Id: Ib42849852e32348385fcb4389e7ddcfb0085cdf3 Reviewed-on: https://chromium-review.googlesource.com/c/1456010Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630069}
-
Harald Alvestrand authored
This is a step in the process of making the IceTransportAdapter use interfaces from webrtc/api rather than interfaces from cricket:: Bug: chromium:864871 Change-Id: Ibd402232d29949e4aa50d01fd3ff510b950099c1 Reviewed-on: https://chromium-review.googlesource.com/c/1458176 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#630068}
-
Rayan Kanso authored
The CL adds a general-purpose feature flag, and creates DevToolsBackgroundServicesContext which is part of the StoragePartition. The context will be responsible for logging the events from the relevant features (BackgroundFetch/BackgroundSync), and will be accessible from the soon-to-be-added DevTools protocol handler (via the StoragePartition) to perform the reads/writes. Bug: 927726 Change-Id: I7c48a1bac742b9e6e8eaed52f8e69eace6c25f1b Reviewed-on: https://chromium-review.googlesource.com/c/1407077 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630067}
-
