- 10 Aug, 2018 40 commits
-
-
Sungguk Lim authored
Current implemtation for chrome.windows.create cannot handle following combination, but throw an error message instead. - minimized with 'focused'. - maximized, fullscreen with 'not-focused' This change slightly improve documentation about it Bug: 459841 Change-Id: Id925904c2e8c1b319041a455970252bc4f59750e Reviewed-on: https://chromium-review.googlesource.com/1169039Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#582091}
-
Yoshifumi Inoue authored
This patch changes |CorrectedSelectionAfterCommand()| to use |Position:: IsValidFor()| to make it to check |Position| offset and return valid selection. Bug: 873037 Change-Id: I70c7d6f514a39414a4c3245b59969d19beb13f45 Reviewed-on: https://chromium-review.googlesource.com/1170458Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582090}
-
Mohsen Izadi authored
Whenever HostGpuMemoryBufferManager tries to get the GpuService instance using GpuServiceProvider callback, it also sends a callback to be used as the connection error handler for the GpuService. The code is also updated such that the provider callback is called only when GpuService has changed and the return value is cached. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7f30dc4fd63fe079a02f6c2484ac14c75da3c36a Reviewed-on: https://chromium-review.googlesource.com/1161211 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582089}
-
David 'Digit' Turner authored
Minor cleanups to the code base. Preparing for future changes. BUG=843987,802068 R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org Change-Id: I65598259521b3e21b540cedadba99cfa58f13051 Reviewed-on: https://chromium-review.googlesource.com/1169480Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#582088}
-
Maksim Sisov authored
On chrome/x11, right-clicking on the window decoration bar toggles a context menu whose one of the menu items allows switching between builtin and system/native window decorations. Today, chrome/ozone/wayland crashes when building the menu because it tried to read a preference only registered in use_x11: kUseCustomChromeFrame. So this CL does two things: - registers the preference [1] based on PlatformProperties in case of USE_OZONE. - checks whether using system title bar[2] is supported by underlying ozone platform. By default, ozone platforms have this feature disabled. [1] kUseCustomChromeFrame [2] IDC_USE_SYSTEM_TITLE_BAR Based on tonikitoo@igalia.com's patch. Bug: 578890, 849596 Change-Id: Ib05d2057f1193a9e41580d0133e35dff4bc2ea77 Reviewed-on: https://chromium-review.googlesource.com/1167045 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582087}
-
Oscar Johansson authored
When building with jumbo the compiler sees two operator==, declared in the files: content/common/media/media_devices.h content/browser/indexed_db/scopes/scopes_lock_manager.cc Therefore, it throws an error. This commit solves the issue by replacing the operator with a lamdba doing the same operation. Change-Id: I285a95a77ac55d2502d146316da12339de277fc9 Reviewed-on: https://chromium-review.googlesource.com/1169468 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582086}
-
vitaliii authored
This is a reland of bd08401c92882ed1c69503217a67b17274439621 (Note that the original CL is no longer in the tree; it landed during yesterday's Gerrit outage and was reset out of existence. So this is the first time it has "officially" landed in the tree.) Original change's description: > Disable some LayerTreeHostBlendingPixelTest on Linux, because flaky. > > Disable on Linux > > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrixAA_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrixAA_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskAA_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL_TextureRect > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersColorMatrixAA_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskAA_GL > LayerTreeHostBlendingPixelTest.BlendingWithRenderPassColorMatrixAA_GL > > because flaky. > > TBR=ajuma@chromium.org > > Bug:872733 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I61a0b1cc99172da0437eec8f10149f0c46c966eb > Reviewed-on: https://chromium-review.googlesource.com/1169204 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> TBR=ajuma@chromium.org Bug: 872733 Change-Id: I044022d2db22b1cccb20692cf7300c3784ba2859 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1170543Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#582085}
-
Eriko Kurimoto authored
Bug: 821926 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie1a0d74985a7fb689ff0d47ba9404fd15803f0f8 Reviewed-on: https://chromium-review.googlesource.com/1158315Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#582084}
-
Tien-Ren Chen authored
This CL adds code to PaintPropertyTreeBuilder to create transform node for CSS object-fit. Currently only LayoutImage is supported. BUG=854195 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If9002cae344c4a27c2c45cd8a7d9b94dda236861 Reviewed-on: https://chromium-review.googlesource.com/1168471 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582083}
-
Kenichi Ishibashi authored
This reverts commit 826c708a. Reason for revert: This was speculatively reverted but wasn't the culprit. Original change's description: > Revert "Remove unnecessary NetworkService flag check in ResourceDispatcher" > > This reverts commit 3d493dc6. > > Reason for revert: FindIt blamed this CL with 85% confidence. > > Sorry. I don't see anything wrong with this CL, but I also don't see > anything wrong with any other CL in the blamelist, so I'm starting > here. See https://crbug.com/873015 for analysis. > > Original change's description: > > Remove unnecessary NetworkService flag check in ResourceDispatcher > > > > blink::ServiceWorkerUtils::IsServicificationEnabled() checks > > whether NetworkService is enabled, so we don't need the check > > in ResourceDispatcher::StartAsync(). > > > > Bug: N/A > > Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1 > > Reviewed-on: https://chromium-review.googlesource.com/1168707 > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581828} > > TBR=yhirano@chromium.org,bashi@chromium.org,shimazu@chromium.org > > Change-Id: Ia89cf9c0523395c7b331482f39e708f283cbc3ec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: N/A > Reviewed-on: https://chromium-review.googlesource.com/1170402 > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582023} TBR=yhirano@chromium.org,bashi@chromium.org,mgiuca@chromium.org,shimazu@chromium.org Change-Id: Ia3b4db0a6d9586d4febc3a16c1d6f8c987b124fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/1170622Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582082}
-
Mitsuru Oshima authored
AppWindow has its own ImmersiveFullscreenController therefore it has to do this by itself. (similar to CustomFrameViewAshWindowStateDelegate). Bug: 869945 Test: covered by unit tests. Change-Id: Ibbbd71441138ff4f8cabaae6c98d30a1fc0c954d Reviewed-on: https://chromium-review.googlesource.com/1166254 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582081}
-
Xunran Ding authored
Bug: 855465 Change-Id: I1736e5d83494341e068e4aeffeea535d624f3dd4 Reviewed-on: https://chromium-review.googlesource.com/1168944Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Xunran Ding <xunran.ding@samsung.com> Cr-Commit-Position: refs/heads/master@{#582080}
-
Nigel Tao authored
Change-Id: I4ba329c49203a99a9d0d2bd0c14d67b629e9da36 Reviewed-on: https://chromium-review.googlesource.com/1170448Reviewed-by:
-
David Roger authored
This is a reland of 13143b64ae10001dd25dcb8b2d8e707b9e439382 Original change's description: > [Settings] UserEvents depends on history and passphrase > > The user events UI toggle should be grayed out and turned off > when there is a passphrase or when history sync is disabled. > Note that this is purely a UI change: the internal sync datatype > is not really turned off in that case, and we assume that the Sync > engines will correctly stop syncing user events in these cases, > even if the preference is still ON. > > Bug: 865522, 865537 > Change-Id: I04844e2ab9c631300e88f02bbedd712f7618bc32 > Reviewed-on: https://chromium-review.googlesource.com/1160658 > Reviewed-by: Scott Chen <scottchen@chromium.org> TBR=droger Bug: 865522, 865537 Change-Id: Ifae79eaf00a42c3b536bc54fa5d23cbcbcabd18a Reviewed-on: https://chromium-review.googlesource.com/1170202 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#582078}
-
Mitsuru Oshima authored
This is reland of https://crrev.com/c/1164570 Change summary: A header view may outlive the target widget, which can be differet widget. Reset the reference and check before calling target widget. I also changed the ownership of the widget for WideFrameView because its lifetime is controlled by ClientControlledShellSurface. This fixed the asan issue. Bug: b/112240082 Test: covered by unittests. asa build of exo_unittests passed Change-Id: I2ef2cc4be2fa0294b689def79d35bc0884b0fe1a Reviewed-on: https://chromium-review.googlesource.com/1169969 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#582077}
-
Xianzhu Wang authored
Painters uses physical coordincates. Previously sometimes we mistakenly skipped painting when a flipped element had asymmetric visual overflow. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If9ae7f6b772fc5b64a3a0ce4f0a52f6c3eb90f90 Reviewed-on: https://chromium-review.googlesource.com/1167791Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582076}
-
Eriko Kurimoto authored
Added the checkbox to disable logging in ChromeVox options page. Bug: 871165 Change-Id: I69c6ecbb47bd15a0e058ce06e52e49bbbacd6f44 Reviewed-on: https://chromium-review.googlesource.com/1164736 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I52d5f06a4b524307d6b1045e4e8057de641e6289 Reviewed-on: https://chromium-review.googlesource.com/1170260Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582074}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bca7d20ad76a..0d25dda9b148 git log bca7d20ad76a..0d25dda9b148 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 benjhayden@chromium.org Clarify report_template.Static. 2018-08-09 dtu@chromium.org [pinpoint] Add `comparison_magnitude` field to /api/new. Created with: gclient setdep -r src/third_party/catapult@0d25dda9b148 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:870324 TBR=sullivan@chromium.org Change-Id: Ic7108e34fdecdb7971eb6bf6761da80d696e450b Reviewed-on: https://chromium-review.googlesource.com/1170286Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582073}
-
Matt Giuca authored
Bug: 872575 Change-Id: I5d94177e46ede0b1107da0a253ed58f450c2c7ff No-Tree-Checks: true Tbr: mgiuca@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1170161Reviewed-by:
-
Eric Willigers authored
The code and test (but not the flag) were deleted in March 2017. https://codereview.chromium.org/2745913003 BUG=652448 Change-Id: Ic5fe2c9be786dfa57bdd03546c990889df2a5475 Reviewed-on: https://chromium-review.googlesource.com/1163059Reviewed-by:
-
Jia authored
When the screen dim is deferred, its associated event will be logged along with the next event (where screen dim doesn't get deferred). Previously we log the latest event first and then log the earlier event associated with deferred dim. Now we change the order to log earlier event first. Bug: 862461 Change-Id: Ib29ebf60814ce266e6d271a0a4b7a52e6b5b36f3 Reviewed-on: https://chromium-review.googlesource.com/1170158 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582070}
-
Jun Choi authored
AAGUID length received from AuthenticatorGetInfo response must be of length 16[1]. Add this check when parsing response from device and if AAGUID length is any number other than 16, return base::nullopt. [1]: https://fidoalliance.org/specs/fido-v2.0-rd-20170927/fido-client-to-authenticator-protocol-v2.0-rd-20170927.html#authenticatorgetinfo-0x04 Bug: 872217 Change-Id: I58e86942ef7eedd3075dabcf49c25407ce3c3050 Reviewed-on: https://chromium-review.googlesource.com/1167798 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582069}
-
Matt Giuca authored
Adds a bunch of tests with high-probability flake due to timeout or crash, to existing lists of very similar tests that were already disabled. Tbr: mgiuca@chromium.org Bug: 873045, 838057, 856601, 869818 Change-Id: I66e14994ef4551d5690d3a66d51fce84a1eaf456 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1170450Reviewed-by:
-
Ella Ge authored
The touchevent.clientX is in CSS pixel, and TrackWidth is in CSS * zoom. This causes when drag on the timeline element by touch, the position set is wrong. Bug: 871146 Change-Id: I6ca3c199fc9ad9eede6eea9ae92bb946fdd2fbca Reviewed-on: https://chromium-review.googlesource.com/1165320Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#582067}
-
Mitsuru Oshima authored
caused by frame change * Set the NONE targeting policy to the subtree of the shell surface so that WindowEventDispatcher does not generate syntheiszed events when window is moved during frame change (in WindowEventDispatcher::OnWindowBoundsChanged) This will be updated in next version of ARC++. Bug: b/111319005 Test: covered by unittests. also tested manually on nami device. Change-Id: I40b86983857ef3ca564d8e3504bf23b448f0626b Reviewed-on: https://chromium-review.googlesource.com/1170389Reviewed-by:
-
Dominic Farolino authored
Some changes in http://crrev.com/c/1111743 had made the default referrer policy the only referrer policy used for fetching module workers and worklet scripts, when in fact the spec indicates the referrer policy of the fetch client settings object ("outer settings" in the spec") should be used in the case where a ScriptFetchOptions' referrer policy was not explicitly set. This CL ensures that we fallback to the fetch client settings object's referrer policy in the appropriate cases. It is a follow-up to the WPT fixes made in both: - https://github.com/web-platform-tests/wpt/pull/12321 - https://github.com/web-platform-tests/wpt/pull/12330 Remaining failures are due to, and tracked by https://crbug.com/786862, which revolves around SecurityPolicy::GenerateReferrer not taking into account a request's origin when determining whether a request is same-origin or not. R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: If493b728df5410a332b064265bbea30527ec9e0f Reviewed-on: https://chromium-review.googlesource.com/1164648Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#582065}
-
Nigel Tao authored
There's a "move these two files" comment in that list that should only apply to two files. Change-Id: Ic09f71fb8a41de2e2a8b99dc2f41c7e547c79b01 Reviewed-on: https://chromium-review.googlesource.com/1168942Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582064}
-
Koji Ishii authored
The following text failures: paint/invalidation/reflection/scroll-fixed-layer-with-reflection.html paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer.html paint/invalidation/scroll/scroll-in-fixed-layer.html paint/invalidation/scroll/scroll-in-transformed-layer.html paint/invalidation/scroll/scroll-with-transformed-parent-layer.html were added to FlagExpectations in the maintenance CL:1166930, but they are improvements. Their invalidation images match, and has one less object. Reviewed the test result of build 8758. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7665a49b24ab94f6871722f9cd172743d662ba63 Reviewed-on: https://chromium-review.googlesource.com/1170443 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582063}
-
Yuki Awano authored
- Gesture can be accidentally locked to scroll if user performs pinch gesture at right or bottom of the screen. This CL removes gesture lock. - Gesture lock was implemented to avoid blurry scroll but it seems that it's not happening with gesture centered pinch zoom. screen and confirm that it works. Bug: 870635 Test: Manually tested. Perform pinch gesture on right or bottom of the Change-Id: I79893d8f7ef23b51b7339aa3930771aebec78a07 Reviewed-on: https://chromium-review.googlesource.com/1168712Reviewed-by: -
Koji Ishii authored
Following bot results are included. 8704 8705 8708 8711 8718 8723 8729 8731 8734 8737 8738 8739 8745 8750 8755 8758 3 lines were removed and 5 lines were deflaked by consecutive results since 8718. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7e5f08221d619f8f9d473cc0c7dcf7becae15f74 Reviewed-on: https://chromium-review.googlesource.com/1166930 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes NGLineBreaker not to give the text before the start of the line to ICU TextBreakIterator. It looks like ICU computes all the text from the beginning of the given text. Giving the block text content makes ICU to perform much slower, especially when LayoutNG re-creates break iterators on each line. This patch improves ArabicLineLayout.html by more than double. Also it is expected to improve all 16-bit cases. For break-anywhere, this patch relies on r581771 (CL:1165276) that adds StringView to NonSharedCharacterBreakIterator. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I32f6d214e0b64a728ec4d91c1cd9e8a1870745ba Reviewed-on: https://chromium-review.googlesource.com/1168279 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582060}
-
Alexei Filippov authored
Change-Id: If706b5db0ca42234156430bb3ff2c8ab15e388af Reviewed-on: https://chromium-review.googlesource.com/1168191 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582059}
-
Matt Falkenhagen authored
Bug: 789577 Change-Id: Ib228eed68a8ab418f5a7922a3e1f0f3e4f311c0f Reviewed-on: https://chromium-review.googlesource.com/1168947 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582058}
-
Eric Willigers authored
The img.decode() api shipped in M64 https://chromium-review.googlesource.com/721771 https://www.chromestatus.com/feature/5637156160667648 BUG=705669 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I79ea70305d2746794b4ddc0d0af608c32291ce14 Reviewed-on: https://chromium-review.googlesource.com/1165042Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
This CL moves all the logic from the FormInputAccessoryViewController that is not directly related to managing its view to a new mediator. Creates a consumer for the communication the the view controller. Updates tests to use this mediator instead. Removes the dependency on the CRWWebViewProxy. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b0f6c595f069ea45e04c9dacdc4437dbfe9041a Bug: 661622, 727716, 845472, 847408 Reviewed-on: https://chromium-review.googlesource.com/1130522Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582056}
-
Changwan Ryu authored
element_ can be null, so adding IsNull() checks to prevent crashes. Bug: 862044 Change-Id: Ibcbf445684b6f221729e7a6f4259c84ed8ed8127 Reviewed-on: https://chromium-review.googlesource.com/1169435 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582055}
-
Matt Giuca authored
This reverts commit af00b29e. Reason for revert: Suspect for https://crbug.com/873015 I have low confidence that this is the culprit but it's my best guess. Original change's description: > Delete constructor for creating empty CSSStyleSheets > > Currently, empty CSSStyleSheets can be constructed either with a constructor or with Document.createEmptyCSSStyleSheet. > This CL deletes the constructor so that they can only be produced by Document.createEmptyCSSStyleSheet. > > Document.createEmptyCSSStyleSheet is considered to be more desirable, as CSSStyleSheets produced by Document.createEmptyCSSStyleSheet can be tied to documents in the future. This means that their use can be limited in the documents where they were produced, resulting in higher security. > > Note: > The constructed CSSStyleSheet is not currently tied to the Document yet > > Link to related comments in discussion: > https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786 > https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056 > > Bug: 807560 > Change-Id: I767e15e83e1f31eb278bc81233c8b579d0f511c7 > Reviewed-on: https://chromium-review.googlesource.com/1164876 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Commit-Queue: Momoko Sumida <momon@google.com> > Cr-Commit-Position: refs/heads/master@{#581836} TBR=hayato@chromium.org,rakina@chromium.org,momon@google.com Change-Id: Iea70ff4dcc3a5ecf3a806b417572fd8f88e2e58b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807560, 873015 Reviewed-on: https://chromium-review.googlesource.com/1170462Reviewed-by:
-
Joel Hockey authored
This function runs the crostini installer GUI to install the default crostini vm and container and perform sshfs mount. Callback executes when installation is complete. Bug: 854401 Change-Id: Iafee8161b159fb5d2430d46b3cbb0e0ac5f7527a Reviewed-on: https://chromium-review.googlesource.com/1166765 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582053}
-
Eric Willigers authored
PerformancePaintTiming shipped in M60 https://codereview.chromium.org/2905543002 https://www.chromestatus.com/feature/5688621814251520 BUG=720055 Change-Id: I528c714cb7a913bc9b8e453096aa92ec8eae5e5a Reviewed-on: https://chromium-review.googlesource.com/1164969Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
