- 16 Mar, 2011 40 commits
-
-
benjamin.poulain@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt][WK2] Loading an empty URL crashes https://bugs.webkit.org/show_bug.cgi?id=55501 A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is. This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter ensure the returned string is a valid null string. Tested through the Qt API tests. * UIProcess/API/C/WKPage.cpp: (WKPageLoadURL): * UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyUrl): * UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added. * UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added. (tst_QWKPage::init): (tst_QWKPage::cleanup): (tst_QWKPage::loadEmptyUrl): * UIProcess/API/qt/tests/tests.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@81237 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ossy@webkit.org authored
* platform/qt/Skipped: Remove unnecessary "#". git-svn-id: svn://svn.chromium.org/blink/trunk@81236 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
[Chromium] Unreviewed, suppress Win builder failures from r81222. Also, one tentatively stale suppression is removed. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81235 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Martin Robinson. [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it. https://bugs.webkit.org/show_bug.cgi?id=56403 In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING); As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched i.e the pause() made when beginScrubbing is done is just internal. No new tests: Verified manually. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates): git-svn-id: svn://svn.chromium.org/blink/trunk@81234 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=56242 Flaky Test: transitions/interrupted-accelerated-transition.html Skip this while https://bugs.webkit.org/show_bug.cgi?id=54151 (Animation API) is in progress. * platform/chromium/test_expectations.txt: * platform/mac/Skipped: * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81233 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop. https://bugs.webkit.org/show_bug.cgi?id=36467 Removing the test from skipped list since the problem seems to be solved. * platform/qt/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81232 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Reviewed by Eric Carlson. [GTK] media/audio-repaint.html times out again https://bugs.webkit.org/show_bug.cgi?id=56366 Rewrote the test to avoid a timer and attempt the seek on media elements only after we are sure playback started to avoid an INVALID_STATE_ERR exception. * media/audio-repaint.html: git-svn-id: svn://svn.chromium.org/blink/trunk@81231 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Eric Seidel. WebCore GYP build should build platform/ https://bugs.webkit.org/show_bug.cgi?id=56430 Adding platform/ to the GYP build required disabling ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent style issues. I suspect we'll end up excluding some of these files from the build in the final analysis, but we might as well fix the style errors while we're here. * bindings/js/JSMainThreadExecState.h: * bindings/js/ScheduledAction.h: * css/CSSPrimitiveValueCache.cpp: * gyp/WebCore.gyp: * platform/KillRingNone.cpp: (WebCore::KillRing::append): (WebCore::KillRing::prepend): * platform/graphics/ContextShadow.h: * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::TessellationState::combineCallback): * platform/graphics/gpu/PODRedBlackTree.h: (WebCore::PODRedBlackTree::updateNode): (WebCore::PODRedBlackTree::logIfVerbose): * platform/graphics/opengl/TextureMapperGL.cpp: * platform/graphics/opengl/TextureMapperGL.h: * platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::save): (WebCore::TextureMapper::paintToTarget): * platform/graphics/texmap/TextureMapperNode.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81230 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Reviewed by Eric Carlson. [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails https://bugs.webkit.org/show_bug.cgi?id=56370 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Let the mediaPlayerClient handle the stream error, in this case the HTMLMediaElement will emit a stalled event. 2011-03-15 Philippe Normand <pnormand@igalia.com> Reviewed by Eric Carlson. [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails https://bugs.webkit.org/show_bug.cgi?id=56370 * platform/gtk/Skipped: Unskip fixed test. git-svn-id: svn://svn.chromium.org/blink/trunk@81229 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Reviewed by Martin Robinson. [GStreamer] Frame accurate seeking isn't always accurate https://bugs.webkit.org/show_bug.cgi?id=55217 Attempt to build the seek GstClockTime position by converting the float time value to a GTimeVal value rounded at microsecond precision. Additionally perform the seek with the ACCURATE seek flag. These modifications at least fix this manual-test: http://www.massive-interactive.nl/html5_video/smpte_test_universal.html * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81228 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. [Qt] Some inspector test fail intermittently https://bugs.webkit.org/show_bug.cgi?id=42090 Unskip a bunch of non-http inspector tests on Qt. All these tests pass locally. * platform/qt/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81227 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ossy@webkit.org authored
* platform/qt/Skipped: - Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled(). - Add fast/workers/shared-worker-frame-lifecycle.html because it is still flakey. (bug 34281) git-svn-id: svn://svn.chromium.org/blink/trunk@81226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hayato@chromium.org authored
Reviewed by Ojan Vafai. Ignore files that will be used by reftests in old-run-webkit-tests. https://bugs.webkit.org/show_bug.cgi?id=55936 * Scripts/old-run-webkit-tests: git-svn-id: svn://svn.chromium.org/blink/trunk@81225 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
* platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
<http://webkit.org/b/56047> tracks the failure. * platform/win/Skipped: Added editing/style/iframe-onload-crash.html. git-svn-id: svn://svn.chromium.org/blink/trunk@81223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests https://bugs.webkit.org/show_bug.cgi?id=56389 Instead of sending one big request populateScriptObjects each agent requests for initial data in its constructor. * inspector/Inspector.idl: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::getPreferredPanel): * inspector/InspectorAgent.h: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): (WebCore::InspectorDOMAgent::restore): * inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::isEnabled): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): * inspector/front-end/inspector.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81222 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
being in the mac-leopard directory). svg/w3c due to r81168 svg/custom/mouse due to r81053 * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Removed. * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Reviewed by Darin Adler. Devirtualize isContentEditable and isRichlyContentEditable https://bugs.webkit.org/show_bug.cgi?id=56421 Rewrote Node::isContentEditable as a non-recursive non-virtual function. * dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable. * dom/Document.h: Ditto. * dom/Node.cpp: (WebCore::Node::isContentEditable): Rewritten. * dom/Node.h: (WebCore::Node::isContentEditable): Calls isContentEditable(Editable). (WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable). * html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable. * html/HTMLElement.h: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81220 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Adam Roben. Function relativeScriptsDir doesn't return the correct relative Scripts directory. * Scripts/webkitdirs.pm: (relativeScriptsDir): Ensure we use the directory that contains webkitdirs.pm, not the one that contains the original script that was invoked. git-svn-id: svn://svn.chromium.org/blink/trunk@81219 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Eric Seidel. WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/ https://bugs.webkit.org/show_bug.cgi?id=56412 Yay for smooth sailing. * gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81218 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Darin Fisher. Move isReadOnly() from WebInputElement to WebFormControlElement https://bugs.webkit.org/show_bug.cgi?id=55760 * public/WebFormControlElement.h: * public/WebInputElement.h: * src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::isReadOnly): * src/WebInputElement.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81217 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Kent Tamura. REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved https://bugs.webkit.org/show_bug.cgi?id=56059 Note: the test should pass on all platforms, because it was designed to not use platform-specific metrics. * fast/dom/HTMLInputElement/input-slider-update-styled.html: Added. * fast/dom/HTMLInputElement/input-slider-update-styled-expected.checksum: Added. * fast/dom/HTMLInputElement/input-slider-update-styled-expected.png: Added. * fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added. 2011-03-15 Dimitri Glazkov <dglazkov@chromium.org> Reviewed by Kent Tamura. REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved https://bugs.webkit.org/show_bug.cgi?id=56059 Test: fast/dom/HTMLInputElement/input-slider-update-styled.html * html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue. * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromValue): Added. (WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint. (WebCore::SliderThumbElement::setPositionFromPoint): Ditto. (WebCore::SliderThumbElement::defaultEventHandler): Ditto. * html/shadow/SliderThumbElement.h: Added decls. git-svn-id: svn://svn.chromium.org/blink/trunk@81216 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
* platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::encodePixels): git-svn-id: svn://svn.chromium.org/blink/trunk@81215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
* platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call. git-svn-id: svn://svn.chromium.org/blink/trunk@81214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D https://bugs.webkit.org/show_bug.cgi?id=56238 Add new test from webgl conformance test. * fast/canvas/webgl/premultiplyalpha-test-expected.txt: Added. * fast/canvas/webgl/premultiplyalpha-test.html: Added. * fast/canvas/webgl/resources/webgl-test-utils.js: Update to fix fillTexture (WebGLTestUtils): * platform/chromium/test_expectations.txt: * platform/mac-wk2/Skipped: 2011-03-15 John Bauman <jbauman@chromium.org> Reviewed by Kenneth Russell. Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D https://bugs.webkit.org/show_bug.cgi?id=56238 Attempt to get an ImageData (non-premultiplied) from a WebGL canvas instead of getting an ImageBuffer, so there's a chance the data can be passed straight through to the consumer with no premultiplication necessary. Fixes Chromium and Safari. Test: fast/canvas/webgl/premultiplyalpha-test.html * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::getImageData): * html/HTMLCanvasElement.h: * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): * html/canvas/WebGLRenderingContext.h: * platform/graphics/GraphicsContext3D.h: * platform/graphics/ImageBuffer.h: * platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL): * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::readRenderingResults): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::paintRenderingResultsToImageData): * platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToImageData): * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL): * platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): (WebCore::RGBAtoRGB): (WebCore::encodePixels): (WebCore::JPEGImageEncoder::encode): * platform/image-encoders/skia/JPEGImageEncoder.h: * platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA): (WebCore::encodePixels): (WebCore::PNGImageEncoder::encode): * platform/image-encoders/skia/PNGImageEncoder.h: 2011-03-15 John Bauman <jbauman@chromium.org> Reviewed by Kenneth Russell. Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D https://bugs.webkit.org/show_bug.cgi?id=56238 Add support for reading a webgl context into an ImageData. * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData): * src/GraphicsContext3DInternal.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81213 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
kevino@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@81212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://bugs.webkit.org/show_bug.cgi?id=56425beidson@apple.com authored
* loader/icon/IconDatabaseBase.h: #include instead of forward declare. git-svn-id: svn://svn.chromium.org/blink/trunk@81211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
* platform/chromium-mac-leopard/svg/text/small-fonts-2-expected.txt: * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added. * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added. * platform/chromium-win/svg/carto.net/selectionlist-expected.checksum: * platform/chromium-win/svg/carto.net/selectionlist-expected.png: * platform/chromium-win/svg/text/text-text-07-t-expected.checksum: * platform/chromium-win/svg/text/text-text-07-t-expected.png: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/8944558bdakin@apple.com authored
send notifications appropriate times (showing up, resizing) -and corresponding- https://bugs.webkit.org/show_bug.cgi?id=56067 Reviewed by Darin Adler. The general strategy here is to add a HashSet of ScrollableAreas to the page that can be accessed when necessary to send notifications to all ScrollableAreas. In turn, all of the ScrollableArea classes that add themselves to the HashSet must keep a weak pointer to Page so that they can remove themselves without relying on Frames or Renderers to still have references. Find layers for relevant node and if the layers are in the Page's ScrollableArea set, then send the relevant notification. * page/EventHandler.cpp: (WebCore::layerForNode): (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::updateMouseEventTargetNode): When the page is set active or not active, iterate through the Page's ScrollableAreas to send hide/show notifications. * page/FocusController.cpp: (WebCore::FocusController::setActive): When a FrameView is created, add it to the ScrollableArea set. When it's destroyed, remove it. * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): Iterate through the Page's ScrollableAreas to send the paint notification. (WebCore::FrameView::notifyPageThatContentAreaWillPaint): * page/FrameView.h: (WebCore::FrameView::disconnectFromPage): Add the new ScrollableArea set. * page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::addScrollableArea): git-svn-id: svn://svn.chromium.org/blink/trunk@81209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson@apple.com authored
WebKit2 icon database. Reviewed by Sam Weinig. ../WebCore: * WebCore.exp.in: ../WebKit2: Project file paperwork: * DerivedSources.make: * DerivedSources.pro: * GNUmakefile.am: * WebKit2.pri: * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: * win/WebKit2Common.vsprops: * Scripts/webkit2/messages.py: Special-case capitalization for messages that start with "URL" to be lowercased to "url" instead of "uRL". Add messaging-related stuff: * Platform/CoreIPC/MessageID.h: * UIProcess/WebIconDatabase.messages.in: Added. * WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Added. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage): (WebKit::WebProcessProxy::didReceiveSyncMessage): Prep to make WebIconDatabase an API object: * Shared/APIObject.h: Add an "icon DB is enabled" flag to WebProcessCreationParameters: * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: Add SPI for client apps to set the icon database path: * UIProcess/API/C/WKContext.cpp: (WKContextSetIconDatabasePath): * UIProcess/API/C/WKContextPrivate.h: * UIProcess/WebContext.h: (WebKit::WebContext::setIconDatabasePath): Hook up initialization, clearing, and messaging for the icon database: * UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::~WebContext): (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::didReceiveMessage): (WebKit::WebContext::didReceiveSyncMessage): (WebKit::WebContext::iconDatabasePath): * UIProcess/gtk/WebContextGtk.cpp: (WebKit::WebContext::platformDefaultIconDatabasePath): * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultIconDatabasePath): * UIProcess/qt/WebContextQt.cpp: (WebKit::WebContext::platformDefaultIconDatabasePath): * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformDefaultIconDatabasePath): Add the UIProcess-side IconDatabase. It will be the "actual database" as well as the API object: * UIProcess/WebIconDatabase.cpp: Added. (WebKit::WebIconDatabase::create): (WebKit::WebIconDatabase::~WebIconDatabase): (WebKit::WebIconDatabase::WebIconDatabase): (WebKit::WebIconDatabase::invalidate): (WebKit::WebIconDatabase::retainIconForPageURL): (WebKit::WebIconDatabase::releaseIconForPageURL): (WebKit::WebIconDatabase::setIconURLForPageURL): (WebKit::WebIconDatabase::setIconDataForIconURL): (WebKit::WebIconDatabase::iconDataForPageURL): (WebKit::WebIconDatabase::iconURLForPageURL): (WebKit::WebIconDatabase::iconDataKnownForIconURL): (WebKit::WebIconDatabase::loadDecisionForIconURL): (WebKit::WebIconDatabase::didReceiveMessage): (WebKit::WebIconDatabase::didReceiveSyncMessage): * UIProcess/WebIconDatabase.h: Added. (WebKit::WebIconDatabase::clearContext): (WebKit::WebIconDatabase::type): Add the WebProcess-side IconDatabaseProxy. It acts as the WebCore IconDatabase and operates via messaging: * WebProcess/IconDatabase: Added. * WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Added. (WebKit::WebIconDatabaseProxy::~WebIconDatabaseProxy): (WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy): (WebKit::WebIconDatabaseProxy::isEnabled): (WebKit::WebIconDatabaseProxy::setEnabled): (WebKit::WebIconDatabaseProxy::iconForPageURL): (WebKit::WebIconDatabaseProxy::retainIconForPageURL): (WebKit::WebIconDatabaseProxy::releaseIconForPageURL): (WebKit::WebIconDatabaseProxy::iconURLForPageURL): (WebKit::WebIconDatabaseProxy::iconDataKnownForIconURL): (WebKit::WebIconDatabaseProxy::loadDecisionForIconURL): (WebKit::WebIconDatabaseProxy::setIconURLForPageURL): (WebKit::WebIconDatabaseProxy::setIconDataForIconURL): (WebKit::WebIconDatabaseProxy::urlImportFinished): (WebKit::WebIconDatabaseProxy::didReceiveMessage): * WebProcess/IconDatabase/WebIconDatabaseProxy.h: Added. Hook up initialization and messaging for the icon database proxy: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::didReceiveMessage): * WebProcess/WebProcess.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
* platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-expected.txt: * platform/qt/fast/js/global-constructors-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=56416 Reviewed by Darin Adler. This can be used either like $ svn-create-patch | show-pretty-diff or $ show-pretty-diff patch.diff * Scripts/show-pretty-diff: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
weinig@apple.com authored
Reviewed by Anders Carlsson. WebKit2: False SPOD cursor when context menu is open <rdar://problem/9029154> https://bugs.webkit.org/show_bug.cgi?id=56433 * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showContextMenu): Update to match showPopupMenu idiomatically, and stop the responsivenessTimer since the act of showing the context menu could spin a nested runloop. * UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::showContextMenu): * UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu): * UIProcess/win/WebContextMenuProxyWin.cpp: (WebKit::WebContextMenuProxyWin::showContextMenu): Move isEmpty() check to implementations, since we don't want to show this in any case, not just the one where we check it. git-svn-id: svn://svn.chromium.org/blink/trunk@81205 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
http://trac.webkit.org/changeset/81144 https://bugs.webkit.org/show_bug.cgi?id=56432 Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-15 It broke the ui test NPAPITesterBase.GetURLRedirectNotification. (Requested by dave_levin on #webkit). * public/WebURLLoader.h: * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail): * src/AssociatedURLLoader.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Reviewed by Dimitri Glazkov. WebCore GYP build should build editing, fileapi, history, and html https://bugs.webkit.org/show_bug.cgi?id=56411 These all went smoothly. * gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81203 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Eric Seidel. WebCore GYP build should build dom/ https://bugs.webkit.org/show_bug.cgi?id=56409 * gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81202 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Eric Seidel. WebCore GYP build should build css/ https://bugs.webkit.org/show_bug.cgi?id=56408 CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the build yet. I've punted on that problem for now, but we'll come back to it. * gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81201 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Dimitri Glazkov. WebCore GYP build should build bindings/ https://bugs.webkit.org/show_bug.cgi?id=56406 I wanted to include bindings/objc in this patch, but they were somewhat complicated. It looks like they include headers from the output directory (via PrivateHeaders), but we haven't wired up the PrivateHeaders yet. * gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81200 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
Fix the expectation for input-autofilled. * platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: * platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: * platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: * platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: * platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.checksum: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.png: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.checksum: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.png: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.checksum: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.png: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.checksum: Removed. * platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.png: Removed. * platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Removed. * platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Removed. * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Removed. * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Removed. * platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Removed. * platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Removed. * platform/chromium/fast/forms/input-autofilled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/input-autofilled-expected.txt. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simonjam@chromium.org authored
Reviewed by Tony Gentilcore. Need different behavior for ensuring execution order of dynamically loaded scripts https://bugs.webkit.org/show_bug.cgi?id=50115 Dynamically added scripts with async=false will load in parallel, but execute in order. See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async * fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added test cases for forceAsync. * fast/dom/HTMLScriptElement/script-async-attr.html: Ditto. * http/tests/misc/script-async-load-execute-in-order-expected.txt: Added. * http/tests/misc/script-async-load-execute-in-order.html: Added. 2011-03-15 James Simonsen <simonjam@chromium.org> Reviewed by Tony Gentilcore. Need different behavior for ensuring execution order of dynamically loaded scripts https://bugs.webkit.org/show_bug.cgi?id=50115 Dynamically added scripts with async=false will load in parallel, but execute in order. See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async Tests: fast/dom/HTMLScriptElement/script-async-attr.html http/tests/misc/script-async-load-execute-in-order.html * Android.mk: Rename AsyncScriptRunner -> ScriptRunner. * CMakeLists.txt: Ditto. * GNUmakefile.am: Ditto. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * dom/DOMAllInOne.cpp: Ditto. * dom/Document.cpp: (WebCore::Document::Document): Ditto. (WebCore::Document::~Document): Ditto. * dom/Document.h: (WebCore::Document::scriptRunner): Ditto. * dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder. (WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes. (WebCore::ScriptElement::prepareScript): Added support for forceAsync. (WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed. * dom/ScriptElement.h: (WebCore::ScriptElement::forceAsync): Added. * dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp. (WebCore::ScriptRunner::ScriptRunner): Added in-order script queue. (WebCore::ScriptRunner::~ScriptRunner): Ditto. (WebCore::ScriptRunner::executeScriptSoon): (WebCore::ScriptRunner::queueScriptForInOrderExecution): Added. (WebCore::ScriptRunner::suspend): (WebCore::ScriptRunner::resume): (WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready. * dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h. (WebCore::ScriptRunner::create): (WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too. * html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes. (WebCore::HTMLScriptElement::setAsync): Ditto. (WebCore::HTMLScriptElement::async): Include forceAsync in calculation. * html/HTMLScriptElement.h: * html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior. * page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-