GitLab

Feature has shipped in M56 and two milestones have passed, we should
be able to remove the runtime flag now.

BUG=554834

Review-Url: https://codereview.chromium.org/2895543004
Cr-Commit-Position: refs/heads/master@{#473447}

Revert of android: Move most hooks to target_os-specific section. (patchset #3 id:40001 of https://codereview.chromium.org/2889323003/ )

Reason for revert:
Causes build failures.

BUG=724813

Original issue's description:
> android: Move most hooks to target_os-specific section.
>
> gclient recently learned about os-specific hooks, so let's make it so
> that only people working on android need to run the many, many
> android-specific hooks.
>
> No intended behavior change.  This depends on your gclient being
> up-to-date -- it's supposed to auto-update every time you run
> `gclient`, but that sometimes doesn't work.  If you see issues
> after this, `cd ~/src/depot_tools` and `git log` to verify
> that your depot_tools is up-to-date (if it isn't, it's probably
> easiest to delete and re-checkout depot_tools).
>
> BUG=none
>
> Review-Url: https://codereview.chromium.org/2889323003
> Cr-Commit-Position: refs/heads/master@{#473247}
> Committed: https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c

TBR=jbudorick@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none

Review-Url: https://codereview.chromium.org/2900523002
Cr-Commit-Position: refs/heads/master@{#473446}

https://skia.googlesource.com/skia.git/+log/766f9cd5553a..5d7f2b5301f8

$ git log 766f9cd55..5d7f2b530 --date=short --no-merges --format='%ad %ae %s'
2017-05-20 mtklein tidy up dither stage
2017-05-20 mtklein streamline SkRasterPipeline::run()
2017-05-20 mtklein Revert "dither copies when decreasing precision"

Created with:
  roll-dep src/third_party/skia
BUG=720105


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Ib86a1f24e85a0316e559fa65b77b12ea86614a2f
Reviewed-on: https://chromium-review.googlesource.com/509966Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473445}

NGInlineNode::CopyFragmentDataToLayoutBox copies geometry from inline
NGFragment tree to RootInlineBox and InlineTextBox, but didn't include
InlineFlowBox. This results in InlineFlowBox, generated for nested
inline elements, to have (0,0). Their children are placed, but since
parent InlineFlowBox is at (0,0), they were clipped.

This fix turns several tests to fail. They used to pass because expected
images did not render. This fix unhides such tests.

BUG=636993, 723117
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2887623002
Cr-Commit-Position: refs/heads/master@{#473444}

https://skia.googlesource.com/skia.git/+log/2f687877835b..766f9cd5553a

$ git log 2f6878778..766f9cd55 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 mtklein dither copies when decreasing precision

Created with:
  roll-dep src/third_party/skia
BUG=720105


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I3cf00fe5b9cb0e8923d88166bbe89600cf360931
Reviewed-on: https://chromium-review.googlesource.com/509942Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473443}

BUG=602666

Review-Url: https://codereview.chromium.org/2896623002
Cr-Commit-Position: refs/heads/master@{#473442}

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2894923002
Cr-Commit-Position: refs/heads/master@{#473441}

Using wpt-import in Chromium 507bbc4d.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/97

Directory owners for changes in this CL:
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry-1

TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: Ie424f254d865cf6536d2bc93fe765b9fd8bbbab6
Reviewed-on: https://chromium-review.googlesource.com/509729Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473440}

BUG=699569

Review-Url: https://codereview.chromium.org/2891193002
Cr-Commit-Position: refs/heads/master@{#473439}

pgomgr.exe has been moved to a different location in VS2017 so the logic
that find it should be updated.

It can't just be copied to the build directory because we always run the
x64 bit version of this binary (and we don't want to mix x86 and x64
binaries in the same build dir)

BUG=719319

Review-Url: https://codereview.chromium.org/2884613003
Cr-Commit-Position: refs/heads/master@{#473438}

Bot results up to 218 are included.

95 tests pass for a week and thus removed.

BUG=591099
TBR=eae@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2900503003
Cr-Commit-Position: refs/heads/master@{#473437}

Minor cleanups lefts from the previous CL in preparation
of larger upcoming refactoring.

BUG=703184

Review-Url: https://codereview.chromium.org/2891113003
Cr-Commit-Position: refs/heads/master@{#473436}

Replace use of Title Case in the Developer Tools' Security Panel to use sentence case, matching Chrome text standards.

BUG=721176

Review-Url: https://codereview.chromium.org/2881513003
Cr-Commit-Position: refs/heads/master@{#473435}

These methods were used by content/ to request the deletion of cookies
and cache from embedder. This should no longer be necessary, since
BrowsingDataRemover has been moved to content/ and can be used directly.
Embedders that need to execute additional deletions can still subclass
BrowsingDataRemoverDelegate and implement them there.

There were only two ContentBrowserClient subclasses that used
the methods:

1. ChromeContentBrowserClient::ClearCache() was used by dev_tools/.
This was replaced by an equivalent call to BrowsingDataRemover.

2. In android_webview, ClearCookies() and ClearCache() were defined,
but not called. ClearCache() used android_webview::RemoveHttpDiskCache
for cache deletion, which is in fact a subset of functionality that
already exists in BrowsingDataRemover, and can be replaced by it.

BUG=668114

Review-Url: https://codereview.chromium.org/2892953002
Cr-Commit-Position: refs/heads/master@{#473434}

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to inherited_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938

Review-Url: https://codereview.chromium.org/2886293004
Cr-Commit-Position: refs/heads/master@{#473433}

This CL is to confirm that in a real browser environment javascript
battery APIs(navigator.getBattery and its event listener) CAN eventually
succeed in connecting to Device Service to receive battery status change
notifications correctly.

BUG=717379
TEST=content_browsertests

Review-Url: https://codereview.chromium.org/2882633002
Cr-Commit-Position: refs/heads/master@{#473432}

Using wpt-import in Chromium 3c7f1c4e.

NOEXPORT=true
TBR=tkent
TBR_REASON=unblocking the importer so it works over the weekend

Change-Id: I352c6adf7371696b0545366aa25cde0f9274b576
Reviewed-on: https://chromium-review.googlesource.com/509898Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473431}

This was causing getPrimaryService(s) promises to reject.

Bug: 719289
Change-Id: I0860e53778cb6c8d1d69564bcbdd5438052769e8
Reviewed-on: https://chromium-review.googlesource.com/510055
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473430}

BUG=718655

Review-Url: https://codereview.chromium.org/2886393003
Cr-Commit-Position: refs/heads/master@{#473429}

Compare https://html.spec.whatwg.org/#downloading-resources step 3-9.

BUG=714373
R=dtrainor@chromium.org

Change-Id: Iae9831c488fac56442ebf608203853da022fdf10
Reviewed-on: https://chromium-review.googlesource.com/509253
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473428}

Support for events like click, close etc is now fully handled by the
ExtensionNotificationHandler like persistent web notifications.

The delegate is now just a little shim to hold the delegate id since it
is still required by the Notification class.

BUG=720345

Review-Url: https://codereview.chromium.org/2875673002
Cr-Commit-Position: refs/heads/master@{#473427}

BUG=714109,695810

Review-Url: https://codereview.chromium.org/2889173003
Cr-Commit-Position: refs/heads/master@{#473426}

It's somewhat common for metric authors to specify the wrong separator when
using a histogram_suffixes element, as the default is underscore, whereas dot is
common. This CL makes it harder to use the wrong separator by making the
attribute required.

Relatedly, this CL makes enum labels required (fixing one enum that lacked
labels), and makes name attributes always required.

BUG=724311
TEST=git cl format
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2894833005
Cr-Commit-Position: refs/heads/master@{#473425}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8fa0a956..893039d0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2893143002
Cr-Commit-Position: refs/heads/master@{#473424}

https://pdfium.googlesource.com/pdfium.git/+log/d15ce4c1e088..6c8ed646d1fc

$ git log d15ce4c1e..6c8ed646d --date=short --no-merges --format='%ad %ae %s'
2017-05-19 weili Better identify web links by trimming irrelevant chars

Created with:
  roll-dep src/third_party/pdfium
BUG=720578


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib1b36144a82c69fc153fad4271742f82338ec983
Reviewed-on: https://chromium-review.googlesource.com/510062
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473423}

We create the VideoCaptureDeviceFactory instance on the UI thread
now. Update the comments accordingly.

BUG=584797
TEST=None
R=chfremer

Review-Url: https://codereview.chromium.org/2849023002
Cr-Commit-Position: refs/heads/master@{#473422}

BUG=596252
TEST=No functionality change
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2882813002
Cr-Commit-Position: refs/heads/master@{#473421}

Instead, use the same machinery that chrome uses also for layout tests.

BUG=318365
R=mkwst@chromium.org,torne@chromium.org

Change-Id: I62df62cb035c666b03331f7384df6c49e0dfc9fa
Reviewed-on: https://chromium-review.googlesource.com/507288
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473420}

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783

Review-Url: https://codereview.chromium.org/2885203003
Cr-Commit-Position: refs/heads/master@{#473419}

Fix a typo that leaves "close" button visible after sign-in
starts. Just before we finish sign-in, login screen UI is
re-enabled and if user clicks on the button at this very moment,
it would trigger gaia reload which would do sign-in profile
clean up. This would cause post login actions such as cookies
to oauth2 token exchange failure (for SAML users).

BUG=677312
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891373003
Cr-Commit-Position: refs/heads/master@{#473418}

ProxyServiceFactory does not require any code from ios/chrome and moving
it will allow for it’s reuse by ios/web_view.

BUG=none

Review-Url: https://codereview.chromium.org/2888583002
Cr-Commit-Position: refs/heads/master@{#473417}

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2892323002
Cr-Commit-Position: refs/heads/master@{#473416}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/917b0589..8fa0a956

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2894103003
Cr-Commit-Position: refs/heads/master@{#473415}

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636

Review-Url: https://codereview.chromium.org/2893833005
Cr-Commit-Position: refs/heads/master@{#473414}

Removed Omnibox.ProgressBarUpdateCount and
Omnibox.ProgressBarBreakPointUpdateCount
since collected data is not used anymore

BUG=719801
R=mdjones@chromium.org

Review-Url: https://codereview.chromium.org/2885013004
Cr-Commit-Position: refs/heads/master@{#473413}

https://skia.googlesource.com/skia.git/+log/a40d9c89b766..2f687877835b

$ git log a40d9c89b..2f6878778 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 msarett SkWebpEncoder: use bgra for lossless and yuv for lossy
2017-05-19 egdaniel Update Porter Duff analysis to match LCD logic.
2017-05-19 stephana Remove debug flag for ios bots

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Icbcae09596f9e84c5452336548f9c381982fd436
Reviewed-on: https://chromium-review.googlesource.com/509941Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473412}

Rename DocumentMarkerController::RenderedRectsForMarkers() to
RenderedRectsForTextMatchMarkers() and remove the marker_type param.
After https://codereview.chromium.org/2883503004, we only create
RenderedDocumentMarkers for TextMatch markers, and the type param is
no longer needed.

BUG=707867

Review-Url: https://codereview.chromium.org/2886893008
Cr-Commit-Position: refs/heads/master@{#473411}

https://pdfium.googlesource.com/pdfium.git/+log/92c13a7d495c..d15ce4c1e088

$ git log 92c13a7d4..d15ce4c1e --date=short --no-merges --format='%ad %ae %s'
2017-05-19 tsepez Use observed ptrs from CFGAS_GEFont back to its font mgrs.
2017-05-19 thestig Use std::vector and std::sort() in CPDF_PageRenderCache.
2017-05-19 tsepez Use unowned ptr from CXFA_FFDocView to CXFA_FFDoc
2017-05-19 tsepez Fix off-by-one introduced at ab20404
2017-05-19 thomasanderson Update more references to sanitizers:deps
2017-05-19 tsepez Back-fill some functionality for CFX_UnownedPtr

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2a79a022380f5a6525660dd84edf9321f7fb8b54
Reviewed-on: https://chromium-review.googlesource.com/509903
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473410}

Replaced Blink.UseCounter.Features by Blink.UseCounter.Extensions.Features when
URL protocol is chrome-extension://

BUG=687169

Review-Url: https://codereview.chromium.org/2796283005
Cr-Commit-Position: refs/heads/master@{#473409}

Revert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ )

Reason for revert:
Using stub cdm is a workaround and it breaks the load_library_perf_test.
This change reverts the stub cdm because the unaligned ELF header issue
has been fixed for libwidevinecdm.so, so that we can re-enable the
load_library_perf_test.

Original issue's description:
> Use Stub CDM for building libwidevinecdmadapter.so
>
> - This is a temporary fix for unblocking LLD.
> - We use the stub CDM to build the CDM adapter.
> - We ship the copied (real) CDM and the CDM adapter.
> - Even though the CDM adapter is built against the stub cdm at
>   "stub_cdm/libwidevinecdm.so", only the filename is baked
>   into the adapter because of the gn dependency,
>   e.g., readelf -d libwidevinecdmadapter.so :
>   0x0000000000000001 (NEEDED)    Shared library: [libwidevinecdm.so]
> - At run time, when loading the CDM adapter, the system will search
>   for the CDM in the same dir where the adapter is located. Hence
>   the real CDM will be loaded.
>
> BUG=707488
>
> Review-Url: https://codereview.chromium.org/2792743002
> Cr-Commit-Position: refs/heads/master@{#462104}
> Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff26971cfb5648

TBR=xhwang@chromium.org,hmchen@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707488

Review-Url: https://codereview.chromium.org/2893853003
Cr-Commit-Position: refs/heads/master@{#473408}