- 24 Oct, 2016 40 commits
-
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6962f5c0344a..4d43e1baaf06 $ git log 6962f5c03..4d43e1baa --date=short --no-merges --format='%ad %ae %s' 2016-10-24 jbudorick [devil] Add support for run-as in DeviceUtils.RunShellCommand. 2016-10-24 jbudorick [devil] Work around occasionally fatal `adb forward --list` bug. BUG=623989 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2444983002 Cr-Commit-Position: refs/heads/master@{#427099}
-
dougarnett authored
BUG=655341 Review-Url: https://codereview.chromium.org/2431193003 Cr-Commit-Position: refs/heads/master@{#427098}
-
mfoltz authored
This hook allows the Media Router component to properly record the cause of event page wakeups that are caused by invoking the Media Route Provider API. BUG= Review-Url: https://codereview.chromium.org/2422773004 Cr-Commit-Position: refs/heads/master@{#427097}
-
boliu authored
Continuation of CL by ojars@ here: https://codereview.chromium.org/2383933002/ Async hardware draw synchronously returns a frame future that is fulfilled asynchronously on the IO thread. This allows the frame future to be waited on either the UI thread or android's render thread without deadlocks. In content, make SynchronousCompositorObserver a true message filter owned by RenderProcessHostImpl. Will rename this to SCFilter in a later CL. In android_webview, wait on the frame future in kModeDraw, immediately before where the frame is needed, to maximize parallelization. Note that there is a hack in BVR to produce a synchronous frame first to ensure that bindings are initialized before render thread runs any code. This makes a complete more or less working path. But there are still lots of TODOs needs to be fixed before the async path is ready to ship. BUG=636164 Review-Url: https://codereview.chromium.org/2418383002 Cr-Commit-Position: refs/heads/master@{#427096}
-
torne authored
Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 Review-Url: https://codereview.chromium.org/2444913002 Cr-Commit-Position: refs/heads/master@{#427095}
-
floppymaster authored
Review-Url: https://codereview.chromium.org/2446643002 Cr-Commit-Position: refs/heads/master@{#427094}
-
hans authored
The latest version of Clang rejects direct relational comparison between null pointer constants and pointers. BUG=none TBR=justinlin Review-Url: https://codereview.chromium.org/2448533002 Cr-Commit-Position: refs/heads/master@{#427093}
-
wittman authored
We're seeing reasonable stability and performance numbers from the current 10% enable rate on canary, so enable at the same rate on dev. BUG=650869 Review-Url: https://codereview.chromium.org/2444573002 Cr-Commit-Position: refs/heads/master@{#427092}
-
lfg authored
Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (patchset #2 id:20001 of https://codereview.chromium.org/2415973002/ ) Reason for revert: Caused a regression on Mac. BUG=658688 Original issue's description: > Do not hide the old RenderWidgetHostView when commiting a navigation. > > This fixes an issue where the old RenderView is reused by a new remote > subframe. We shouldn't be leaking resources, because now we are already > hiding the unused RenderView in the renderer, when the local main frame > gets detached and the WebViewFrameWidget is closed. > > BUG=638375 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/7c3d7bbd510eda2bcfb971f6d166da26bcfe4222 > Cr-Commit-Position: refs/heads/master@{#426913} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638375 Review-Url: https://codereview.chromium.org/2448503002 Cr-Commit-Position: refs/heads/master@{#427091}
-
dgn authored
Adds a mocking method for Feature flags in SnippetsConfig BUG=657319 Review-Url: https://codereview.chromium.org/2434263002 Cr-Commit-Position: refs/heads/master@{#427090}
-
schenney authored
TBR=xidachen@chromium.org Review-Url: https://codereview.chromium.org/2448513002 Cr-Commit-Position: refs/heads/master@{#427089}
-
dmazzoni authored
Revert of Use the serviceworker with mojo by default (patchset #2 id:20001 of https://codereview.chromium.org/2436223004/ ) Reason for revert: I think this is causing InstallableManagerBrowserTest.CheckManifest404 to crash, see http://crbug.com/658702 Original issue's description: > Use the serviceworker with mojo by default > > This patch changes --mojo-service-worker to --disable-mojo-service-worker. > Let's try mojo for the service worker. > > BUG=629701 > > Committed: https://crrev.com/391fa63bcefd25b35addf678356828dded5ae71e > Cr-Commit-Position: refs/heads/master@{#427013} TBR=horo@chromium.org,avi@chromium.org,shimazu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629701 Review-Url: https://codereview.chromium.org/2443983002 Cr-Commit-Position: refs/heads/master@{#427088}
-
mathp authored
BUG=634418 Review-Url: https://codereview.chromium.org/2438403002 Cr-Commit-Position: refs/heads/master@{#427087}
-
treib authored
Followup to https://codereview.chromium.org/2429523002 - Remove NTP_*_SIDE_SUGGESTION (replaced by LogMostVisitedImpression calls) - Cleanup tests BUG=656646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2435683003 Cr-Commit-Position: refs/heads/master@{#427086}
-
jam authored
There are two main fixes: -use the new NavigationHandle callbacks on WebContentsObserver which are compatible with PlzNavigate -update the renderer side so that handles the new order of IPCs: while ReadyToCommitNavigation means the browser side can send its IPC before the internal content ones, with PlzNavigate one content IPC will fire both DidStartProvisionalLoad & DidCommitProvisionalLoad. So add extra logic to the renderer side to handle this. This fixes SubresourceFilterBrowserTest.MainFrameActivation SubresourceFilterBrowserTest.MainFrameActivationOnStartup SubresourceFilterBrowserTest.SubFrameActivation with PlzNavigate. BUG=504347, 653807 Review-Url: https://codereview.chromium.org/2446503002 Cr-Commit-Position: refs/heads/master@{#427085}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2445513002 Cr-Commit-Position: refs/heads/master@{#427084}
-
mattreynolds authored
iOS prompts the user to enable Bluetooth when the CBCentralManager object is created. Setting the ShowPowerAlert option to NO suppresses the prompt. This allows Chrome to check the Bluetooth enabled state without prompting the user. BUG=630769 Review-Url: https://codereview.chromium.org/2443733002 Cr-Commit-Position: refs/heads/master@{#427083}
-
ajuma authored
This change is in preparation for adding "expanding" clip nodes, which will involve adding a new ClipType. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel BUG=653631 Review-Url: https://codereview.chromium.org/2437923002 Cr-Commit-Position: refs/heads/master@{#427082}
-
jdonnelly authored
This method is called by the cross-platform autofill code resulting in regular log spam. The calling sites don't expect a non-null return value so there's no need to log this as an error. BUG=658299 Review-Url: https://codereview.chromium.org/2435343002 Cr-Commit-Position: refs/heads/master@{#427081}
-
fs authored
The following methods in SVGLengthContext: convertValueFromUserUnitsToCHS convertValueFromUserUnitsToEXS convertValueFromEXSToUserUnits needs the same treatment as convertValueFromCHSToUserUnits got in https://chromiumcodereview.appspot.com/2445463002. R=pdr@chromium.org,eae@chromium.org BUG=657438,658585,658613 Review-Url: https://codereview.chromium.org/2449433002 Cr-Commit-Position: refs/heads/master@{#427080}
-
hcarmona authored
BUG=654738 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1914653002 Cr-Commit-Position: refs/heads/master@{#427079}
-
dougt authored
Add a version of GetPermissionStatus that takes a host_content_settings_map. This method is guaranteed to be threadsafe. BUG=658020 R=jochen, mlamouri Review-Url: https://codereview.chromium.org/2439673004 Cr-Commit-Position: refs/heads/master@{#427078}
-
krb authored
Currently, only Blink depends on payment_requet.mojom. Going forward, all the platforms will, so moving it to a more generic location. BUG= Review-Url: https://codereview.chromium.org/2406923002 Cr-Commit-Position: refs/heads/master@{#427077}
-
msarett authored
This test was flaky before. It would just always "succeed" on the second attempt. Now it is still flaky. It just sometimes succeeds outright and sometimes fails on all attempts. I'll disable for now until I can come up with a better fix for these timing issues. NOTRY=true BUG=657839 TEST=none TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2448493002 Cr-Commit-Position: refs/heads/master@{#427076}
-
torne authored
Switch the JNI generator sample code to use a JavaRef for java method parameters instead of jobject. BUG=506850 Review-Url: https://codereview.chromium.org/2418893003 Cr-Commit-Position: refs/heads/master@{#427075}
-
harkness authored
Because of crbug.com/657517 the original submit of the test for NotificationImageLoader had a very loose timeout value. Now that the bug was fixed (https://chromiumcodereview.appspot.com/2433323003), this CL updates the timeout values to be tighter. BUG=579137 Review-Url: https://codereview.chromium.org/2442323002 Cr-Commit-Position: refs/heads/master@{#427074}
-
rob.buis authored
Update table.deleteRow(-1) behavior to latest spec, the change is that if there are no rows left to delete we do nothing instead of throwing an IndexSizeError exception. BUG=657837 Review-Url: https://codereview.chromium.org/2427963004 Cr-Commit-Position: refs/heads/master@{#427073}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/dba76ba32 BUG=657839 TBR=msarett@google.com Review URL: https://codereview.chromium.org/2442323003 . Cr-Commit-Position: refs/heads/master@{#427072}
-
mvanouwerkerk authored
BUG=655498 Review-Url: https://codereview.chromium.org/2437923004 Cr-Commit-Position: refs/heads/master@{#427071}
-
bshe authored
This is implemented by using Daydream Api. After a headset is detected by phone, instead of launch Daydream Home app, ChromeVR is launched iff Chrome was the foreground app. Follow up CLs will trigger auto presentation if VR aware content was showing. BUG=641401 Review-Url: https://codereview.chromium.org/2428563003 Cr-Commit-Position: refs/heads/master@{#427070}
-
foolip authored
Using update-w3c-deps in Chromium 3524bd79. This is for rtcpeerconnection-constructor.html BUG=658423 Review-Url: https://codereview.chromium.org/2448433002 Cr-Commit-Position: refs/heads/master@{#427069}
-
rob.buis authored
Payments apps can support multiple methods, and each method can have associated data, so instead of passing on method associated data as JSON string, pass a method -> method specific data map. This CL also renames some methods to make it clear if we are dealing with the PaymentApp or PaymentInstrument. BUG=587995 Review-Url: https://codereview.chromium.org/2434333005 Cr-Commit-Position: refs/heads/master@{#427068}
-
cfroussios authored
The various libsecret methods have different contracts w.r.t. unlocking keyring items. Of the currently used methods, only secret_service_store will trigger unlocking as necessary. As a result, operations fail in various ways until someone performs the first store operation. With the CL, the libsecret native backend of Password Manager is set to explicitly request unlocking of items on every call. OSCrypt avoids using secret_service_lookup, which apparently ignores locked items. BUG=657828,631171 Review-Url: https://codereview.chromium.org/2441653002 Cr-Commit-Position: refs/heads/master@{#427067}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82319475..e64d0caf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2444833002 Cr-Commit-Position: refs/heads/master@{#427066}
-
foolip authored
This preserves behavior as far as possible and adds use counters for cases that aren't per spec. One intentional change is that the first argument of the RTCPeerConnection constructor is made optional, as that is a very low risk change, and requiring the dictionary makes no sense when providing null, undefined and {iceServers:[]} already work. Without custom bindings it is unfortunately not possible to distinguish {certificates:null} from no certificates specified, so that is not measured. BUG=649343 Review-Url: https://codereview.chromium.org/2442763002 Cr-Commit-Position: refs/heads/master@{#427065}
-
maksim.sisov authored
The old implementation doesn't handle possible overflows, when year is too large, for example. It makes a result to be larger than 2^63 - 1, which results in overflow. Fix Posix: use safe_math.h for multiplication and addition. If overflow occurs, return possibly maximum platform dependent value. Fix Mac and Win: if safe cast is impossible, return Time(0). Fix media and components: use day of week as well, as long as unused variable results in undefined behavior and overflow BUG=653445 Review-Url: https://codereview.chromium.org/2405453002 Cr-Commit-Position: refs/heads/master@{#427064}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/7a86423c4243..826167111f80 $ git log 7a86423c4..826167111 --date=short --no-merges --format='%ad %ae %s' 2016-10-24 caryclark fix one more fuzzer 2016-10-24 borenet Roll recipe DEPS Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=reed@google.com Review-Url: https://codereview.chromium.org/2446583002 Cr-Commit-Position: refs/heads/master@{#427063}
-
estade authored
Remove last references to non-custom IDR_THEME_TOOLBAR. Remove some unused SHADE images. Remove DropdownBarView, which is nothing but a bunch of dead code. BUG=648281 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2441863002 Cr-Commit-Position: refs/heads/master@{#427062}
-
msarett authored
NOTRY=true BUG=657839 TEST=none TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2443943002 Cr-Commit-Position: refs/heads/master@{#427061}
-
bauerb authored
This makes SnippetArticle a pure model class that doesn't know about the adapter. Goals of the overall refactoring: 1) Decoupling the various pieces of logic, by moving them from the adapter into the tree structure. For example, dismissal is something that could be handled by a TreeNode instead of doing the big switch statement we have right now in the Adapter. 2) Stabilizing the structure of the tree. Right now we tend to throw away everything and rebuild, which means we have to manually figure out what changes exactly to notify about (cf. removeSuggestion). If we keep the tree structure stable and just adjust the number of children below each node as necessary (like SigninPromo already does), we get correct notifications for free, and it will allow for some optimizations as well (we could cache the number of children for each node and update it incrementally when a subtree changes. Right now we'd have to contort ourselves a bit to make that work with things like resetChildren()). BUG=616090 Review-Url: https://codereview.chromium.org/2439683003 Cr-Commit-Position: refs/heads/master@{#427060}
-