- 31 Aug, 2020 40 commits
-
-
Brian Sheedy authored
Adds a test for exercising Telemetry's hung renderer detection/crashing code. If Telemetry detects a hung renderer, it should crash the hung renderer process and the GPU process so that we can get minidumps to diagnose the root cause. Bug: 1119564 Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803200}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0940e75ccf4aaa92b856ccf13e2d6ec5e52a4e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385439Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803199}
-
Peter Wen authored
Remove test-specific suppressions. If and when we enable lint on test targets again, blanket testonly suppressions should be added to lint.py instead. Fix some WrongConstant issues. These are useful to understand and make sure we are passing the right @IntDef and @StringDef variables to android APIs. Bug: 1116130 Change-Id: I43bea517bca2436f2063829fe74d280b5df6bca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375700Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803198}
-
Sadrul Habib Chowdhury authored
If a CompositorFrame includes new updates from the main-thread, then that frame should be treated as having complete update, rather than partial update, even if the main-thread update is not for that specific begin-frame. BUG=1115376 Change-Id: I9987e77a3357c1c5eeb895514e584e780628fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381731Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#803197}
-
Vladimir Levin authored
This patch renames RenderPass and associated types to CompositorRenderPass to distinguish it from AggregatedRenderPass. R=weiliangc@chromium.org, magchen@chromium.org Bug: 1106418 Change-Id: Ia1ab7199473d960df4ea5ce715476d2c4c290a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380730Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803196}
-
Geoff Lang authored
Bug: chromium:1115621 Change-Id: I00580d92c3b33ac84d3a9509bb94fc76f810cf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378753Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803195}
-
Panos Astithas authored
Bug: 646113 Change-Id: I4e16b3db222dd2a5b4084adfbecb601e1a97e355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368323 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#803194}
-
Kalvin Lee authored
We erased the effective_uri_ member of the Printer class in https://crrev.com/c/1551683; this CL erases its declaration in the header file. Bug: chromium:838677 Test: CQ passes Change-Id: I2a6307cf0a56b32ec30375aeaeeafc1f15fb3f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382684Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803193}
-
Daniel Classon authored
Link "Time Zone" search result in the case the setting appears on the subpage as well as the main section page, making the setting accessible for deep linking. Bug: 1084154 Change-Id: I68ec9fabbce8cf25b25779b2f694efa5965e3db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382885 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803192}
-
Sadrul Habib Chowdhury authored
The test wants to send a begin-main-frame for every frame. However, posting a task on the main-thread to request 'begin main frame' can be too slow in some configs (e.g. in asan/tsan etc. builds). There is a more direct way of forcing a 'begin main frame' to be issued directly from the compositor thread through LayerTreeHostImpl. So use that to have a more deterministic behaviour. BUG=1115376 Change-Id: I9ba0304be6f271f9b8025bcd2d82ce1470e9fd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383313 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803191}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2f99b8ecd4118707dc535d15ed3d07c727dce653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382078 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#803190}
-
Maksim Ivanov authored
Fix a typo (wrong variable) found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3a546274cb3efbc9226cccb86dc37fea89771e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385463Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803189}
-
Jae Hoon Kim authored
Preloading times out for large DLC images because the hash takes too long. F20 provisioning can resolve this issue for tests that currently depend on preloadable DLC images. BUG=b:164310699 TEST=unit_tests # --filter=*Dlc* Change-Id: I919004d7081de6e93aa26113f931ac1c0154e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381052 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#803188}
-
arthursonzogni authored
COOP reporting is gated behind: 1) An Origin Trial: https://developers.chrome.com/origintrials/#/view_trial/2780972769901281281 2) Use of the Cross-Origin-Opener-Policy(-Report-Only) HTTP header with the "report-to" attribute. 3) The following features used as "kill-switch": - CrossOriginOpenerPolicyReportingOriginTrial - CrossOriginOpenerPolicyAccessReporting This patch turns the flags from (3) on to match with the future finch config. [specification]: https://github.com/whatwg/html/pull/5518 [explainer]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md [intent-to-prototype]: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h5s3SMpF8QI [intent-to-prototype-review]: https://docs.google.com/spreadsheets/d/1g8sekkR7J_nYf5WFUSkgllxujrZEYD-R77K4vofDVm8/edit#gid=1681607078&range=H309 [intent-to-experiment]: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/JhRU2d7RQ_k/eu5Jx3jIAwAJ [intent-to-experiment-review]: https://docs.google.com/spreadsheets/d/1g8sekkR7J_nYf5WFUSkgllxujrZEYD-R77K4vofDVm8/edit#gid=1681607078&range=H404 Bug: 1116413 Change-Id: I2ca66ce3a9228602ff2e471b9b7b8f6cde418e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379774Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803187}
-
Tomasz Moniuszko authored
mock_tsf_bridge.cc was compiled as a part of //ui/base:test_support and //ui/base/ime/win:win. This caused link errors in some configurations as MockTSFBridge symbols were duplicated. //ui/base:test_support depends on //ui/base/ime/win:win so mock_tsf_bridge.cc is redundant there. Bug: 968222 Change-Id: Ibc159c336c0feef285e1066d3dc73c57c62b981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379764 Commit-Queue: Yohei Yukawa <yukawa@chromium.org> Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803186}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 096493df. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I48bc26d7a872f235a9d664dfa56856a7b7c9f76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385637Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803185}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0d24fdc82118ff3d62609500d859507742a8cb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383653Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803184}
-
Nohemi Fernandez authored
Fixed: 464306 Change-Id: I561a1465616f16103c285620e8689b761f5a07a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385338Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#803183}
-
Sean Gilhuly authored
Test names can only contain alphanumeric characters, plus underscores. testing::PrintToStringParamName() stringifies tuples using characters that aren't valid for test names. Add a similar function which joins each element using underscores. This will generate valid names for test parameterization, provided each element of the tuple can be written using valid characters. Bug: 1092945, 1117587 Change-Id: I868b1d4040a93bdbf763dbb45b94ff15f181dd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376882Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#803182}
-
Becca Hughes authored
Using the frame on the NTP to load the data is too slow for what we want to do so this removes the frame and does the fetching in C++ instead. The deserialization and business logic is still handled by the JS but on the NTP instead of in a child frame. BUG=1121360 Change-Id: Idad8c9403fd51cccaf4a8edff31d244ac2642432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373384Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803181}
-
Nicolas Ouellet-Payeur authored
Since default apps' installation isn't urgent, it's fine if they take a bit more time to install. This saves precious CPU cycles during fresh profile startup, when Chrome is already busy doing a bunch of other stuff. There are 2 benefits: (1) Other extensions that install at the same time install faster (e.g. force-installed extensions) (2) It reduces jank during the first-run experience (FRE), especially for lower-end/older CPUs, and virtual machines. Since the FRE has fancy CSS animations, the jank is noticeable. Before/after trace comparison: https://imgur.com/a/o9Y0Dqv Bug: 1103447, 904486 Change-Id: I4b9f2eecf71c3414a36769d896296d4f089c81a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377888Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#803180}
-
Wojciech Dzierżanowski authored
`player_id_` identifies MediaSessionControllers in MediaSessionImpl. The possibility to mutate it left the door open to failing to unregister a MediaSessionController from MediaSessionImpl on destruction. That could lead to a use-after-free of MediaSessionController in MediaSessionImpl. Bug: 1115478 Change-Id: Ib309b09345be9c6da2668a40100297942118b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353250 Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803179}
-
Jonah Ryan-Davis authored
Since this bot has low capacity, we can try to keep the testing load a little lower. We choose to only test the validating command buffer with webgl2 tests, and the passthrough with webgl1. Also, we don't need to duplicate SwANGLE testing here since it's likely to be the same on any Mac. Bug: chromium:850252 Change-Id: Ib912758efb5e352cc746553f0a3c8d6ee9947cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363831Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#803178}
-
Nicolas Arciniega authored
This patch adds the right dependency to fix the build error described by the below bug. Bug: 1122770 Change-Id: I943e10ef4b10750d01bd4c1ce47bc9f4f0e0816c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368455Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803177}
-
Kyle Horimoto authored
Before this CL, Phone Hub results would show up when searching within settings, even if the feature flag was disabled. This CL fixes this issue by checking the flag value before adding search tags. Bug: 1106937, 1123607 Change-Id: If0bd1ea23864ef9634db608c35dbd03571e332b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385781 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803176}
-
Leonard Grey authored
Follow-up to r801401 (thanks, mehmet@!) Bug: 635853 Change-Id: I9c49650b2d6ab52b342d4aeea7771ff2abb85ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380734Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803175}
-
Shubham Aggarwal authored
This CL changes the behaviour of FileReader so that the result attribute is only set right before the Load event is fired. The existing web tests that covered this behaviour have their expected result changed to now be passing (the expectation file was deleted as all tests now pass). The CL also removes the kFileReaderResultBeforeCompletion feature which measured how often the result attribute was accessed before load. This feature is no longer needed. Change-Id: Ide34aa7ebe5d4caadc2c40821b1eb7cbbe7e91d7 Bug: 768972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352610Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803174}
-
Mohammad Refaat authored
I own most of Cookies related code in the codebase, and i created system_cookie_store_util which was moved in this directory. Change-Id: Ib025b980c111f528cd0180a16a82909a70eec305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382875 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803173}
-
Jonathan Freed authored
Bug: 1122409 Change-Id: I2f732f6ec8344dd0c91ed2935d1e8d434e425503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385756 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803172}
-
Nela Kaczmarek authored
[Passwords] Affiliation Service - change SchemeHostPort to GURL type for parameters in public methods. Changes type of parameters in public methods of Affiliation Service from SchemeHostPort to GURL. This change makes AffiliationService compliant with the public interface of ChangePasswordUrlService. Bug: 1108279 Change-Id: I2b59560f991176ac94ac9a57cc2db5577bd72ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379717Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#803171}
-
Vladimir Levin authored
This patch adds two use counters to count 1. The number of times we have strict containment on an element and no content-visibility 2. The number of times we have strict+style containment and no content- visibility. The second case is a potential optimization for having an effective content-visibility (ie just skip the work automatically) The first one is more likely to be present and it _can_ be used as a content-visibility style optimization if there are no counters present on the page (or in the subtree, which is harder to check). R=chrishtr@chromium.org Change-Id: I9243a4d03217b661cb3be4cb12549a61d7e95092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382403 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803170}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c73782c8d8ff..6c37d40bb531 2020-08-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3a5e02bd415f832ef6bb8e7e9984a4ed06690acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803169}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2fdbfa0eac5fec5e3d995888ce830bece01e02cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382815Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803168}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008310800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/qWERs0_B9Z--fvL8HtwVcESrcvhGQn_WW5tYzLXvrvsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166192181 Tbr: media-app@grotations.appspotmail.com Change-Id: I06dbf15f34c21c0d9e23ed39cb5046cd444e9d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385675Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803167}
-
Xianzhu Wang authored
This is consistent with the chromium feature which is disabled by default and is enabled when "experimental web platform feature" is enabled [1]. This prepares for letting blink feature status override chrome's default feature status. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/public/common/content_switch_dependent_feature_overrides.cc;drc=02fc05043bd38d318ba9ce59ccc4c7602284f990;l=56 Bug: 1121839 Change-Id: I92b7c68ce409971ef920ce00cb0951600547ef57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382486Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803166}
-
Andrew Xu authored
This CL does the following changes: (1) Implementing the logic of item deletion. (2) ClipboardHistoryController does not cache the clipboard history items anymore. This CL should be landed after https://crrev.com/c/2370656 Bug: 1112888 Change-Id: Id6b128f7903f814fd13aeb53f2832a4bbd06c3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378401 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#803165}
-
Jérôme Lebel authored
AccountConsistencyService::active_cookie_manager_requests_for_testing_ is not set to 0. AccountConsistencyServiceTest fails. Related to crrev.com/c/2346664 Fixed: 1123568 Change-Id: If9842d57daef2bcc4e3c365ada38d5668ddbcc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385516 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#803164}
-
Alice Wang authored
This CL uses correct warning icon for sign-in general error and adds render tests for the sign-in general error view. Bug: 1120308 Change-Id: Ie25b8be7fca803ea49dfbc855dac41bc2bd89f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379751Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803163}
-
James Vecore authored
Bug: b:154865204 Change-Id: I0edd7de777ecdcade982e9dadb30449d0c4b5b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385875Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803162}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ec0b23923e9..7b5439987f75 2020-08-31 jmadill@chromium.org Remove Vulkan repos from export targets ignore list. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ie5f8754241736c00e24cb3d542a67f17c7d96ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803161}
-