- 08 Oct, 2019 40 commits
-
-
Friedrich Horschig authored
By setting the bottom sheet observer whenever we bring up the sheet, the closing signal will be captured reliably. This wasn't the case before which caused the bottom sheet to be permanently dismissed. Note: I removed the NOTIMPLEMENTED() call from onDismiss() since it crashes but has no real reason to do so — the cleanup happens in the destructor anyway. It might be late but it's not wrong. Side effect: for some reason, this seems to fix the intermediate peek state (see screenshot 1 in the linked bug). This is unexpected and since it's a timing-related issue probably not a reliable fix. It will be addresses and tested separately, later. Bug: 1011856 Change-Id: I8e2321ef920bc5adab116278521f95b449d10565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847214Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703707}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a639f7a24477..b4161d3c0d43 git log a639f7a24477..b4161d3c0d43 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 peah@webrtc.org AEC3: Add multichannel support to the residual echo estimator 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5ac2340a..977e7324 (703358:703537) 2019-10-07 dinosaurav@chromium.org Add/remove receive streams with SSRC 0 from media channels Created with: gclient setdep -r src/third_party/webrtc@b4161d3c0d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie684d8c1cb5d1f7f057cf68ae5109231993b33b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703706}
-
Roman Sorokin authored
TBR=antrim@chromium.org Bug: 1011005 Test: checked locally saml login/saml interstitial Change-Id: I25888c67ff193bcd6555c71dd83c7f090009ee23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845010Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703705}
-
Rune Lillesveen authored
Shadow DOM V0 insertion points are not part of the flat tree, which means they won't have non-null ComputedStyle (unless cached by getComputedStyle()). Make sure we skip up to the flat tree parent to check if the style inheritance parent GetComputedStyle for the optimization of not marking style dirty unnecessarily in non-rendered subtrees. The TEST was failing with FlatTreeStyleRecalc enabled. TEST=fast/css/clear-activechain-list-shadow-dom.html Bug: 972752, 1012201 Change-Id: Ia36c418bb06d9988fe8cdb118e93d072a3c7cc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847273 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703704}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79eb4f5c..c4823069 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb96327130dfa283ff871872d68af5053b72b969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847253Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703703}
-
Ryan Daum authored
Bug: internal b/141853741 Change-Id: Iaa5f5ac1a6fe46addd11d8f666c9cee4fa6b08f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845674 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#703702}
-
Charlie Harrison authored
Bug: None Change-Id: I56ef31ecfaebe5bfd14ec57826d99578ae17a883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841231Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#703701}
-
Elly Fong-Jones authored
Replace it with a member var of DialogDelegate with an appropriate setter, and stash it inside the DialogDelegate's params. Bug: 1011446 Change-Id: I3b9e096b70e1fbac5a80c0171655c67c74c0379e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846291Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703700}
-
Geoff Lang authored
With the passthrough command decoder on Mac, backpressure fence and flush workarounds need to be done in the GLContextEGL as well. Move them to the base GLContext class so they are usable by both context types. Fixes flickering issues on UI elements on Mac when using the passthrough command decoder. BUG=1011017 Change-Id: Iba226caada24341abc58053e7d033e114d16df3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838371 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#703699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/482a6e85b167..a9e7e778b1db Created with: gclient setdep -r src-internal@a9e7e778b1db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic47f37120c54a30d574f4b314b3a6dbcc260bf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703698}
-
Rouslan Solomakhin authored
Before this patch, Context.bindService() could return false when connecting to payment app's org.chromium.intent.action.IS_READY_TO_PAY service, although ServiceConnection.onServiceConnected() was also invoked. The onServiceConnected() method would set mIsServiceConnected to true, which would cause Context.unbindService() call, which would throw InvalidArgumentException, because bindService() returned false. This patch removes mIsServiceConnected boolean that was set in onServiceConnected() method and adds mIsServiceBindingInitiated that is set to the return value of bindService(). If this boolean is true, then unbindService() is called. After this patch, unbindService() is called only if bindService() returned true, thus avoiding the IllegalArgumentException. Tested locally against BobPay.apk downloaded from https://bobpay.xyz and invoked from https://rsolomakhin.github.io/pr/skip-ui/. Bug: 828852 Change-Id: I00647791098f129b3a16f1f3430a363ee12ecee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845953Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703697}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ibe9df49abb07530e6613de0865db75420f7c396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837114Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703696}
-
Xida Chen authored
This test is just a sample to show how to write an interpolation test. Bug: None Change-Id: Ie66e8c6d290703052ea1f30d71bac44f2dfe8f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841938Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703695}
-
Rune Lillesveen authored
We do not consider dirty bits on shadow roots with FlatTreeStyleRecalc enabled. The skipped LocalStyleChange had no effect, even in the current code since ShadowRoot::RecalcStyle only checks for SubtreeStyleChange. With the FlatTreeStyleRecalcFlag enabled, mark the shadow host for subtree recalc instead. TEST=fast/css/invalidation/shadow-root-sibling-invalidation-crash.html TEST=fast/css/invalidation/shadow-root-sibling-invalidation-crash-2.html Bug: 972752 Change-Id: I1b4917f4d0cf30cb235284cbdcff26c7018190fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844984 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703694}
-
Nico Weber authored
This will hopefully "fix" the following tests in cross builds (by no longer running them) in interactive_ui_tests: ExtensionSettingsUIBrowserTest.ActivityLogInactiveWithoutSwitch ExtensionSettingsUIBrowserTest.ListenerRegistration ExtensionSettingsUIBrowserTest.ViewSource ExtensionsActivityLogTest.TestActivityLogVisible See comment 6 on the bug. If this helps, I'll try reverting #702844 which might then no longer be necessary. Bug: 1010561 Change-Id: Id31c4ea33493f6917d3a855d49cada56a032e9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845801 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#703693}
-
Xida Chen authored
Bug: 900581 Change-Id: Ide1ea499203b960fe59faeecda1a273a0689477c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841412Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703692}
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I17818dd46ad42882388a145cdd49400f2f2e5a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845711Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#703691}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I1893aedc7584da2d31507eb16b284c2a9ea495cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847611Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703690}
-
Etienne Pierre-doray authored
Problem: EXPECT_EQ(1U, task_source->HasOneRef()) fails because threads don't release ref right away. Fix: use JoinForTesting Bug: 1011502 Change-Id: I4f5c7da2d3cf66cd6635a97c4b99acba866c2db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845232 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#703689}
-
kylechar authored
This reverts commit 5ccc40c0. Reason for revert: Broke Linux build and has closed tree. Original change's description: > Reland "Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5" > > This is a reland of 5d024fd7 > > Missed including "ip_address_space.mojom-blink.h" > in worker_module_script_fetcher.cc > > Original change's description: > > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5 > > > > To reduce pre-processed size of header files have been including > > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > > .mojom-blink-forward.h in blink header files. > > > > This CL has no behavior changes and following CLs will > > continue replacing them more. > > > > Bug: 1001360 > > Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#703549} > > Bug: 1001360 > Change-Id: I5279e2fba33e46fa7eb002deeda34421c4176f53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846416 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703592} TBR=tkent@chromium.org,gyuyoung@igalia.com Change-Id: Icbaee19c0a33a0fe7bfc0d7012041e2e3ef962dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847671Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703688}
-
Marc Treib authored
This reverts commit 1886f107. Reason for revert: Looks like this broke the build, e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/10940 https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/81787 https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/80241 Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 7 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: Ic627fb1cb10815ee58ba107a9fa4fc98f5884aa6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844527 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703686} TBR=kinuko@chromium.org,tkent@chromium.org,gyuyoung@igalia.com Change-Id: I62773d78577ee622fee300e3cf5d51de990714ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847298Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703687}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: Ic627fb1cb10815ee58ba107a9fa4fc98f5884aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844527Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#703686}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I01ed96c6886b089f75eaace9bce31743872838d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846624Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#703685}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/902cf1e12a74..a6f07c5b5c7e git log 902cf1e12a74..a6f07c5b5c7e --date=short --no-merges --format='%ad %ae %s' 2019-10-08 benjaminwagner@google.com Reland "Use integer patchset and issue variables." Created with: gclient setdep -r src/third_party/skia@a6f07c5b5c7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I8feee4c4babe44e61c352fcae6c6138ada76501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703684}
-
Julie Jeongeun Kim authored
This CL converts BeforeUnloadControl and MimeHandlerService from mime_handler.mojom using PendingReceiver, PendingRemote, Remote, and Receiver. Bug: 955171 Change-Id: Ia4ad1433553490f1288b766a75471b1599b8da19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846614 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703683}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1167bff3e9a6..5a1a79c0e8de git log 1167bff3e9a6..5a1a79c0e8de --date=short --no-merges --format='%ad %ae %s' 2019-10-08 wl@gnu.org [woff2] Fix SFNT table checks. Created with: gclient setdep -r src/third_party/freetype/src@5a1a79c0e8de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Iff093d7a6c20b33515e69693260f0bcb2ca8c8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#703682}
-
Miyoung Shin authored
This change converts MediaDevicesDispatcherHost and MediaStreamDispatcherHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ibe45f9fa4502812e43634ac18ab4defc8ed097c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844004Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#703681}
-
Mikhail Khokhlov authored
The old name is also supported for compatibility. Bug: 1011813 Change-Id: I513d316bea76c1355a2fdf6785acee6e6ca940af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847292Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#703680}
-
Marc Treib authored
FindBestMatches now returns the best matches in a vector, instead of in a map keyed by username. For now, FormFetcher[Impl] still sorts the matches by username; that'll be addressed in followup CLs. Bug: 1011399 Change-Id: I217aa7646bdc9eb9bf8cb2ff244f54f17b4f7a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844969 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703679}
-
Julie Jeongeun Kim authored
This CL converts AppWindow in app_window.mojom using PendingReceiver, Remote, and ReceiverSet. Bug: 955171 Change-Id: I254824287a2dc520a8b1383bb34e9a829c7a9942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846637Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#703678}
-
Patrik Höglund authored
Tbr: skyostil@chromium.org Bug: 1012218 Change-Id: If238d6632769c3f4faa4fde81d53b26ba83bdf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847293Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703677}
-
Roman Aleksandrov authored
Bug: 1001484 Change-Id: I9e8ac8b51a197d807abe21b6c81546d5c9042f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823848Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#703676}
-
Julie Jeongeun Kim authored
This CL converts KeepAlive in keep_alive.mojom using PendingReceiver, ReceiverSet, and Receiver. Bug: 955171 Change-Id: I29b195d41000d185a3c7b45193794aac16ad0829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846413Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#703675}
-
Ioana Pandele authored
The type was left over from the export feature cleanup. Change-Id: I7d50256119f1467a36cafd33d385234f2ea06212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845768Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#703674}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a333b87cfcbe..199e8ee06a7a git log a333b87cfcbe..199e8ee06a7a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src c18c9ff6bc30..3c7ff8d4f0a1 (1 commits) Created with: gclient setdep -r src/third_party/angle@199e8ee06a7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: Ifb9e9abe78ee56c8cddf8c73290a9b8810d2f849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703673}
-
Fredrik Söderquist authored
Keep a cached value for the next "interesting"[1] time in a timed element. This cache is updated every time we get a new interval, change the end of an interval or trigger a repeat. This reduces the time spent in SMILTimeContainer::NextInterestingTime(), and lays the foundation for improved scheduling of interval updates in the future. The term "interesting" is replaced by "interval" in related function names and variables. [1] The next time that an interval either starts, ends or repeats. Bug: 998526 Change-Id: I082d37b2000bc8d691363d87c22309013823664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844818 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703672}
-
Alexander Timin authored
R=ahemery@chromium.org Change-Id: Ib82b3c0861673822f79445df58db9429b3d72ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847333 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#703671}
-
Marc Treib authored
After https://crrev.com/c/1831873, a lot of code in the model is unused. Bug: 1007942 Change-Id: Ifc57c83d8cfd828836c704584c4c27c40b098565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835618 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66bd5d4deb12..482a6e85b167 Created with: gclient setdep -r src-internal@482a6e85b167 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7ddcc39602d8facd72ad19e82ca436013085d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703669}
-
Julie Jeongeun Kim authored
This CL converts UDPSocketListener from udp_socket.mojom to new Mojo types using PendingReceiver, Receiver, PendingRemote, Remote and Receiver. Bug: 955171 Change-Id: I6ce6be80e58a485ba7674db40fe55b6d95452eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831961Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#703668}
-