- 03 May, 2018 40 commits
-
-
Sammie Quon authored
Allows user drop down menu to activatble so that it can be cycled through. Add a custom focus search so the drop down menu closes after all items have been cycled through. Migrate Closure to OnceClosure. Make drop down menu a transient child of system bubble. Test: manual Bug: 799401 Change-Id: I67af2bb3e58c88f6926ab65ecf565d69325d00b8 Reviewed-on: https://chromium-review.googlesource.com/1038656Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#555756}
-
Douglas Creager authored
We weren't including the `include-subdomains` field of each endpoint group in the data we were handing over to the net-internals page. (The net-internals code that reads this field is already there; we just weren't filling in a value.) Bug: 829353 Change-Id: Ifdff1d6e0baf802eb7f094571060b93c761936af Reviewed-on: https://chromium-review.googlesource.com/1019661Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@google.com> Cr-Commit-Position: refs/heads/master@{#555755}
-
Koji Ishii authored
Following bot results are included. 5144 5146 5148 5149 5150 5151 5152 5154 5155 1 lines were removed and 0 lines were deflaked by consecutive results since 5100. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib0614dfcb6f39c7e101920875079278f1bb795c7 Reviewed-on: https://chromium-review.googlesource.com/1040225 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555754}
-
Roman Sorokin authored
Don't DCHECK on password being plain text in existing user controller. Make it if statement. BUG=chromium:839314 TEST=manual Change-Id: I7a649ddb922edd2105563cb2b4959b764d0383a4 Reviewed-on: https://chromium-review.googlesource.com/1041958 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555753}
-
Steve Kobes authored
These virtual test suites no longer exist. Bug: 823365 Change-Id: I62503d3b99f192f46e09acd6b8f38fad84e1ee9a Reviewed-on: https://chromium-review.googlesource.com/1042369Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555752}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ff5b671. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16757 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI TBR=kereliuk No-Export: true Change-Id: I3a8ae73b98b0099bbc66b21fbffd1c46b01a7412 Reviewed-on: https://chromium-review.googlesource.com/1042207 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555751}
-
https://pdfium.googlesource.com/pdfium.git/+log/6312bf94bb44..ccd942158992 $ git log 6312bf94b..ccd942158 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 tsepez Add CPDF_Page::Extension::GetDocExtension() 2018-05-03 tsepez Make GetPDFDocument return a CPDF_Docment*, not void*. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I57a6b3d5a99ada684414265fb3d323869a4d13f9 Reviewed-on: https://chromium-review.googlesource.com/1042371 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555750}
-
Amirhossein Simjour authored
This is a reland of 480d1516. Patch was not responsible for bot failures. Original change's description: > Scroll support for hosted dialogs in VR > > Now that VR supports html <select>, we should send scroll events > to dialogs. > > Bug: 836292 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288 > Reviewed-on: https://chromium-review.googlesource.com/1028584 > Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555454} TBR=vollick@chromium.org, asimjour@chromium.org Bug: 836292 Change-Id: I8391daee7a1908273d5349106237e2177ad3c293 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1042546Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555749}
-
Greg Thompson authored
The new text makes it more clear how the setting impacts Chrome OS vs Chrome browser. BUG=839308 R=atwilson@chromium.org Change-Id: I73de539820bd1fb7b822c88fad2eb6f2f2e8b3ab Reviewed-on: https://chromium-review.googlesource.com/1042306Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555748}
-
Alexander Timin authored
R=alexclarke@chromium.org Change-Id: I77cf2e26643a862217d009cc7539fd838d3c1583 Reviewed-on: https://chromium-review.googlesource.com/1042189 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555747}
-
Marc Treib authored
The version without the "virtual/video-surface-layer/" prefix already had it. Bug: 520736,838128 Change-Id: I815f420dd134143837d1602e795075176f4e4eb5 Reviewed-on: https://chromium-review.googlesource.com/1042565Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#555746}
-
Oskar Sundbom authored
Now that AudioInputDevice doesn't automatically redirect calls to the correct thread, ProcessedLocalAudioSource needs to do that itself. Bug: 838929 Change-Id: I55f1cf9c6446b90b464b229e4c9a621613bf9dfb Reviewed-on: https://chromium-review.googlesource.com/1041954 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555745}
-
Egor Pasko authored
I think digit@chromium.org is more preferable these days, so change the remaining cases of digit@google.com to the preferable way for extra consistency. TBR=estevenson@chromium.org NOTRY=true Bug: None Change-Id: Ie545282b334f056c7e72836caabec8539441ec3b Reviewed-on: https://chromium-review.googlesource.com/1030376 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#555744}
-
Kevin McNee authored
If we pinch an element with a touch-action that prevents pinch in an OOPIF, we route the pinch events to the child so that the child's TouchActionFilter filters them. Due to crbug.com/771330, the TouchActionFilter could let the pinch events through. We'll filter such events in RenderWidgetHostViewChildFrame::FilterInputEvent to prevent them from being sent to the child renderer. Bug: 827182 Change-Id: I3782a2d135a008df271a73d79ecade25dcc9f1a5 Reviewed-on: https://chromium-review.googlesource.com/1040354Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#555743}
-
Marc Treib authored
TBR=pauljensen@chromium.org Bug: 838524 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1ae71d8c07f91827e164b046d4c379aeee4125ac Reviewed-on: https://chromium-review.googlesource.com/1042397 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#555742}
-
Antonio Gomes authored
This method is creating a net::HttpRequestHeaders object, serializing it to a string, and then parsing that string to create a new net::HttpRequestHeaders object. CL just returns the net::HttpRequestHeaders object directly. No expected behavior change. TESTS=Covered by existing tests. Bug: None Change-Id: I356c5987e0dcf60e454efc08f93d25ec75954c11 Reviewed-on: https://chromium-review.googlesource.com/1040705 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
spqchan authored
The horizontal padding around the browser actions container was incorrectly reduced. This causes issues where you can't resize the omnibox (because the extensions now overlap the gripper) or drag the extensions into the wrench menu Bug: 825378, 825782 Change-Id: I66061a67546fab679c280a8d816b78dbe19b876e Reviewed-on: https://chromium-review.googlesource.com/1040914Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555740}
-
jonross authored
The test WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode is flaking so I'm disabling. TBR= xiyuan@chromium.org TEST=WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode Bug: 838756 Change-Id: I68f90b668996a885ef37e047d453e6ecca12217c Reviewed-on: https://chromium-review.googlesource.com/1042350Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#555739}
-
David 'Digit' Turner authored
Now that we can safely depend on C++11, add a few move constructors to the String and Vector utility classes. This will be used in future CLs used to fix various issues with the crazy linker. BUG=802068 R=pasko@chromium.org, lizeb@chromium.org, agrieve@chromium.org Change-Id: I7fe420fe16e03e2eb1dbabafdcc0fb72c40ce3ba Reviewed-on: https://chromium-review.googlesource.com/1041960 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555738}
-
Wez authored
Bug: 706592 Change-Id: I5e399e76e3ca98ee80d76aa4fd92b2d3bba60d39 Reviewed-on: https://chromium-review.googlesource.com/976085Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Oskar Sundbom authored
This is done specifically to filter out the aggregate devices created when using kAudioUnitSubType_VoiceProcessingIO. Those should not be directly user-selectable. This CL allows other aggregate devices, but ensures they do not claim to support native echo cancellation, since they don't. Those devices will have to use software AEC. Bug: 837227 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iebb5286cafebe40204899ee2b7f1e0ff263d1fd6 Reviewed-on: https://chromium-review.googlesource.com/1030170 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555736}
-
Annie Sullivan authored
NOTRY=true TBR=nednguyen@google.com Bug: 839411 Change-Id: I659bb4ca9a7cac243e6ccc294d383ce71776f84d Reviewed-on: https://chromium-review.googlesource.com/1042527Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555735}
-
Mikel Astiz authored
With DCHECKs enabled, GetStorageKey() might potentially fail in some codepaths that are updated in this patch. In addition, we introduce a CHECK for a scenario that is subject to investigation. Bug: 837517 Change-Id: I903f83e8ed7ca96aa525c0640aa9ffc629fc5721 Reviewed-on: https://chromium-review.googlesource.com/1042393Reviewed-by:
-
Vadym Doroshenko authored
Bug: None Change-Id: Ib80295f0aaa4bb2001c2ffd28d78924030b06e4f Reviewed-on: https://chromium-review.googlesource.com/1042289Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#555733}
-
jonross authored
Currently MSE_ExternalClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM is flaking on Mac. So I'm disabling it until that can be resolved. TBR=xhwang@chromium.org TEST=MSE_ExternalClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM Bug: 835585 Change-Id: Ifb82978c391d99804667c87a3d43ea1539bf9110 Reviewed-on: https://chromium-review.googlesource.com/1042373Reviewed-by:
-
Alex Newcomer authored
Add a chrome flag so users can enable the feature without using a switch. BUG=832876 Change-Id: I18b754c892e37e995561bd22b6e95545683ff03e Reviewed-on: https://chromium-review.googlesource.com/1012930Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555731}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc1a04fd..e043a8b3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ieb151d6570f0c1960f2a39ff80502cd86a23b331 Reviewed-on: https://chromium-review.googlesource.com/1042045Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555730}
-
Rune Lillesveen authored
We need the special-cased width because of some icon taking up space for input type="search". However, we should not modify computed style to do so. Instead use SetOverrideLogicalWidth(). Gets rid of MutableStyleRef() access. TEST=fast/forms/placeholder-position.html Bug: 813068 Change-Id: I93886bc8c53ff84b3c37a0cc543ab7dc274a758f Reviewed-on: https://chromium-review.googlesource.com/1041932 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#555729}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0caef298c2ff..4722a4135911 $ git log 0caef298c..4722a4135 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 rmistry Skip post upload hooks for new service accounts 2018-05-03 skia-bookmaker Update markdown files 2018-05-03 angle-skia-autoroll Roll third_party/externals/angle2/ 78feddc28..e708f004b (5 commits) 2018-04-30 bungeman Update SkRandomScalerContext to handle mask filters. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2533cfb22f6b1d2b736592cac79b60a3dfd53ffa Reviewed-on: https://chromium-review.googlesource.com/1042368 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555728}
-
arthursonzogni authored
This updates the following tests: - NavigationControllerBrowserTest.ReloadWithUrlAnchor - NavigationControllerBrowserTest.ReloadWithUrlAnchorAndScroll This two tests are making a <div> to scroll because of a navigation to an anchor. Then the tests check the scroll position is restored after a reload. The issue is that it is not deterministic when the scrolled area is not the root area. It is working consistently only because the main resource's response is small (e.g <64ko) and FrameLoader::ProcessFragment() is called before FrameLoader::RestoreScrollPositionAndViewState(). This CL make the tests uses the root area instead of the <div>. --- Description of what happens in the current code: 1) When ProcessFragment() is called first: a) ProcessFragment(): Several scrollable layers are scrolled such that the anchor is displayed. It may includes the root one, but also some children. b) RestoreScrollPositionAndViewState(): The root layer is scrolled using what is stored in the HistoryItem. It overrides the scroll done in a) for the root layer. Children layers are not overridden. 2) When RestoreScrollPositionAndViewState() is called first: a) RestoreScrollPositionAndViewState(): The root layer is scrolled using what is stored in the HistoryItem. Children layers are not scrolled. b) ProcessFragment(): Nothing happens because InitialScrollState::did_restore_from_history has been set to true in a). The ProcessFragment() will skip the fragment scroll. At the end, the difference is that the children layers are scrolled in 1), but not in 2). --- Bug: 821877, 831155, 839292 Change-Id: I11c74224ba42ad58814c4d4e185d7db189551775 Reviewed-on: https://chromium-review.googlesource.com/1039827Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#555727}
-
Christian Dullweber authored
Protocol handler are site settings and should be deleted when a user decides to remove site settings from Clear Browsing Data. In order to allow precise deletions, we need to add a timestamp. Old handlers don't have timestamps, so they are treated as created at base::Time(0) and will only be removed if all data is deleted. Preinstalled and policy defined handlers are not removed. Bug: 824131 Change-Id: I2599a53ff5712d5aac28ba4024bb0bc123aa32e6 Reviewed-on: https://chromium-review.googlesource.com/1000697 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#555726}
-
Mounir Lamouri authored
Bug: None Change-Id: I99ee800fcfc009f45f789c1343ab026e400bb2d0 Reviewed-on: https://chromium-review.googlesource.com/1042405Reviewed-by:
-
Antonio Gomes authored
Of the various unittests associated with the migration that were reworked to work with the TestURLLoaderFactory machinery, two particularly became unneeded: - OneGoogleBarFetcherImplTest::SecondRequestOverridesFirst. The test exercised a premise of SimpleURLLoader that says once an instance is deleted its completion call will not be called. - OneGoogleBarFetcherImplTest, HttpErrorIsFatal The latest CL does not distinguish between server and common HTTP errors any more. CL also updates OneGoogleBarFetcherImplTests::thread_bundle_ to initialize with IO_MAINLOOP, so that it accommodates network requests being made on UI threa BUG=773295 Change-Id: I1a186f4067eb64f0e36d1b88ccbe9c8914a67480 Reviewed-on: https://chromium-review.googlesource.com/1031450 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555724}
-
jonross authored
PushMessagingBrowserTest.UnsubscribeSuccess is flaking on Windows, so I'm disabling it. TBR=peter@chromium.org TEST=PushMessagingBrowserTest.UnsubscribeSuccess Bug: 838759 Change-Id: I7cf36aa034f8666639830a510aa1d18da6189911 Reviewed-on: https://chromium-review.googlesource.com/1042366Reviewed-by:
-
Alex Newcomer authored
When an event occurs that closes the Context Menu, do not repost the event. This cl also updates a few tests that broke once the change was made. Bug: 826517 Change-Id: I9fa29ab37f55ebbd62ef0764750174db1057043c Reviewed-on: https://chromium-review.googlesource.com/1038757Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555722}
-
John Budorick authored
TBR=rdevlin.cronin@chromium.org Bug: 839371 Change-Id: I828d3038e4651275905ae82c984bc58d7262917e Reviewed-on: https://chromium-review.googlesource.com/1042367Reviewed-by:
-
Leonard Grey authored
In https://chromium-review.googlesource.com/c/chromium/src/+/852978, TabWindowController was changed to no longer subclass NSWindowController. But, since many callers assumed that a browser window's window controller was also its delegate, the new window controller proxies NSWindowDelegate methods to the TabWindowController. Unfortunately, it turns out that callers also make assumptions about the delegate, and if we only forward NSWindowDelegate methods, some fall through the cracks. This change removes the NSWindowDelegate check from the forwarding code, to ensure that TabWindowController receives all method calls meant for it. Bug: 835296 Change-Id: Ia16b8018c7c110e44a34b0f4cb1a636a143c3415 Reviewed-on: https://chromium-review.googlesource.com/1040945Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#555720}
-
chaopeng authored
This issue is caused by: 1. When user tap on screen, we receive TapDown, ShowPress, Tap. TapDown and ShowPress will active the tapped element. Then Tap checks the LastShowPressTimeStamp() to stay active or cancel. 2. Each frame has GestureManager and we store LastShowPressTimeStamp() in GestureManager. 3. We check the root frame GestureManager LastShowPressTimeStamp() before hit test so we read the wrong LastShowPressTimeStamp(). In this patch, we move last_show_press_timestamp_ to root frame EventHandler so we don't need to hit test and figure which GestureManager should use. Bug: 714573 Change-Id: I80c75bf2f0493a6cbfd3b24873e1127da4fd7a27 Test: EventHandlerSimTest_TapActiveInFrame Test: Manual test for OOPIF Reviewed-on: https://chromium-review.googlesource.com/1041065Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555719}
-
Christian Fremerey authored
The API of the video capture service currently depends on a native enum VideoPixelFormat and a struct media.mojom.MailboxVideoFrameData declared in media_types.mojom. This CL breaks this dependency by defining a (non-native) Mojo enum VideoCapturePixelFormat and a struct media.mojom.MailboxBufferHandleSet specifically for the video capture service. This has two benefits: 1.) It makes it clear from the API that the video capture service actually only supports a much more limited set of pixel formats. 2.) It allows the reuse of the API definition in the mojom files in contexts where media/ and type mappings to native enums are not available. In particular, this is the case when trying to use the video capture service API from ChromiumOS. This is purely an interface refactoring. There is no intent for functional change. TBR=xjz@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I418e5bb95bd92da0600afd874b6fde71e982761a Reviewed-on: https://chromium-review.googlesource.com/1026795Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555718}
-
Roman Sorokin authored
Problem is gssapi library (which Chrome uses for Kerberos SSO) uses krb5.conf settings. So even if DisableAuthNegotiateCnameLookup is enabled, GSSAPI still does canonicalization internally. This can be toggled in krb5.conf by setting dns_canonicalize_hostname, so this CL modifies the krb5.conf we get from authpolicy accordingly. It also sets reverse dns (rdns) to false, because Chrome does not do reverse search BUG=chromium:815158 TEST=ExistingUserControllerActiveDirectoryTest.PolicyChangeTriggersFileUpdate Change-Id: I418ed028d1bc4ba58883b01fb9f3c314fbed7c1c Reviewed-on: https://chromium-review.googlesource.com/1016802 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#555717}
-
