1. 19 Sep, 2014 40 commits
    • qsr's avatar
      mojo: Add deserialization to python structs. · 25606073
      qsr authored
      This is a reland of https://codereview.chromium.org/588493002 using buffer on
      bytearray before trying to call unpack_from because python 2.7.3 and earlier
      doesn't handle unpacking a bytearray directly.
      
      BUG=415491
      R=sdefresne@chromium.org,cmasone@chromium.org
      
      Review URL: https://codereview.chromium.org/584893002
      
      Cr-Commit-Position: refs/heads/master@{#295716}
      25606073
    • sdefresne's avatar
      Use libc++ by default on iOS · 7da3d887
      sdefresne authored
      libc++ is the recommended C++ library for iOS development so use
      it by default when targeting iOS.
      
      clang ToT ships with all the required header and libraries to
      support compiling with -stdlib=libc++ so remove the exception.
      
      BUG=366744
      
      Review URL: https://codereview.chromium.org/589513003
      
      Cr-Commit-Position: refs/heads/master@{#295715}
      7da3d887
    • shilpa.shri's avatar
      [Mac] Remove unnecessary button on 'Bookmark all tabs' window · 0ce925fc
      shilpa.shri authored
      Remove unnecessary button on 'Bookmark all tabs' window which appears
      before "Bookmarks Bar"
      XIB Changes:
      Removing the line in the following .xib file which is responsible for the appearance of empty button.
      chrome/app/nibs/BookmarkAllTabs.xib
      
      BUG=415554
      R=asvitkine@chromium.org
      
      TEST=
      1) Launch chrome, open 2-3 tabs.
      2) Right click on last tab and select 'Bookmark all tabs'
      3) Empty button shouldn't be shown.
      
      Review URL: https://codereview.chromium.org/583633002
      
      Cr-Commit-Position: refs/heads/master@{#295714}
      0ce925fc
    • xians's avatar
      Dynamically allocate more memory to AudioBlockFifo. · f6734cf6
      xians authored
      PulseAudio input can provide larger buffer size than what we ask for. This happens if the pulse internally increase its buffer size for various reasons. This patch handles it by dynamically allocate more memory to the FIFO.
      
      BUG=411453
      TEST=1. Have Jackd own a second (USB) microphone, and have
      Pulseaudio connect to Jackd with the Pulseaudio Jack
      module. There are many steps:
      1a. Obtain a USB mic.
      1b. Find out the ALSA name of the mic and of the default
      audio.
      1c. Create a file ~/.jackdrc containing:
      /usr/bin/jackd -dalsa -d hw:<default audio device>
      1d. Run "alsa_in -d hw:<USB mic name> &" (in background)
      1e. Install pulseaudio-module-jack if not installed.
      1f. Run "pactl load-module module-jack-source channels=2"
      1g. Go into Pulseaudio and select Input, then Jack source.
      1h. Install patchage, start it up and connect the USB mic
      to the Pulseaudio JACK source.
      2. Start up Chrome and begin a Hangout. Make sure that
      Chrome is using the Default mic.
      3. Have someone (or yourself on another computer) join the
      Hangout and listen to you talk.
      
      Review URL: https://codereview.chromium.org/557693003
      
      Cr-Commit-Position: refs/heads/master@{#295713}
      f6734cf6
    • skia-deps-roller's avatar
      Roll src/third_party/skia 65b4895:f782639 · cf009964
      skia-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/skia/+log/65b4895..f782639
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=stephana@google.com
      
      Review URL: https://codereview.chromium.org/583213002
      
      Cr-Commit-Position: refs/heads/master@{#295712}
      cf009964
    • flackr's avatar
      Don't minimize dragged window when shelf hidden. · 35afaeb4
      flackr authored
      If the shelf hides we should not immediately minimize a dragged panel. This panel can be dropped where it now is and detached.
      
      BUG=393047
      TEST=PanelWindowResizerTest.DetachThenHideShelf
      TEST=Drag a panel window while switching profiles. There is no crash and the window is detached where it was when switching back.
      
      Review URL: https://codereview.chromium.org/582803002
      
      Cr-Commit-Position: refs/heads/master@{#295711}
      35afaeb4
    • mgiuca's avatar
      Experimental app list: Enforce a 24-pixel padding on the top and sides. · 4bf6b514
      mgiuca authored
      Applies to the horizontal divider line under the folder heading, and
      above the contents switcher view, and the folder back button. Also set
      the contents switcher background colour to the main background colour
      (it doesn't make sense to have a different colour if the divider line
      doesn't reach all the way to the edge).
      
      BUG=411775
      
      Review URL: https://codereview.chromium.org/578223002
      
      Cr-Commit-Position: refs/heads/master@{#295710}
      4bf6b514
    • kulkarni.a's avatar
      Code re-factor related to WeakPtrFactory in src/gin module · 71a12a87
      kulkarni.a authored
      Changing in the initialization order of WeakPtrFactory in src/gin module
      such that all member variables should appear before the WeakPtrFactory
      to ensure that any WeakPtrs to Controller are invalidated before its members
      variable's destructor are executed, rendering them invalid.
      
      BUG=303818
      
      Review URL: https://codereview.chromium.org/580703002
      
      Cr-Commit-Position: refs/heads/master@{#295709}
      71a12a87
    • reillyg's avatar
      Add a service to track devices selected by the user. · 89b276fb
      reillyg authored
      apps::SavedDevicesService tracks USB devices that have been selected by
      the user in the context of a given extension. Devices that can be
      identified accurately after they have been reconnected because they have
      a serial number are written out to ExtensionPrefs. All others are only
      remembered until they are disconnected.
      
      A new OnDisconnect observer function has been added to UsbDevice to
      enable this monitoring.
      
      BUG=346953
      
      Review URL: https://codereview.chromium.org/580963002
      
      Cr-Commit-Position: refs/heads/master@{#295708}
      89b276fb
    • henrika's avatar
      Adds time measurement of AudioOutputDevice::AudioThreadCallback::Process · bfae6356
      henrika authored
      BUG=NONE
      TEST=Manually tested WebRTC clients and verified new UMA after close.
      
      Review URL: https://codereview.chromium.org/577953002
      
      Cr-Commit-Position: refs/heads/master@{#295707}
      bfae6356
    • lanwei's avatar
      Clean up GestureEventDetails constructors and fix unit tests. · 46f76555
      lanwei authored
      Reland the code change for Issue 573963005: Clean up GestureEventDetails
      constructors and fix unit tests:
      https://codereview.chromium.org/573963005/.
      
      The code does not change, just merge two commits into one.
      
      BUG=350942
      TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org
      
      Review URL: https://codereview.chromium.org/581963004
      
      Cr-Commit-Position: refs/heads/master@{#295706}
      46f76555
    • sullivan's avatar
      Set IdleHandler timer on background threads a minimum of 30s in the future after initial run. · cd45a3ee
      sullivan authored
      BUG=394187
      
      Review URL: https://codereview.chromium.org/580173003
      
      Cr-Commit-Position: refs/heads/master@{#295705}
      cd45a3ee
    • sullivan's avatar
      Properly escape goma dir on windows. Fixes errors in goma path. · 9d4ff755
      sullivan authored
      BUG=394990
      
      Review URL: https://codereview.chromium.org/583793002
      
      Cr-Commit-Position: refs/heads/master@{#295704}
      9d4ff755
    • rohitrao's avatar
      Uses the correct scale factor for fallback images on iOS. · fb35e64a
      rohitrao authored
      Fallback images should always have a source scale factor of 1.0, even on 300P
      devices.
      
      BUG=413300,415616
      TEST=None
      
      Review URL: https://codereview.chromium.org/579383003
      
      Cr-Commit-Position: refs/heads/master@{#295703}
      fb35e64a
    • eugenis's avatar
      Revert of Make ONCCertificateImporter async. (patchset #1 id:1 of... · 3d9825c9
      eugenis authored
      Revert of Make ONCCertificateImporter async. (patchset #1 id:1 of https://codereview.chromium.org/582413002/)
      
      Reason for revert:
      Use-after-free.
      https://code.google.com/p/chromium/issues/detail?id=415916
      
      Original issue's description:
      > Make ONCCertificateImporter async.
      >
      > This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
      > Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
      > Now, the import itself is asychronous and calls back on completion.
      >
      > While there, this also removes the GMock of the importer.
      >
      > This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925
      >   refs/heads/master@{#295534}
      > with the fixed destruction order in ONCCertificateImporterImplTest.
      >
      > The fix was reviewed in
      >   https://codereview.chromium.org/589443002/
      >
      > TBR=eroman@chromium.org
      > BUG=413219
      >
      > Committed: https://crrev.com/3b4ba221657f6b27e2156818bc445c885d87fc0e
      > Cr-Commit-Position: refs/heads/master@{#295687}
      
      TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=413219
      
      Review URL: https://codereview.chromium.org/584923002
      
      Cr-Commit-Position: refs/heads/master@{#295702}
      3d9825c9
    • dnicoara's avatar
      Reland of: Remove deprecated cursor event filter for Ozone · ea18a994
      dnicoara authored
      Initial code review: https://codereview.chromium.org/580553002/
      
      BUG=none
      
      Review URL: https://codereview.chromium.org/575143002
      
      Cr-Commit-Position: refs/heads/master@{#295701}
      ea18a994
    • skia-deps-roller's avatar
      Roll src/third_party/skia 3c29c4d:65b4895 · 990cee7b
      skia-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/skia/+log/3c29c4d..65b4895
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=stephana@google.com
      
      Review URL: https://codereview.chromium.org/583193002
      
      Cr-Commit-Position: refs/heads/master@{#295700}
      990cee7b
    • sdefresne's avatar
      Fix compilation with Xcode 6.0.1 · f1994cef
      sdefresne authored
      Apply Xcode 6.0 fix to all following versions of Xcode (it's great that
      gyp does support python string ordering).
      
      BUG=385030
      
      Review URL: https://codereview.chromium.org/589493002
      
      Cr-Commit-Position: refs/heads/master@{#295699}
      f1994cef
    • perkj's avatar
      This fixes a component build breakage introduced by the latest WebRtc roll to r7234. · dd449e72
      perkj authored
      The missing symbol on linux was: _ZN6webrtc18videocapturemodule16VideoCaptureImpl6CreateEiPKc
      
      TBR=sergeyu@chromium.org
      
      Review URL: https://codereview.chromium.org/584623003
      
      Cr-Commit-Position: refs/heads/master@{#295698}
      dd449e72
    • mgiuca's avatar
      App list: The line under folder headings has a fixed margin. · 2cf06c31
      mgiuca authored
      Previously, it had a fixed width, causing it to be very short on the
      wider app list window style. Now it extends (almost) all the way to the
      edge regardless of the app list's width.
      
      BUG=415461
      
      Review URL: https://codereview.chromium.org/581853003
      
      Cr-Commit-Position: refs/heads/master@{#295697}
      2cf06c31
    • vasilii's avatar
      Disable flaky lscreenControllerInteractiveTest.MouseLockSilentAfterTargetUnlock on CrOS. · dba9f11e
      vasilii authored
      BUG=159000
      TBR=erg@chromium.org,mad@chromium.org
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/589513004
      
      Cr-Commit-Position: refs/heads/master@{#295696}
      dba9f11e
    • vabr's avatar
      Clean up BrowsingDataAppCacheHelper · 0b803cd3
      vabr authored
      Remove unused #includes, lower dependencies etc. in preparation for componentisation.
      
      BUG=384873
      
      Review URL: https://codereview.chromium.org/545243002
      
      Cr-Commit-Position: refs/heads/master@{#295695}
      0b803cd3
    • earthdok's avatar
      Fix path prefix stripping in asan_symbolize.py. · 7dc2d89a
      earthdok authored
      BUG=none
      R=glider@chromium.org
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/586533004
      
      Cr-Commit-Position: refs/heads/master@{#295694}
      7dc2d89a
    • vasilii's avatar
      Disable flaky ExtensionOptionsApiTest.ExtensionCanEmbedOwnOptions on Mac. · 38abcc93
      vasilii authored
      BUG=415949
      TBR=ericzeng@chromium.org
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/586693002
      
      Cr-Commit-Position: refs/heads/master@{#295693}
      38abcc93
    • mlamouri's avatar
      Explicitely unlock screen orientation when navigating. · 34841110
      mlamouri authored
      BUG=162827
      
      Review URL: https://codereview.chromium.org/582373003
      
      Cr-Commit-Position: refs/heads/master@{#295692}
      34841110
    • tdresser's avatar
      Revert of Update V8 to version 3.29.78 (based on bleeding_edge revision... · 70647c61
      tdresser authored
      Revert of Update V8 to version 3.29.78 (based on bleeding_edge revision r24051). (patchset #1 id:1 of https://codereview.chromium.org/583023003/)
      
      Reason for revert:
      This is causing crashes in Perf bots.
      
      See crbug.com/415943 for details.
      
      Original issue's description:
      > Update V8 to version 3.29.78 (based on bleeding_edge revision r24051).
      >
      > TBR=machenbach@chromium.org
      >
      > Committed: https://crrev.com/48c3e5ebfd2640061ed488216f1d275d17c887bd
      > Cr-Commit-Position: refs/heads/master@{#295676}
      
      TBR=machenbach@chromium.org,v8-autoroll@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/591433002
      
      Cr-Commit-Position: refs/heads/master@{#295691}
      70647c61
    • chrome-tpm's avatar
      Updating trunk VERSION from 2163.0 to 2164.0 · 7fbaeac9
      chrome-tpm authored
      Cr-Commit-Position: refs/heads/master@{#295690}
      7fbaeac9
    • vasilii's avatar
      Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001... · 9db2dffd
      vasilii authored
      Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/588493002/)
      
      Reason for revert:
      Linux Tests mojo_python_bindings_tests failure
      http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712
      
      ======================================================================
      ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization
          v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize
          serialization_object.Deserialize(fields, data, handles)
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize
          (_, version) = HEADER_STRUCT.unpack_from(data)
      TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray
      
      Original issue's description:
      > mojo: Add deserialization to python structs.
      >
      > This is a reland of https://codereview.chromium.org/578263003 using
      > buffer instead of memoryview, because on some early version of python
      > 2.7, memoryview cannot be used with struct.unpack_from.
      >
      > BUG=415491
      > R=sdefresne@chromium.org,cmasone@chromium.org
      >
      > Committed: https://crrev.com/37dd5f484593b1c8b92b825a9648edf7fb6944e6
      > Cr-Commit-Position: refs/heads/master@{#295684}
      
      TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=415491
      
      Review URL: https://codereview.chromium.org/584003002
      
      Cr-Commit-Position: refs/heads/master@{#295689}
      9db2dffd
    • vasilii's avatar
      Revert of mojo: fix python unittests. (patchset #1 id:1 of... · faf1182f
      vasilii authored
      Revert of mojo: fix python unittests. (patchset #1 id:1 of https://codereview.chromium.org/586683002/)
      
      Reason for revert:
      Linux Tests mojo_python_bindings_tests failure
      http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712
      
      ======================================================================
      ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization
          v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize
          serialization_object.Deserialize(fields, data, handles)
        File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize
          (_, version) = HEADER_STRUCT.unpack_from(data)
      TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray
      
      Original issue's description:
      > mojo: fix python unittests.
      >
      > TBR=sdefresne@chromium.org
      >
      > Committed: https://chromium.googlesource.com/chromium/src/+/80ced42d624a1eec8e8a2f0c0c760ab576d65ead
      
      TBR=sdefresne@chromium.org,qsr@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/587653003
      
      Cr-Commit-Position: refs/heads/master@{#295688}
      faf1182f
    • pneubeck's avatar
      Make ONCCertificateImporter async. · 3b4ba221
      pneubeck authored
      This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
      Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
      Now, the import itself is asychronous and calls back on completion.
      
      While there, this also removes the GMock of the importer.
      
      This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925
        refs/heads/master@{#295534}
      with the fixed destruction order in ONCCertificateImporterImplTest.
      
      The fix was reviewed in
        https://codereview.chromium.org/589443002/
      
      TBR=eroman@chromium.org
      BUG=413219
      
      Review URL: https://codereview.chromium.org/582413002
      
      Cr-Commit-Position: refs/heads/master@{#295687}
      3b4ba221
    • Sylvain Defresne's avatar
      Move PageTransition from //content/public/common to //ui/base · c6ccc77d
      Sylvain Defresne authored
      Move PageTransition enumeration from //content/public/common to //ui/base
      so that it can be used by iOS and layered components that are used on iOS.
      
      BUG=372373
      R=avi@chromium.org, ben@chromium.org, wfh@chromium.org
      TBR=ben, nasko
      
      Review URL: https://codereview.chromium.org/562603002
      
      Cr-Commit-Position: refs/heads/master@{#295686}
      c6ccc77d
    • Benjamin Lerman's avatar
      mojo: fix python unittests. · 80ced42d
      Benjamin Lerman authored
      TBR=sdefresne@chromium.org
      
      Review URL: https://codereview.chromium.org/586683002
      
      Cr-Commit-Position: refs/heads/master@{#295685}
      80ced42d
    • qsr's avatar
      mojo: Add deserialization to python structs. · 37dd5f48
      qsr authored
      This is a reland of https://codereview.chromium.org/578263003 using
      buffer instead of memoryview, because on some early version of python
      2.7, memoryview cannot be used with struct.unpack_from.
      
      BUG=415491
      R=sdefresne@chromium.org,cmasone@chromium.org
      
      Review URL: https://codereview.chromium.org/588493002
      
      Cr-Commit-Position: refs/heads/master@{#295684}
      37dd5f48
    • eugenis's avatar
      Revert of Make ONCCertificateImporter async. (patchset #5 id:190001 of... · 70753227
      eugenis authored
      Revert of Make ONCCertificateImporter async. (patchset #5 id:190001 of https://codereview.chromium.org/547553005/)
      
      Reason for revert:
      Use-after-free.
      https://code.google.com/p/chromium/issues/detail?id=415916
      
      Original issue's description:
      > Make ONCCertificateImporter async.
      >
      > This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
      >
      > Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
      >
      > Now, the import itself is asychronous and calls back on completion.
      >
      > While there, this also removes the GMock of the importer.
      >
      > BUG=413219
      >
      > Committed: https://crrev.com/bc656c0e7b7bd67fb28e5a880d21b9510ebd3e3a
      > Cr-Commit-Position: refs/heads/master@{#295534}
      
      TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=413219
      
      Review URL: https://codereview.chromium.org/580283005
      
      Cr-Commit-Position: refs/heads/master@{#295683}
      70753227
    • perkj's avatar
      Roll WebRtc/Libjingle to r7234. · 4a201500
      perkj authored
      TBR=kjellander@chromium.org
      
      Review URL: https://codereview.chromium.org/578383005
      
      Cr-Commit-Position: refs/heads/master@{#295682}
      4a201500
    • engedy's avatar
      Fix is_chrome_branded check in chrome_repack_locales.gni. · 8afbc8c6
      engedy authored
      It was using chromium resources when it should have used chrome resources, and vice versa.
      
      BUG=None
      
      Review URL: https://codereview.chromium.org/575923004
      
      Cr-Commit-Position: refs/heads/master@{#295681}
      8afbc8c6
    • ernstm's avatar
      Fix and re-enable v8 idle notification after commit. · 5e0a3fde
      ernstm authored
      For idle times < 1000us, we sent notifications with 0ms. This patch
      adds a check for idle_time_in_ms to be non-zero and re-enables the
      feature by default.
      
      R=jochen@chromium.org
      BUG=414815
      
      Review URL: https://codereview.chromium.org/583833002
      
      Cr-Commit-Position: refs/heads/master@{#295680}
      5e0a3fde
    • plundblad's avatar
      Upgrade liblouis to 2.6.0. · 88aa7765
      plundblad authored
      This changes to the new mirror of the third_party library liblouis,
      necessary because the project moved to github from an svn repository on
      code.google.com.  Since the git mirroring infrastructure doesn't support
      excluding parts of the tree, this means adding some GPL files and some files
      without license headers.  The whitelist in tools/checklicenses/checklicenses.py
      has been extended as needed.
      
      One braille table (Hindi computer braille) is not available in liblouis
      and has been removed.  A follow-up CL will add support for new braille
      tables added in this release.
      
      BUG=341951
      R=dtseng@chromium.org, phajdan.jr@chromium.org
      
      Review URL: https://codereview.chromium.org/579623003
      
      Cr-Commit-Position: refs/heads/master@{#295679}
      88aa7765
    • vasilii's avatar
      Revert of [telemetry] Read MSRs from a separate privileged process. (patchset... · 773f55fe
      vasilii authored
      Revert of [telemetry] Read MSRs from a separate privileged process. (patchset #3 id:40001 of https://codereview.chromium.org/578123002/)
      
      Reason for revert:
      Fails telemetry_unittests and telemetry_perf_unittests on XP Tests (2) http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/35314
      
      Traceback (most recent call last):
        run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
          testMethod()
        testPowerMonitoringSync at tools\telemetry\telemetry\core\platform\platform_backend_unittest.py:16
          if not platform.CanMonitorPower():
        CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248
          return self._platform_backend.CanMonitorPower()
        CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313
          return self._power_monitor.CanMonitorPower()
        CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
          if self._PackageEnergyJoules() <= 0:
        _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
          return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
        ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
          self._StartMsrServerIfNeeded()
        _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
          sys.executable, parameters, elevate_privilege=True)
        LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
          if elevate_privilege and not IsCurrentProcessElevated():
        IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
          win32security.GetTokenInformation(token, win32security.TokenElevation))
      error: (87, 'GetTokenInformation', 'The parameter is incorrect.')
      
      Locals:
        handle : -1
        token  : <PyHANDLE:0>
      
      [  FAILED  ] platform.platform_backend_unittest.PlatformBackendTest.testPowerMonitoringSync (3422 ms)
      
      Traceback (most recent call last):
        run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
          testMethod()
        wrapper at tools\telemetry\telemetry\decorators.py:84
          func(*args, **kwargs)
        testMsrRuns at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor_unittest.py:19
          if not power_monitor.CanMonitorPower():
        CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
          if self._PackageEnergyJoules() <= 0:
        _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
          return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
        ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
          self._StartMsrServerIfNeeded()
        _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
          sys.executable, parameters, elevate_privilege=True)
        LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
          if elevate_privilege and not IsCurrentProcessElevated():
        IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
          win32security.GetTokenInformation(token, win32security.TokenElevation))
      error: (87, 'GetTokenInformation', 'The parameter is incorrect.')
      
      Locals:
        handle : -1
        token  : <PyHANDLE:0>
      
      [  FAILED  ] platform.power_monitor.msr_power_monitor_unittest.MsrPowerMonitorTest.testMsrRuns (32 ms)
      [----------] 1 test (32 ms total)
      
      Traceback (most recent call last):
        run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
          testMethod()
        wrapper at tools\telemetry\telemetry\decorators.py:55
          func(*args, **kwargs)
        BenchmarkSmokeTest at tools\perf\benchmarks\benchmark_unittest.py:59
          self.assertEqual(0, SinglePageBenchmark().Run(options),
        Run at tools\telemetry\telemetry\benchmark.py:95
          page_runner.Run(pt, ps, expectations, finder_options, results)
        Run at tools\telemetry\telemetry\page\page_runner.py:429
          page, credentials_path, possible_browser, results, state)
        _PrepareAndRunPage at tools\telemetry\telemetry\page\page_runner.py:259
          finder_options)
        StartBrowserIfNeeded at tools\telemetry\telemetry\page\page_runner.py:54
          test.WillStartBrowser(possible_browser.platform)
        WillStartBrowser at tools\perf\measurements\webrtc.py:21
          self._power_metric = power.PowerMetric(platform)
        __init__ at tools\perf\metrics\power.py:31
          self._MeasureQuiescentPower(quiescent_measurement_time_s)
        _MeasureQuiescentPower at tools\perf\metrics\power.py:54
          if not self._platform.CanMonitorPower() or \
        CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248
          return self._platform_backend.CanMonitorPower()
        CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313
          return self._power_monitor.CanMonitorPower()
        CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
          if self._PackageEnergyJoules() <= 0:
        _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
          return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
        ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
          self._StartMsrServerIfNeeded()
        _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
          sys.executable, parameters, elevate_privilege=True)
        LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
          if elevate_privilege and not IsCurrentProcessElevated():
        IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
          win32security.GetTokenInformation(token, win32security.TokenElevation))
      error: (87, 'GetTokenInformation', 'The parameter is incorrect.')
      
      Locals:
        handle : -1
        token  : <PyHANDLE:0>
      
      [  FAILED  ] BenchmarkSmokeTest.webrtc.webrtc_cases (766 ms)
      
      Original issue's description:
      > [telemetry] Read MSRs from a separate privileged process.
      >
      > This allows us to read MSRs on Windows Vista+.
      > Also move ReadMsr into PlatformBackend.
      >
      > BUG=336558
      > TEST=tools/telemetry/run_tests msr
      >
      > Committed: https://crrev.com/2156b0323c83d6f11e68344ecf7e7e0c833cfa14
      > Cr-Commit-Position: refs/heads/master@{#295634}
      
      TBR=tonyg@chromium.org,thestig@chromium.org,dtu@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=336558
      
      Review URL: https://codereview.chromium.org/582123003
      
      Cr-Commit-Position: refs/heads/master@{#295678}
      773f55fe
    • vasilii's avatar
      Revert of Remove void** from disk_cache interface. (patchset #30 id:650001 of... · a3b75585
      vasilii authored
      Revert of Remove void** from disk_cache interface. (patchset #30 id:650001 of https://codereview.chromium.org/542733002/)
      
      Reason for revert:
      Introduced memory leaks on linux asan
      http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892:
      Direct leak of 80 byte(s) in 2 object(s) allocated from:
      #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
      #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5
      #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
      #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
      #4 0x2e3b0bf in Run base/callback.h:401:12
      #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
      #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
      #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
      #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
      #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
      #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
      #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
      #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
      #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
      #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308
      
      Indirect leak of 64 byte(s) in 2 object(s) allocated from:
      #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
      #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5
      #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
      #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
      #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
      #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
      #6 0x2e3b0bf in Run base/callback.h:401:12
      #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
      #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
      #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
      #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
      #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
      #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
      #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
      #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
      #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
      #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308
      
      Indirect leak of 36 byte(s) in 1 object(s) allocated from:
      #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
      #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5
      #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121
      #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8
      #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8
      #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
      #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
      #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
      #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
      #9 0x2e3b0bf in Run base/callback.h:401:12
      #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
      #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
      #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
      #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
      #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
      #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
      #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
      #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
      #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
      #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308
      
      Original issue's description:
      > Remove void** from disk_cache interface.
      >
      > Enumeration and iteration were passing around void**. With this CL, we
      > instead use an Iterator object.
      >
      > R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org
      > BUG=413644
      >
      > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342
      > Cr-Commit-Position: refs/heads/master@{#295659}
      
      TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,pasko@chromium.org,piman@chromium.org,michaeln@chromium.org,cbentzel@chromium.org,gavinp@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=413644
      
      Review URL: https://codereview.chromium.org/585833002
      
      Cr-Commit-Position: refs/heads/master@{#295677}
      a3b75585