- 05 Sep, 2018 40 commits
-
-
Clemens Hammacher authored
After the flag flip in v8 (https://crrev.com/c/1118485), this CL also changes the default of the chromium flag to enabled. Chromium always passes either "--no-wasm-tier-up" or "--wasm-tier-up" to d8, so the flag flip in v8 did not have any effect on chromium. R=titzer@chromium.org, hablich@chromium.org Bug: chromium:880790, chromium:787421 Change-Id: I3d6b66a90ca41cb093b9bfd174ca3bfc3c35263a Reviewed-on: https://chromium-review.googlesource.com/1206351Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589066}
-
Miguel Casas authored
This reverts commit e865a56b. Reason for revert: Causing gn analyze problems e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-dbg/331 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/2125 /b/swarming/w/ir/cache/builder/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //components/viz/service/main/viz_main_impl.cc:22:11: Can't include this header from here. #include "media/gpu/buildflags.h" ^--------------------- The target: //components/viz/service/main:main is including a file from the target: //media/gpu:buildflags It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //components/viz/service/main:main --> //components/viz/service:service --[private]--> //media/gpu/ipc/service:service --[private]--> //media/gpu:buildflags Original change's description: > Do not use components/arc/common in non CrOs builds > > I found that (at least win) bots are using components/arc/common > stuff (see e.g. [1]), when this are supposed to be limited to > CrOs. This CL corrects that by sandwiching the appropriate > BUILD entries between if(is_chromeos). > > [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout > /BUILD.gn mojom(media) > > Bug: 732531 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d > Reviewed-on: https://chromium-review.googlesource.com/1208410 > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589056} TBR=lhchavez@chromium.org,mcasas@chromium.org,rsesek@chromium.org,kylechar@chromium.org Change-Id: I2638bbedd77268b26ca0c3ca4fc94606d196b545 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208678Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589065}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29a4a684af25..0c3dc59fc1c6 git log 29a4a684af25..0c3dc59fc1c6 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader fe5861bf5bb1..ad5c2952ca88 (5 commits) 2018-09-05 mtklein@google.com fix sw extended transfer functions 2018-09-05 mtklein@google.com fix typo 2018-09-05 mtklein@google.com add src/opts headers to .gni files 2018-09-05 bsalomon@google.com Don't use MEM_MOVE=true with SkTArrays of sk_sp 2018-09-05 jvanverth@google.com Rip out variable offsetting 2018-09-05 bsalomon@google.com Fix GrAAConvexTessellator to handle cases slightly concave bistectors. 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-05 herb@google.com Centralize the predicate for a glyph being too large for the atlas 2018-09-05 bsalomon@google.com Fix missing triangle when miter point omitted in GrAAConvexTessellator. 2018-09-05 brianosman@google.com Remove SK_USE_LEGACY_PRIMARIES_TO_XYZ 2018-09-05 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 8a251fa55434..da4870efd7b7 (1 commits) 2018-09-05 caryclark@google.com Revert "makeSurface defaults to raster" 2018-09-05 egdaniel@google.com On GrAHardwareBufferImageGenerator store the owned texture as a GrGpuResource instead of GrTexture. Created with: gclient setdep -r src/third_party/skia@0c3dc59fc1c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:875650,chromium:851637,chromium:b/112859199 TBR=jvanverth@chromium.org Change-Id: I21e2f158cebeb62dbc38dfafaf9daea314093269 Reviewed-on: https://chromium-review.googlesource.com/1208297Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589064}
-
Christian Biesinger authored
Addref takes 3.27% in one profile (floats_2_100.html); reduce some of that. R=eae@chromium.org, ikilpatrick@chromium.org Change-Id: Ie88ebd6907afc64e8a138d4279549ba1bd0b80c8 Reviewed-on: https://chromium-review.googlesource.com/1208930 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589063}
-
Sky Malice authored
There's a difference between downloading a page and prefetching a page. While ContentMetadata is passed for Prefetch, this action results in a download. Offline Pages component does not support and does not want to support holding/using this metadata for downloads. Bug: 879824 Change-Id: I3fd21936355aa94f74066ceac20fe3df2ac4c587 Reviewed-on: https://chromium-review.googlesource.com/1208910Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#589062}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79ec21c5d4cf..7359954301e1 git log 79ec21c5d4cf..7359954301e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 jmadill@chromium.org Update update_canary_angle script. 2018-09-05 jmadill@chromium.org Update jsoncpp DEPS. Created with: gclient setdep -r src/third_party/angle@7359954301e1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:None TBR=fjhenigman@chromium.org Change-Id: I855c73346d68391bc8911ee429af037f2ef0ada2 Reviewed-on: https://chromium-review.googlesource.com/1208295Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589061}
-
Jared Saul authored
This change adds |chrome_user_context| and |full_sync_enabled| values to Unmask, GetDetails, Upload, and MigrateCards requests, as long as either of the appropriate flags are enabled. Bug: 840703 Change-Id: Ieb3baf980b68add43a3111c0902a03b574b1adcf Reviewed-on: https://chromium-review.googlesource.com/1208434 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589060}
-
Raymond Toy authored
Catch more cases where we should throw errors if a new setValueCurveAtTime overlaps an existing setValueCurveAtTime event. Add some additional tests for more coverage. Also, some of the existing tests were using incorrect expected error types so fix them. Remove test expectations file since we pass now. Bug: 879767 Test: the-audioparam-interface/audioparam-setValueCurve-exceptions.html Change-Id: I14a7a7c9ab36955b7e084ca9148495860b661111 Reviewed-on: https://chromium-review.googlesource.com/1205719 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589059}
-
Kevin Marshall authored
This change reduces load on system resources by terminating the webrunner and its instance of the Context (aka browser process) when the last Component channel is disconnected. Change-Id: If667cfa7680e02519105d8303bd734235f6180f9 Reviewed-on: https://chromium-review.googlesource.com/1208715 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589058}
-
Takumi Fujimoto authored
Call on the CastDialogController in CastDialogView::SinkPressed() only if the pointer to it is not null. Also hide the dialog when the controller gets invalidated. Bug: 876900 Change-Id: I248385f086e3d3bde68ea2603afa77fca76e7d9c Reviewed-on: https://chromium-review.googlesource.com/1200523 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589057}
-
Miguel Casas authored
I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d Reviewed-on: https://chromium-review.googlesource.com/1208410Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589056}
-
Shakti Sahu authored
This CL attempts to add the following : 1 - Removes dependency on SelectableListLayout. 2 - Moves toolbar creation, menu action, search and toolbar shadow logic out of DownloadManagerCoordinatorImpl to a ToolbarCoordinator which wraps around the toolbar. 3 - ToolbarCoordinator delegates the user actions to various delegates. 4 - Also fixes a bug in search menu icon visibility update which wasn't happening due to listening to incorrect observer methods on RecyclerView.Adapter Bug: 850601 Change-Id: Id1ba4bc435040c3d01644d4ccff34a7f2dd73e97 Reviewed-on: https://chromium-review.googlesource.com/1173481 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589055}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cc5f350ab9c8..ad370480282d git log cc5f350ab9c8..ad370480282d --date=short --no-merges --format='%ad %ae %s' 2018-09-05 npm@chromium.org Roll third_party/freetype/src/ 2c8e6279a..f8af8fba7 (34 commits) Created with: gclient setdep -r src/third_party/pdfium@ad370480282d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie222bef540fab684e76c2c194a1795a476cf7338 Reviewed-on: https://chromium-review.googlesource.com/1208312Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589054}
-
Patrick Noland authored
Bug: 799162 Change-Id: I30e500be19d7da676436d99cfc4fd331d23a9635 Reviewed-on: https://chromium-review.googlesource.com/1208720Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#589053}
-
spqchan authored
Bug: 873219 Change-Id: I34a7c5024e84d6c2f65f1b6df122dde4ca3798f9 Reviewed-on: https://chromium-review.googlesource.com/1208359Reviewed-by:
-
Miguel Casas authored
The original CL crrev.com/c/1199580 was reverted in crrev.com/c/1204599 because it broke windows compilation (File path literals etc). This CL limits the compilation to linux and chromeos: the new changes can be seen in crrev.com/c/1206675e/1..2 TBR=jbudorick@chromium.org, sandersd@chromium.org since the changes are trivial re. the previous CL. Original CL description ----------------------------------------------- jpeg_decode_accelerator_unittest is compiled and run on the CrOs autotest infra, but is not compiled on the bots, when it possibly should. This CL adds that target to the chromiumos_preflight of the top level BUILD.gn. Bug: 732531, 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1199580Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588635} Change-Id: Ic71fc5076484d30dda90654cd5501aa802258feb Reviewed-on: https://chromium-review.googlesource.com/1206675Reviewed-by:
-
Tarun Bansal authored
Fix the flakiness by checking if all the subresources have been actually fetched. This check is not really necessary since the test additionally checks (via UMA) if the resource loading hints were actually received by the renderer. The tests still check if the resources that were vlocked via hints are indeed blocked from loading. Change-Id: I931570b73068250636916b0c234d17648976c84c Bug: 866212 Reviewed-on: https://chromium-review.googlesource.com/1203321Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589050}
-
dpapad authored
The semantics of document.activeElement and someElement.shadowRoot.activeElement seem to have changed between Shadow DOM v0 and v1. In V1 the following is possible: someElement.shadowRoot.activeElement is null AND document.activeElement points to a child belonging to |someElement|. which does not seem to be the case for Shadow DOM v0. Always recursing from document.activeElement seems more robust and works for both cases. Bug: 875470 Change-Id: I53044c23bcfcfa85264b5154e635e44c05ce0f6f Reviewed-on: https://chromium-review.googlesource.com/1208454Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#589049}
-
Miguel Casas authored
This CL : - Adds some LOG() info of the average time taken for image decoding for sw & hw, (see e.g https://pastebin.com/raw/RKiGqjBS) - Removes unnecessary {} Bug: 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id2147989456a0cb3cb2a64c3e89c355c0e736fa5 Reviewed-on: https://chromium-review.googlesource.com/1198524 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
khmel@google.com authored
As described TEST=None BUG=None Change-Id: I655413d632243de7a693fa0bdcaa4d53733aecc0 Reviewed-on: https://chromium-review.googlesource.com/1205474Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#589047}
-
Becca Hughes authored
Add a feature to disable AudioContext playbacks counting towards the MEI score. BUG=878460 Change-Id: I486f3853ebc26a703e52712bee13600c99c7be14 Reviewed-on: https://chromium-review.googlesource.com/1204728Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589046}
-
Raymond Toy authored
The WebAudio spec says we must throw errors for a negative rolloffFactor and for a coneOuterGain outside the interval [0, 1]. Make it so. Also add some additional tests to ctor-panner.html to verify that a rolloffFactor of 0 or 100 do not throw errors and that a coneOuterGain of 0 or 1 do not throw errors. Remove invalid tests from panner-rolloff-clamping.html because negative rolloffFactor now throws an error. Finally remove text expectation for ctor-panner.html test, which passes now. Bug: 879845 Test: the-pannernode-interface/ctor-panner.html, the-pannernode-interface/panner-rolloff-clamping.html Change-Id: Ie90e9fe13e82fd3cc955060dc9e77266ef4ff591 Reviewed-on: https://chromium-review.googlesource.com/1205099 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#589045}
-
Victor Costan authored
This CL only handles the files in misc directories. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs tackle other directories with significant diffs. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) => auto x = base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester Change-Id: I79c682e76b3cdcee8cc2093801664f97908861b5 Reviewed-on: https://chromium-review.googlesource.com/1189548 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589044}
-
Robbie McElrath authored
There was a call to net::NetworkChangeNotifier::GetConnectionType() that I missed in the intial NetworkChangeNotifier -> NetworkConnectionTracker conversion. This migrates that over. This also makes some changes to ScopedTaskEnvironment and TestBrowserThreadBundle in order to get ScopedTaskEnvironment::MainThreadType::MOCK_TIME working with TestBrowserThreadBundle. Bug: 868001 Change-Id: Ie7d87bdd854ff278a258b26f416c9643b3d4dbcd Reviewed-on: https://chromium-review.googlesource.com/1185887 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#589043}
-
Wenzhao Zang authored
We should try to install the Highlights app from the update url in the two cases: 1) Offline enrollment, but offline resources are not available for any reason (should be a bug if it ever happens). 2) Online enrollment (will do in a follow-up CL). In addition, enable app caching so that Highlights app can be launched in cases when device is offline (but was once enrolled online). Besides, the correct version of Highlights app can be determined dynamically, so only one copy will be downloaded/cached to save bandwidth and disk space. Bug: 819404 Change-Id: Ia3b6d8d5222411474b106e1871bfbac6f0c755e5 Reviewed-on: https://chromium-review.googlesource.com/1194337Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#589042}
-
Erik Luo authored
When debugger is paused, holding Ctrl/Cmd highlights Continue-to-location markers, and DevTools prevents scrolling from adjusting zoom. This CL checks whether we are paused somewhere, and allows zooming via Ctrl-Wheel when not paused. Bug: 878400 Change-Id: Ibe664f5241914b89fff9c5d7ae90658f2d803918 Reviewed-on: https://chromium-review.googlesource.com/1205537Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#589041}
-
Wenzhao Zang authored
Verified sending reports with/without bluetooth keywords and the correct tags are added. Bug: 880978, 872403 Change-Id: If139bc6d5c894596fd97de7d234aae63bd88e4dd Reviewed-on: https://chromium-review.googlesource.com/1208467 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589040}
-
Josh Pratt authored
This adds a second stage to OnStartTerminaVm in the form of a callback, fired when Tremplin starts. Bug: 879953 Change-Id: I9dee6f9750f03fb50c12b7473763abc966d0a7a7 Reviewed-on: https://chromium-review.googlesource.com/1203510Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#589039}
-
Alexander Alekseev authored
This adds full OOBE/first run end-to-end test. Bug: 880804 Change-Id: Ib1ebe8a9f1412060236f7936de9e385a181a9a3b Reviewed-on: https://chromium-review.googlesource.com/1206692Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#589038}
-
Sky Malice authored
Feed articles that have been prefetched may be displayed on other surfaces. When this happens, it should feed back into feed update scheduling and cause more articles to be fetched. This change wires up notifications coming from Prefetch, through host logic, and ultimately to the UserClassifier. Bug: 874970 Change-Id: I4813564ff8ed0c7d315c2449a823e933a6067e8d Reviewed-on: https://chromium-review.googlesource.com/1192696 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589037}
-
David Tseng authored
Bug: 880928 Change-Id: I373480d1431ba07e2f60332d429052d364f04ce2 Reviewed-on: https://chromium-review.googlesource.com/1207098Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589036}
-
Dominic Mazzoni authored
The enum defined in the file is AXMode, so it's more logical this way. Uploading this required making a quick fix to a PRESUBMIT.py script too. BUG: none TBR=nasko@chromium.org Change-Id: Ic6ef5574645761767e9277e3d34568725deb383a Reviewed-on: https://chromium-review.googlesource.com/1207353Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589035}
-
Evangelos Foutras authored
Similarly to pulse_stubs.cc, va_stubs.cc contains dlsym() resolved functions which trigger cfi-icall failures. The affected builds of Chromium do use out-of-tree patches to enable hardware-accelerated video decode on Linux where the VA-API driver is installed, but it would still be nice to have them work with cfi-icall enabled. Change-Id: Iefa27f4b95007da23423d17727826adb8825b278 Reviewed-on: https://chromium-review.googlesource.com/1208830Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589034}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7467d2cf1be1c9113e5d371ada28614d9d57bc20 Reviewed-on: https://chromium-review.googlesource.com/1208414 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589033}
-
Robert Sesek authored
In 6e6fab4f, these tests were disabled on all of OS_MACOSX even though they were only failing on 10.11. Try to reenable them on other macOS versions. Bug: 868667, 880496 Change-Id: Icf41045f3fbe032ef06d995e02a0ad1b9f977c24 Reviewed-on: https://chromium-review.googlesource.com/1207611Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/638bda3a17c0..bcc3e491fb2e git log 638bda3a17c0..bcc3e491fb2e --date=short --no-merges --format='%ad %ae %s' 2018-09-05 benjhayden@chromium.org Optimize change_internal_only 2018-09-05 anthonyalridge@google.com Add back assignment to all labels. Created with: gclient setdep -r src/third_party/catapult@bcc3e491fb2e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868512,chromium:866423 TBR=sullivan@chromium.org Change-Id: I6d171eaf79fe7b80da39bd0a86bf5cdbb1343b0c Reviewed-on: https://chromium-review.googlesource.com/1208290Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589031}
-
Emil A Eklund authored
Update ShapeResultBloberizer to remove use of templates and instead call ToStringView on TextRuns to allow the same implementation to be used for both legacy layout and LayoutNG. A StringView has extremely low overhead both in terms of creation and memory usage, should have no perf impact. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iaebcb3a5893d619950d1e7cc8c77fcef2015fffe Reviewed-on: https://chromium-review.googlesource.com/1207095Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589030}
-
Lukasz Anforowicz authored
The overflow bucket for Navigation.ReadyToCommitUntilCommit accounted for around half a percent of all data - this seems like too much. Additionally, some Navigation.* metrics (like Navigation.StartToCommit) used a 3 minutes cut-off, while others (like Navigation.ReadyToCommitUntilCommit and Navigation.TimeToReadyToCommit) used a 10s cut-off - this seems needlessly inconsistent (given that both TimeToReadyToCommit and StartToCommit will likely spend most of their time in network-related activities - e.g. waiting for responses from remote hosts). Because of the above, this CL consistently sets the overflow bucket for Navigation histograms to 180s (which is based on UMA_HISTOGRAM_MEDIUM_TIMES). Note that this CL retains Navigation-specific underflow bucket which is set at 1ms (like UMA_HISTOGRAM_TIMES or UMA_HISTOGRAM_LONG_TIMES and unlike UMA_HISTOGRAM_MEDIUM_TIMES). Bug: 848821 Change-Id: I4765d8c7dd6da076fb01e209cd02c524b5da9dbf Reviewed-on: https://chromium-review.googlesource.com/1188977 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589029}
-
Weidong Guo authored
Background: When assistant is opened, the mask layer of folder icon somehow disappears to reveal the unclipped folder icon. The root cause is unknown. Changes: Remove the mask layer completely and use skia lib to draw clipped folder icon instead. This not only fixed the issue, but also improved the animation efficiency (mask layer is expensive). Bug: 879372 Change-Id: I240ef1bece839ff80957654de2c19d11fe97abf9 Reviewed-on: https://chromium-review.googlesource.com/1208468Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589028}
-
Boris Sazonov authored
This CL fixes a rare issue in SelectableListLayout: if the data in the adapter isn't changed after a call to initializeRecyclerView, then RecyclerView visibility stays GONE even though there are items to display. It happens because initially the visibility of RecyclerView is GONE and it is only changed from AdapterDataObserver.onChanged. This CL fixes the issue in bookmarks by calling notifyDataSetChanged after bookmark model is loaded. Bug: 789531 Change-Id: Ic424e636a87eed7fc6bbf50a49fdf875a18e5410 Reviewed-on: https://chromium-review.googlesource.com/1206009Reviewed-by:
-
