GitLab

To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
OOPR.

Bug: 895568
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286950
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609033}

Bug: none
Change-Id: I3c5f6e3aeea9bfb6b9c00be89b807c2a603cddac
Reviewed-on: https://chromium-review.googlesource.com/c/1340869
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609032}

This change makes a reprioritized SOCKSConnectJob pass down the priority
change to its underlying transport socket handle.

Bug: 166689
Change-Id: I5fdb0d9ea4e14b6ba6ec73925c9b2158791fa57d
Reviewed-on: https://chromium-review.googlesource.com/c/1329347Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609031}

This moves fields relating to:
 - Floats clearance
 - Fragmentation
 - Margin struts
 - Weird percentages

... to a rare data member. This decreases partition alloc usage on
system_health.memory_desktop by approximately 6-7%, at the cost of
0-6% on most benchmarks.

Change-Id: Ifaeaf5d874efcd13ce9eff785d8093d24637de86
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/c/1323803
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609030}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b33404f0931..a64e6d552792


git log 8b33404f0931..a64e6d552792 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 dgarrett@chromium.org Revert "workspace_stages: Create dual sync stage."


Created with:
  gclient setdep -r src/third_party/chromite@a64e6d552792

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib91ca4a8c9cf61de5615bfd5c94222cc50d63676
Reviewed-on: https://chromium-review.googlesource.com/c/1340397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609029}

This reverts commit 29a3a80a.

Reason for revert:
We still need to package asan for i686-android: https://crbug.com/906246

Original change's description:
> Roll clang 346388-1:346388-3
> 
> This picks up package.py changes #607265 and #608413. It does not change
> the version of clang.
> 
> It also includes a crazy workaround for msys binaries (in our case
> find.exe and mv.exe, used by lit tests) crashing during some unknown
> chrome infra problem (see last bug).
> 
> Bug: 870331, 905289
> Change-Id: Ic1d9fa64d6fcd4b590139c9343bed5bbe4d3faa3
> Reviewed-on: https://chromium-review.googlesource.com/c/1337614
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608776}

TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,mmoroz@chromium.org

Change-Id: I225d64bd4e166c0150d63cfa7ab0bad7e0dd92f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870331, 905289, 906246
Reviewed-on: https://chromium-review.googlesource.com/c/1340836Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609028}

Handle the case where the menu is not dismissed due to a drag sequence.
This was not handled gracefully, and resulted in a bad drag state on the
app icon.

finger. Then touch the screen somewhere else.

Example: Show a menu on an app icon via long press, don't release the
Bug: 876440
Change-Id: I8ebde0669aec7b7925fb1c855008cbfbaa8b3683
Reviewed-on: https://chromium-review.googlesource.com/c/1340822Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609027}

https://pdfium.googlesource.com/pdfium.git/+log/75d214c50d2f..a8b6376430de


git log 75d214c50d2f..a8b6376430de --date=short --no-merges --format='%ad %ae %s'
2018-11-16 thestig@chromium.org Use another enum class in CBC_PDF417HighLevelEncoder.
2018-11-16 thestig@chromium.org Use enum class in CBC_PDF417HighLevelEncoder.
2018-11-16 thestig@chromium.org More CBC_PDF417HighLevelEncoder cleanup.
2018-11-16 thestig@chromium.org Simplify fx_opj_stream_create_memory_stream().
2018-11-16 npm@chromium.org Improve JPX fuzzer
2018-11-16 thestig@chromium.org Slightly simplify CPDF_FontEncoding::Realize().


Created with:
  gclient setdep -r src/third_party/pdfium@a8b6376430de

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:903724
TBR=dsinclair@chromium.org

Change-Id: Ic5098a9f104a0caaabf4ebe41d55a048223dda2c
Reviewed-on: https://chromium-review.googlesource.com/c/1340398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609026}

Hopefully should have enough bots:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/linux-chromeos-compile-dbg

R=jbudorick, dpranke

Bug: 902468
Change-Id: I9273d96ede4c056d8bd4b936f5f843176bac087a
Reviewed-on: https://chromium-review.googlesource.com/c/1340536Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609025}

When the P2PQuicTransport's packet writer gets an error from the
underlying P2PTransportChannel, it will signal write blocked to the
QUIC library. In order to resume sending, the P2PTransportChannel
should indicate when it can start sending again.

This CL fixes two problems:
1) Changes the writable signal from SignalWriteState to
   SignalReadyToSend. SignalReadyToSend is signaled by the
   underlying IPC socket when a Send would no longer cause an
   EAGAIN.
2) Changes the IPC socket to fire SignalReadyToSend only at the
   very end of the IPC handler so that the listener can back in to
   the P2PPacketSocket safely.

Bug: 874296
Change-Id: I8276f60165928f77ca62243f3e5865897aa2cf6f
Reviewed-on: https://chromium-review.googlesource.com/c/1330299
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609024}

This reverts commit d8854b56.

Reason for revert: The original use-after-free is caused by storing part
of a temporary object into a reference:

const Position& sentence_end =
      EndOfSentence(range.EndPosition()).GetPosition();

This is fixed after changing the reference into a real instance.

Original change's description:
> Revert "Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition"
>
> This reverts commit 390c941f.
>
> Reason for revert: causing layout test failure crbug.com/906174
>
> Original change's description:
> > Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition
> >
> > This patch stops the two functions from using VisiblePosition by switch
> > to the VP-free versions of Start/EndOfSentence(). Hence, this patch
> > reduces the usage of legacy VisiblePosition.
> >
> > Bug: 657237
> > Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337816
> > Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#608849}
>
> TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org
>
> Bug: 657237, 906174
> Change-Id: I915e9d68f16a11344b0160db4c5702113380273a
> Reviewed-on: https://chromium-review.googlesource.com/c/1340899
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608963}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,eirage@chromium.org

Change-Id: Ib4832ab51086777c926f4188936f31391a87f019
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 657237, 906174
Reviewed-on: https://chromium-review.googlesource.com/c/1340833
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609023}

We can just get them from the line. This also moves overriding the line's
cross axis extent to a more logical place (and adds it to the NG implementation).

Change-Id: I04da17674645fa55ff1903a15bdd4781ad26ef6e
Reviewed-on: https://chromium-review.googlesource.com/c/1338478Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609022}

This is no longer necessary after https://crrev.com/c/1283482

R=dgrogan@chromium.org, ikilpatrick@chromium.org

Change-Id: I4e0b4d631481f38157072d3f331c11eb05c1f5e7
Reviewed-on: https://chromium-review.googlesource.com/c/1340958Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609021}

https://chromium.googlesource.com/angle/angle.git/+log/e4634a13a74d..778bf09deea4


git log e4634a13a74d..778bf09deea4 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 jmadill@chromium.org Auto-generate validation headers.
2018-11-16 syoussefi@chromium.org Vulkan: Emulate Luminance/Alpha with R8G8B8A8


Created with:
  gclient setdep -r src/third_party/angle@778bf09deea4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I7e8a4bf7dd083edeaf6e380ff7c9a8d5e05660f5
Reviewed-on: https://chromium-review.googlesource.com/c/1340578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609020}

Using wpt-import in Chromium b55d1dd9.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I8dd402a80346c2d8bae4be57de0af68156343210
Reviewed-on: https://chromium-review.googlesource.com/c/1340874
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609019}

This reverts commit 4391edc0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 608932 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDM5MWVkYzA4MjAzZDY2Zjg3OTUwYTA4MGNiZmJmY2IyZjJiOWQyMgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26490

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: virtual/threaded/animations/composited-filter-animation.html

Original change's description:
> [BlinkGenPropertyTrees] Associate each cc::KeyframeModel with ElementId
> 
> In BGPT, each KeyframeModel on a given Animation may need to animate a different
> ElementId, as the various effects of an element are split into multiple
> different nodes in some of the same node trees. This change sets the ElementId
> on the keyframe model and uses that when applying mutations.
> 
> Since animations currently expect to look for the existence of a single element,
> this patch also modifies PaintPropertyBuilder to construct each node type that
> may be needed for an animation when any property is being animated on an element
> and then uses the kPrimaryEffect id to check whether this has happened.
> 
> This also makes several changes to plumb the proper list of element ids:
> - Register all ancestor ElementIds in PaintArtifactCompositor::Update.
> - Synchronize registered ids during commit.
> - Synchronize registered ids during activation.
> 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Bug: 896549
> Change-Id: I717822a1ca174658ef792005e76613a5033f4f6a
> Reviewed-on: https://chromium-review.googlesource.com/c/1297305
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608932}

Change-Id: Idaed0e8efd9ea459af64a2201bb53ba2d58d2a28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896549, 906268
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1341060
Cr-Commit-Position: refs/heads/master@{#609018}

Build on existing naive PosInSet and SetSize implementation to handle
cases such as inconsistent or invalid assignments of kPosInSet and
kSetSize attributes

Change-Id: I966f3ad00e778e0d68bcb48d160f1be5818b587b
Reviewed-on: https://chromium-review.googlesource.com/c/1340523
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609017}

Bug: 904986, 906151
Change-Id: I5aef21b730446234742c2420435aeba8fb81f76e
Reviewed-on: https://chromium-review.googlesource.com/c/1334274
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609016}

Under several circumstances, the network transaction or the
HttpAuthController may invalidate an authentication handler with the
intention of retrying the same transaction. During this process, any
sources of identity that were consumed should be made available for
reuse. Otherwise the behavior of the retry operation could end up being
wildly different from the original transaction.

This is particularly pronounced when dealing with HttpAuthHandler
implementations that support both ambient and explicit credentials. For
those, the retry attempt will switch from ambient to explicit identity.
This CL updates HttpAuthController to restore the identity source such
that the retry correctly attempts the ambient identity again.

Bug: 857228
Change-Id: If4a9cfa30aa0ddb996a4856ae282c7f7358dce7b
Reviewed-on: https://chromium-review.googlesource.com/c/1329902Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609015}

In the presence of an opaque background,
BoxPainterBase::PaintNormalBoxShadow() insets the shadow clip by one
unit (in order to mitigate seaming artifacs), effectively expanding the
shadow inwards, and relies on the opaque background overdrawing this
inset.

But <body> doesn't paint its own background -- it gets transferred to
the view and painted in a different context => the shadow inset remains
visible.

To address this, pass background-skip information to
PaintNormalBoxShadow(), and disable the inset logic when the background
is not being drawn.

Bug: 899342
Change-Id: I5e04a1c17c2be324bf4c6767d2159372f546cc24
Reviewed-on: https://chromium-review.googlesource.com/c/1336495
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#609014}

Aligning with the POSIX impl in preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/1283010

Also adds two trivial ScopedAllowBaseSyncPrimitivesForTesting around
existing thread joins in tests (more advanced changes were extracted
to precursor CLs).

Bug: 707362
Change-Id: If4c4c49b4a20554518ca4a25ae1ea16b84d3a510
Reviewed-on: https://chromium-review.googlesource.com/c/1324370
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609013}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5705acabe03a..6343daaa40fe


git log 5705acabe03a..6343daaa40fe --date=short --no-merges --format='%ad %ae %s'
2018-11-16 iannucci@chromium.org [led] Update led to latest version.


Created with:
  gclient setdep -r src/third_party/depot_tools@6343daaa40fe

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I694e2a34951176ccb92e51f278ebdb3204cc3a36
Reviewed-on: https://chromium-review.googlesource.com/c/1340396Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609012}

This fixes the issue when side swiping from one SadTab to another.
Since -[SadTabCoordinator start] is idempotent it is important to start
coordinator for new sad tab, not for the old one which is not visible
anymore.

Bug: 901563
Change-Id: I9dfb488037da18be5fdb1079e849b723fa723c08
Reviewed-on: https://chromium-review.googlesource.com/c/1337814
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609011}

This should cover:
- Infobar
- Detached bookmark bar
- Avatar menu text (but not icons yet)
- Default bookmark icon
- Toolbar buttons
- Secondary UI controls

Bug: 850098
Change-Id: I6583f06e9470e320826f766e18d9c6e9141b75fa
Reviewed-on: https://chromium-review.googlesource.com/c/1337793
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609010}

Observe mojo connection errors and re-establish the connection once
it's lost.

Bug: 780514
Change-Id: Ic393f737bee97b97ed588ea47040327a4b639a4b
Reviewed-on: https://chromium-review.googlesource.com/c/1340945Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609009}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1d08bca895a..721662b8ce13


Created with:
  gclient setdep -r src-internal@721662b8ce13

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8b8ad31d13e61679c68d93467c11b1eb136c195b
Reviewed-on: https://chromium-review.googlesource.com/c/1340392Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609008}

TaskQueues shouldn't be confused with task runners.

Bug: 865411
Change-Id: Ibc37eb30de002f126a76231122f77c16fc3e8e35
Reviewed-on: https://chromium-review.googlesource.com/c/1336470Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609007}

The early out comes from initial.commit, but I think it was not needed
even then. We also RemoveRoute for the IPC channel in OnClose() which
means no new IPCs can arrive. Then GetWebWidget() will return null
after the OnClose() is fully handled, so by then there are no IPCs.

RenderViewImpl can also route messages to RenderWidget, which could
violate the above, but OnWasShown is only sent to the RenderWidget's
routing id.

R=avi@chromium.org

Change-Id: I19438c840c916cb09da8a26e265d390558dbca70
Bug: 896836
Reviewed-on: https://chromium-review.googlesource.com/c/1340483Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609006}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/28d8d7bc673a..8e9be303b00b


git log 28d8d7bc673a..8e9be303b00b --date=short --no-merges --format='%ad %ae %s'
2018-11-16 dneto@google.com Validator: Support VK_EXT_scalar_block_layout


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@8e9be303b00b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I23f0fb768b6ba97bad5b4ef0fe123752846b4d4c
Reviewed-on: https://chromium-review.googlesource.com/c/1340394Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609005}

Bug: 906162
Change-Id: I564bcbf2ac8c600e357f10ffaf085279ab7fe12e
Reviewed-on: https://chromium-review.googlesource.com/c/1340954Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609004}

Move stylus_tools interface out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ie891710ea8df139f49ae350cd40ec9f083870460
Reviewed-on: https://chromium-review.googlesource.com/c/1324141
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609003}

Threading issues have been fixed. Re-enabling.

Bug: 529678
Change-Id: Ie8b0a3ed0821bc388f678f45b418e75794e3a063
Reviewed-on: https://chromium-review.googlesource.com/c/1336490Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609002}

R=csharp@chromium.org

Bug: 830892
Change-Id: Ib3157dc17c2e2c7738f6b2a6af7d88ed72eb4d33
Reviewed-on: https://chromium-review.googlesource.com/c/1338402Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#609001}

Bug: internal b/118727323
Test: manual
Change-Id: I9623edf4e221d477d9e44b63357f86092b24f332
Reviewed-on: https://chromium-review.googlesource.com/c/1338112Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609000}

Update the TRIGGER_EVENT description in ukm.xml to accurately reflect
the values recorded. This update was missed in previous patchset that
added metrics for the toolbar button triggering UI.

BUG=859563

Change-Id: Ia270c452195a46120802d6de00032583007f7459
Reviewed-on: https://chromium-review.googlesource.com/c/1333998Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608999}

Change-Id: I4f0b2cf77e12561743380a192d20d1c6d438cd2f
Reviewed-on: https://chromium-review.googlesource.com/c/1324145Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608998}

https://pdfium.googlesource.com/pdfium.git/+log/4d0fac4a2c9e..75d214c50d2f


git log 4d0fac4a2c9e..75d214c50d2f --date=short --no-merges --format='%ad %ae %s'
2018-11-16 tsepez@chromium.org Pack XFA_SCRIPTATTRIBUTEINFO tighter on 64-bit platforms
2018-11-16 thestig@chromium.org Remove DOS line endings from bug_713197.in.
2018-11-16 tsepez@chromium.org Use macros to deselect strings in cxfa_node_statics.cpp
2018-11-16 thestig@chromium.org Fix some nits in CBC_PDF417HighLevelEncoder.
2018-11-16 thestig@chromium.org Make CBC_PDF417HighLevelEncoder::encodeText() faster.
2018-11-16 thestig@chromium.org Use the {{trailer}} macro in more PDFs.
2018-11-16 tsepez@chromium.org Add tests for radiobutton/checkbox JS properties.
2018-11-16 tsepez@chromium.org Remove unused strings from XFA_SCRIPTATTRIBUTEINFO.


Created with:
  gclient setdep -r src/third_party/pdfium@75d214c50d2f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:902302
TBR=dsinclair@chromium.org

Change-Id: I6b3dde8c5ecc8da9a4737fd36746bdcc7e7bcd3a
Reviewed-on: https://chromium-review.googlesource.com/c/1340393Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608997}

This is part of cleaning up for a new Clang warning that's currently disabled:

../../chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc(121,3):
error: explicitly defaulted default constructor is implicitly deleted
[-Werror,-Wdefaulted-function-deleted]
  TestScanner() = default;
  ^
../../chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc(119,21):
note: default constructor of 'TestScanner' is implicitly deleted because base
class 'chrome_cleaner::UrzaScannerImpl' has no default constructor
class TestScanner : public UrzaScannerImpl {
                    ^

Bug: 890307
Change-Id: I0ae013e278b85ae3ea706b1ecb716d5382a32132
Reviewed-on: https://chromium-review.googlesource.com/c/1340316
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608996}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/a2c529b5dda1..7cb43009d543


git log a2c529b5dda1..7cb43009d543 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 dj2@everburning.com Add option to skip examples.


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@7cb43009d543

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I313986008cf3d7a94fbc36f8c5b41ee325d557cc
Reviewed-on: https://chromium-review.googlesource.com/c/1340395Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608995}

At present this is only done at navigation time, which can leave frames
disconnected from their hosting process.

Bug: 901828
Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9
Reviewed-on: https://chromium-review.googlesource.com/c/1318405
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608994}