- 19 Aug, 2019 40 commits
-
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ib27f3df1a5aeb76ba8e24b5b1040a75efb7a1f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760139Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688144}
-
Jimmy Gong authored
Bug: 965721 Test: manual end to end Change-Id: I6dbf6081d1babde6f0476a93b66392864acf2898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760858Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#688143}
-
Gabriel Charette authored
(second half of https://chromium-review.googlesource.com/c/chromium/src/+/1756247) This is step #1 of the mass migration. Some of these will be backported to SingleThreadTaskEnvironment in a later phase. scoped_task_environment.h will also only move in a follow-up CL. TBR=dcheng@chromium.org Bug: 992483 Change-Id: Ie80f083eeeb209180ab3c2884f1b566f73549cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756248Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688142}
-
Tanisha Mandre authored
Architecture: Superclass - scannerView Subclasses - qrScannerView - Shift the video preview view and preview overlay view to shared 'scanner' directory. Bug: 990744 Change-Id: Ib81957f80d18b205865d9e4e6390c4ca56e4cf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736889 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688141}
-
Gang Wu authored
******************************Resource Sizes Diff****************************** Specifics: +77,824 bytes main lib size +626,344 bytes main dex size +1,028,222 bytes normalized apk size InstallSize: +402,088 bytes APK size +1,134,911 bytes Estimated installed size (Android Go) +2,932,517 bytes Estimated installed size InstallBreakdown (+2,929,368 bytes): +3,954 bytes Native resources (no l10n) size +2,139 bytes Non-compiled Android resources size +77,824 bytes Native code size +3,412 bytes PNG drawables size +603 bytes Package metadata size +2,813,504 bytes Java code size +27,932 bytes Compiled Android resources size Dex: +2,938 entries fields +2,473 entries strings +3,989 entries unique methods +1,255 entries types +3,989 entries methods Change-Id: I5a72a2c017cfdc16b56308d59e11ae205baaf6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759928Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688140}
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: I27391139d718457da50d9e96d7ffc958d1d4a11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755544Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688139}
-
Philip Jägenstedt authored
Change-Id: Ied8e0177399d514a26be17092f4dcdbbcf659574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757989Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#688138}
-
Alex Clarke authored
Split off from https://crrev.com/c/1751324 The ResourceLoadPriority tests send Priority and a Status result via postMessage. Due to the way this is implemented the test is unnecesarially sensitive to the loading order and can fail even when the thing it's actually testing passes. This patch changes the message to a key-value pair which is more robust. Bug: 971191 Change-Id: Ieb7d7d736c363b75a0b1e2e1f1a2ad95cfaddbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760226 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688137}
-
Joshua Peraza authored
components/crash/ supports multiple embedders (not just chrome) so chrome specific crash configuration should live in its CrashReporterClient implementation. Change-Id: I6406f06e1a228c69bcaa4654a7743d039229fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756423Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#688136}
-
Peter Kasting authored
This minimizes the readability cost for using custom frame colors. Bug: 854738 Change-Id: Ifee3e07a6a1317c93c1e5bccdcce921008d7e58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759223 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#688135}
-
Thomas Tangl authored
Bug: 966388 Change-Id: Ic07d37be9443516563817533c5bd2613b973c6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760207 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688134}
-
sczs authored
Bug: 979201 Change-Id: Idfc2836db82f7f8ae68b580e84f2fbb65aba1337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759222Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#688133}
-
Owen Min authored
All callers have been migrated to the new API, cleanup the old ones. Bug: 983174 Change-Id: I28c851e363d74079e6a7f669726e24710d004c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758592Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688132}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/2906c3c5b3bf..795a3ae59002 git log 2906c3c5b3bf..795a3ae59002 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@795a3ae59002 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: I3ed99c4134f93a7d3f1d9e0b1beb525d6c96515a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688131}
-
Changwan Ryu authored
WebPlatformTests (wpt.fyi) assumes that the product in test can support mutliple windows such that one window can run as a test runner, while we run the test on another window. On top of multiple window support, we enable JavaScript, and INTERNET is already enabled in system webview shell. Bug: 992947 Change-Id: I4688040b828b7c40f67f3bc809065015909567d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747371Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688130}
-
Joshua Peraza authored
sigtimedwait() is used by Crashpad clients to wait for crash dump completion. https://osscs.corp.google.com/chromium/chromium/src/+/master:third_party/crashpad/crashpad/util/linux/exception_handler_client.cc;l=143?q=exception_handler_client&ss=chromium Bug: 942279 Change-Id: Id6f744c278a072dd495995b2040238661881c900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760133Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#688129}
-
Austin Eng authored
Bug: dawn:154 Change-Id: I40c484f40c618a564c7f462aa21785ce85a68020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758807Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#688128}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I9dfb009d49e8f287ca8fdd10c6b922a372b583c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758449 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#688127}
-
Hans Wennborg authored
Because there was a virtual call to one of its methods (factory_->Create...) but the class was never instantiated, the UBSan build failed like this: FAILED: unit_tests ../../third_party/llvm-build/Release+Asserts/bin/c... ld.lld: error: undefined symbol: typeinfo for safe_browsing::MultipartUploadRequestFactory >>> referenced by multipart_uploader.cc >>> safe_browsing/multipart_uploader.o:(.data..L__unnamed_37+0x18) in archive obj/chrome/browser/safe_browsing/libsafe_browsing.a clang-10: error: linker command failed with exit code 1 (use -v to see invocation) It turns out factory_ is always NULL, and the class was never actually used. Bug: 993693 Change-Id: If10eea4adb7bd99d826be4630d945cbf0643eab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752850Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688126}
-
Fredrik Söderquist authored
When we've built the shadow tree for a <use>, we should not have set up any new instance references, and the old one's should have been invalidated when the element was marked for "shadow tree recreation". Drop the InvalidateDependentShadowTrees() call in SVGUseElement::BuildPendingResource() and also add a DCHECK in Document::UpdateUseShadowTreesIfNeeded() for checking that the shadow tree construction did not add any new entries to the set (which would make the document state inconsistent). This should pave the way for a future change that performs the instance mapping as part of shadow tree building rather than during layout attach. Bug: 953263, 986114 Change-Id: I3474eea0d8face10b88315421aaa36ca782a6e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757834Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#688125}
-
Andrew Xu authored
Adapt ScrollableShelfView's layout to new specs Bug: 973481 Change-Id: I9990c86892c388e17657c6cc1347efc9877be197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757429Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688124}
-
Koji Ishii authored
This patch implements basic float painting in |NGBoxFragmentPainter| when children are not inline. 1. Change |PaintFloats| to work without |NGPaintFragment|. 2. Apply the |kFloat| paint phase logic in |PaintObject| to when |ChildrenInline| is false. The block logic is very similar to the inline logic, but this patch does little work to share because the inline logic will need to revise by the NGFragmentItem work. Fixes ~200 tests, failures is down to ~500. There are still some floats failures and they seem complex, such as when floats are under the engine boundaries. They need to be investigated in future patches. There should be no behavior changes unless NG painter is enabled for block boxes. Bug: 988015 Change-Id: I90a152ee31a6db5d69d611a097e28af0823a47a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757988 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#688123}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 4abb566fb..fd3ee30e9 (16 commits) https://quiche.googlesource.com/quiche.git/+log/4abb566fbbc6..fd3ee30e9b48 $ git log 4abb566fb..fd3ee30e9 --date=short --no-merges --format='%ad %ae %s' 2019-08-16 bnc Add QUIC_EXPORT_PRIVATE macros to qpack_index_conversions.h functions. 2019-08-15 bnc Remove SpdyString wrapper for std::string. 2019-08-15 dschinazi Do not queue coalesced undecryptable packets twice 2019-08-15 bnc Support blocked decoding in qpack_round_trip_fuzzer.cc. 2019-08-15 renjietang Prevent duplicate HTTP/3 control stream. 2019-08-15 zhongyi Re-arrange the order of the code to call OnConnectivityProbeReceived. 2019-08-15 fayang gfe-relnote: In QUIC, add probe timeout mode, which unifies TLP and RTO. Protected by gfe2_reloadable_flag_quic_enable_pto. 2019-08-15 bnc Check that every dynamic entry reference is acknowledged. 2019-08-15 bnc Add fuzzer data transmitters for header blocks and encoder/decoder stream data in qpack_round_trip_fuzzer.cc. 2019-08-14 fayang gfe-relnote: In QUIC, schedule RTO whenever there is bytes in flight (rather than pending retransmittable frames). When timer fires in RTO_MODE and there is no data to send, force to send PING. Protected by gfe2_reloadable_flag_quic_fix_rto_retransmission3 which replaces gfe2_reloadable_flag_quic_fix_rto_retransmission2. 2019-08-14 bnc Factor out QPACK absolute, relative, and post-base index conversion functions, and add new ones. 2019-08-14 bnc Fix QpackDecoder::EncoderStreamRelativeIndexToAbsoluteIndex(), simplify QpackProgressiveDecoder::RequestStreamRelativeIndexToAbsoluteIndex(). 2019-08-14 dschinazi Add VersionNegotiationProbeEndToEnd test 2019-08-14 renjietang Update StreamIdManagerTest. 2019-08-14 bnc Refactor QPACK roundtrip fuzzer. 2019-08-14 quiche-dev gfe-relnote: Implement sending the MAX_PUSH_ID frame when the client sets a non-zero maximum push id. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ia98bffe41bc1f5e70ac501e6a78d104962a31ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757287 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688122}
-
Mohamed Amir Yosef authored
Bookmarks Sync USS has been enabled by default in M77, but it turned out that it's not yet ready for prime time. The plan is to disable it, and merge the disable CL back to M77, and enable it by default for M78. Change-Id: I1031714f42830ddf3b81a44d4036f29b338d6bb1 Bug: 950869,516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760911 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688121}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5e5d250bc85..185243b33522 git log f5e5d250bc85..185243b33522 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 sprang@webrtc.org Remove most of PacedSenderUnittest 2019-08-19 artit@webrtc.org Roll chromium_revision c7f14188..afb0a631 (687843:688061) 2019-08-19 henrik.lundin@webrtc.org NetEq fuzzer: reduce max input size slightly to avoid timeout 2019-08-19 peah@webrtc.org Reland of Correct conversion between float and fixed formats 2019-08-19 sakal@webrtc.org Revert "Introduce ability to test echo in PC level test framework" 2019-08-19 sprang@webrtc.org Remove some usage of RtpRtcp::SetSSRC() 2019-08-19 gustaf@webrtc.org AEC3: Fix computation of audio buffer delay 2019-08-19 chxg@google.com Enable `VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources` for iOS. 2019-08-19 titovartem@webrtc.org Introduce ability to test echo in PC level test framework 2019-08-19 titovartem@google.com Add steps logging into PC test framework 2019-08-19 danilchap@webrtc.org Delete deprecated RtpRtcp::CreateRtpRtcp factory 2019-08-19 artit@webrtc.org Roll chromium_revision d5a13ccb..c7f14188 (687732:687843) 2019-08-19 mbonadei@webrtc.org Remove rtcbot. 2019-08-19 hbos@webrtc.org Reland "[GetStats] Expose video codec implementation in standardized metrics." 2019-08-19 sprang@webrtc.org Extract most of PacedSender into PacedSendingController. 2019-08-19 jonaso@webrtc.org Update constributing source before publishing frame 2019-08-16 mellem@webrtc.org Only combine media transport and ICE states if used for media. 2019-08-16 kron@webrtc.org Remove deprecated constructors of RtpSource 2019-08-16 yinwa@webrtc.org Allowing 40ms audio frame length. 2019-08-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c7f850c7..d5a13ccb (687596:687732) Created with: gclient setdep -r src/third_party/webrtc@185243b33522 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:988542,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I5760e7b8cdf706345b79b3da36f520495fba9f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688120}
-
Justin Cohen authored
Keep the placeholder's virtualURL in sync with its URL. Otherwise, a previous page's virtualURL can still be used for a new page's URL. Bug: 995066 Change-Id: I5314591e1605987317ee7964dadc2f4c5c699afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758975Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688119}
-
Marc Treib authored
Before this CL, DataTypeController::RegisterWithBackend got a callback parameter, which (for USS types) was always synchronously called, and for directory types was not called at all. After this CL: DataTypeController::RegisterWithBackend directly returns an enum value with the result. The enum includes an "ignored" value for directory types. Bug: 991907 Change-Id: I9f36ef69a4952c4869c55b8dfbff48c55a8de567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751984 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688118}
-
Dominik Röttsches authored
When incoming requests for CJK characters come in with an unsuitable locale to resolve Han unification ambiguities, in other words with a locale that does not explain whether a Chinese simplified, traditional, Japanese or Korean font is best suitable, avoid caching this font as otherwise the cache will be primed with an incorrect result for the next similar request. Bug: 994717 Change-Id: I40aab8dcce6cd4a6a3ee9a4a2481e88cb0a1b3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758080 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688117}
-
Michael Thiessen authored
This reverts commit c6a96ae8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add debug logging to WebApk network errors. > > Touchless tests are hitting network errors inexplicably on bots, and I'm > unable to repro locally, so I'm adding logging to hopefully get more > insight. > > Bug: 983769 > Change-Id: If9ed3b7569c1d26a7923bac5f458a44fb4edb331 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741291 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685195} TBR=mthiesse@chromium.org,pkotwicz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983769 Change-Id: I8a79e579e04c6cd3a528dfff744e9400093dd3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759681Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#688116}
-
Robbie Gibson authored
Bug: 976674 Change-Id: Iba69905f69586d3938b87e610af39e8ae17e1855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760298 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688115}
-
Christian Dullweber authored
To correctly check if storage access is allowed, both site_for_cookies and top_frame_origin are required. Most storage systems currently only provide top_frame_origin. Bug: 989926 Change-Id: I616842caf1f28e26767f2b23bb76bcecc74bdc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742159 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688114}
-
Vlad Tsyrklevich authored
In https://crrev.com/c/1754737 supported was added for white listing memory ranges in crashpad sanitized snapshots (used for WebView.) Add support to store and expose the memory range whitelist to crashpad. Bug: 973167 Change-Id: Ia96644af0af3de7e4b57e6d7c5d413e1bd28d725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756705 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#688113}
-
Lily Chen authored
Bug: 978172 Change-Id: Id8594533c1135e71dc15a3195007129f3bcc99e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718359Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#688112}
-
Sahel Sharify authored
This cl disables RenderWidgetHostTouchEmulatorBrowserTest.TouchEmulator on MSAN,TSAN,and DEBUG builds. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests%20(with%20patch)&tests=RenderWidgetHostTouchEmulatorBrowserTest.TouchEmulator TBR=wjmaclean@chromium.org NOTRY=TRUE Bug: 994353 Change-Id: I5bcf6de5471ee229edde3423ecd0a5c2fccb336c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760458 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688111}
-
Sahel Sharify authored
Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=DevToolsExtensionTest.DevToolsExtensionSecurityPolicyGrants NOTRY=TRUE TBR=dgozman@chromium.org Bug: 993982 Change-Id: I1690e6db8ec7e6a67182075a45ce7891bc1bc2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760861Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688110}
-
Yann Dago authored
OMA-URI example (at step 2): https://support.google.com/chrome/a/answer/9102677?hl=en Bug: 985722 Change-Id: I49036c1ccbcd8a0567fdc1687ac537bfa7023516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724664Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#688109}
-
Ken Rockot authored
r687811 caused a regression which leads to the Device Sync service instance outliving its KeyedService dependencies, resulting in a UAF on browser shutdown. This properly destroys the service instance during the DeviceSyncClientHolder's KeyedService Shutdown. Bug: 995010 Change-Id: Ieca3937180f5580798c7ea735dd61e8b8f95c539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759675Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#688108}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dadeb009a297..303ddb5c8807 git log dadeb009a297..303ddb5c8807 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 srisser@google.com Make ClipDstRect/ClipSrcRect cease on non-finite Created with: gclient setdep -r src/third_party/swiftshader@303ddb5c8807 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I7f0c7ce9a5f869c1d3c05ec26dd0a99012af311e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688107}
-
Gabriel Charette authored
Migrated on its own because of the change in test expectations. R=dcheng@chromium.org Bug: 992483 Change-Id: I68dfd16a91ab4563cd62870446a8bc44f47dc194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760273 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#688106}
-
Etienne Bergeron authored
This CL replacing the usage of the address of the SkTypeface by it's uniqueID. It's adding the script and font to the hashing function since text is often rendered with fonts of different size. We also observed many collisions while rendering the same text but with different text range. The previous code was working correctly since the HashingMRUCache is looking for every member with the same hash. It is reducing the amount of collisions. Under the hood, HashingMRUCache is using an std::unordered_map. R=msw@chromium.org Change-Id: I916798ccd218be2f959aff272768c05633138140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710131 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688105}
-