- 24 Jul, 2018 6 commits
-
-
chrome://accessibilityJames Wallace-Lee authored
Saves the option to show the internal accessibility tree as the preference kShowInternalAccessibilityTree. Change-Id: Ib16c93f982da3e3cae1728fb8cdb0747a7463549 Reviewed-on: https://chromium-review.googlesource.com/1144271 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577353}
-
Alexei Filippov authored
The class provides support for module lookups for memory addresses. BUG=803276 TBR=dcheng@chromium.org Change-Id: Iaae0d70c6e7091ced6276e321321b74a6496255a Reviewed-on: https://chromium-review.googlesource.com/1132545 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577352}
-
W. James MacLean authored
Now that we know this pathway is involved in the incorrect setting of page scale factors for OOPIFs, convert this CHECK to a DCHECK. Bug: 859428 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d8805056546cc6ada3525e57d307dbcb27e6f55 Reviewed-on: https://chromium-review.googlesource.com/1146329Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#577351}
-
Peter Wen authored
http://b/111756850 Bug: None Change-Id: I7b7038eceb5872970598fcffd3f86c8b661a2140 Reviewed-on: https://chromium-review.googlesource.com/1147496 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577350}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie6de2e359cbe2067f7304e3dfd0fe65cfe390bf7 Reviewed-on: https://chromium-review.googlesource.com/1147666Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#577349}
-
Ryan Hamilton authored
Use a std::unique_ptr<ProofVerifyContext> instead of a raw pointer in the QuicCryptoClientStream constructor. Merge internal change: 203836768 Change-Id: I80e3cefd998af739fd4baa0a6df79034da407613 Reviewed-on: https://chromium-review.googlesource.com/1147492Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577348}
-
- 23 Jul, 2018 34 commits
-
-
Zhiheng Vincent Li authored
Bug: b/111566470 Test: tested on Android Things device Change-Id: I17f09973a3ac9ed5498efb6f21ffc6f87e6c878a Reviewed-on: https://chromium-review.googlesource.com/1142896 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#577347}
-
proberge authored
A spinner previously replaced the icon while scanning or cleaning was in progress. Since the icon is removed, the spinner is now positioned to the right of the text, replacing the action button while scanning or cleaning is in progress. Bug: 803683 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2272ae8280d464c252cb10c00d77bbee35983a03 Reviewed-on: https://chromium-review.googlesource.com/1133318 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577346}
-
Trent Apted authored
Brackets have the "common script" unicode property and need special handling when breaking runs (see http://www.unicode.org/reports/tr24/#Common ). Currently, emoji breaks runs correctly around other bracket and quote mark types, but not around 「」, which is commonly used in CJK languages. Bug: 843426, 396776 Change-Id: Ia5ff5165d5c260aa1876488e2f51d566f2164cd6 Reviewed-on: https://chromium-review.googlesource.com/1146401Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#577345}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0df813c37570..522095f7d7fe git log 0df813c37570..522095f7d7fe --date=short --no-merges --format='%ad %ae %s' 2018-07-23 jmadill@chromium.org Rename "color" functions to "pixel" functions. 2018-07-23 jmadill@chromium.org Vulkan: Support inverted blit for depth/stencil. 2018-07-23 ynovikov@chromium.org Don't generate error for compressed texture formats in glFramebufferTexture2D 2018-07-23 jmadill@chromium.org Make PackPixels take an angle::Format. 2018-07-23 geofflang@chromium.org Pass Context to EGLImage creation and Display to EGLImage initialization. Created with: gclient setdep -r src/third_party/angle@522095f7d7fe The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8044f6199153305dfc025dd95315ed6b181ca28c Reviewed-on: https://chromium-review.googlesource.com/1147066Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577344}
-
Trent Apted authored
Implement the currently unimplemented (on mac) NativeWidget:: SetVisibilityAnimationTransition() for this. Autofill uses this but not constrained windows. Constrained windows on aura platforms have bespoke animation suppression code, which is currently different to the desired behavior on Mac (i.e. the very first "show" should animate). Consolidate some of the animation logic in MacViews Widgets. Bug: 767743 Change-Id: If49d139a66873e896e68030f69efdaa81a8dc948 Reviewed-on: https://chromium-review.googlesource.com/1146408Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#577343}
-
Mostyn Bramley-Moore authored
extensions/common/extension_features.h contains an extensions::features namespace, which can be confused with chrome/common/chrome_features.h's features namespace in jumbo builds. Let's disambiguate these enough to get jumbo builds working again. Followup to this CL, which uncovered the issue (but didn't cause it): https://chromium-review.googlesource.com/c/chromium/src/+/1145630 Bug: 866170 Change-Id: Iea5cca04c3c636014eae14f987c4aecd2dfb93bc Reviewed-on: https://chromium-review.googlesource.com/1147521Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#577342}
-
Erik Luo authored
Introduces JavaScriptREPL, a utility that includes - Logic used by EagerEval for building side-effect-free previews - Console prompt's preprocessing logic (object literal wrapping and top level await) Bug: 849875 Change-Id: Ie8146435fced9ebf440b43c225d25ef145416247 Reviewed-on: https://chromium-review.googlesource.com/1145911Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#577341}
-
akaba authored
This CL adds the 3 following histograms: 1) logs the number of alive surfaces after each surface garbage collection in Viz. 2) logs the number of temporary references after each surface garbage collection in Viz. 3) logs the distance between a surface returned by SurfaceManager::GetLatestInFlightSurface and the primary_surface_id passed in. Bug: 866113 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I644c5005ba1a0997956a75083f8b25bd8a5f5abc Reviewed-on: https://chromium-review.googlesource.com/1142591 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577340}
-
Kim Paulhamus authored
Change-Id: I951cea4684a12284b2861b1bc4fc3771db637b32 Reviewed-on: https://chromium-review.googlesource.com/1145955Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#577339}
-
Adrienne Walker authored
Colorspace conversion is showing up in profiles, and this is unnecessary on the renderer side when it is SRGB. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9de0be7700ceffa44f072e8160ddb6fed5fd7730 Reviewed-on: https://chromium-review.googlesource.com/1147491Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577338}
-
Sahel Sharify authored
This cl have the following changes to make sure that fling animation is smooth. 1-Instead of scheduling a fling progress after processing a GFS, the fling controller calls progress fling to send the first progress event to the renderer without waiting for the next frame. This change broke some tests that had GFS events with small velocity and had the assumption that fling is still active when a GFC is sent. 2- The controller does not reset the GFS timestamp when the progress fling when current_time is less than the GFS timestamp since changing the GFS timestamp to a smaller time makes the next event's delta bigger. 3- ProgressFling does not early return if the first time that progress fling is called is two frames later than the GFS timestamp (the call on the first frame is missed) since deferring sending the progress event even longer makes the fling janky. Bug: 249063 Change-Id: I7aec6a891fc01c11d65445e3bb4d432df7bf1955 Reviewed-on: https://chromium-review.googlesource.com/1140912Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577337}
-
Findit authored
This reverts commit d3981964. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577272 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QzOTgxOTY0ZjI0OTkwMzMwNTlhYWU2MDA3MzJkNjU2MzcwZTBkZGYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/71239 Sample Failed Step: site_per_process_content_unittests Original change's description: > [Background Fetch] Move all updatable UI options to their own proto. > > Bundle up the icon and the title since they will be accessed/modified > together in the updateUI call. > > It also makes sense to move the icon from the metadata proto since that > will speed up getting the registration info. > > TBR=avi@chromium.org > > Bug: 865063 > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > Reviewed-on: https://chromium-review.googlesource.com/1146650 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577272} Change-Id: I3a2cf95f1f058c5c026c68c4ca76998f8ccf52e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865063 Reviewed-on: https://chromium-review.googlesource.com/1147641 Cr-Commit-Position: refs/heads/master@{#577336}
-
Leonard Grey authored
Bug: 846796 Change-Id: I417702c78b1b5dec4914a9efbc0ec16e1d016de9 Reviewed-on: https://chromium-review.googlesource.com/1147148 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577335}
-
Christopher Cameron authored
Two bugs here. First bug: Interactions with calling RWHVMac::Show/Hide. With the non-unified compositor, calling RWHVMac::Show/Hide will cause the Cocoa NSView to have its show or hide method called. With the unified compositor, calls to RWHVMac::Show/Hide are largely ignored. The ui::Layer will always be visible if it has a parent ui::Layer. This is a bug -- the ui::Layer should be made visible or not based on the visibility specified by the calls to RWHVMac::Show/Hide. Second bug: Child NSViews not matching child ui::Layers It is possible for a WebContentsViewCocoa NSView to have multiple RenderWidgetHostViewCocoa NSViews. Which of these views is visible is controlled by called to RWHVMac::Show/Hide. Track the parent RenderWidgetHostViewBases that added NSViews, and iterate through all of them when updating the parent ui::Layer. Unrelated cleanup: Remove parameter from BrowserCompositorViewMac that is always false (and add a DCHECK that it is false, just for good measure). Bug: 859834, 865227 Change-Id: I8767692443d5eb6381a8ea4b087c5c312fef305d Reviewed-on: https://chromium-review.googlesource.com/1141148Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577334}
-
Matt Giuca authored
Was committed as CRLF line endings in r576221, despite existing rule against this, which caused git to always consider this file to be dirty. Converted to Unix (LF) line endings. Bug: 866342 Change-Id: Ie05d8a83e7ef6721bb0dd58fe3e278da245c313c Reviewed-on: https://chromium-review.googlesource.com/1146407Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#577333}
-
Sunny Sachanandani authored
This is a reland of 6beef1e6 Removed incorrect DCHECKs that were added in the original change. Original change's description: > cc: Throttle incoming begin frames in scheduler > > Unlike PostTask from IO thread to compositor thread in Chrome IPC, mojo > polls for messages on the compositor thread which means it can dequeue a > large number of begin frame messages after the compositor thread has > been busy for some time. All but the last begin frame cancels the > previous begin frame, and is essentially a nop, but it still ticks > animations. When a page has a large number of animations each begin > frame can take a long time and push out other tasks such as tile manager > callbacks stalling the pipeline. > > Throttling the begin frames in viz doesn't fully solve the problem > because we have to allow at least two begin frames in flight for > pipelining, and so the client can still process two begin frames back to > back. > > Throttling in AsyncLTFS causes issues with LTFS lifetime and ordering > with respect to other messages. > > Saving incoming begin frame in scheduler and posting a task works and > ensures that only one begin frame is outstanding at any time. > > R=danakj > BUG=782002 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I247a87ad7475d33f878a215ce87056d20482f88c > Reviewed-on: https://chromium-review.googlesource.com/1130082 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577046} TBR=danakj BUG=782002 Change-Id: Iec7bd9e421bdb372f101ecebc6cb71835dcb27bf Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1147082 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#577332}
-
Sammie Quon authored
Test: none Bug: 862489, 866715 Change-Id: Iebf4ee24d693f49258b9c01bad9ac6cfcdb838b2 Reviewed-on: https://chromium-review.googlesource.com/1142230 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577331}
-
Christopher Cameron authored
Optimization part 2.5 of ~3 In ShapeRunsWithFont, identify runs that the same initial CommonParams and insert them into a RunVector. Change the rest of the shaping pipeline to operate on these RunVectors, and move most of the processing of CommonParams to be done once per RunVector instead of once per run. This change was intended to be part of the change to allow coalescing of similar calls into HarfBuzz (which may or may not land), but it was found to improve the performance in the cache hit case by a factor of almost 2. Bug: 862773 Change-Id: I8df02c2a8622eb9be74a65191fad79613ff1da2d Reviewed-on: https://chromium-review.googlesource.com/1145904 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#577330}
-
Reilly Grant authored
This change modifies ScopedLibusbDeviceRef and adds a new class ScopedLibusbDeviceHandle. This now explicitly own a reference to the UsbContext object (which reference counts a libusb_context) in addition to the libusb_device or libusb_device_handle they are wrapping. This resolves potential use-after-frees possible when posting tasks with a ScopedLibusbDeviceRef since the UsbService the task is being posted to could be destroyed before the task is executed. The libusb_device would then be released after its libusb_context has been destroyed. This is based on https://crrev.com/c/1131949 after I realized there where additional issues that needed to be addressed. Bug: 838947 Change-Id: Idee02828bf615bd477033e585fffe03cf4d20595 Reviewed-on: https://chromium-review.googlesource.com/1145910Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577329}
-
Andrey Lushnikov authored
This will allow devtools_session to own parsed message and bind it as a part of a callback. R=dgozman Bug: 817413 Change-Id: I48dc7a12741902603e22233cdd26b6bb97ecf453 Reviewed-on: https://chromium-review.googlesource.com/1145954 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577328}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/9a518d097dca..486c9b53c4d5 $ git log 9a518d097..486c9b53c --date=short --no-merges --format='%ad %ae %s' 2018-07-23 maruel [client] lower default task priority to 200 2018-07-23 maruel Roll infra_libs, gae_event_mon and gae_ts_mon. 2018-06-28 maruel client: fix exception on symlink 2018-06-26 martiniss Revert "Bump version of infra_libs to 1.4.0" 2018-06-25 martiniss Bump version of infra_libs to 1.4.0 2018-06-22 maruel [swarming] more task state documentation 2018-06-20 nodir Add Google RPC protobufs 2018-06-18 maruel [client] Fix regression in d335c4bf86 2018-06-18 maruel [client] Fix regression in a768d983f4 Created with: roll-dep src/tools/swarming_client Bug: 855253,864655 Change-Id: Ic98b9572df6ec364afa2595802abf266e3202a46 Reviewed-on: https://chromium-review.googlesource.com/1147154Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577327}
-
Justin Novosad authored
BUG=866273 Change-Id: Ie53ffb789b005089813f11f26f4425a8f8884b0f Reviewed-on: https://chromium-review.googlesource.com/1147461Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577326}
-
Tom McKee authored
According to the spec (https://w3c.github.io/server-timing/#the-server-timing-header-field), optional whitespace is allowed amongst parameter names and values. We should be discarding this whitespace during parsing but, when there are tabs, we were treating it like an error and discarding the whole value. Changed the code that tokenizes HTTP headers to skip tabs and spaces when consuming optional whitespace. BUG=798446 Change-Id: If776761e5ea199e662ec7b2b5aa245e4581131fd Reviewed-on: https://chromium-review.googlesource.com/1147258Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#577325}
-
Wei-Yin Chen (陳威尹) authored
Right now Android build uses platform_font_linux if the VR support is enabled. VR support is enabled on all Android ARM builds (see |enable_gvr_services| and crbug/733935). We'd like to use RenderText in compositor UI, so this CL makes all Android builds use platform_font_linux, regardless of whether VR is enabled. This only affects non-ARM Android builds. Bug: 853281, 642010 Change-Id: I843c53964f1af932ad9f00b67ac690c5b43916ab Reviewed-on: https://chromium-review.googlesource.com/1142484 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577324}
-
Fritz Koenig authored
Push mesa to invert the framebuffer if the GL_MESA_framebuffer_flip_y extension is available. BUG=680851 Change-Id: Ib22dfb1d03fcc54acc016de29bdead16398ef416 Reviewed-on: https://chromium-review.googlesource.com/1091917 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577323}
-
Justin Novosad authored
BUG=866241 Change-Id: Ic789573da753fe1e438778d777556a659fbf0ba9 Reviewed-on: https://chromium-review.googlesource.com/1147460Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577322}
-
Christopher Cameron authored
The GLFences used for backpressure in ImageTransportSurfaceOverlayMac are objects that should be scoped to a GLContext, not a GLSurface. Add methods to GLContext to allow creation and waiting on fences, and call those methods from GLSurface. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib0fc8cac3efdd50f88c197c6bdeb2ee2e22696bd Reviewed-on: https://chromium-review.googlesource.com/1146483 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577321}
-
Gabriel Marin authored
We are trying to uprev the tcmalloc version used in Chromium. As part of the transition to a new tcmalloc, we plan to run experiments with the new tcmalloc on a small number of boards before we enable the new version globally. This CL adds a build flag to select between the two tcmalloc versions at build time. By default, the old tcmalloc version is used. BUG=724399,b:70905156 Change-Id: I6839bba721b0d2a5f3515e7346bff418b0155221 Reviewed-on: https://chromium-review.googlesource.com/1130672Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#577320}
-
Ricardo Quesada authored
Use correct TexCoord precision in GLRenderer::EnqueueTextureQuad. Under certain cases, specially when resizing ARC++ windows, the surface size == fullscreen size. But when EnqueueTextureSize asks for the TexCoord precision, it passes visible_quad_layer_rect which could be less than the highp_threshold_cache. So it will use a mediump qualifier instead of a highp. Probably this is only reproducible on Kevin because its mediump is only 10 bits, and I guess other GPUs use a higher precision for mediump. * Add unit test for the fix * Remove unused vars from gl_renderer_unittest.cc * Replace bottom_right() with size() before calling TexCoordPrecisionRequired, since it only cares about sizes and not positions. * Add #include <utility>, <map>, <memory> since "git cl lint" complained about it BUG=862452 TEST=viz_unittest in Linux. Passed all tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I51ec129db3369c45192f4f0c69ec38f3a2ec511d Reviewed-on: https://chromium-review.googlesource.com/1132607 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577319}
-
May Lippert authored
This fixes an issue where an existing user's passwords are not saved in the UserContext if views-based login is used. This in turn meant that the user's password would not be saved in the kernel keyring in cases where the ${PASSWORD} variable is used in the OpenNetworkConfiguration policy. BUG=chromium:866566 TEST=run unit tests, run autotests Change-Id: I2d43ebfb6869d8d333e61505d1987081076fc3da Reviewed-on: https://chromium-review.googlesource.com/1147207Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#577318}
-
Stephan Stross authored
This CL adds a quick change to boot_data.py that makes the output directory path absolute before provisioning SSH files, to work around ZX-2397 Bug: https://fuchsia.atlassian.net/browse/ZX-2397 Change-Id: Iae0c2f8bd992e14bc3d7bcce88c82e65407b829b Reviewed-on: https://chromium-review.googlesource.com/1147247 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577317}
-
Hiroshige Hayashizaki authored
Before this CL, ExecutePendingScriptAndDispatchEvent() implements two different spec concept depending on its two call sites, and ScriptStreamer::Type parameter is used just to distinguish the two call sites. This CL splits the method into two (one for each call site), to remove unnecessary dependency to ScriptStreamer::Type and make spec correspondence clearer. Bug: 865098, 686281 Change-Id: I2ddb10ebe4c20861121d42d11d4a83cb349c3369 Reviewed-on: https://chromium-review.googlesource.com/1144462 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577316}
-
Stephen Martinis authored
This CL enables logic to only retry failed tests for most isolated script tests. The following test suites are affected: * angle_perftests * chromedriver_py_tests * components_perftests * content_shell_crash_test * devtools_closure_compile * devtools_eslint * heap_profiling.mobile.disabled * heap_profiling.mobile.native * heap_profiling.mobile.pseudo * memory.leak_detection * metrics_python_tests * mini_installer_tests * monochrome_apk_checker * passthrough_command_buffer_perftests * performance_test_suite * site_per_process_webkit_layout_tests * telemetry_gpu_unittests * telemetry_perf_unittests * telemetry_perf_unittests_viz * telemetry_unittests * telemetry_unittests_viz * validating_command_buffer_perftests * views_perftests * webkit_python_tests These should all work with this logic; I've tested these manually myself. NOTRY=true NOPRESUBMIT=true Bug: 533481 Change-Id: If3a5a03410fd7f1f597197d98ae3060bd91ff487 Reviewed-on: https://chromium-review.googlesource.com/1141340 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577315}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c7a5d6a83b6..5bc35fd6c631 git log 2c7a5d6a83b6..5bc35fd6c631 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 yunlian@google.com Re-eanble cfi on eve-arcnext Created with: gclient setdep -r src/third_party/chromite@5bc35fd6c631 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9354b2b8cff903b1ab21f5185564db205a8753b3 Reviewed-on: https://chromium-review.googlesource.com/1147061Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577314}
-