- 08 Sep, 2020 40 commits
-
-
Anqing Zhao authored
We did some refactoring for Chrome app Kiosk. UsbStickUpdateAppNoNetwork case can pass stably in local now. Please let me re-enable it and keep monitoring. Bug: 1021492 Change-Id: Icfeaf4ca83de0f0b71208588b25775a73802ab50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396126Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#804889}
-
Rakina Zata Amni authored
For better readability of metrics Change-Id: Ibaeaf6adf59a90774e2d05b2eacf122f4840ae29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397516 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804888}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69e45dc92bd0..7f6cd0ad669b 2020-09-08 jleconte@google.com Adapt ChromePerf code to retrieve WebRTC git hash for bisection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: rmhasan@google.com Change-Id: If12ecd4fc8d518a3593055437435f58355bf4935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804887}
-
Benoit Lize authored
PartitionRoot precomputes constants that are needed in the hot path, to save branches. These constants are the same across all PartitionRoots, and they could be known at compile-time. This CL precomputes these at compile time, which saves ~1kiB per PartitionRoot, and should improve cache locality, as we have multiple partitions in use at any point. Bug: 998048 Change-Id: I36ff92b8df684c7788a1ffee7cfb160d3e4cc98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375248 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804886}
-
Wei Lee authored
Also, since shenghao@ is not in camera team now, change the owner to me. Bug: 1125686, 1125688 Test: None Change-Id: I6947dc960282b502d05202558ee9842a853df22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397515 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#804885}
-
Christian Dullweber authored
Disable cookie deletion button in new PageInfo UI when deletion is restricted for supervised users. Bug: 1077766 Change-Id: Iabb07fb686b761a1a3a9ca8b9c3d0f2be95f499c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396122 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#804884}
-
Frédéric Wang authored
This CL adds a web platform test to check that MathML content inside a multi-column list is still correctly laid out. It is copied from the similar relations/html5-tree/integration-point-4.html test for MathML inside SVG foreignObject. These two tests are failing because legacy layout is currently forced in the subtree containing MathML. They should pass when this issue is fixed and would crash if the legacy check mentioned on issue 1125133 is removed before this actually happens. Bug: 6606, 1125133, 829028 Change-Id: I4b060c445e551f32f1884e1676e6b48f8f5e09a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397718Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e46a2aea1478..c0ee2b2ab51b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I6556d1e60ce28e42cf3cb2b754706b81d0b8b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804882}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599501535-4517b466b7e93a6fa96665d6e0ac00556c34e7cf.profdata to chrome-win64-master-1599544645-d1be9de4019833ccd2c919c2308fdd2d63a2121c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I75d9aa3e75a6fc899f25ffc3108b1ed78f6cb4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397664Reviewed-by:
-
Christian Dullweber authored
ManageSpaceActivity would crash when the manage storage button is clicked because it tried to create the wrong Fragment. This is fixed and a test is added that clicks the button to verify that it works. Asserts are changed to exceptions to get more meaningful errors if there are more false usages. Bug: 1125062 Change-Id: Ie78af6d04c91d4b85b21b04b4f98605e0c4c46a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395498Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#804880}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07d44b97cf65..51932f610c36 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b3510742 to 4a41eb42 (172 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic37b946d08bdb5eb0d206d73f1fcdc793574086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397666Reviewed-by:
-
Takashi Toyoshima authored
As OOR-CORS is fully launched, we don't need these flags to activate some CORS related checks in Blink. Bug: 1053866 Change-Id: I9e0f65768fa151818165e1835318b20c4a612f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397063 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#804878}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5422981b71e3..91fd72f9456b 2020-09-08 changhaohan@chromium.org Add style-map directive from lit-html 2020-09-08 spctstr@gmail.com Add filter for full request url in network tab 2020-09-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104188 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8abc0eace54b6aa6ecbc39f29ae6f1a54b346567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397667Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599525924-8e0161c47f5f22554f3324d544d18a882035921a.profdata to chrome-win32-master-1599540720-2c8a746fd34db3cbe60ec0abca5753030633ccf0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I98d05847fd7d9ed6889469f3fa1634fb109417dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397658Reviewed-by:
-
Paula Vidas authored
Before this CL, LocalDeviceInfoProvider was observing SyncInvalidationsService and caching state internally. After this CL, it instead queries the same information on demand through DeviceInfoSyncClient. This change is needed because with the current implementation, it's not possible to resend device info when FCM token or interested data types change. Bug: 1102336 Change-Id: Ic18f164014b899daa38b1570b2a984805365f384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396142Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#804875}
-
Martynas Sinkievic authored
Change the form sectioning so that a new section is created when a FULL_NAME is encountered after seeing a LAST_NAME field, since this most likely implies a full name has already been given and a new one should be entered. Bug: 1113970 Change-Id: Ibdc33dfc70c8baf60f37e7dff4a56dff0bd00c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346305Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#804874}
-
Pavol Marko authored
Add CertProvisioningSchedulerObserver which can be used to get notifications about state changes regarding the set of workers / the set of failed cert profile ids / states of individual workers. The CertProvisioningWorker gets a StateChangeCallback to be able to report state changes back to the owner (the CertProvisioningScheduler). Bug: 1081396 Test: unit_tests Change-Id: Ib41f2913edbefdffb250aba417dca5ace9e85dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339997 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#804873}
-
Antonio Sartori authored
Bug: 1094909 Change-Id: Ia823b00ae5f62188547f714026d7dece11b9933e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351771 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#804872}
-
Alice Wang authored
This CL fixes the threading bug for ChromeBackupAgent. Bug: 1121344 Change-Id: I1fb2e1935ac602db70a660dc468bf89016f0873f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391142 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804871}
-
Gauthier Ambard authored
The test is flaky on iOS 12. Fixed: 1095534 Change-Id: I31acfa4187a3e14edd76914131d08b35beff30ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396115 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804870}
-
Alexander Timin authored
WebContentsImpl is a major class responsible for routing many events between different parts of //content and between //content and the rest of the codebase (e.g. //chrome and //components). Add trace events to all non-trivial methods to ensure that it's possible to understand the execution flow from reading the trace. Together with crrev.com/2343269 this in particular would allow the user of the tracing to know which WebContentsObserver notifications were dispatched. R=nasko@chromium.org BUG=1043616 Change-Id: If00550c233ab16186a2ebf9f4042c5f1fd457fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240326 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804869}
-
Pavol Marko authored
Adds additional errors to the cert provisioning result: BAD_PUBLIC_KEY: the backend has performed some checks on the client-provided public key and did not accept it. Also improve comment. Bug: 1045895 Test: compiles Change-Id: I161519c831829677ce911ca190569e4fcbf5d207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390907Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
-
Kent Tamura authored
- This directory depends on html/parser:parser, which is a part of "core", but "core" didn't expose it. This CL has no behavior changes. Bug: 800764 Change-Id: I54c621d93b0fc3959197d88ec7363f2670060e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397456 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#804867}
-
Victor Hugo Vianna Silva authored
The motivation is that AndroidSyncSettings will soon have different behaviors depending on Chrome's startup state, so we need to be able to fake the appropriate state in tests before actually constructing the object. We also take the time to update some documentation of this class that became inaccurate with crrev.com/c/2366895. Bug: 1125622 Change-Id: I7fd0399bcb49024f151b78c7a234f99601481948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396335 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Antonio Sartori authored
After reimplementing Content-Security-Policy: Embedded Enforcement in services/network, I forgot to port some unit tests for the subsumption algorithm from blink. Bug: 1094909 Change-Id: Idfc2a47d791f6eb85190757e12933fffe270cb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349298 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
Michael Lippautz authored
CTWP is a weak ref used on a different thread than the object has been original been allocated on. Using the object directly is inherently unsafe as garbage collection only consider the stack of the thread the heap is attached to. For that reason, working on an object must require a strong reference. Note that this does not rule out issues, as the originating thread may terminate in which case even the strong CrossThreadPersistent does not keep the object alive. Nonetheless, the only valid use case of a CTWP should be weakly pointing to an object. The CL introduces a Lock() call, similar to std::weak_ptr::Lock() with the same semantics: The reference (CTP) needs to be check against cleared'ness before the object can be used. Blink: Most use cases rely on external synchronizations when accessing a CTWP, so this change merely hardens the API but likely does not fix any real issues. Bug: 1125495 Change-Id: Ib859df5e9c5f418aa36797c4bd9a444de8c82b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391231 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804864}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cafd6b657827..5422981b71e3 2020-09-08 chrche@microsoft.com [network] Fix Null Pointer Exception with data grid createCells If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0923c2f56d0465e18e02ea2a7fd99d272b1f9c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397012Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599436335-52e1c862010d0691dd04c2a7a430ef4fc681e61e.profdata to chrome-mac-master-1599544645-2607fe83108ec346cd143f52f7129c53aeca332a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I900e99e7be26b49c75ffdfa8d8e1e2b556b14710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397663Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic99591d89663524d2391a5d134474b4f4267548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397014Reviewed-by:
-
Side Yilmaz authored
AsyncInitializationActivity preconnects with always regular profile, even called in incognito. However preconnect should be blocked for OTR profiles, since LoadingPredictorFactory doesn't support OTR profiles. This CL checks the extras of intent and blocks the preconnect if there is any extra related to incognito. Note that, this code block will be called by IncognitoCCT that has non-primary OTR profile. Hence, we need to block this flow not to cause data leakage from OTR profiles to regular profile. Bug: 1041781, 1075562 Change-Id: I1365bdfa9b63c8e904740d3ffaccc34a628b6caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379892Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804860}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/390014529fa1..cd54c8385c31 2020-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 72f6b99c29f2 to 07d44b97cf65 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I473225281685b5c5c9d9e8032f04ab249f90c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397657Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 7e47f6d4. Reason for revert: Possible culprit of failures on Linux Tests (dbg)(1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/b8870138525564824400 All failing tests have the following lines: LaunchProcess: failed to execvp: xdg-desktop-menu No such file or directory LaunchProcess: failed to execvp: xdg-icon-resource Original change's description: > Improved error reporting when execvp fails > > Currently the execvp fails for a launch process it does not give > much diagnosis. This change reports the errno reason why the execvp > failed. This has been useful in finding simple naming errors. > > Change-Id: Ifcc33c87931535019d8509234818c9d995fa4b9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383292 > Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804383} TBR=penghuang@chromium.org,dcheng@chromium.org,rsesek@chromium.org,fangzhoug@chromium.org,petermcneeley@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1b39de8b004e4318560c8a304043057d040f2e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397476Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#804858}
-
danielng authored
Some minor changes for cleaning up some of the installer code and making it more testable. Unit tests being introduced here CL:2392163 and browser tests here CL:2392285. Tests: Tested manually on my test device and ran the new tests. Bug: b:161650651 Change-Id: Ia241ec790096b33b56b54fcb579b08eef3a9ace8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391891 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#804857}
-
Antonio Sartori authored
This CL adds one missing step to the Subsume algorithm of the services/network Content-Security-Policy module, checking the plugin-types directives Although the plugin-types directive is ignored in the current version of the spec https://w3c.github.io/webappsec-cspee, subsumption is already being checked in the blink module, and we reimplement the same logic here. Bug: 1094909 Change-Id: Iae43bac96b111667623cad923f913165c8f02c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346356 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL adds the MVC elements of the incognito interstitial view and also adds the functionality of the "Learn more" and "Continue" buttons. This CL also adds Robolectric tests to tests the Incognito Interstitial delegate. The instrumentation tests would be followed up later. The strings to the incognito interstitial would be added later. Bug: 1120350, 1119280 Change-Id: I2c212029a6d440f95c074c04b068223dacaaba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359032Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804855}
-
Rakina Zata Amni authored
The equality of the "cross origin isolated" value should not be checked if it's still speculative, and some other cases covered by IsSiteInstanceCompatibleWithCoopCoepCrossOriginIsolation. Bug: 1107814, 1096135 Change-Id: I37152bbc348d598dc4612666bfc181da60e75555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385255 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#804854}
-
Jose Dapena Paz authored
Bug: 957519 Change-Id: I7b763c1d5dee77d3a2b12f5169d6ad86e5dcbc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394164 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804853}
-
phillis authored
This is a reland for https://chromium-review.googlesource.com/c/chromium/src/+/2198369. It adds test for the flow of initiating uninstall and accept/cancel the uninstall action. It also fixes a bug that the autoconfirm for testing is called before the widget is instantiated by |constrained_window::CreateBrowserModalDialogViews| Bug: 1073258 Change-Id: Id0f1fff4bdaa4901b50b3d3c12271d54ad1c2e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382952 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804852}
-
Gauthier Ambard authored
This CL makes sure that the status bar appearance is correctly updated when switching mode (icognito/normal) through opening a new tab. The status bar theme is chosen based on the childViewControllerForStatusBarStyle property of the TabGrid. The notification of UIKit is done at the same time as the child view controller is updated. Fixed: 1122239 Change-Id: I847c4d1d70148cabbd824e4bdb40b7aa6fd50847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395735Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804851}
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8152eec38dd1..fd5a98f6204f $ git log 8152eec38..fd5a98f62 --date=short --no-merges --format='%ad %ae %s' 2020-08-20 hollingum vm_tools: Make concierge boot vm's that are DLCs. 2020-08-19 hashimoto arc: Add arc-host-clock-service Created with: roll-dep src/third_party/cros_system_api Bug: 953544 Change-Id: I1db8914d3d850a43e838c15ac6542433cd695e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397124 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
-
