- 06 Mar, 2019 40 commits
-
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6d65c60fca0e..31757f969fba $ git log 6d65c60fc..31757f969 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 wl [base] Handle numeric overflow (#55827). 2019-03-05 sebras Fix use of uninitialized memory. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Bug: chromium:937572 PDFium-Change: https://pdfium-review.googlesource.com/c/pdfium/+/51511 Change-Id: Ia7be5319379c54f1499dbe582ff94c46abad9083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504002 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#638131}
-
Zakhar Voit authored
Recommended flag was ignored (resolution was always forced) when either internal or external configuration was not set. Bug: 938859 Change-Id: Ic60bb9b8ca4dac1b00fd396c92aa1f8a9ef85e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505437Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#638130}
-
Jérôme Lebel authored
Autocomplete wallet needs to be explicitly turned on when the user turns on sync everything. Bug: 938012 Change-Id: I2c90e592a39b6f305c0c4212b2ef7d1eadcf1681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505497Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638129}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1558ed6d1d1..141258c373d9 Created with: gclient setdep -r src-internal@141258c373d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Ie8cef77ae3fa2a6d155b06bfd93463fe26f4fb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505975Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638128}
-
Peter E Conn authored
Bug: 938836 Change-Id: Ib9b4ade4104485f28704f41f8108b93d39c7a5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505556Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638127}
-
Owen Min authored
This reverts commit 43e1f5d7. Reason for revert: Revert didn't fix the flaky test, reland the CL. Original change's description: > Revert "innerText setter should not modify an existing Text child" > > This reverts commit 976ec7a9. > > Reason for revert: crbug.com/938591 > > Original change's description: > > innerText setter should not modify an existing Text child > > > > We have an optimization reusing a Text child, but the standard doesn't > > define such behavior, and Edge, Firefox, and Safari don't have it. > > > > This CL might regress benchmarks. We'll accept it. > > > > Bug: 573309 > > Change-Id: I3aacae5d37e5a7685ce2d310944dfef8d6e4b13a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502338 > > Commit-Queue: Kent Tamura <tkent@chromium.org> > > Auto-Submit: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637665} > > TBR=yosin@chromium.org,tkent@chromium.org > > Change-Id: Ib1884d8b20d9c8d10fc1566498cbdd719cc97b50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 573309 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504128 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637805} TBR=yosin@chromium.org,tkent@chromium.org,zmin@chromium.org Change-Id: Id66ace389fd1b318b57b598e462182155a5f9d0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 573309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505997Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638126}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/dc3db3a5ae5e..03a081524afa git log dc3db3a5ae5e..03a081524afa --date=short --no-merges --format='%ad %ae %s' 2019-03-06 cepheus@frii.com Make all "IdScope" be either Execution or Memory. Created with: gclient setdep -r src/third_party/spirv-headers/src@03a081524afa The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1693c0569bca15cffa5b609612f2d7349c0517bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638125}
-
Gauthier Ambard authored
This CL removes the _webStateImpl, _webView, _userInteractionRegistered, _nativeController. Remove _jsInjectionReceiver and create a readonly public property instead of just an accessor. Bug: 938255 Change-Id: I3af15444bc483dd19076180644eeb6be8770086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503577 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638124}
-
Rijubrata Bhaumik authored
flags: Assign ownership of the "enable-webnfc" flag. Setting expiry milestone to be M79. We will update the status if there are any changes. Bug: 520391 Change-Id: I64e46a4da6abcb4c47947c4928f4ae981880a369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505496 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638123}
-
Mohamed Abdelhalim authored
This CL moves the usage of starting_site_instance_, site_url and expected_render_process_host_id from NavigationHandleImpl to NavigationRequest. With this, these functions were also moved: NavigationHandleImpl::UpdateSiteURL NavigationHandleImpl::SetExpectedProcess A new function is introduced, NavigationRequest::ResetExpectedProcess for refactoring. Change-Id: I92fd557b05108b2bf6b786e6467311e67791ce7d Bug: 916537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481322Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Cr-Commit-Position: refs/heads/master@{#638122}
-
Gauthier Ambard authored
If the pasteboard is containing a URL, the omnibox popup suggestions is displayed as soon as the omnibox is focused. If the fake omnibox animation is triggered at the same time, it is possible to see the NTP going up where the real omnibox should be displayed. This CL fixes it by removing the animation of the fakebox is the popup is opened. Bug: 938077 Change-Id: I74bd6f124da948e98f661cb9c00db2d95ede0930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503455 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638121}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/cc4a756d48e9..79d25ea0ce18 git log cc4a756d48e9..79d25ea0ce18 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 johnkslang@users.noreply.github.com Merge pull request #1714 from jeffbolznv/volatil Created with: gclient setdep -r src/third_party/glslang/src@79d25ea0ce18 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0f9dc0d369b45b5172123d1b4c1251710961e67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505974Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79ffd9b5..028b41c5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2bf0da37afb66b28eab89f73d8027b5f935e8f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505835Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638119}
-
Eric Seckler authored
Might have snuck in during the refactor :) Change-Id: Iacb0743719deae0c998066226db4198492c15ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505634Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#638118}
-
Marc Treib authored
This groups the prefs into actual user preferences vs internal/bookkeeping ones, and updates some comments. Bug: none Change-Id: If3a9dc98ba4f6f26f76a69158fa839d281597d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505442 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638117}
-
Karolina Soltys authored
Bug: 938316 Change-Id: I442d2adcf949227f91a1111921d609d908670953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503736 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638116}
-
Matthew Braithwaite authored
Change-Id: I73c812b724692657b2f3b02067e4aa93d5fb27e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504846 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#638115}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47a505533310..8defcc15b1b8 git log 47a505533310..8defcc15b1b8 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 robertphillips@google.com Update YUVA mipmap generation path to take a GrRecordingContext Created with: gclient setdep -r src/third_party/skia@8defcc15b1b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I74395ac1817c37431a157b2b64ee51f284d86ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505972Reviewed-by:
-
Hazem Ashmawy authored
Mirror WebView Js console messages to logcat only if the application or the device is debuggable. Bug: 905251 Change-Id: I934e20a6881413b17c4f2b6221a0a4e9a15a53bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496364 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#638113}
-
Sergiy Belozorov authored
R=dvadym@chromium.org, perezju@chromium.org Bug: 938487 Change-Id: I86a68f29fb1ad55e80b10893d0fb038c4409e200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505439 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638112}
-
Takuto Ikuta authored
I will deprecate deps in proto_library for improved build throughput. And we can use proto_deps here instead. Bug: 938011 Change-Id: I4ce34aec6299e1eb2b70436714a5d02031041859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504604 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638111}
-
Takuto Ikuta authored
This copy was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/746990/ But seems not necessary, can we remove this? Bug: 938011 Change-Id: Ie32bd7737abd1353f33fb4a52068539af4d06731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504481 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
W. James MacLean authored
When attaching WebContents into the WebContentsTree, the inner WebContents may have child nodes. If so, they will have registered their FrameSinkIDs with the inner WebContent's InputEventRouter. and will not received events that are routed by the outer WebContents' (or higher) InputEventRouter. In this CL, we make sure that not only does the inner WebContents register its FrameSinkID (thus attaching to the appropriate InputEventRouter), but all the child WebContents do so as well. Bug: 768526 Change-Id: Ib1aaf9f04beee1f53c78aa04f6abfaa98c4bfa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498458 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#638109}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31e0aecb035f..a1558ed6d1d1 Created with: gclient setdep -r src-internal@a1558ed6d1d1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I19c8b08cac2502116c1ba620d152b2e551d2eb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505892Reviewed-by:
-
Yi Gu authored
We used to have will-change: transform in test reference but they are no longer needed. Change-Id: Ib6870863760e32de201a0560fa59f43634c72da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504711 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638107}
-
W. James MacLean authored
This CL removes a helper class, InnerWebContentsHelper, that is no longer needed since the associated bug has been resolved. TBR=alexmos@chromium.org Bug: 821187 Change-Id: I2bdbe77f995b31d727e10bd5e6a86e3d636e0cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505834Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#638106}
-
Michael Lippautz authored
With unified heap TraceWrapperMember is deprecated and we need an alternative way to produce heap snapshots in the case (a) we are interested in JS objects, and (b) in the case we are interested in the full unified object graph. This patch provides a new way to generate the snapshot for V8 embedders and performs the following operations: - Objects are classified as attached, detached, or unknown. - Depending an implicit mode, objects are classified as relevant or internal. This classification happens based on NameTrait and the fact that all ScriptWrappable objects (those that can have JS properties) are using that trait. - Not relevant objects are filtered where possible, e.g., sub graphs of internals are filtered and not reported. The algorithm performs a single pass on the graph, starting from V8-to-Blink references that identify attached nodes. Each object then starts a recursion into its own subgraph to identify and filter subgraphs that only consist of internals. Roots, which are potentially Blink only, are transitively traversed after handling JavaScript related objects. Change-Id: I746930e0ede6b18d6942d9bfcef4950f13aea967 Bug: 936797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499567Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638105}
-
Gauthier Ambard authored
This CL groups the private properties together. Bug: 938255 Change-Id: I27345e69ee48593c5fc30e02913b5fae95a82cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503327 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Lowell Manners authored
IdentityAccessorImpl is being migrated to use IdentityManager, the new interface for external clients to Identity. Change-Id: Iad5cef7d8f4fe069516f35e17a23d6363f3533c9 Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499454Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638103}
-
Kent Tamura authored
Bug: crbug.com/894661 Change-Id: I1df3af43ec2818f181eff99277c1d14c0dd3bb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502772 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#638102}
-
dalyk authored
CT log inclusion checks use secure DNS if the associated hostname lookup was resolved securely; otherwise the CT log inclusion checks use insecure DNS. Bug: 878582 Change-Id: Iaaa47078a7278576811c70cb95430a6e116c6c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480547 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#638101}
-
Richard Townsend authored
Makes LapTimer (which provides a runs per second figure) accessible to base_perftests benchmarks by updating it and moving it into base/. Bug: 908966 Change-Id: I7913ea8e37b04d5309bed577dbdc54d98df971c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1353950Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#638100}
-
Gauthier Ambard authored
This CL puts all the public methods together. It also moves webState, webStateImpl and scrollPosition to private properties. Bug: 938255 Change-Id: Ic2b9870da254f538c201893dad87a99f4d18c216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503323 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Saman Sami authored
The current logic is probably wrong if a client changes its embed token. Bug: 931801 Change-Id: I9ce49fa2fd8efccd5a556483d6c24bb81d95a783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504212 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#638098}
-
Marc Treib authored
This acts as a killswitch for https://crrev.com/c/1478878. Bug: 938819 Change-Id: I2f724523bd8ceab648998d5a656ce4ea88eb2860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505492Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638097}
-
Kush Sinha authored
It was required that |IdentityManager::LegacySeedAccountInfo| be called before calling |chromeos::AccountManager::UpsertAccount| because Chrome OS Account Manager's |Observer|s needed to translate |chromeos::AccountManager::AccountKey| to other formats (raw email and canonical email) and relied on |AccountTrackerService| / |AccountMapperUtil| for doing so. This is no longer required: - Chrome OS Account Manager can now maintain the mapping from AccountKey to email id by itself (https://crrev.com/c/1452003) and can notify its |Observer|s about this information (https://crrev.com/c/1477691). All new account additions to Chrome OS Account Manager are now guaranteed to have an email id associated with them in Account Manager itself. - AccountMapperUtil has now been deleted (https://crrev.com/c/1483024). Hence, remove the temporal coupling between |IdentityManager::LegacySeedAccountInfo| and |chromeos::AccountManager::UpsertAccount| in all production call-sites. This seeding of AccountInfo will now be handled within |ChromeOSOAuth2TokenServiceDelegate::OnTokenUpserted|, just after the account gets added to |chromeos::AccountManager|. Bug: 922026 Change-Id: I77cdaa93ef34fc400f00a09aee8d9d847ef0fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495551Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Bryan McQuade authored
This implements support for tracking performance metrics for AMP documents loaded in subframes. This is something we'd wanted to implement but weren't sure how to implement. After discussion with AMP team we determined that we should take the following approach: * whenever the main frame URL gets updated with an AMP viewer URL (e.g. https://www.google.com/amp/...), we track that in OnCommitSameDocumentNavigation. we use the time of the main frame URL update as the baseline time from which the user-perceived performance metrics like FCP are computed. * whenever an iframe AMP document is loaded, we track that in OnDidFinishSubFrameNavigation. we also keep track of the performance timing metrics such as FCP reported in the frame. * we associate the main frame AMP navigation with its associated AMP document in an iframe by comparing URLs between the main frame and the iframe documents. * we record AMP metrics at the times when an AMP viewer URL is navigated away from. when a user swipes to change the AMP document, closes a tab, types a new URL in the URL bar, etc, we will record AMP metrics for the AMP doc in an iframe that the user is navigating away from. Change-Id: I08c36148907145ea89aa24652ed7efc9ed863757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500202 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638095}
-
Yi Su authored
This CL moves helper function "PreferredFontForTextStyleWithMaxCategory" from uikit_ui_util.mm to dynamic_type_util.mm, and adds some unittests. Change-Id: I08620274827845d58a9a4cced1c91b849c5da91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496857 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638094}
-
Ben Wagner authored
This allows gn to check FreeType includes. Change-Id: If9fe723e876e88164fa95191f8384d6805056b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504235 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Boris Sazonov authored
If Mirror header has a service type GAIA_SERVICE_TYPE_SIGNUP or GAIA_SERVICE_TYPE_ADDSESSION, start an activity to add an account to the device. Bug: 938554 Change-Id: Ib2d77afaa3434941c0597026211fa3d03292e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504016 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
