Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jan, 2018 30 commits
  3. 27 Jan, 2018 10 commits
    • Nico Weber's avatar
      Work more on getting things built with -Wimplicit-fallthrough. · 88cb4047
      Nico Weber authored 
      This CL was uploaded by git cl split.

R=eae@chromium.org

Bug: 177475
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3a861bf5eb39da51b628eafae99d0bff3ebfab39
Reviewed-on: https://chromium-review.googlesource.com/889728Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532255}
      88cb4047
    • Vaclav Brozek's avatar
      [Android password settings] Separate timer for export · 2ed20c91
      Vaclav Brozek authored 
      The user needs to reauthenticate both to view/copy and to export
passwords. Once reauthenticated, the authentication is skipped for the
next 60 seconds.

Through authentication, the user grants an easy access to anybody
holding their device in the next 60 seconds to the passwords on their
device.

The explanation message of the reauth prompt includes the scope of the
approval (e.g., "to view your passwords" or "to export your
passwords") of the _first_ reason to reauthenticate.

To protect the privacy of the user, if they grant the access for a
one-at-a-time access (e.g., viewing passwords) but then a bulk access
(e.g., export of all passwords) is requested within the grace period
of 60 seconds, Chrome ignores the grace period and requests the reauth
again.

Bug: 800686
Change-Id: Icc96bf490b13ba7ba172bc88fdef0ffdefaf97f2
Reviewed-on: https://chromium-review.googlesource.com/883525
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: default avatarBernhard Bauer <bauerb@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532254}
      2ed20c91
    • Scott Violet's avatar
      Changes ordering so that ConfigurationPolicyProviders are set earlier · 615e458c
      Scott Violet authored 
      Specifically this converts back to setting the
ConfigurationPolicyProviders *before* the PolicyService is created.

There is a subtle difference between this code and the way the
code was before my patch. Specifically previously the code did
the following:

1. ChromeBrowserPolicyConnector created, which added a bunch of providers
   from constructor.
2. BrowserPolicyConnectorBase::GetPolicyService is called, which creates
   the service and pushes the providers to the PolicyServiceImpl
3. local state/field-trials created.
4. BrowserPolicyConnector::InitInternal was called, which in turn
   called Init() on the providers.

With this patch, order is now:

1. ChromeBrowserPolicyConnector constructor does very little
2. ChromeBrowserPolicyConnector::InitPolicyProviders is called, which
   creates the providers.
3. BrowserPolicyConnectorBase::SetPolicyProviders is called, which
   creates the PolicyService and calls Init() on all the providers and
   sets is_initialized_.
4. BrowserPolicyConnectorBase::GetPolicyService is called, creating
   the PolicyService.
5. local state/field-trials created.
6. BrowserPolicyConnector::InitInternal is called.

Key differences:
. ConfigurationPolicyProvider::Init() is called earlier.
. Had to remove DCHECK in BrowserPolicyConnector::InitInternal() because
  SetProviders sets is_initialized_.


BUG=806538
TEST=none

Change-Id: I0981419cb1734208789639cc1713e49ac8e901c7
Reviewed-on: https://chromium-review.googlesource.com/889500
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532253}
      615e458c
    • John Chen's avatar
      Reland "[ChromeDriver] Add ChromeDriver tests to Commit Queue" · cde8919d
      John Chen authored 
      This is a reland of aa7860c7,
with the change to enable the ChromeDriver tests on release bot only.
The original commit was reverted due to flakiness of the tests on debug
build. The reason for the flakiness is debug build of Chrome takes a
long time to start, usually between 20 to 40 seconds. The timeout for
the test is 30 seconds, thus it can either succeed or fail depending
on whether Chrome started quick enough or not.

While it is possible to increase the timeout, spending over 30 seconds
per test appears to be too much overhead in the long run. Also, the
purpose of running these tests is to catch incompatibilities that can
develop between Chrome and ChromeDriver, and running these tests on
release builds should suffice for that purpose.

Original change's description:
> [ChromeDriver] Add ChromeDriver tests to Commit Queue
>
> This is the initial check-in of the feature to add ChromeDriver tests
> to commit queue. It includes the following:
>
> * A new test target chromedriver_py_tests, to encapsulate dependencies
>   needed to run the Python-based ChromeDriver tests. This target is
>   currently enabled on Linux only. Other platforms will be added later.
>
> * Only a single test case is enabled. Enabling additional test cases
>   will be done later.
>
> Bug: 793370
> Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47
> Reviewed-on: https://chromium-review.googlesource.com/874816
> Commit-Queue: John Chen <johnchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531234}

Bug: 793370
Change-Id: Ic8873c326dfcd676552083d6f90aba29cc046e67
Reviewed-on: https://chromium-review.googlesource.com/885082Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532252}
      cde8919d
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ fc2000881..d3c1b84a6 (2 commits) · 6cc85e0c
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/fc20008819f3..d3c1b84a6e26

$ git log fc2000881..d3c1b84a6 --date=short --no-merges --format='%ad %ae %s'
2018-01-27 fmalita [skottie] Render DM frames out-of-order
2018-01-27 mtklein Revert "hide picture virtuals (no public callers)"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I02b187e0d3afe1434aeb43bff6e54f8785c0d303
Reviewed-on: https://chromium-review.googlesource.com/890460
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532251}
      6cc85e0c
    • Chromium WPT Sync's avatar
      Import wpt@4bc45de5dee49a428a3bd9b0fae3632f3114749b · 9e6fa610
      Chromium WPT Sync authored 
      Using wpt-import in Chromium 712abc66.
With Chromium commits locally applied on WPT:
9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11096

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-writing-modes

TBR=leon.han@intel.com

No-Export: true
Change-Id: I7e040b7dabbfa5217aa0d5240f4d71ad1464d4e7
Reviewed-on: https://chromium-review.googlesource.com/889952
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532250}
      9e6fa610
    • Tom Anderson's avatar
      Fix build with glibc 2.27 · 9f63f94a
      Tom Anderson authored 
      BUG=806340
TBR=hamelphi@chromium.org

Change-Id: Ib4e5091212d874d9ad88f3e9a1fdfee3ed7e0d5e
Reviewed-on: https://chromium-review.googlesource.com/890059Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Reviewed-by: default avatarPhilippe Hamel <hamelphi@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532249}
      9f63f94a
    • dpapad's avatar
      WebUI: Update Polymer paper-{tabs,spinner,listbox} to 2.x. · 7909ce40
      dpapad authored 
      Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3ebeca61c483721c96b597c406910637d920fcb
Reviewed-on: https://chromium-review.googlesource.com/887558Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532248}
      7909ce40
    • Thomas Anderson's avatar
      Revert "FrameSinkVideoCapturer: Fix refresh logic for damaged sources." · 52c31b74
      Thomas Anderson authored 
      This reverts commit 93f7aa87.

Reason for revert: Causes failure in WebContentsVideoCaptureDeviceBrowserTest on Linux Tests (dbg)(1)(32):
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/47651

Original change's description:
> FrameSinkVideoCapturer: Fix refresh logic for damaged sources.
> 
> Fixes a couple of issues where frame capture becomes frozen or choppy,
> with the following changes:
> 
> 1. Move the "source dirty" logic out of VideoCaptureOracle and into
> FrameSinkVideoCapturerImpl.
> 
> 2. More-agressive response to frame refresh requests (needed for
> improved mouse cursor update response).
> 
> 3. Remove the distinction between passive and active refreshes from
> VideoCaptureOracle. FrameSinkVideoCapturer now tracks source damage, and
> can execute any refresh passively when there is no damage.
> 
> 4. Add logic to ensure that FrameSinkVideoCapturerImpl provides
> consumers with a refresh frame whenever key events occur; such as params
> changes, capture target changes, etc.; that are known to require a full
> update.
> 
> 5. Re-enable the content_browsertests that were disabled due to
> flakiness.
> 
> Bug: 785072, 754872
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I402f3f928de61e6754e04014327421e4f6917d5f
> Reviewed-on: https://chromium-review.googlesource.com/884996
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532161}

TBR=miu@chromium.org,kylechar@chromium.org,xjz@chromium.org

Change-Id: I32fd2fb0bf1e1dc32c026198809d12ff2ecc69f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785072, 754872
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/890380Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532247}
      52c31b74
    • dpapad's avatar
      MD Extensions: Surface ExtensionInfo runtimeWarnings in the UI. · fb85136d
      dpapad authored 
      Bug: 800773
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I546e25b3748e455449ee3c0a541c5a6658ee2504
Reviewed-on: https://chromium-review.googlesource.com/884847
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532246}
      fb85136d