- 25 Jun, 2018 40 commits
-
-
Steven Bennetts authored
Bug: 798569 Change-Id: I68aa4c7f08458324a6a59aa9cd2d8bfafeb95c99 Reviewed-on: https://chromium-review.googlesource.com/1111024 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570173}
-
Tom Anderson authored
Sized deletion was added in c++14. Now that Chrome is building with c++14, we must override sized operator delete for symbol linkage consistency (see bug 855773). R=thakis BUG=855773 Change-Id: Idb673307939119ec520f71911e2074db2496b5ae Reviewed-on: https://chromium-review.googlesource.com/1112731 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570172}
-
Aleks Totic authored
Part 1: PhysicalLineFragment ScrollableOverflow ScrollableOverflow was not taking relative position into account. PhyiscalLineFragment used to recompute overflow when created. This can't be done if relative position is needed, because resolving % relative position needs size of containing block. New code computes ScrollbleOverflow dynamically for PhysicalLineFragment. Part 2: Make RelativeUtils API physical. It is a better fit for PhysicalFragments. Part 3: NGMixin::AddScrollableOverflow should also add overflow from oof children. Another tricky bug: If ContainingBlock() is inline, Legacy positions OOF block wrt inline block, while NG positions OOF block wrt inline's block container. Because OOF blocks affect scrollable overflow, NG must be responsible for making sure OOF block is included in container's overflow. This patch makes 3 tests pass, and 1 new test fail: compositing/culling/tile-occlusion-boundaries.html The failure is caused by NG not using transfroms for scrollable overflow computation. To fix this, we must make fragments tranform-aware. Filed a bug to do so. Bug: 728378 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib511a95cc71648e806d0cc1376f1f6303152ecee Reviewed-on: https://chromium-review.googlesource.com/1113030 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570171}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed55419d859b..ff168d9258e0 git log ed55419d859b..ff168d9258e0 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 bsalomon@google.com Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists. 2018-06-25 enne@chromium.org Validate transformed SkPaintImageFilter rects 2018-06-25 hcm@google.com update externally published milestone schedule 2018-06-25 reed@google.com remove bad assert Created with: gclient setdep -r src/third_party/skia@ff168d9258e0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 852048,chromium:855854 TBR=jcgregorio@chromium.org Change-Id: I66cbf0f9efc9793ac60c1d969b4ad7207eea857e Reviewed-on: https://chromium-review.googlesource.com/1113825Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570170}
-
John Abd-El-Malek authored
Bug: 844927 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib0b437f76822800bc393253250ed2660527f276b Reviewed-on: https://chromium-review.googlesource.com/1110666Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570169}
-
Peter Kasting authored
Callers outside Tab only referred to the vertical insets, which are now either 0 or Tab::GetStrokeWidth(), a new function added for this purpose, depending on the context. Inside Tab this is subsumed into GetTabEndcapWidth(), which itself has been split into two parts: a general-purpose routine and a pre-refresh-specific "paint" width routine. This may be cleaned up further depending on how I solve narrow tabs in the end. BUG=none TEST=none Change-Id: Ifca96b76b694f3f922e0252cf5198c7a9bb475e3 Reviewed-on: https://chromium-review.googlesource.com/1112773Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570168}
-
Hongchan Choi authored
AudioIOCallback is specifically designed for real-time audio IO and is not appropriate for AudioDestinationNode. This CL moves the class to DefaultAudioDestinationNode. Bug: 854229 Change-Id: Icb0df6414b944ea1dde3e957d2f36c314b079e0e Reviewed-on: https://chromium-review.googlesource.com/1113955Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570167}
-
Kenneth Russell authored
There aren't enough Windows AMD machines to run this test suite on AMD GPUs against all ANGLE CLs. The suite runs on NVIDIA and Intel GPUs, and the AMD-specific version doesn't catch many errors at this point, so accept the potential for waterfall-only failures. Bug: 854698 Tbr: geofflang@chromium.org Change-Id: Ifaacd8f559ab339bde24d345548fdf5257d6082e Reviewed-on: https://chromium-review.googlesource.com/1112766Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570166}
-
manuk hovanesian authored
This reverts commit b7e58d9d. Reason for revert: Introduced regression issues relating to omnibox text being cleared. Original change's description: > omnibox: reset display url when re-navigating to the current page by clicking a link > > Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. > > Bug: 830491 > Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 > Reviewed-on: https://chromium-review.googlesource.com/1103233 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568831} TBR=tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830491 Change-Id: If20093795454513c9734fa2c8ed686843e83a683 Reviewed-on: https://chromium-review.googlesource.com/1113879Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570165}
-
Jordy Greenblatt authored
Change-Id: Ia035745cc311bb7683ad74a446e60468f4dbacaf Reviewed-on: https://chromium-review.googlesource.com/1114082Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#570164}
-
Nico Weber authored
Reapplies https://chromium-review.googlesource.com/c/chromium/src/+/757880, which got removed in https://chromium-review.googlesource.com/c/762380/ when we removed all crashpad_tests from all win/asan bots. crashpad_tests runs on the win/asan bots again, so this one test needs to be disabled again. (See bug; root cause bugs.llvm.org/PR35137) Bug: 856174 Change-Id: I0796efd9ba306ea5a304a5ae85eeb4af9eec656e Reviewed-on: https://chromium-review.googlesource.com/1113664Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570163}
-
Xianzhu Wang authored
- Remove unused parameters of BoxClipper, RoundedInnerRectClipper and BoxPainterBase; - Remove accumulated scroll offset from PaintLayer; - Remove PaintLayer::MaskBlendingAppliedByCompositor() which always returned true for SPv175. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4295b6d770294e3ab18a084a88887ec1a17131b9 Reviewed-on: https://chromium-review.googlesource.com/1112954 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570162}
-
Ehsan Karamad authored
The test virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html times out on Linux and Windows quite regularly and is not supported on Mac. Instead of pass-timeout just skip it. TBR=foolip@chromium.org Bug: 853852 Change-Id: Id1e14f95284c93b680e71d27055f107c54e52352 Reviewed-on: https://chromium-review.googlesource.com/1113663Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570161}
-
Nico Weber authored
Introduce a move-only ScopedWlArray to make sure all wl_arrays in the tests get wl_array_release()d when they are no longer needed. Also rename SetWlArrayWithState() to AddStateToWlArray() since it appends to its argument and doesn't replace the contents (this part has no behavior change). TBR=kbr Bug: 855588 Change-Id: I384ca182b44c9cb864d2d3e94c8ed4f0a0a16f77 Reviewed-on: https://chromium-review.googlesource.com/1113658 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570160}
-
Kurt Horimoto authored
This has been renamed to ReadingListListViewAccessibilityDelegate, and its interface has been updated to use ListItems rather than CollectionViewItems so the protocol can be shared between implementations. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ief145a21be03ae1bfeb23419e57875be8128c1d6 Reviewed-on: https://chromium-review.googlesource.com/1102125Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570159}
-
Tessa Nijssen authored
When text is selected in a textfield, the touch bar displays options to replace the selected text. Clicking on one of the options will replace the selected text with the selected option. Currently, there are no functional unit tests for the suggested text touch bar. As functionality is fleshed out, unit tests will be created. A new folder (chrome/browser/ui/cocoa/touchbar) was created to house all files related to the Mac touch bar. The CreditCardAutofillTouchBarController files and the WebTextfieldTouchBarController files were moved to this new folder. Dependencies and header guards were updated to reflect this change. New files: - suggested_text_touch_bar_controller.h - suggested_text_touch_bar_controller.mm - suggested_text_touch_bar_controller_browsertest.mm Moved files: - credit_card_autofill_touch_bar_controller.h - credit_card_autofill_touch_bar_controller.mm - credit_card_autofill_touch_bar_controller_unittest.mm - web_textfield_touch_bar_controller.h - web_textfield_touch_bar_controller.mm BUILD files were updated to accommodate the change in location for the moved files and to include the new files. RenderWidgetHostViewMac now informs its RenderWidgetHostDelegate (WebContentsImpl) when RenderWidgetHostViewMac::OnTextSelectionChanged() is called. WebContentsImpl then notifies its observers that the text selection changed. A feature flag SuggestedTextTouchBar was created and added to chrome://about so that the new touch bar is disabled by default and can be enabled via command line or chrome://flags with the flag This CL includes the following browser tests for SuggestedTextTouchBarController: - SetTextTest - TouchBarTest - TextSelectionChangedTest This is a reland of crrev/c/1096443 with the following addition: A check was added to see if the SuggestedTextTouchBar feature flag is enabled around the initialization of SuggestedTextTouchBarController and its WebContentsObserver. This way, the controller and observer are not initialized unless they are actually going to be used. Bug: 717553 Change-Id: Ib591a6791700f79f8f683ee3f6c629f00b612cb0 Reviewed-on: https://chromium-review.googlesource.com/1101306Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#570158}
-
Victor Costan authored
This CL integrates the following issues: https://github.com/WICG/cookie-store/issues/54 - startsWith -> starts-with https://github.com/WICG/cookie-store/issues/51 - remove cookieStore.has Bug: 729800 Change-Id: If296a9e1eb896cb0ef344a889b1715836610bc6d Reviewed-on: https://chromium-review.googlesource.com/1112912 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570157}
-
Sadrul Chowdhury authored
Change-Id: I6f561871d9f41994519274731bb766dddcad20e9 Reviewed-on: https://chromium-review.googlesource.com/1113823Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570156}
-
rbpotter authored
Bug: 855003 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0b9d3d14c6d1efdbc3b12cfd38d23da4d5d9a112 Reviewed-on: https://chromium-review.googlesource.com/1111336Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570155}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8396e3498fd4..d5b8ee1e175e git log 8396e3498fd4..d5b8ee1e175e --date=short --no-merges --format='%ad %ae %s' 2018-06-25 mbonadei@webrtc.org Re-enable PeerConnectionEndToEndTest.Call on TSan. 2018-06-25 nisse@webrtc.org Delete unused methods for replacing the "default filesystem". Created with: gclient setdep -r src/third_party/webrtc@d5b8ee1e175e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I67a939e672b06578804d0f32aefa4b8cd8717b58 Reviewed-on: https://chromium-review.googlesource.com/1113822Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570154}
-
Fady Samuel authored
We don't need to ship updated RenderFrameMetadata on change in root scroll offset. Shipping RenderFrameMetadata is expensive and so we should minimize shipping them to the browser process as it also involves synchronization with Viz. We initially decided to plumb this value via RenderFrameMetadata in order to properly support the overscroll glow on Android but this turned out to be too expensive and so we are now investigating ways to compute the overscroll glow at least partially in the renderer. Bug: 672962, 855473 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I139f773eaf673785fec04c9f989abb36e0941ad9 Reviewed-on: https://chromium-review.googlesource.com/1113799 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570153}
-
Lei Zhang authored
Change-Id: I6f90580f977ca2ccb19d3f1196bd26bbcbb98898 Reviewed-on: https://chromium-review.googlesource.com/1112909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570152}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id76ef2699bcc5f5e1d316ba27026dcc351bba718 Reviewed-on: https://chromium-review.googlesource.com/1114093 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570151}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ia6d200535697101d6c76edbfe2b117a3f5d3d733 Reviewed-on: https://chromium-review.googlesource.com/1113201 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570150}
-
Peter Mayo authored
Add new bug numbers for types of failures seen in animations failures when enabling blink-gen-property-trees. TBR=flackr@chromium.org BUG=836897 Change-Id: I3375acfaac7470834de65e905714e5244b1715c3 Reviewed-on: https://chromium-review.googlesource.com/1113904Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570149}
-
Ryan Daum authored
Fails in memory sanitizer test downstream. Bug: none Test: unit test Change-Id: If03106801056d192dd70eefd6d4ffaa443505391 Reviewed-on: https://chromium-review.googlesource.com/1114087Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#570148}
-
David Tseng authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I09802d7786ef583c37a33489516eea2200a5d7c1 Reviewed-on: https://chromium-review.googlesource.com/1112584 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570147}
-
Eric Karl authored
Updating owners as khushalsagar@ and ericrk@ have been maintaining compositor_impl_android* and would like owners for this and related android code under renderer_host. Change-Id: I2d549bbfd307c0d6e931bfcb47001e2349b6aace Reviewed-on: https://chromium-review.googlesource.com/1114060Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570146}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/abae09e75336..c8a626f49c09 git log abae09e75336..c8a626f49c09 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 xdai@chromium.org Revert "Add Android mojo_core binaries to Chrome deployment" Created with: gclient setdep -r src/third_party/chromite@c8a626f49c09 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:822034 TBR=chrome-os-gardeners@chromium.org Change-Id: I6f0bc61794ea73128958886893bebc99251997ea Reviewed-on: https://chromium-review.googlesource.com/1113824Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570145}
-
dpapad authored
When disabled, calling click() (which simulates a 'click' event) should not change the state of the toggle. Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2f1950c698fbc99abd7620d1573f592607f160e2 Reviewed-on: https://chromium-review.googlesource.com/1112719Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570144}
-
akaba authored
This CL rewires zoom to use surface synchronization instead of page messages which solves the problem of OOPIFs zooming faster than their embedding frame, In other words this allows zoom to be executed atomically for a web page containing OOPIFs. Design Doc (Draft): https://docs.google.com/document/d/1J7BTRsylGApm6KHaaTu-m6LLvSWJgf1B9CM-USKIp1k/edit?usp=sharing Bug: 819611,672962 Change-Id: Ifc61b47886fd8ebd99c98851442b9caf59905413 Reviewed-on: https://chromium-review.googlesource.com/1095557 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#570143}
-
Kyle Horimoto authored
This class verifies that this device can connect to the currently-set MultiDevice host. The verification process consists of creating a Bluetooth connection to the device, performing an authentication handshake, and enabling the per-device features which are supported. This CL adds an abstract class, test double, and stub implementation. The actual implementation is left as a TODO; this CL unblocks some higher-priority work. Bug: 824568 Change-Id: I457a5dae5edf2182f565f782ab201c5505ffb702 Reviewed-on: https://chromium-review.googlesource.com/1112936 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570142}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc00dcbd..031690a9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I21b4ae42e11c13b1f0f28cbb8a6ae04684f1577a Reviewed-on: https://chromium-review.googlesource.com/1113902Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570141}
-
Min Qin authored
This reverts commit c7496eca. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "All callbacks to notify when InProgressDownloadManager is initialized" > > This reverts commit 39c14237. > > Reason for revert: > Broke many tests on many bots, eg. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/1473 > > Original change's description: > > All callbacks to notify when InProgressDownloadManager is initialized > > > > Currently DownloadManagerImpl intializes InProgressDownloadManager. > > However, when only ServiceManager is running, DownloadManagerImpl will > > not be created. > > As a result, some other class will initialize InProgressDownloadManager. > > And when chrome fully starts, DownloadManagerImpl needs to know whether > > InProgressManager has been initialized. > > This CL allows InProgressDownloadManager to take more callbacks to > > notify when initialized. > > So multiple classes can observe the initialization event. > > > > BUG=842245 > > > > Change-Id: I5881b10db0f93f98262ab1baebc67621c2743fbe > > Reviewed-on: https://chromium-review.googlesource.com/1111027 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#569849} > > TBR=dtrainor@chromium.org,qinmin@chromium.org > > Change-Id: Ic2e8b09dc8aca3680c7a5939fdfb545e0dfec82a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 842245 > Reviewed-on: https://chromium-review.googlesource.com/1112977 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569879} TBR=thakis@chromium.org,dtrainor@chromium.org,qinmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842245 Change-Id: I9a2d1e2215f755785190400e554408f3bf2e7de5 Reviewed-on: https://chromium-review.googlesource.com/1113839 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570140}
-
Eric Willigers authored
Spec: https://drafts.csswg.org/css-transforms/#propdef-transform-origin Blink no longer accepts transform-origin 'top 1px'. We previously parsed it as 'top center 1px'. Edge/Firefox/WebKit already reject such values. BUG=855787 Change-Id: I8ac8745d41c867a2ef659ce9afe17143d60a1806 Reviewed-on: https://chromium-review.googlesource.com/1112883Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#570139}
-
George Burgess authored
This reverts commit 9f907acb. Reason for revert: The cause of the failures has (hopefully) been fixed. Original change's description: > Disable failing blink_perf.events story on 5X webview > > NOTRY=true > TBR=nednguyen@chromium.org > > Bug: 851539 > Change-Id: I2128758cdc151cf496ee9485d9f639641bb48c69 > Reviewed-on: https://chromium-review.googlesource.com/1095636 > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566040} Bug: 851539 Change-Id: I46cfb5ff14395207d25c4b1d05bdc479fadcdd47 Reviewed-on: https://chromium-review.googlesource.com/1112517Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570138}
-
Mikel Astiz authored
These tests were believed to be failing or be flaky, but I could not reproduce the failures locally, presumably due to recent improvements in https://chromium-review.googlesource.com/1111716 As it seems, DataTypeManagerImpl's mechanism to defer reconfigurations via |needs_reconfigure_| is sufficient to handle fast enable-disable-enable sequences. Bug: 855375 Change-Id: Iec677202f9db15787da1a62345e09852e84a9f79 Reviewed-on: https://chromium-review.googlesource.com/1111844 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570137}
-
Ted Choc authored
On Android, the InfoBar text layout is handled by Android, which causes the click region fo the links to be very small. For InfoBar messages with a single clickable span, this enables the full text to be clickable. BUG=670340 Change-Id: I1cc2dd0ffd34a583ae2040859b003c33c2e12baf Reviewed-on: https://chromium-review.googlesource.com/1114002 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#570136}
-
James Wallace-Lee authored
When a node's CSS transform changes, the accessibility tree should perform a layout so that focus appears in the correct location. R=dmazzoni@chromium.org, ikilpatrick@chromium.org Bug: 610840 Test: DumpAccessibilityTreeTest.AccessibilityTransform Change-Id: I2517358ea8f8b8a2b24c2daf358dca2058fe1c37 Reviewed-on: https://chromium-review.googlesource.com/1108393 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570135}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07c24bb0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=robertma No-Export: true Change-Id: I3c47d84ce9d69eaf50c9cf479bed37a35c0396fa Reviewed-on: https://chromium-review.googlesource.com/1113907 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570134}
-