- 12 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f75973390723..716adb3d87b3 Created with: gclient setdep -r src-internal@716adb3d87b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41c9e4c57d1a3ac7396c3f1f3605f36d9f1bf3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1331180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607189}
-
Jérôme Lebel authored
MDCShadowElevations.m has been removed from material_components_ios/src/components/ShadowElevations https://critique.corp.google.com/#review/220518015 TBR: rohitrao Bug: 903150 Change-Id: I07d7150b3b4fa2fca01bcbbb718bc4a9c8081f60 Reviewed-on: https://chromium-review.googlesource.com/c/1329250Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607188}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I6992d6773ec3f753fe8c225dee223b522593347b Reviewed-on: https://chromium-review.googlesource.com/c/1323449Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#607187}
-
A Olsen authored
crbug.com/433840 says we should split the read and write path for cros settings (or device settings), which will simplify the read path and get rid of its dependency on the write path. Calls to CrosSettings->Set(kSystemTimezone) don't actually affect signed device settings (unlike other cros settings), but end up calling TimezoneSettings->SetTimezone. We can simplify the cros settings interface by calling this directly. This CL replaces the last call to CrosSettings->Set(kSystemTimezone) with an equivalent call to timezone_util, which also delegates to TimezoneSettings. Bug: 433840 Change-Id: Ibaac986323cb286eab83ec7c0b29780dc2ef7d87 Reviewed-on: https://chromium-review.googlesource.com/c/1326144Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607186}
-
Arthur Sonzogni authored
This test a server redirect, for which the new url is redirected by the extension. The bug caused DumpWithoutCrashing to be reached in: * https://chromium-review.googlesource.com/c/1319710 * https://chromium-review.googlesource.com/c/1316734 The bug is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1326481 Bug: 882661, 880741 Change-Id: I2952dd601fba7fff8b8e110d434413e22e751bba Reviewed-on: https://chromium-review.googlesource.com/c/1328983Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607185}
-
Yutaka Hirano authored
This is preliminary work for reading data pipes in RequestPeer implementations. Bug: 894819 Change-Id: I93ce399fa83796ab6fd095ea7dbf4666fb1458d4 Reviewed-on: https://chromium-review.googlesource.com/c/1312184Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#607184}
-
Colin Blundell authored
This is a drive-by cleanup: On tonikitoo's chain of CLs converting UserCloudPolicyTokenForwarder to IdentityManager, I noticed the CloudPolicyService::Observer::OnInitializationComplete() method. This method is ambiguously named from a client POV, as their override simply ends up being Foo::OnInitializationComplete(). This was especially weird from the POV of UserCloudPolicyTokenForwarder because its implementation of that method starts its *own* initialization, i.e., invokes Initialize() ;). This CL renames the method to OnCloudPolicyServiceInitializationComplete() and additionally eliminates the CloudPolicyService* argument, which is not needed: its only usage is to have a few clients confirm that it is the same as the instance on which they registered as an observer, but this will always be the case by the nature of observer callbacks. Change-Id: Iaf73c26b9b4ad1305ad6774c23da0828200d499c Reviewed-on: https://chromium-review.googlesource.com/c/1329146Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607183}
-
Hirokazu Honda authored
VideoFrameDoneNotifier is unnecessary. It is the helper class to execute a given callback in the destructor. That totally can be done with VideoFrame::AddDestructionObserver. This just removes VideoFrameDoneNotifier. BUG=None TEST=CtsMediaTestCases Change-Id: I30222876159565f2b639d92650d4ab3fa6de385b Reviewed-on: https://chromium-review.googlesource.com/c/1331103 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#607182}
-
Yuki Shiino authored
EventListener::handleEvent => Invoke JSBasedEventListener::CallListenerFunction => InvokeInternal EventListener::Code => ScriptBody Change-Id: I5d73913f5808eb7767cae4e37eeaa437ba3d7e8c Reviewed-on: https://chromium-review.googlesource.com/c/1329123Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607181}
-
Mikel Astiz authored
This cleans up the remaining leftovers of sessions-related logic from interface SyncService, including: 1. The propagation of PROXY_TABS's runtime state directly from the controller to SessionSyncService. 2. The removal of the getter, SyncService::GetOpenTabsUIDelegate(). 3. The removal of SyncServiceObserver::OnForeignSessionUpdated(), now replaced by a new subscription mechanism in SessionSyncService. Besides simplifying core sync code, it also means client code (UI and tests) have less dependencies, since they can now depend exclusively on SessionSyncService. Bug: 883199 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id89410fa7149ae97db8e707adbab331e68d5cb8b Reviewed-on: https://chromium-review.googlesource.com/c/1271101 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607180}
-
Morten Stenshorne authored
LayoutObject::PropagateStyleToAnonymousChildren() doesn't do the right thing for LayoutMultiColumnSpannerPlaceholder. Spanner placeholders need to copy the margins from the actual spanner object, in addition to inheriting properties from the parent of the actual spanner. Bug: 903699 Change-Id: I4252c546610eca2698efd523f98f20a98627d217 Reviewed-on: https://chromium-review.googlesource.com/c/1328986 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607179}
-
Keishi Hattori authored
Converts DOM*, AX*, Event* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I872e34038e2ef3d4c3913d7cd94d1e4da7888ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1331348Reviewed-by:
-
Keishi Hattori authored
Convert SVG* classs allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Ifb603bcec1bae98d3763738627dd06248e8b6dae Reviewed-on: https://chromium-review.googlesource.com/c/1331104Reviewed-by:
-
Mihai Sardarescu authored
This reverts commit ec686dc0. Reason for revert: The fix does not work in all cases and it adds a lot of complexity in the way avatar images are now used. There are now 3 sources of truth for the avatar icon index and it is not clear what the relationship between them is: * kAccountIdKey in the profile entry cache * kProfileAvatarIndex which is a synced pref. * kLocalProfileAvatarIndex which is non-syncable pref. Note that kProfileAvatarIndex and kLocalProfileAvatarIndex are both set when the user updates the image icon in chrome://settings/manageProfile. I've just tested and if I start sync, set a local avatar icon, then turn off sync, I still have the same image. So this CL does not fix the bug 863008 for this scenario. The core issue comes from the fact that we try to fix a problem that cannot be fixed in the current architecture of sync - sync preferences do not have a local variant and do not get reverted to a local variant when the user turns sync off. I think doing a custom implementation for the profile avatar (and not for the profile name for example or settings) just adds confusion. The fact that the relationship between these preferences is not very clear, fixing the issue 900374 becomes hard and is risky. Bug: 900374 Original change's description: > Restore avatar after user logs out from sync. > > BUG=863008 > > Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 > > R=bauerb@chromium.org,sky@chromium.org > > Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 > Reviewed-on: https://chromium-review.googlesource.com/1135137 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582541} TBR=sky@chromium.org,droger@chromium.org,bauerb@chromium.org,tangltom@chromium.org,boocmp@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863008 Change-Id: I46aed023494d94e197828339f6870bf9ba0c9da8 Reviewed-on: https://chromium-review.googlesource.com/c/1329153Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#607176}
-
Yuta Kitamura authored
This enum is exposed to //content and other non-Blink code, so its name should start with "Web". Bug: 826203 Tbr: creis@chromium.org Change-Id: I9fc9aa50ef276dae7ecd64a3bd299590893b19a8 Reviewed-on: https://chromium-review.googlesource.com/c/1328549 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL adds animations when the user is tapping the "switch to this tab" indicator in the omnibox suggestions. Bug: 893121 Change-Id: Ia7af97f6175efa959bbb2e84ab5661f00adedf81 Reviewed-on: https://chromium-review.googlesource.com/c/1322871Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#607174}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8668e959c79c..f75973390723 Created with: gclient setdep -r src-internal@f75973390723 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5e889b1d9d96e6795289f359911c1b4e77cb9268 Reviewed-on: https://chromium-review.googlesource.com/c/1331214Reviewed-by:
-
Hajime Hoshi authored
V8 should not be executed on per-thread task runner. Use per-frame (per- execution-context) task runner instead. Bug: 870606 Change-Id: I353c421901f0ff78966df5d197014f8cb650a985 Reviewed-on: https://chromium-review.googlesource.com/c/1331289Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607172}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7dbd8f071016..cb830a07e835 git log 7dbd8f071016..cb830a07e835 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 yunlian@google.com generic_stages: temporarily ignore all target prebuilts. Created with: gclient setdep -r src/third_party/chromite@cb830a07e835 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I19be62a112191cc9f7a6c3a67e69f9d690350139 Reviewed-on: https://chromium-review.googlesource.com/c/1331175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607171}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d9349484. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I740b7ffb027e29aa60d4e9653ffae9f37f3d7b41 Reviewed-on: https://chromium-review.googlesource.com/c/1331176 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607170}
-
Yuzu Saijo authored
This CL adds new UMAs that report the amount of memory metrics that's reduced as a result of intervention. Bug: 888935 Change-Id: Ie336559f2046f0929830df7bf3b2d35ce7887423 Reviewed-on: https://chromium-review.googlesource.com/c/1319399Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch adds test cases for selection crossing blocks. The test checks regression behavior that reverted crrev.com/c/1182710 caused. Bug: 892584 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I299ca3323c201a71267f50f8bba95269f759a0fe Reviewed-on: https://chromium-review.googlesource.com/c/1272819Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#607168}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfd15c4df421..8668e959c79c Created with: gclient setdep -r src-internal@8668e959c79c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1d3756e747d30ef39186a532ecad0989cafc64a Reviewed-on: https://chromium-review.googlesource.com/c/1331213Reviewed-by:
-
Alexey Baskakov authored
Instead of extension-based sizes. Bug: 901226 Change-Id: I4729ac0206fea143980db4cf43de67a71d83f7be Reviewed-on: https://chromium-review.googlesource.com/c/1329819Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#607166}
-
Kent Tamura authored
* layout_test_content_browser_client.cc: Pass --tests-in-blink flag to a renderer process. GetWebTestsFilePath() in blink_test_helpers.cc needs this flag. * LayoutTests/editing/assert_selection.html * LayoutTests/editing/assert_selection.js * LayoutTests/editing/execCommand/insert-paragraph-into-table-expected.txt Drop 'LayoutTests/' part from error description * LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js * LayoutTests/external/wpt/webusb/resources/usb-helpers.js Support web_tests/ as well as LayoutTests/ * LayoutTests/fast/js/exception-line-number-expected.txt * LayoutTests/fast/js/script-tests/exception-line-number.js Drop 'LayoutTests/' part from error description Bug: 843412 Change-Id: I817b40bb2e7edf0216a32d9f3a3e2320e4b6956a Reviewed-on: https://chromium-review.googlesource.com/c/1329811Reviewed-by:
-
Rob Buis authored
Add more tests to SignedExchangeUtilsTest regarding whitespace in quoted strings and a string containing b2 but not equal to b2. Bug: 803774 Change-Id: Idb4948283b9df3d85db60f6229e44be5054e0145 Reviewed-on: https://chromium-review.googlesource.com/c/1328961Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#607164}
-
Hitoshi Yoshida authored
This CL drops support of an IDL extended attribute [PrimaryGlobal], and cleans up some comments about it. Bug: 792432 Change-Id: I6f476966e08a5dbd58aca5e72ad41bb9e8bb89bb Reviewed-on: https://chromium-review.googlesource.com/c/1329709Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#607163}
-
John Abd-El-Malek authored
Bug: 903569 Change-Id: I2f031411f09cfbfcb006e3093a9e24ee5eeb23e6 Reviewed-on: https://chromium-review.googlesource.com/c/1327172 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#607162}
-
Rune Lillesveen authored
Remove the propagation from DidRecalcStyle as we already did the propagation in LayoutObject. TEST=fast/css-generated-content/ Change-Id: I0f8a101020d1920071dd329ee00ebd86174e5d08 Reviewed-on: https://chromium-review.googlesource.com/c/1329928 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#607161}
-
Yuta Kitamura authored
This CL renames the class MockRendererScheduler which is the mock of WebThreadScheduler, formerly named RendererScheduler, so it would match the current name of its parent class and follow the naming convention for Blink public classes (starting with "Web"). Bug: 826203 Change-Id: Ibda5282749e1379b053ff27bb03b9140fa124f37 Reviewed-on: https://chromium-review.googlesource.com/c/1328547Reviewed-by:
-
Koji Ishii authored
This patch reduces the size of NGPhysicalFragment by: * NGPhysicalFragment by pointer, by removing virtual functions. * NGPhysicalTextFragment by a word, by moving flags to NGPhysicalFragment. * NGPhysicalTextFragment::EndEffect() is no longer used and that removed. Also adds size warning to all subclasses. Currently, NGPhysicalFragment has 13 bits in flags, plus 5 bits for its subclasses, 18 bits total. Bug: 591099 Change-Id: I189f691c1976da1eb1223ac9c782e02567038310 Reviewed-on: https://chromium-review.googlesource.com/c/1329703 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607159}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11c9a4b5b5fa..cfd15c4df421 Created with: gclient setdep -r src-internal@cfd15c4df421 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4888462f6c04b3fe7bc6e90c9dad49ce48970058 Reviewed-on: https://chromium-review.googlesource.com/c/1331212Reviewed-by:
-
Simon Que authored
Previously, it was reduced from 10% to 5% due to machine overload: http://crrev.com/c/1235273 Now we have more machines added in https://crrev.com/i/703404. (Disregard the incorrect CL name) BUG=855319 Change-Id: I5dbce569f1d4cf3e8fd45fbcd9068124351dd12c Reviewed-on: https://chromium-review.googlesource.com/c/1331288Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#607157}
-
Adam Rice authored
This reverts commit abcd4da5. Reason for revert: Causing failures on Linux debug bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75629 Original change's description: > [LayoutNG] Fix text-transform for 8-bit text > > Fix a bug in CaseMappingHarfBuzzBufferFiller where 8-bit strings weren't > up-converted to 16-bit in cases were the original and case mapped string > differed in length which hit a CHECK in the String::Characters16 method. > > Bug: 899876, 899868 > No-Try: true > Change-Id: I5de8fbaabbc08932904846ffa4674129263f50aa > Reviewed-on: https://chromium-review.googlesource.com/c/1330723 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607106} TBR=szager@chromium.org,cbiesinger@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899876, 899868 Change-Id: I0dbcc4d3c64cfcc9f074b6255dca09885043eed7 Reviewed-on: https://chromium-review.googlesource.com/c/1331096Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607156}
-
Noel Gordon authored
This reverts commit b6eee6f0. Reason for revert: still not enough reliability in the NaCl compiler on the ASAN bots. Original change's description: > Re-enable FilesApp zip file integration tests on ASAN > > The Chrome OS ASAN bots now have longer test time-outs limits and maybe > enough to run the zip file tests to completion. Let's see. > > Bug: 867738 > Change-Id: Ibda0a13ccb13095d14504c19d48d619cee5d5cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/1321653 > Reviewed-by: Anand Mistry <amistry@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605944} TBR=noel@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867738 Change-Id: Ie0cf1a09d880692ca1ba1c2ce3ab3645405e05e3 Reviewed-on: https://chromium-review.googlesource.com/c/1329818Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607155}
-
Chromium WPT Sync authored
Using wpt-import in Chromium afd3d04f. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I76407ab4196af70bd81825e7ddb1c9903a46336d Reviewed-on: https://chromium-review.googlesource.com/c/1331173 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Hitoshi Yoshida authored
Web IDL spec says [Global] must take an argument, and its support for [PrimaryGlobal] was removed. This CL updates IDL files to follow its spec, but keeps code for [PrimaryGlobal] as-is. Bug: 792432 Change-Id: I56bc07487a5a366aed49385140b9b57a8eeb646c Reviewed-on: https://chromium-review.googlesource.com/c/1331093Reviewed-by:
-
Alice Boxhall authored
This is in preparation for cl/1242572, which will include elements with a display: contents style in the Accessibility tree. Since display: contents means an element will not get a LayoutObject, walking the Layout Tree means we miss some elements. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=835455 Change-Id: I63c7da185da25f4661bfdeacb5a29ce79c2a3701 Reviewed-on: https://chromium-review.googlesource.com/c/1206050 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607152}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ia427966bf3b62b0e3d7cfab1e53026c94b3e528d Reviewed-on: https://chromium-review.googlesource.com/c/1329710Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#607151}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I9dc96c9669ca28719ecda9d571eec0311d014a82 Reviewed-on: https://chromium-review.googlesource.com/c/1329711Reviewed-by:
-
