GitLab

Create TaskAttributionTiming PerformanceEntry for attribution in PerformanceLongTaskTiming. Move culprit-frame-related fields in there

BUG=676484

Review-Url: https://codereview.chromium.org/2610063006
Cr-Commit-Position: refs/heads/master@{#441814}

https://pdfium.googlesource.com/pdfium.git/+log/48f776f7e801..7855a2c57745

$ git log 48f776f7e..7855a2c57 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 dsinclair Cleaning up memory allocation in CXFA_FM2JSContext - I
2017-01-05 tsepez Properly ref-count CFGAS_GEFont with CFX_RetainPtr.
2017-01-05 tsepez Remove CFX_MapPtrToPtr from xfa/fxfa.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2617513005
Cr-Commit-Position: refs/heads/master@{#441813}

Provide the original profile to incognito so that users can still use
their printers.

BUG=678796

Review-Url: https://codereview.chromium.org/2610373003
Cr-Commit-Position: refs/heads/master@{#441812}

This was originally intended as an optimization, but now that all
intersection tracking happens through IntersectionObserver, and all
active observers must run on each frame, it makes no sense to
short-circuit the recursion in updateViewportIntersectionsForSubtree.

This also allows us to remove IntersectionObserver::trackingDocument,
which was a wart introduced to fix a bug where observers defined in
subframes were not generating IntersectionObserver notifications, as
discussed here:

https://codereview.chromium.org/2553343004

BUG=677620
R=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2610963003
Cr-Commit-Position: refs/heads/master@{#441811}

The first one should always be the default one.

Updated switch case: http://screen/Fy4RTuNHCYE.png
Updated sign-in case: http://screen/PNCAG7SgMKs.png

BUG=660418

Review-Url: https://codereview.chromium.org/2616943002
Cr-Commit-Position: refs/heads/master@{#441810}

This will allow for reuse by Rappor/UKM.

BUG=678682

Review-Url: https://codereview.chromium.org/2614533002
Cr-Commit-Position: refs/heads/master@{#441809}

BUG=678791

Review-Url: https://codereview.chromium.org/2615113002
Cr-Commit-Position: refs/heads/master@{#441808}

NGPhysicalFragmentBase => NGPhysicalFragment
NGPhysicalFragment => NGPhysicalBoxFragment
NGFragmentBase => NGFragment
NGFragment => NGBoxFragment

Suggested by Morten.
Thanks to Eclipse for refactoring tools.

BUG=635619

Review-Url: https://codereview.chromium.org/2612103004
Cr-Commit-Position: refs/heads/master@{#441807}

Ran against trybots 50 times with no issue so I suspect the issue was fixed in cr/2591643004

BUG=676414

Review-Url: https://codereview.chromium.org/2616793002
Cr-Commit-Position: refs/heads/master@{#441806}

This patch fixes 'hyphens: auto' to work only when line wrapping is
allowed.

BUG=678356

Review-Url: https://codereview.chromium.org/2614743004
Cr-Commit-Position: refs/heads/master@{#441805}

Due to a quirk in VC++ it is easy to accidentally prevent
a const global array from being placed in the read-only
data segment. This change removes a should-be-harmless
'const' keyword to work around this quirk and move
~256 bytes to the .rdata (read-only) data segment.

VC++ bug is https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351

Review-Url: https://codereview.chromium.org/2613723005
Cr-Commit-Position: refs/heads/master@{#441804}

They are unnecessary indirection to WindowProxy::namedItemAdded/Removed.

Also this CL updates a dcheck in WindowProxy::namedItemAdded/Removed to verify
that those methods are called after the window proxy is initialized.

(The check will be replaced with a better lifecycle model in a follow-up CL.)

BUG=677253

Review-Url: https://codereview.chromium.org/2616903002
Cr-Commit-Position: refs/heads/master@{#441803}

It makes the tests flaky. Add a TODO to disable OOM killing for these tests,
where possible.

BUG=675255

Review-Url: https://codereview.chromium.org/2618853002
Cr-Commit-Position: refs/heads/master@{#441802}

has_md5, has_sha1, has_sha1_leaf to a helper function.

This change is a prelude to simplifying the
CertVerifyProcWeakDigestTest tests.

BUG=649017

Review-Url: https://codereview.chromium.org/2610903003
Cr-Commit-Position: refs/heads/master@{#441801}

BUG=678034

Review-Url: https://codereview.chromium.org/2608343002
Cr-Commit-Position: refs/heads/master@{#441800}

Changing the way test start child processese on Android.
Forking natively should not be used on Andoid, instead child processes
should be started through the Android framework, which requires going
to Java and using Android services.

For that we introduce the MultiprocessTestClientLauncher java class
which starts a service in a new process. We provide several
MultiprocessTestClientService service classes to ensure we can have
multiple child processes.
File descriptor are passed from the parent to the child process as
Parcelable, and we use the GlobalDescriptors class to register them.

TEST=Run the mojo_system_unittests
BUG=666356

Review-Url: https://codereview.chromium.org/2549363004
Cr-Commit-Position: refs/heads/master@{#441799}

BUG=611706

Review-Url: https://codereview.chromium.org/2618573002
Cr-Commit-Position: refs/heads/master@{#441798}

https://skia.googlesource.com/skia.git/+log/08d57e6ae651..3afa628e50e3

$ git log 08d57e6ae..3afa628e5 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 brianosman Revert "Explicitly fail read/writePixels in invalid color space scenarios"
2017-01-05 brianosman Hard code bicubic coefficients in the shader
2017-01-05 mtklein Use stack instead of malloc() for most calls to SkRasterPipeline::run().
2017-01-05 mtklein Revert "SkRasterPipelineBlitter: support A8"
2017-01-04 mtklein SkRasterPipelineBlitter: support A8
2017-01-04 bsalomon Cleanup ops that are storing GrPipelineOptimizations.
2017-01-05 mtklein monobench: don't sort the Bench vector while iterating through it...
2017-01-05 mtklein monobench: shuffle benchmark order between samples
2016-12-21 bsalomon Rename batch->op in GrAuditTrail json and skiaserver's url handlers
2017-01-05 mtklein GN: add skia_android_serial and push_$foo targets when it's set
2017-01-05 mtklein clamp to 1.0f in sk_linear_to_srgb_needs_round()
2017-01-05 jvanverth Minor fixes for the Linux viewer
2017-01-05 caryclark ignore max curvature at end point
2017-01-05 brianosman Explicitly fail read/writePixels in invalid color space scenarios

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2618533003
Cr-Commit-Position: refs/heads/master@{#441797}

There is currently an Activity to display Physical Web URLs, but we'd
like do display those URLs from a WebUI.  In part, this will be simpler
for redirecting from the omnibox.  In part, it is simpler because we
no longer need an Activity and will be able to move away from it.  That
is, we originally need to display Physical Web URLs without the native
library loaded; this is no longer the case.

BUG=663842

Review-Url: https://codereview.chromium.org/2603043002
Cr-Commit-Position: refs/heads/master@{#441796}

This patch adds support for <resolution>-typed registered properties.
We already parse the string '<resolution>', so this patch just adds the
logic to parse the actual <resolution> values.

BUG=641877

Review-Url: https://codereview.chromium.org/2618553003
Cr-Commit-Position: refs/heads/master@{#441795}

Also address attribution corner case where new tab navigation immediately
followed by a server side redirection (and add browser test for it).

BUG=676691

Review-Url: https://codereview.chromium.org/2601303002
Cr-Commit-Position: refs/heads/master@{#441794}

Reland of ll WebRTC 15911:15919 (5 commits) (patchset #1 id:1 of https://codereview.chromium.org/2615103002/ )

Reason for revert:
Original patch didn't break build. It was https://codereview.chromium.org/2611153002/ .

Original issue's description:
> Revert of Roll WebRTC 15911:15919 (5 commits) (patchset #1 id:1 of https://codereview.chromium.org/2617693003/ )
>
> Reason for revert:
> Revert in hopes of fixing linux x64. If doesn't fix it will revert revert http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545
>
> Original issue's description:
> > Roll WebRTC 15911:15919 (5 commits)
> >
> > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/af5a0a0..5445b07
> >
> > $ git log af5a0a0..5445b07 --date=short --no-merges --format=%ad %ae %s
> > 2017-01-05 ehmaldonado@webrtc.org Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ )
> > 2017-01-05 ehmaldonado@webrtc.org GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries.
> > 2017-01-05 danilchap@webrtc.org Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ )
> > 2017-01-05 mbonadei@webrtc.org Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ )
> > 2017-01-05 mbonadei@webrtc.org Fixing package-boundary violation with srjar_deps
> >
> > TBR=
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2617693003
> > Cr-Commit-Position: refs/heads/master@{#441751}
> > Committed: https://chromium.googlesource.com/chromium/src/+/01b8456652e46cc732b7d9282f07fca6e4c99d00
>
> TBR=perkj@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Review-Url: https://codereview.chromium.org/2615103002
> Cr-Commit-Position: refs/heads/master@{#441774}
> Committed: https://chromium.googlesource.com/chromium/src/+/a671e274dc99a9e9737a241e228ee624e44aef01

TBR=perkj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2614773005
Cr-Commit-Position: refs/heads/master@{#441793}

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618603003
Cr-Commit-Position: refs/heads/master@{#441792}

BUG=678837

Review-Url: https://codereview.chromium.org/2615633007
Cr-Commit-Position: refs/heads/master@{#441791}

On Linux,  device scale factor is not set.
On Win, there is no API to offer hotspot of a cursor.
This cl addresses the above two problems.

BUG=676687

Review-Url: https://codereview.chromium.org/2605773002
Cr-Commit-Position: refs/heads/master@{#441790}

R=atotic@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2613863004
Cr-Commit-Position: refs/heads/master@{#441789}

[reland, refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController

This CL tries to reland the original CL https://codereview.chromium.org/2508363003
which was reverted since it was making WebViewInteractiveTest.Focus_FocusRestored
flake.

The issue in the initial attempt was that
WebFrameWidget::getActiveInputMethodController() would return nullptr when the
WebFrameWidget did not have page focus (m_imeAcceptEvents == false). This
assumption is not correct and resulted into reporting
ui::TEXT_INPUT_TYPE_NONE for TextInputState right after losing page focus, e.g.,
by moving focus from a <webview> to its embedder (in the reverted CL).

On the other hand, when WebFrameWidget does not have page focus, any IME calls
received from browser should be dropped. Specifically, by not doing so, a call
to WebInputMethodController::finishComposingText would lead to a second commit
for the last ongoing composition. This happens when switching tabs or moving
focus to another WebFrameWidget in OOPIFs. Returning nullptr for active
controller was used as the solution to this problem in the original CL that
landed WebInputMethodController (https://codereview.chromium.org/2333813002/).
This is however incorrect since an unfocused WebFrameWidget could still have
IME state such as TextInputState.

The new attempt will reland the reverted CL and fix the issues by:

    1- Returning WebInputMethodController iff there is a focused local frame
    inside WebFrameWidget. Page focus will not affect this value.

    2- Will not process IME events if RenderWidget::has_focus_ is false. This
    is achieved by adding a new method ShouldHandleImeEvents() which will
    return false when there is no WebFrameWidget or page focus.

This CL also adds a RenderWidgetTest to prevent future regressions of this kind.

BUG=629721

Review-Url: https://codereview.chromium.org/2608293002
Cr-Commit-Position: refs/heads/master@{#441788}

As the MediaSession spec changed from using event-listener-based
to callback-based fashion for media controls, we need to keep the
implementation up to date.

Spec PR:
https://github.com/WICG/mediasession/pull/159

BUG=675963

Review-Url: https://codereview.chromium.org/2589893002
Cr-Commit-Position: refs/heads/master@{#441787}

This was missed by https://codereview.chromium.org/2539973004

BUG=678600

Review-Url: https://codereview.chromium.org/2615613005
Cr-Commit-Position: refs/heads/master@{#441786}

SharedWorker service has a mechanism to forward a message sent from a document
to a worker. With this mechanism, a sender creates a nested IPC message and
sends it to the SharedWorker service in the browser process. The service
interprets the nested message and forwards it to an appropriate receiver.

This mechanism is available for any IPC messages but it has been used only for
worker connection message. If we use it only for one message type, we don't have
to manage such a complex mechanism. Therefore, this CL removes the mechanism and
uses a plain IPC message for connecting to a worker.

This simplification also makes it easier to mojofy SharedWorker.

BUG=612308

Review-Url: https://codereview.chromium.org/2601893002
Cr-Commit-Position: refs/heads/master@{#441785}

Driven by change: there is no point in doing the wrapping of
the tooltip text with RTL/LTR formatting, in case there is no view.
Simply bail out earlier.

BUG=

Review-Url: https://codereview.chromium.org/2611943003
Cr-Commit-Position: refs/heads/master@{#441784}

Revert of Don't post multiple task for executing blocked scripts. (patchset #2 id:20001 of https://codereview.chromium.org/2609763002/ )

Reason for revert:
Regression in test for time to first meaningful paint: https://crbug.com/678584

Original issue's description:
> Don't post multiple task for executing blocked scripts.
>
> We may post a lot of tasks for executing blocked scripts in the case
> where we insert multiple shadow trees each containing a style element.
> When we start parsing a style element, we mark it as blocking and
> unblock script execution after finishing parsing. Check if the previous
> task is active before posting.
>
> Found while measuring performance for issue 603621.
>
> BUG=603621
>
> Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0
> Cr-Commit-Position: refs/heads/master@{#441110}

TBR=pmeenan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603621

Review-Url: https://codereview.chromium.org/2617763002
Cr-Commit-Position: refs/heads/master@{#441783}

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252

Review-Url: https://codereview.chromium.org/2616703005
Cr-Commit-Position: refs/heads/master@{#441782}

 - Two IPCs, CreateNewWindow and ShowCreatedWindow, are made to be routed via
   the opener frame. Previously they were routed via the opener view.
 - CreateNewWindow (which is mojofied) stays put but its parameters change
 - ViewHostMsg_ShowView becomes FrameHostMsg_ShowCreatedWindow
 - The corresponding delegate methods move from RenderViewHostDelegate to
   RenderFrameHostDelegate, though the implementation stays in
   WebContentsImpl, which implements both interfaces.
 - Remove the RenderView opener_id parameter from the mojo CreateNewWindow
   params, it can be inferred from the RenderFrame id. This fixes a possible
   bad situation where an unrelated RV/RF route id pair could be supplied.
 - The pending WebContents list is made to be indexed by the main frame
   widget; this turns out to be cleaner than making it frame- based, since
   show() is an operation on the created RenderWidget.
 - The signature of ContentBrowserClient::CanCreateWindow changes to be
   frame-based, which necessitates retooling the android
   SingleTabModeTabHelper to be frame-based also.
 - The ViewMsg_Close message, which cleans up after UI-thread failure of the
   CreateNewWindow operation, is hoisted out to the outermost function where
   failure is possible, RenderWidgetHelper::OnCreateNewWindowOnUI. This
   addresses some possible RenderView leaks when e.g. window.open() races a
   navigation that destroys the opener. These races would have become more
   likely now that we're routing via the frame, since child frames can have a
   shorter lifetime than their RenderViewHosts.
 - The response to ShowCreatedWindow on the opener RenderFrame is a
   ViewMsg_Move_ACK on the openee RenderWidget. This IPC moves to
   WebContentsImpl::ShowCreatedWindow so that it can be sent via the openee
   RenderWidgetHost's IPC::Sender, rather than via the opener RenderFrame.

BUG=431769, 304341
TBR=alokp@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2506183002
Cr-Commit-Position: refs/heads/master@{#441781}

Download.ActualBandwidth:
Download.PotentialBandwidth:
Download.BandwidthUsed:

  These metrics were being recorded on each network read and were
  assuming that the size of the buffer and the duration between the
  prior read completion event and this one were reliable indicators of
  bandwidth.

  In practice, recording on each read is noisy and not all
  useful when aggregated across all users. Also size_of_buffer /
  elapsed_time is not an indicator of potential bandwidth, which makes
  both the PotentialBandwidth and BandwidthUsed incorrect.

Download.DiskBandwidthUsedPercentage:

  Neither useful nor correct.

SB2.DownloadDuration:

  Was measuring the lifetime of a DownloadRequestCore object, which
  doesn't correspond to the duration of a download.

Download.InterruptedOverrunBytes:
Download.InterruptedUnderrunBytes:

  When reporting UMA, the code was incorrectly picking the histogram
  name. Hence the meanings of the two histograms were switched. Rather
  than deprecating, I switched the descriptions around. The names are
  henceforth a bit odd, but the description should clarify what they are
  measuring.

Download.WriteSize:
Download.WriteLoopCount:

  WriteSize and WriteLoopCount metrics aren't actionable. WriteSize
  depends on the buffer sizes involved and the data is too noisy to be
  useful. Likewise WriteLoopCount counts the number of attempts it takes
  to fully write out a buffer. This isn't actionable.

BUG=none

Review-Url: https://codereview.chromium.org/2598773002
Cr-Commit-Position: refs/heads/master@{#441780}

BUG=none

Review-Url: https://codereview.chromium.org/2607103004
Cr-Commit-Position: refs/heads/master@{#441779}

This has been the the application context for some time now, so there
is no point in storing it when we can use ContextUtils as needed.

BUG=678787

Review-Url: https://codereview.chromium.org/2604953002
Cr-Commit-Position: refs/heads/master@{#441778}

https://chromium.googlesource.com/chromium/src/+/495d8354acfb5

BUG=642454
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2613153004 .
Cr-Commit-Position: refs/heads/master@{#441777}

Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls (patchset #3 id:40001 of https://codereview.chromium.org/2611153002/ )

Reason for revert:
Revert in hopes of fix linux x64 bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545

Original issue's description:
> Delete Mac & Cairo skia::BitmapPlatformDevice impls
>
> We are no longer performing native drawing on these platforms, use the
> Skia placeholder instead.
>
> BUG=675977
> R=reed@google.com
> TBR=
>
> Review-Url: https://codereview.chromium.org/2611153002
> Cr-Commit-Position: refs/heads/master@{#441750}
> Committed: https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece0459a4aeaddf

TBR=reed@google.com,robertphillips@chromium.org,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675977

Review-Url: https://codereview.chromium.org/2616003003
Cr-Commit-Position: refs/heads/master@{#441776}

Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ )

Reason for revert:
This patch was not the culprit for the layout test failures.

Original issue's description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
> Cr-Commit-Position: refs/heads/master@{#441599}

TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460

Review-Url: https://codereview.chromium.org/2611233002
Cr-Commit-Position: refs/heads/master@{#441775}