- 29 Oct, 2020 40 commits
-
-
Mugdha Lakhani authored
This reverts commit b344652b. Reason for revert: We have collected enough crashdumps now, and this is causing crash metrics to be skewed as it's getting counted as a real crash. Bug: 1132770 Change-Id: Ia2e7a92bea2ebeca01c62ca9af73d3fe014685f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505985 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#822189}
-
Sigurdur Asgeirsson authored
Change-Id: I9bf7d0b0f5cbd33ded4ff55bd3b11bdf3c380376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507509Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822188}
-
Vidhan authored
StateNameMapUpdater is a helper class for StateNameMapUpdater that reads the data from the state data files and loads them to the map. Bug: 1111960 Change-Id: I8add7215a1ec450e0a31ef999b2adfa6dade138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471337Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#822187}
-
Geoff Lang authored
This test generates GL errors in ANGLE and flakes very frequently. This was exposed after ANGLE started looking for errors in https://chromium-review.googlesource.com/c/angle/angle/+/2134424 TBR=zmo@chromium.org NOTRY=true Bug: angleproject:3020 Bug: angleproject:5213 Change-Id: Id5f9407c0b819abcf7d150af3104a1a2e7ae6f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507571Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822186}
-
Mohamed Adel authored
The filename and class name should match, so the files were renamed to service_delegate.h and service_delegate.mm. Change-Id: Ib268c39ff7197002f56dfa637ddf81d237326132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507749Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#822185}
-
Regan Hsu authored
PhoneHub will now show a max of two most recently visited tabs instead of four. Screenshot: https://screenshot.googleplex.com/4CoC5BrWf4FXAY7 Fixed: 1142981 Bug: 1106937 Change-Id: I12a54bd92512dd8fb86722be6551ea6284e7badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504009 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822184}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74cd21ef..35582ccb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id109e9ea3907984e79f914c4a6ce2a83c43cb77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507391Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822183}
-
Tina Wang authored
Change-Id: I09f4847df30ab8dab5aebffc49152c4f40cc2196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507458 Commit-Queue: Tina Wang <tinazwang@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822182}
-
Nico Weber authored
On clang rolls, the tidy trybot fails with Failed to download prebuilt clang package clang-llvmorg-12-init-10002-ga998cae0-1.tgz since that hasn't been built yet at the start of the run. Ideally we'd have a way to say "don't run clang-tidy automatically, but do include it as a bot when running this through cq", but for now just skipping all tricium steps altogether seems ok. For roll CLs that get close to landing, we can try to remember to remove the line after packages have been pushed. Change-Id: I07fb68b872e9a05565967929f81b67e9ea707e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505933 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822181}
-
Andrew Grieve authored
This reverts commit 8815d0ef. Reason for revert: Likely cause of "Deterministic Android" failures Original change's description: > Reland "Enable JDK library desugaring by default" > > This is a reland of 8699ff59 > > Original change's description: > > Enable JDK library desugaring by default > > > > Bug: 1056751 > > Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Ian Wells <iwells@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817575} > > Bug: 1056751 > Change-Id: I7d6f7336057afd80960d3b6c6a37c595b7c84629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493362 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820353} TBR=agrieve@chromium.org,iwells@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056751, 1142478 Change-Id: I6dd83fd6888ada2ac3ec350eed3345062080e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507490Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822180}
-
Noam Rosenthal authored
For rational numbers this worked OK by chance when both the nominator and the denominator were < 65536, because the error was cancelled by the division. However, this doesn't work when the nominator/denominator are larger than 65535. Fixed the offset, and added a test with large nom/denom. Bug: 1143645 Change-Id: Ic8e46c580437fb4585197807c89a48f43435852a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507110Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#822179}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7b7cafac212..b6d93e6c4293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC parastoog@google.com,futhark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1018739,chromium:1143646 Tbr: parastoog@google.com,futhark@google.com Change-Id: Iddcdecf63f1384d38cc447af62f6563183814258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822178}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/d2fa57d26dff..62bbc6f6c050 2020-10-29 dsinclair@chromium.org Fix doc tables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I3fe30e1d973fe478483c2f08260214af05fe9930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822177}
-
Jonathan Ross authored
Two old Histograms are coming up on expiry, and we haven't used them in a long time. So I'm marking them Oboslete now: Compositing.SurfaceDependencyDeadline.Duration* Compositing.SurfaceManager.AliveSurfaces* Bug: 1140020, 1140021 Change-Id: Ibbfd90c72edb2a206cf114b77682116061c613b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505965Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Yunke Zhou authored
In RTL case, the coordinate system is from right to left and the origin is the right upper corner. The coordinates for everything on the lock screen should be the same in both LTR and RTL cases and therefor mirroring is not needed. The misplacement is due to doing mirroring in `ConvertPointToTarget` when finding the position of the bubble. We need to remove the mirroring effect in order to find the correct position for login bubble. Bug: 937245 Change-Id: I4c4ce54ab7617a5c4c56e861afb7a103b045ef8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505869 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#822175}
-
cfredric authored
Study. Bug: 973801, 1137081 Change-Id: Ieab55af5ac66aa23f2e3c2392e80da6c80404507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492601 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#822174}
-
Fredrik Söderqvist authored
Rather than passing three bools, pass a SVGContainerLayoutInfo struct as argument. Makes some of the callsites slightly more readable. Change-Id: Ic71bb7d863de047bf8e20dfec02e30fee02a8d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505754Reviewed-by:
-
Dan McArdle authored
Bug: 1052476 Change-Id: I0c8a0280fe121b82e17e602098732895ac9100f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507451Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#822172}
-
Sébastien Séguin-Gagnon authored
Bug: 1136043 Change-Id: Icb3d8aa472ec1f6fb932369ce7e80ba69470fedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506044 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#822171}
-
Ramin Halavati authored
Profiles that are scheduled for deletion cannot be used to create new browser windows. Bug: 1141551, 1125474 Change-Id: I0239b4b51c09be7dc0ff2c3189972dfa75a2ca00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497446 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#822170}
-
Tomasz Wiszkowski authored
Bug: 1112385 Change-Id: Id75f093fde39d3abf1fc06481771015c5062eda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506351Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#822169}
-
Domenic Denicola authored
URLs which are secure contexts can use the origin isolation feature, even if they're not HTTPS. The most important example of this is http://localhost. Fixed: 1142894 Change-Id: I0c8d1c73465c2c289ae2996695f0c42f78cf100c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503849Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822168}
-
Caleb Raitto authored
Change-Id: I4134461984fff33f9e6470cb7b4982ba51802dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505581Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822167}
-
Mohamed Adel authored
The purpose of this subclass is to move all specific API calls to their appropriate subclass. This is being done as UNUserNotificationCenter is going to be added to the XPC service so it needs to be able to support both. Bug: 1142497 Change-Id: I123fc0144f507c18ca30ae66c75129ab1410b7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498594Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
needed in preparation to moving the chime DFM definition downstream. followup cl downstream crrev.com/i/3364724 Bug: 1142775 Change-Id: I2b07234fdba5dc2fa49632d5710f5ebedf48439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501667 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822165}
-
RJ Ascani authored
This reverts commit cca7402b. Reason for revert: This made the FuchsiaCdmManager tests flaky. See crbug.com/1143067 Original change's description: > [Fuchsia] Move CDM data file i/o off main thread > > The FuchsiaCdmManager needs to create directories for each origin to > pass to the platform CDM services to fulfill EME origin isolation > requirements. The FuchsiaCdmManager runs on the main thread and the > calls to CreateDirectoryAndGetError are potentially blocking. This CL > moves the directory creation step to a background task. > > Bug: 1140655 > Change-Id: I060edc909976e7b5a493afc3bc9a2a26e26994be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500532 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: RJ Ascani <rjascani@google.com> > Cr-Commit-Position: refs/heads/master@{#821353} TBR=wez@chromium.org,rjascani@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140655, 1143067 Change-Id: I06955764f82f32f3aa96443f91ffd566aede3b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505977Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#822164}
-
Aya ElAttar authored
- Added source for drag-and-drop data the same as clipboard data to be able to apply the rules of data leak prevention policy. Bug: 1139886 Change-Id: I321c9ab7527cb1b16561973b1e57420e5a4b9e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489634Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#822163}
-
Eric Orth authored
Targeting draft-ietf-dnsop-svcb-httpssvc-03. Bug: 1138620 Change-Id: I5198bb2aebff3d4aebfbc4e457965b0021991787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503490Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#822162}
-
Ramin Halavati authored
System profiles create a primary off-the-record profile. |IsIncognitoProfile| function is updated to return false for this OTR profile. Bug: 1143077, 1125474 Change-Id: Ib0763eabb154556c96fb47add3b738372edf8555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504231Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#822161}
-
Dominique Fauteux-Chapleau authored
All references to functions using those prots were already removed, so this just cleans up the remaining dead code. Bug: 1103390 Change-Id: I6e2c6c70eb52144cedc7f8ab390c3b6d89a02e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505943 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#822160}
-
Rune Lillesveen authored
Test is flaky on multiple platforms, not only Windows. TBR=acolwell@chromium.org Bug: 980446 Change-Id: I8a26aefa4beaf53c501f922e2bbc6021cd86b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506578Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822159}
-
Rune Lillesveen authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50702 TBR=joedow@google.com Bug: 1143671 Change-Id: I16cd36a9f8edaad8b02a78d2170b30107e878800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506442Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603929441-de7c595584c292110f839d1296c0369f387aa3ca.profdata to chrome-linux-master-1603972752-7774997975c1fc77dd139039f32c4c5217a4f93d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic282a849c64d5c002ad89721610ccaf6f3041aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507104Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3cd384a5b039..83c38a8fd6b1 2020-10-29 robertphillips@google.com Allow uniqueKey invalidation messages to reach the thread safe cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jcgregorio@google.com Change-Id: Idb0a174358821cab5a88813281489834555cb206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507100Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603929441-b6b34c1c4b0f9e2ddac4473f28fe820beebad5c9.profdata to chrome-mac-master-1603972752-eb96abf6b462a9960649372890eeb96e7f549740.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic97d3d026cc93a3c50aba27168869779dd53df5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507105Reviewed-by:
-
Hajime Hoshi authored
Before this CL, |BackForwardCacheMetrics:: browsing_instance_not_swapped_reason_| is not reset at navigation and might be recorded in non-related navigations unexpectedly. This CL fixes this by resetting it every navigation. Bug: 1134847 Change-Id: Ib9e00f6937c5425c82cd2e40bdb47cb1fb740d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501546Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822154}
-
Sergey Ulanov authored
SnapshotAuraTest.FullScreenWindow was using action_max_timeout() on Linux, but not on Fuchsia. Now it's timing out on Fuchsia periodically. Increase the timeout on Fuchsia as well. Bug: 1143031, 1142521 Change-Id: Iaddd417af60a127273b965e1e0646674f8af10e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503347 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822153}
-
Jakob Ivarsson authored
Tests using callAndExpectResolution falsely assume that the captured resolution is always sent. The sent resolution is dependent on bandwidth estimation so any changes to that can make these tests fail. This is blocking landing of: https://webrtc-review.googlesource.com/c/src/+/190143 Bug: webrtc:6762 Change-Id: I69c226ca146db7cd03dd90c073aa84cc0d064d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506433Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#822152}
-
Reda Tawfik authored
This CL disables "Use other password" button on low level security sites Bug: 1129026, 1104132 Change-Id: I7bb85d2179933420f8c13b3e1dce7d30d81ffb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470658Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#822151}
-
Rayan Kanso authored
This reverts commit 9d31a5ee. Reason for revert: Android test bots failing Looks like the test is causing a segfault. Sample run: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/623 Bug: 1143642 Original change's description: > Add fetch uploading big arraybuffer test in LoaderBrowserTest. > > This CL adds fetch uploading 150Mbytes arraybuffer test. > > Since similar layouttest was so slow, I decided to test it in browser > test. > > Bug: 919361 > Change-Id: I693e67666e71b999276f25cfe0c0ff56436c4369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490964 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821648} TBR=mmenke@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919361 Change-Id: Id415f1e404bc9bb53ae8e04a9556238314593f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506181Reviewed-by:
-
