GitLab

Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://codereview.chromium.org/2254963002/ )"

This reverts commit d1109b15.

The crash rate is too high and polluting crash report data.
I'll reland it when the fix lands.

BUG=636377
TBR=jam

Review-Url: https://codereview.chromium.org/2338113002
Cr-Commit-Position: refs/heads/master@{#418462}

https://pdfium.googlesource.com/pdfium.git/+log/63f545c485c0..2ca2da505ba7

$ git log 63f545c48..2ca2da505 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 dsinclair Sort include entries.
2016-09-13 tsepez Add check for trivial string equality
2016-09-13 tsepez Remove inner FX_DATETIME struct from CPDFSDK_DateTime

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2332383003
Cr-Commit-Position: refs/heads/master@{#418461}

Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not be used.

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2335283002
Cr-Commit-Position: refs/heads/master@{#418460}

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737

Review-Url: https://codereview.chromium.org/2337013002
Cr-Commit-Position: refs/heads/master@{#418459}

BUG=646443, 623700

Review-Url: https://codereview.chromium.org/2338893003
Cr-Commit-Position: refs/heads/master@{#418458}

Looks like unified logcat of the results causes exception on the bot.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2343493002
Cr-Commit-Position: refs/heads/master@{#418457}

PrinterSpecifics will sync Printer device information for Chrome OS.
This just adds the proto.  Actual syncing will follow.

BUG=616862
TEST=Unit tests pass.

Review-Url: https://codereview.chromium.org/2306763002
Cr-Commit-Position: refs/heads/master@{#418456}

Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'

Running ninja twice now reports "no work to do" again.

This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.

build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.

BUG=646165

Review-Url: https://codereview.chromium.org/2336173003
Cr-Commit-Position: refs/heads/master@{#418455}

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2270993003
Cr-Commit-Position: refs/heads/master@{#418454}

Made ElementRareData store ComputedStyle on LayoutObject of it's base
class NodeRareDataBase if it has a LayoutObject.
Otherwise it is stored on the ComputedStyle member of ElementRareData.

The reason for this is to make it consistent with storage of
ComputedStyle on Node, which stores a union that can be one of:
1) a ComputedStyle
2) a LayoutObject (ComputedStyle can be stored on this)
3) a NodeRareData (LayoutObject can be stored on this which stores
ComputedStyle or if no LayoutObject ComputedStyle can be stored
directly on ElementRareData)

This patch encapsulates the logic of where to store the ComputedStyle
on the ElementRareData so that it doesn't need to be done at the call
site (e.g. in new method Node::setComputedStyle from
https://codereview.chromium.org/2001453002)

The clearComputedStyle method is special and only clears the
ComputedStyle member as its current use is not intended to clear a
LayoutObject's ComputedStyle.

BUG=595137

Review-Url: https://codereview.chromium.org/2293713002
Cr-Commit-Position: refs/heads/master@{#418453}

The prefix is redundant with the class name. TYPE_ cannot be stripped
because the members like "2G" wouldn't be a proper identifier.

BUG=629299
R=xunjieli

Review-Url: https://codereview.chromium.org/2341443002
Cr-Commit-Position: refs/heads/master@{#418452}

The filter fix temporarily uses the slow path before we have full
support of filter in paint property tree.

Test: run-webkit-tests --additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation paint/invalidation
Ran 838 tests. 2 crashes, 99 failures. (55 less failures/crashes than
https://codereview.chromium.org/2334113002/).

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2332353003
Cr-Commit-Position: refs/heads/master@{#418451}

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org
BUG=645716

Review-Url: https://codereview.chromium.org/2339783002
Cr-Commit-Position: refs/heads/master@{#418450}

BUG=640996

Review-Url: https://codereview.chromium.org/2337343002
Cr-Commit-Position: refs/heads/master@{#418449}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bde91cb96f13..1d2ebc4608d2

$ git log bde91cb96..1d2ebc460 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 benjhayden Fix metrics-side-panel

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2339603003
Cr-Commit-Position: refs/heads/master@{#418448}

BUG=643016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2307703002
Cr-Commit-Position: refs/heads/master@{#418447}

resizing.

This also requires changing Widget::SetInitialBoundsForFramelessWindows,
which inexplicably constrains the bounds to a rectangle that is smaller
than the work area.

BUG=646418

Review-Url: https://codereview.chromium.org/2337213002
Cr-Commit-Position: refs/heads/master@{#418446}

BUG=646509

Review-Url: https://codereview.chromium.org/2335193004
Cr-Commit-Position: refs/heads/master@{#418445}

Now ScrollPerformance also reports network bandwidth utilization.

Also removed two outdated tests: StreamFrameRate and IntermittentChanges.
These tests were intended mainly to evaluate performance of the PseudoTCP
layer and they were using verbatim video codec. They are not applicable
for WebRTC-based protocol. Also the protocol perf tests have been updated
to use SoftwareVideoRenderer which allows to get FrameStats when using
ICE protocol and this approach is not compatible with the old tests.

Bandwidth utilization numbers I get currently with 8Mbps bandwidth:
ICE: 93%
WebRTC: varies from 21 to 25%

The second number also goes to 32 when I change test length and warm-up
time to 5 seconds. This suggests that the problem is partly that the
bandwidth estimate in WebRTC is below the actual bandwidth in the test and
it takes a lot of time to ramp up.

BUG=645656

Review-Url: https://codereview.chromium.org/2338693002
Cr-Commit-Position: refs/heads/master@{#418444}

BUG=

Review-Url: https://codereview.chromium.org/2233373002
Cr-Commit-Position: refs/heads/master@{#418443}

https://chromium.googlesource.com/skia.git/+log/cecd617a4297..21cc9950c4b4

$ git log cecd617a4..21cc9950c --date=short --no-merges --format='%ad %ae %s'
2016-09-13 mikejurka re-add SkDebug_stdio for Fuchsia builds
2016-09-13 bungeman Simulated fonts aren't TrueType fonts.
2016-09-13 fmalita [SVGDom] Linear gradient 'gradientTransform' support
2016-09-13 mtklein Update gn_android_flavor for Vulkan.
2016-09-13 jcgregorio No \n in bench names.
2016-09-13 mtklein Android GN: don't reboot before running

BUG=639198

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2336233003
Cr-Commit-Position: refs/heads/master@{#418442}

BUG=645774

Review-Url: https://codereview.chromium.org/2329243002
Cr-Commit-Position: refs/heads/master@{#418441}

setStreamMute() was deprecated in Marshmallow, but this
invocation is restricted to Lollipop. Move the logic into
a private method and annotate it with @SuppressWarnings.

BUG=Internal b/31140436
TEST=Build cast_shell_apk

Review-Url: https://codereview.chromium.org/2334383002
Cr-Commit-Position: refs/heads/master@{#418440}

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2335043002
Cr-Commit-Position: refs/heads/master@{#418439}

This attempts to deflake two tests which flake on the Lollipop low-end
tester.

WebappSplashScreenIconTest#setUp decodes a string into a bitmap, which
is then encoded back into a string. Remove both of these steps so that
the string is directly inserted into WebappDataStorage. This
speculatively deflakes WebappSplashScreenIconTest#testShowSplashScreen,
which has a criteria takes too long timeout.

WebappSplashScreenTest#testUmaWhenSplashHides fails an assert for
a histogram value representing the number of milliseconds that the
splashscreen was shown. On the theory that the slow device is showing
the splash screen for longer, the speculative fix is to check more of
the histogram buckets.

BUG=636633

Review-Url: https://codereview.chromium.org/2337843003
Cr-Commit-Position: refs/heads/master@{#418438}

Various places in the code like FetchDataLoader and WorkerScriptLoader
keep a StringBuilder as a data member to buffer data and then call
toString() on it later. By clearing the buffer in the string conversion
methods we avoid having two copies of the values in memory persistently.

This restores the behavior from before I switched it to a Vector in
https://codereview.chromium.org/2046353002 where toString() and
toAtomicString() would always clear the buffer when converting to a
string because they called reifyString.

While I haven't been able to confirm this is the cause, this seems a
possible candidate for the small regression on system health benchmarks.
It's also just generally better behavior since it avoids an accidental
2x memory increase from a StringBuilder member.

This also makes appending individual characters cheaper by removing the
branch from resetting m_string every time.

BUG=633197

Review-Url: https://codereview.chromium.org/2335193005
Cr-Commit-Position: refs/heads/master@{#418437}

I had overlooked this in previous submission.  This histogram would be useful.

BUG=643552

Review-Url: https://codereview.chromium.org/2337103005
Cr-Commit-Position: refs/heads/master@{#418436}

https://pdfium.googlesource.com/pdfium.git/+log/f86ca3884886..63f545c485c0

$ git log f86ca3884..63f545c48 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 tsepez CFX_FloatPoint default constructor and equals operators

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2339763002
Cr-Commit-Position: refs/heads/master@{#418435}

This runs blink_platform_unittests twice on Marshmallow 64 bit Tester.
Once via non-swarming, and again on swarming.

Plan is to let this run for a bit and if it fails identically, fully swarm
the bot.

BUG=

Review-Url: https://codereview.chromium.org/2336063004
Cr-Commit-Position: refs/heads/master@{#418434}

https://chromium.googlesource.com/angle/angle.git/+log/47cb73a..7ebb97f

BUG=chromium:645071

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2336213003
Cr-Commit-Position: refs/heads/master@{#418433}

Revert of Apply first-line transform-text style (patchset #3 id:40001 of https://codereview.chromium.org/2331793002/ )

Reason for revert:
Still hitting clusterfuzz.

Original issue's description:
> Apply first-line transform-text style
>
> A second go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
>
> BUG=129669,644733
>
> Committed: https://crrev.com/25c2cadce2d4a92f4f0f8b669fed2d097a6b7afa
> Cr-Commit-Position: refs/heads/master@{#418032}

TBR=eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=129669,644733

Review-Url: https://codereview.chromium.org/2337133004
Cr-Commit-Position: refs/heads/master@{#418432}

Ironically, removing OnEnabledChanged() fixes this bug. Not calling
through to the parent class's implementation was problematic, but it
turns out that handling changes to the enable state isn't necessary
anyway since that's done with the state parameter of
ImageButton::SetImage().

BUG=645353

Review-Url: https://codereview.chromium.org/2340503002
Cr-Commit-Position: refs/heads/master@{#418431}

This CL fixes some spelling errors in translation descriptions.

BUG=589630

Review-Url: https://codereview.chromium.org/2337093003
Cr-Commit-Position: refs/heads/master@{#418430}

It's failing on multiple GPU types on macOS.

BUG=599272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org,ccameron@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2331363004
Cr-Commit-Position: refs/heads/master@{#418429}

https://codereview.chromium.org/1960543002 introduced some flakiness in
these tests, which appears to be due to texture sampling flakiness in
Mesa.  One workaround for this is to resize the bitmap in the tests to
be 256x128.  Because the tile (and the tile draw quad) will use this
size directly (instead of rounding up to some other size), the tile
and the render pass share the same size and are nice round numbers,
so texture sampling should have no errors.

BUG=621892

Review-Url: https://codereview.chromium.org/2304243002
Cr-Commit-Position: refs/heads/master@{#418428}

This problem was introduced several months ago (crbug.com/462689) and
causes a crash when a GTK dialog is displayed on debug, non-component
builds on Linux.  The fix is to include some additional linker flags in
this scenario (see libgtk2ui target as another example of this
workaround) which allows the framework to run correctly.

BUG=613231

Review-Url: https://codereview.chromium.org/2333313003
Cr-Commit-Position: refs/heads/master@{#418427}

BUG=618889

Review-Url: https://codereview.chromium.org/2337073005
Cr-Commit-Position: refs/heads/master@{#418426}

This change goes along with
https://github.com/chromium/badssl.com/pull/206, which adds the
preloaded-expect-ct.badssl.com to badssl.com and serves the Expect-CT
header with no SCTs. Along with this CL, we'll get an easy way to
manually test Expect-CT end-to-end, by visiting
preloaded-expect-ct.badssl.com in Chrome and seeing that a report gets
generated and logged on the server side.

BUG=

Review-Url: https://codereview.chromium.org/2336373002
Cr-Commit-Position: refs/heads/master@{#418425}

BUG=639632

Review-Url: https://codereview.chromium.org/2325763004
Cr-Commit-Position: refs/heads/master@{#418424}

This CL enables VideoCaptureDeviceTest.TakePhoto for
Android. (Note that, due to other circumstances, it'll
only be enabled for devices implementing the Camera2
API in non-legacy mode).

The only modification is that Android creates JPEGs
with APP1 JFIF header, because it includes EXIF information.

BUG=518807, 626857

Review-Url: https://codereview.chromium.org/2340573002
Cr-Commit-Position: refs/heads/master@{#418423}