- 28 Nov, 2019 40 commits
-
-
danakj authored
Use OnceCallback where possible, and use BindRepeating() where it is meant to be a RepeatingCallback. TBR=sergeyu@chromium.org Bug: 1007709 Change-Id: I4408f77d876e5b72017892ebc2195dafabadfccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943048Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720028}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/033be28e..c742e26b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1644331a3cb8c562001a227659ea07799f8723f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942988Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720027}
-
Sean Gilhuly authored
The Dawn swapchains now return TextureViews instead of Textures. Update to match the latest API. Following the swapchain change, this Skia patch is also needed to build SkiaRenderer Dawn: https://skia-review.googlesource.com/c/skia/+/254810 Bug: 1021566 Change-Id: I5ff967e5ddfc1fd66e59c4724c6e8f74bd6ff0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941188Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#720026}
-
danakj authored
TBR=sky@chromium.org Bug: 714018 Change-Id: I02a0ee32e2b8113c205ed0353e0b4b330fd732de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942871 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: Idf5eb75341cf69bce7038678cb596a738584e6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942989 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#720024}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d6e903bdc9ef..4cea2aef55dc git log d6e903bdc9ef..4cea2aef55dc --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com Regres: Use android.googlesource.com for dEQP Created with: gclient setdep -r src/third_party/swiftshader@4cea2aef55dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaab91d0a7acf36469d8fe5495deb86f315d24d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720023}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I5f5caa29c0ff72ca384c17a8b5c2426394f20c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942549Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720022}
-
Mihai Sardarescu authored
Bug: 1028523 Change-Id: I7c1de5e352bbf696e9d0a59c72d616c8daeafd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942434 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720021}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/455af892685f..e6b3c2f71351 git log 455af892685f..e6b3c2f71351 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 ilkos@google.com Fix non-reentrant metadata Created with: gclient setdep -r src/third_party/perfetto@e6b3c2f71351 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I406c799131c56c67e76fdd92a362216c1678d9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942769Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1002539 Change-Id: I75d52584a892bb517b15e97a3d2877e676071ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932808 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLVideoElement> and DynamicTo<HTMLVideoElement> as new downcast helper 2. Use IsA<HTMLVideoElement>(element) in place of IsHTMLVideoElement(element) Bug: 891908 Change-Id: Ia65adf5e774d782c21cd911f11c065b96c9b2566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930759 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#720018}
-
Mark Cogan authored
As the first step in making coordinators more consistent in their public APIs and internal usage of Browser, CommandDispatcher is moving to be created and owned by Browser instances. Note that this still leaves us with two dispatchers per scene; one for regular tabs and one for OTR tabs. Untangling that is a separate (and more painful) effort. This change should have no direct side effects Change-Id: I81211a33616cf3c47cc8c286da09166bf1003d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940244 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720017}
-
Alex Chau authored
- Disable check for SharingService instead, which only applies when kSharingDeriveVapidKey is enabled by field trial config, which is never the case for branded builds. Bug: 1028113 Change-Id: I1b9368692ffe3bcf8e2c6cfc4fa8ad4d51867ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942435Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720016}
-
Koji Ishii authored
Following bot results are included. 418 419 420 424 431 433 437 439 440 447 449 450 451 33 lines were removed and 21 lines were deflaked by consecutive results since 419. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I110d57d3724c46ccd5b5131a2c364585775cb5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936695Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720015}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7694024878c8..55fea94c8239 Created with: gclient setdep -r src-internal@55fea94c8239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ibce7ef7a09e7597c44f865ba2624353927046162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942868Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720014}
-
Geoff Lang authored
GPU progress would only be reported after destroying all resources in PassthroughResources but when many objects were allocated the entire process could cause GPU hangs. Report progress after each texture, buffer, renderbuffer or program is destroyed to ensure that no hangs are detected during this process. BUG=1027064 Change-Id: I24fe4c89499f642e2137fd4b8b59d007b7690fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934587Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720013}
-
Joe Mason authored
Bug: 1004848 Change-Id: If501b9dc47dade3fc03396935d8f775ff479d0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939934Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720012}
-
Ella Ge authored
This CL migrates some UserActivation related web_tests (layouttests) to use testdriver (or gpubenchmarking), instead of EventSender. This CL also fixes these test with BrowserVerifiedUserActivationTypeMouse enabled. Because EventSender generated events are not from browser side, so the browser side verification will failed. This CL update the failing mouse type tests to use either testdriver or gpubenchmarking, so that events are correctly dispatch from browser side. Bug: 848778 Change-Id: I23380932d083aef18cf1f54d82621e5e96c52ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872928 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#720011}
-
Julian Pastarmov authored
The policy will lock some user selectable types in the disabled state while allowing the user to control all others individually. BUG=649062 TEST=Existing unit and browser tests cover this code. Change-Id: I14ecf261df5b218ba269fdf669eba1b9f0afcc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860026Reviewed-by:
-
Maksim Moskvitin authored
This CL adapts TryDecryptPendingKeysWith() in UpdateCryptographerFromNonKeystoreNigori(). This allows avoidance of some case handling and simplifies future validation of pending keys after decryption. The only behavioral change is issuing ModelError in case remote keybag doesn't contain its encryption key. This change should be safe, since this is significant protocol violation, which should never occur and if occur it's safer to stop syncing to avoid further data corruption. Bug: 1020084, 922900 Change-Id: I9285aa442300431b83c2aca078cac31c2edb4b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925059 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2610646af11..bc42a63a70fc git log d2610646af11..bc42a63a70fc --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tvanderlippe@chromium.org Remove conditional for external_frontend 2019-11-28 aerotwist@chromium.org Migrates web_audio/ to esm 2019-11-28 mathias@chromium.org Fix `npm test` when run from the devtools/devtools-frontend repo 2019-11-28 aerotwist@chromium.org Migrates security/ to esm 2019-11-28 aerotwist@chromium.org Updates deps script; adds Puppeteer Created with: gclient setdep -r src/third_party/devtools-frontend/src@bc42a63a70fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1006759,chromium:1027519 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic4d79163ce9337f8fbce3d8507d4548e56c8bff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942490Reviewed-by:
-
Kaan Alsan authored
Per spec [1], snap containers should attempt to snap after layout changes and initial layout. If the previously snapped element still exists after the layout change, then the container must snap to it. This patch only considers snap targets set on the main thread since snap targets set on the impl thread are currently not synced back to main; this behaviour will be implemented in a follow-up. Design doc: https://docs.google.com/document/d/1Ufy55a19-iquba-LBiAE6AS2yBzfBQ5ZHFSpZGabS4c/edit?usp=sharing [1] https://drafts.csswg.org/css-scroll-snap/#re-snap Bug: 866127 Change-Id: I1442e0f464408fb5d9c49c5748a45aec0ed4d166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912906 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720007}
-
Mikel Astiz authored
Such instantiations were temporarily allowed in https://chromium-review.googlesource.com/c/chromium/src/+/1883567 before migrating all tests that depended on it. Now that no tests rely on such mechanism, the API can be removed, and the absence of nested instances enforced via DCHECKs. The only exception to this was SearchProviderFeatureTestComponent which was recently changed to exercise nested FieldTrialList instances. Since it's simple to fix, and before additional tests run into the same issue, the test fixture is updated as part of this patch. TBR=krb@chromium.org Bug: 1011088,891959 Change-Id: I92b58ca5361351247567c512084aebc17d7348bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904200 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#720006}
-
Lucas Furukawa Gadani authored
Bug: 759184 Change-Id: I3cb3b30d7c52c6ce174833702057d9c323f688f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942870Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720005}
-
Christopher Grant authored
Bug: None Change-Id: I132f7714d5cd632af313467f91f8368e71098665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941110 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#720004}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df0056acafd6..f145c8234627 git log df0056acafd6..f145c8234627 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 fqj@chromium.org lib: add XkbToKcmConverter for VM Mst build 2019-11-28 vapier@chromium.org cbuildbot: validation_pool: drop unused module 2019-11-28 vapier@chromium.org signing: get unittests passing under Python 3 2019-11-28 mmortensen@google.com BuildAPI: Add unit tests and mocks for Artifacts service. 2019-11-28 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-28 ahassani@chromium.org Revert "paygen: disable payload verification" 2019-11-28 sanikak@chromium.org auto_updater: Adding CheckPayloads() method to LabTransfer 2019-11-28 vapier@chromium.org cipd: fix bytes/string handling when downloading 2019-11-27 vapier@chromium.org cbuildbot: generic_builders: fix encoding when writing 2019-11-27 mmortensen@google.com BuildAPI: Add unit tests for Test service ChromiteUnitTest and DebugInfoTest. Created with: gclient setdep -r src/third_party/chromite@f145c8234627 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie38ff0ab81f074a6c88e5bb253bf324bff092f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942489Reviewed-by:
-
Maksim Moskvitin authored
ForeignSessionsMatchChecker used to check foreign sessions against the *snapshot* of local sessions on other profiles. If these local sessions change again after taking the snapshot (due to postponed events) before check has been completed, then check fails. This might not affect other sessions test because they complete sessions sync faster (before new local changes). The solution is to grab local sessions in every IsExitConditionSatisfied() call. ForeignSessionsMatchChecker now compares foreign sessions only against single profile, instead of all given windows. Bug: 1028968 Change-Id: Ib8c3ea1c71f90e8a5dfc22609eac08c5e3681daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942128 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Koji Ishii authored
This patch implements hit-testing for when FragmentItem is enabled. Existing logic for |NGPaintFragment| is abstracted by using |NGInlineCursor|. Hit-testing text items and culled inline boxes are not implemented yet, I will work on in following patches. ~30 new failures, fixes ~740. There should be no behavior changes unless FragmentItem run-time flag is enabled. Bug: 982194 Change-Id: I4b7ff6020f8d6edfb898ead65976ef6a276cce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935773 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720001}
-
Corentin Wallez authored
The test has been failing since it was introduced. TBR=ynovikov@chromium.org BUG=chromium:1029329 Change-Id: Ifa053cbee22dee75700cbde0895659fe41e65f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942432Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#720000}
-
Ian Clelland authored
This matches the spec change in https://github.com/w3c/webappsec-feature-policy/commit/61b1af7, motivated by the change in WebIDL at https://github.com/heycam/webidl/pull/609, and fixes the test failures introduced by that change. Change-Id: I444db6507d23af766ac325567111b79c7b37f040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830284Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#719999}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=clamy Bug: 953861, 1007763 Change-Id: I408c08684fb08a5ccb135d81acfdccef8f97d779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937862Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719998}
-
Andreas Haas authored
The implementation works directly on ArrayBuffers, and ArrayBuffer get changed from unsigned to size_t at the moment. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I9970fd9c27219be48227906910ac5350b230428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932807 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719997}
-
Kevin McNee authored
Implements a basic ability to navigate back and forward across a portal activation based on a linear model of portal history. Upon activation, only a portal contents' last committed entry is added to user facing session history. When the portal contents is swapped in, its NavigationController copies the navigation entries of the predecessor and combines them with its last committed navigation. Note that this does not cover the full design. Notably, the replace/traverse options of activation are not implemented. If we want to require navigation in a portal to be done with replacement, that's not implemented. Various races/edge cases are not yet addressed or cause us to bail out on the transfer of history entries for now. Bug: 914108 Change-Id: Ie44f8c77b80eb734db519a57ab63ad88a673b862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807192 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719996}
-
Tien Mai authored
These docs outline exactly what is checked when a policy is modified to ensure that no backwards incompatible changes are introduced. Bug: 1026330 Change-Id: Ibc9811727e458ffd02aa25ca9caef482317aea4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942809Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#719995}
-
Liquan (Max) Gu authored
In the new bottom-sheet based Payment Handler UI, the Payment Request UI is currently obstructing the PH UI. This is because PR UI is a Dialog, and the PH UI is a widget on the ChromeActivity - Dialogs displayed on the top graphic layer of their activity. To solve this issue, this CL change to hide the PR UI when opens a PH UI, and reshow the PR UI when hides the PH UI. The way to implement this behavior is to create a coordinator responsible for coordinating the display of both UIs, so that: * at most one of PH UI, PR UI is displayed at any moment * PH UI is prioritized over PR UI * the coordinating mechanism is robust to the external factors, e.g, a timeout event tries to show the PR UI when it's not supposed to be shown. As a side issue this CL solves, clicking the PR UI's "Pay" after hiding the PH UI used to fail. This was because the PH UI reference wasn't cleaned up when hiding. This CL adds a cleanup callback on PH UI closed to solve the issue. Bug: 999196 Change-Id: Ic602378cc30e93d1ba318a55006100feab7eac50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924600Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719994}
-
Renato Silva authored
Implements the sticky footer gradient for OOBE screens on Chrome OS. Adds the behaviour 'CrScrollableBehaviour' to oobe-dialog and make its 'top-scroll-container' 'scrollable'. Bug: 1017621 Change-Id: Ieb0a62e1cf5054cf461addaa8d493a762334a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916872 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/241ab903..033be28e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I728f191596ee898fa11639c7846ed3c6ae8e7886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942567Reviewed-by:
-
David Roger authored
This CL reverses part of the change introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 The reason is that we don't want the pill to stay open while the password bubble is displayed, as the user may mistakenly believe that their password is uploaded to their google account. TBR=pbos, tangltom Fixed: 1027112 Change-Id: I7bdbc4a2020ba3511f2379a737146e7b61458551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942332 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719991}
-
Ewann authored
- Adds downloads action and icon to tools menu that opens Downloads folder. _ Adds keyboard shortcut to open Downloads. Bug: 1013572 Change-Id: I820298c1d3800ea86aef401ac1fdcf9d8eeed10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901075 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719990}
-
Alex Clarke authored
Without this GPU process chain crashes trying to load ExternalBeginFrameSourceAndroid. Change-Id: I011bdd517167e622d04ba9e65f8bd7d283811b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942338 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719989}
-
