GitLab

Add a minimal test for whether transferable streams are functioning or
not. This can be used to determine whether they have been shipped or
not. The test is in its own directory so that it can be added to the
virtual/stable test suite without any other tests.

This will ensure we don't accidentally ship transferable streams.

BUG=894838

Change-Id: I2de66a55fc1c72ddd742f1d192a152a9264064df
Reviewed-on: https://chromium-review.googlesource.com/c/1356723
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613060}

- Reorder all overrides to be grouped by interface, and match the
  interface's ordering.
- Remove a second ctor that isn't necessary anymore.
- Remove some unnecessary includes.

Bug: 910518
Change-Id: I4123e4ce9cd8eeac4fd2cef051e094cccc8c7d14
Reviewed-on: https://chromium-review.googlesource.com/c/1356702
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613059}

 - add Closure @type annotations to unittest JS types
 - add setUp(), add setDriveFsEnabled() helpers
 - prefix test cases with a descriptive comment

No change in test behavior, no new tests.

Bug: 911024
Change-Id: Iaa1bcf5b4ab00d7e2c89875361ff14b1dee03a00
Reviewed-on: https://chromium-review.googlesource.com/c/1358316
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613058}

This CL reverts half of https://crrev.com/c/1329161 by enabling
testModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab
that was disabled by the CL. The issue that was causing the failures
should've been fixed by https://crrev.com/c/1345069.
testAppInstalledModalNativeAppBannerCustomTab, the second test disabled
by https://crrev.com/c/1329161 is not enabled by this CL, as it fails
with TimeoutException (doesn't seem to be connected to the failure fixed
by https://crrev.com/c/1345069).

Bug: 903657
Change-Id: I4ef52c1bfe9d560fecbcfa4e389baffef758fe15
Reviewed-on: https://chromium-review.googlesource.com/c/1350187Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613057}

Using wpt-import in Chromium 24a9832f.
With Chromium commits locally applied on WPT:
b19fca31 "Consistently round table row heights."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Ie9a1d0eaf761cd07a3713b3ca38560a81e164bed
Reviewed-on: https://chromium-review.googlesource.com/c/1357863
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613056}

This CL updates the trailing button displayed in the omnibox popup rows.
- The asset for the Switch to Open Tab button is updated.
- The color is changed, including the system button effect on highlight.
- The previous assets used before UI Refresh are removed.

Bug: 908777
Change-Id: I5c0b0d906089fc630824115a4e0b35d6d905c8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1352151Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613055}

This Moves the AutofilProfileCollectionViewController to use a
UITableView instead of an MDCCollectionVC.
It also reset _deletionInProgress to NO after doing an update, because
it seems that it wasn't reset before (removing one entry ignored all
model updates).

Bug: 894791
Change-Id: I96b61cb71d25aae1d6974a7ae2612659803b6404
Reviewed-on: https://chromium-review.googlesource.com/c/1350956Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613054}

This CL introduces several further integration tests for autofill wallet
metadata. All these tests involve "being offline" which is simulated by
the fake server returning errors.

This CL also changes the behavior in a minor way: it changes merging
two entities that have never been used. The change is non-controversial;
the main motivation for it is to allow writing crisper integration
tests.

Bug: 894001
Change-Id: I6e29c5ff8f96f6b40bb77f77e881ce1bb3ffbe25
Reviewed-on: https://chromium-review.googlesource.com/c/1335931
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613053}

Make flat tree traversal's parent operation faster by avoiding
a lookup of a hashmap (slotname-to-slot) (in ShadowRoot::AssignedSlotFor)
if FlatTreeNodeData's assigned_slot_ can be used.

The feature is under the FastFlatTreeTraversal flag.

BUG=906494

Change-Id: Ia93b8a045146cdfb7008fc5e5914f19ecbd0fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/1350441Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613052}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b501f25a2ef8..bfdfca78e079


Created with:
  gclient setdep -r src-internal@bfdfca78e079

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If3c5285dec046d116886d3421e5960a2f159f515
Reviewed-on: https://chromium-review.googlesource.com/c/1358205Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613051}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6acd03c9..c0d45675

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0c6608cfa49eccbe06bfb961a9a18a34cf9ce9a0
Reviewed-on: https://chromium-review.googlesource.com/c/1357832Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613050}

This CL adds a policy handler for the HomepageLocation policy that
filters out invalid URLs and URLs with a non-standard scheme. It used
to be possible to set Javascript as homepage, which would then execute
in the context of the current page.

This filter applies to the policy only. The user can still use
Javascript in the homepage settings if they want to.

BUG=b:112186030
TEST=Set Javascript homepage through policy, made sure it's rejected in
      chrome://policy and policy is unset in settings; unit tests.

Change-Id: I991b2de55b7edaf67413b7695da7c566e8369600
Reviewed-on: https://chromium-review.googlesource.com/c/1186643
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613049}

Bug: 910905
Change-Id: If339d5e7a354779a094bb10d693f047cb73e5cba
TBR: dalecurtis@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1356988Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613048}

This CL adds the following trace events in the blink category:
- PendingScript::ExecuteScriptBlock
- ScriptRunner::ExecuteInOrderTask
- ScriptRunner::ExecuteAsyncTask
- ClassicPendingScript::GetSource

Bug: 865098
Change-Id: I4b8af61283bd97b0ab1d9e0b74fc0f08ce7a2293
Reviewed-on: https://chromium-review.googlesource.com/c/1356545
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613047}

Public mojom files for dedicated workers and shared workers should be placed in
public/mojom/worker.

Bug: 906991
Change-Id: I570f91823247349609afb3ce0ba62880ba14cf27
Reviewed-on: https://chromium-review.googlesource.com/c/1358291
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613046}

This CL changes how the broadcasted value of toolbar height is done.
The value is now broadcasted when the view will become visible instead
of when it did become visible.
Using this, the toolbar insets are updated when the view will become
visible, allowing a smoother animation when the screen has been rotated
in background.

Bug: 908796
Change-Id: I49e42fa9246ff76fc702243a3f6571cb81ab912c
Reviewed-on: https://chromium-review.googlesource.com/c/1356588Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613045}

https://dawn.googlesource.com/dawn.git/+log/8b07e43dadf8..9ca9435087e0


git log 8b07e43dadf8..9ca9435087e0 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 cwallez@chromium.org Rename BindGroupBinding -> BindGroupLayoutBinding


Created with:
  gclient setdep -r src/third_party/dawn@9ca9435087e0

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Id6ebb7e953dfdcd3f811c33ac338abf62ae6bcd2
Reviewed-on: https://chromium-review.googlesource.com/c/1358207Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613044}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0b287c5bcafd..96fdf7cbe6ed


git log 0b287c5bcafd..96fdf7cbe6ed --date=short --no-merges --format='%ad %ae %s'
2018-12-03 tikuta@chromium.org [ninja] collect build configs


Created with:
  gclient setdep -r src/third_party/depot_tools@96fdf7cbe6ed

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:900161
TBR=agable@chromium.org

Change-Id: I535fbd510142cb5dc9c1811614b248986b533c7f
Reviewed-on: https://chromium-review.googlesource.com/c/1358204Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613043}

This patch introduces the new API, which allows to enable/disable the invalidations
for noisy session sync related datatypes.

The session sync generates a lot of changes, which results into many
invalidations, which should be processed. This can negatively
affect the battery life on Android. For that reason, on Android,
the invalidations for the Sessions should be received only
when user is interested in session sync data, e.g. the history
sync page is opened.

Bug: 909682
Change-Id: I3e875543a8aa17c7b374fb8d963a3dd19e8deccc
Reviewed-on: https://chromium-review.googlesource.com/c/1353933
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613042}

This reverts commit be3c24b4.

Reason for revert:
FindIt has detected it as culprit for at least two tests that started flaking. The FindIt analysis looks correct, but please take a look at the bugs and reland if you think this should reland.
See crbug.com/910997 and crbug.com/910921

Original change's description:
> Reland "Reland "Start gpu channel and compositor mojo pipe collection eagerly""
> 
> This is a reland of eacb6ed3
> 
> The flaky test has been disabled.
> 
> TBR=piman
> 
> Original change's description:
> > Reland "Start gpu channel and compositor mojo pipe collection eagerly"
> >
> > This is a reland of 66794d00
> >
> > In this reland we revert changes to RenderThreadImpl and mus to make
> > LayerTreeFrameSink creation asynchronous again.
> >
> > Then in RenderWidget we must remember that a warmup is underway, we do
> > so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool
> > and invalidate the WeakPtrFactory.
> >
> > If a request for a frame sink beats the warmup completing, we save
> > the callback and run that instead of saving the frame sink on
> > RenderWidget when the warmup completes.
> >
> > This ignores some weird weird corner cases like where warmup is
> > aborted then we start another warmup or unfreeze the widget or something
> > and will just make redundant requests. Since these are so rare they
> > are not worth adding complexity for.
> >
> > Original change's description:
> > > Start gpu channel and compositor mojo pipe collection eagerly
> > >
> > > When a RenderWidget is frozen, its compositor is stopped. However when
> > > the main frame is being navigated, we want to start requesting mojo
> > > pipes for the gpu and display compositor immediately so that it can
> > > happen in parallel with the navigation loading.
> > >
> > > Previously, we just always did this when creating a RenderWidget, and
> > > left them active when freezing the RenderWidget. After 678f025f
> > > however, we don't, and this causes time-to-first-pixels regressions
> > > on navigation.
> > >
> > > So we add a WarmupCompositor() method to RenderWidget, and call this
> > > from RenderFrameImpl::CreateFrame() when it makes the provisional
> > > frame, and the WebFrameWidget, since we expect to make use of the
> > > main frame RenderWidget shortly.
> > >
> > > Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> > > navigation failing, we will AbortWarmupCompositor() to drop the
> > > mojo pipes instead of holding onto them indefinitely.
> > >
> > > This recovers the loading regressions introduced, while also not
> > > allocating mojo channels for frozen RenderWidgets indefinitely.
> > >
> > > In order to do this reasonably, we drop the "callback" from the
> > > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> > > it always returns something immediately. This way RenderWidget
> > > does not need to worry about having a task run to collect the
> > > new frame sink, and ordering with tasks from the compositor to
> > > collect it.
> > >
> > > R=piman@chromium.org
> > >
> > > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> > > Bug: 905191
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> > > Commit-Queue: danakj <danakj@chromium.org>
> > > Reviewed-by: danakj <danakj@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Antoine Labour <piman@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#610909}
> >
> > Bug: 905191
> > Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60
> > Reviewed-on: https://chromium-review.googlesource.com/c/1351938
> > Commit-Queue: danakj <danakj@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611838}
> 
> Bug: 905191
> Change-Id: I0320c8604d50d5d83157c058c230b471c0898b26
> Reviewed-on: https://chromium-review.googlesource.com/c/1355321
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612253}

TBR=danakj@chromium.org,dcheng@chromium.org,sergeyu@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 905191
Change-Id: Ibf041a7a02c80df0f0f4a1a02803846fa443c40a
Reviewed-on: https://chromium-review.googlesource.com/c/1356810Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613041}

This CL moves the transformation of AccessorySheetTab data to
KeyboardAccessoryData.Items from the ManualFillingBridge into the
PasswordsAccessorySheetMediator.
This enables replacing the Items in a follow-up CL completely and use
the AccessorySheetTab to implement the new layout for the passwords.

This is a step towards generalization of accessory sheet tabs as new
tab will be able to add separate element types with respective views.

Bug: 853772
Change-Id: I678d453245568ef006de932274db044b14ffbdfa
Reviewed-on: https://chromium-review.googlesource.com/c/1350890Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613040}

This reverts commit ff451c7b.

Reason for revert: Suspect of causing consistent failure of xr_browser_tests on Win10 Debug (NVIDIA) bot.

See 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29

First failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/10962



Original change's description:
> Enforce active lifetime of XRFrame objects
> 
> Deactivates XRFrame objects once the relevant callback returns, which
> causes future calls to the object methods to throw an exception.
> 
> Bug: 906842
> Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753
> Reviewed-on: https://chromium-review.googlesource.com/c/1343065
> Commit-Queue: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612887}

TBR=bajones@chromium.org,klausw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 906842
Change-Id: I26eb3477ea875362a5f1e6fd0b67bbe4a3c2c4a5
Reviewed-on: https://chromium-review.googlesource.com/c/1356945Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613039}

This makes worker_main_script_load_params.mojom in the directory reusable for
PlzDedicatedWorker.

Bug: 906991
Change-Id: I5a5768bab54f7fa76c758afbfcc1f3bd22928385
Reviewed-on: https://chromium-review.googlesource.com/c/1358197Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613038}

Set the status of the "TransferableStreams" feature to "experimental". This
means that it is enabled by default for layout tests, and behind the
"experimental web platform features" in the browser.

Remove the virtual test suite for the feature.

BUG=894838

Change-Id: I0b1efdbbcaf08448e7578eea2ef859cea1930cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1355299
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613037}

This optimization was introduced in r578233, but with the test
included in this patch it was causing a crash.
The problem is that the RootInlineBox has more than one children
which is not expected.
In that case we shouldn't apply the optimization,
so a new condition has been added in
LayoutText::CanOptimizeSetText() to avoid it.

BUG=805785
TEST=fast/css/containment/change-text-node-data-crash.html

Change-Id: I924f30f4d0e0ae3e40f2437b54e5323a81a40051
Reviewed-on: https://chromium-review.googlesource.com/c/1356590Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#613036}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I85b84b92eb544b02920139aad88a4fb9a31d830f
Reviewed-on: https://chromium-review.googlesource.com/c/1352418Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#613035}

Enables the developer options on <= Dev builds by default and adds a way
to activate them on Beta/Stable channels via 7 taps on the chrome
version in the preferences, in android-like style.

Bug: 898512
Change-Id: Ife44df843e45d660485fb464209964c957a9c887
Reviewed-on: https://chromium-review.googlesource.com/c/1349309
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613034}

Do in LogicalHeightForRow() as in CalcRowLogicalHeight() - i.e. round
instead of floor, to convert from LayoutUnit to int. We calculated the
pagination strut incorrectly for the line that followed, because it was
based on the floored LayoutUnit height of the preceding table row.
Then, later on, it got adjusted (rounded from LayoutUnit), and the
balancing code got confused, because the line had a pagination strut,
but didn't appear to be exactly at the start of a column (there should
be no strut in such a case).

Bug: 908247
Change-Id: I11fa5430b9ff6e83b20dc25ce1d945e54b80f6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1356551
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613033}

With the work for unified ComputedStyle storage on element, found that
we are accessing the LayoutObject from the old layout tree when the
viewport defining element changes and body is marked for re-attach.

TEST=external/wpt/cssom-view/scrollingElement-*

Change-Id: I5b8d8f8291d05d058af61779992c24381f3edba0
Reviewed-on: https://chromium-review.googlesource.com/c/1356479
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613032}

This CL allows ARC to inform ArcAppListPrefs whether a newly installed
package is a web app or not. If it is a web app, ArcAppListPrefs
requests the web app's data from ARC, and upon receiving the data,
triggers an installation of the web app.

BUG=893927

Change-Id: Ia88043ef1d01f709e82340326e81de01da6c1c4c
Reviewed-on: https://chromium-review.googlesource.com/c/1314068Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613031}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b673480e9ca4..b501f25a2ef8


Created with:
  gclient setdep -r src-internal@b501f25a2ef8

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia940a0f092b4abc0e0176241c505bdf65a4cf48d
Reviewed-on: https://chromium-review.googlesource.com/c/1358203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613030}

Stop printing a bogus integer version of the id attribute for nodes. We
are already printing the string version of this attribute when it is
assigned, so removing this code should just make the output less noisy.

Bug: 909620
Change-Id: I0b2f08c99ae5e52a14483f27292c5aacd7e5eace
Reviewed-on: https://chromium-review.googlesource.com/c/1352362Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#613029}

This is a reland of a61d2bb4

The flaky test has been excluded from this patch, will be
reintroduced in a separate patch.

Original change's description:
> Reland "Avoid recycling sync tabs if commit pending"
>
> This is a reland of 62414cfc
>
> Test improved to avoid flakes.
>
> Original change's description:
> > Avoid recycling sync tabs if commit pending
> >
> > When a tab is closed, it's possible that the corresponding history
> > hasn't been committed yet, and hence there is a risk that synced history
> > is lost if the entity is recycled (for another tab that is opened).
> >
> > In this patch, and behind a feature toggle, this issue is prevented by
> > *not* freeing tab nodes while the sync entity is unsynced. Old tabs are
> > excluded from this (to avoid problems with expired history) and a max
> > cap is also introduced to the number of tabs in this state, in order to
> > avoid memory regressions.
> >
> > Bug: 882489
> > Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1356541
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612971}
>
> TBR=treib@chromium.org
>
> Bug: 882489
> Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f
> Reviewed-on: https://chromium-review.googlesource.com/c/1357086
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612980}

TBR=treib@chromium.org

Bug: 882489
Change-Id: Iaa6490f896257baa8a843ca0e7c92f2d7dc11c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1356808Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613028}

for "Web Test".
The following classes are not renamed in order to avoid to loose
blame information though their file names are renamed.

- content::LayoutTestBluetoothFakeAdapterSetterImpl
- content::LayoutTestBrowserMainParts
- content::MojoLayoutTestHelper

They are going to be renamed in a following CL.

This CL has no behavior changes.

Bug: 84341
Change-Id: I86aae05921379bb9d87af65d2203086ee57ee7d6
Reviewed-on: https://chromium-review.googlesource.com/c/1351327Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613027}

Bug: 910240
Test: unit_tests --gtest_filter=*ArcInput* --enable-features=SingleProcessMash
Change-Id: I1e836b6743026c901f1f328d96213d2a3eeb3c24
Reviewed-on: https://chromium-review.googlesource.com/c/1358292Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613026}

This macro is a no-op and can can be safely removed.

Bug: 589840
Change-Id: If00faba34a0f10a3353bc2086329b1ba0c1a0901
Reviewed-on: https://chromium-review.googlesource.com/c/1355768Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613025}

 - remove actions_model_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - make mock_drive_sync_handler visible to foreground unittests
 - Add Closure @type defines to unittest variables (OMG).
 - fix Closure compile errors

Bug: 911005
Change-Id: Ia29ca0e11ee984f00daf66271ff65e5fcb52b1c7
Reviewed-on: https://chromium-review.googlesource.com/c/1356732
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613024}

We have verified that the RBE-based builder is comparable in compile
time versus the class Goma builders.

Bug: 855319
Change-Id: Iacb8baea7291d82a09a839db4c72820482096af5
Reviewed-on: https://chromium-review.googlesource.com/c/1358113Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613023}

Undo a removal from r612849. WindowClient#visibilityState refers to the
web-exposed IDL attribute and is still relevant, even though the
mojom field name changed.

Also, change the order of the mojom fields to match the IDL attribute
order in the specification.

Change-Id: I445b82c368ac5e22e9bca4e8c22d3c7b1878eedb
Reviewed-on: https://chromium-review.googlesource.com/c/1358115Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613022}

This is a preparation to support validation in form-associated custom elements.
This CL has no behavior changes.

This CL also does:
 - Rename SetNeedsWillValidateCheck() to UpdateWillValidateCache() to match
   to the reality
 - Change a checkValidity() argument from |HeapVector<Member<
   HTMLFormControlElement>>| to |HeapVector<Member<ListedElement>>|, which is
   typedefed as |ListedElement::List|

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I0a97ae7eb85406eb0160c9bffa0568440c554a7e
Reviewed-on: https://chromium-review.googlesource.com/c/1358116
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613021}