- 20 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3fc3588cdf37..2fb0633adec8 2020-10-20 bsheedy@chromium.org [devil] Dump dmesg on pkill failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: skyostil@google.com Change-Id: I0f423ac84b7911796dc03c38583ab63d981d3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819128}
-
Koji Ishii authored
1. css/css-text/hyphens/hyphens-auto-010.html This test requires the last word of the paragraph to be hyphenated, which Blink currently intentionally doesn't today. Changes the test not to require this behavior because this test is for testing general hyphenation behavior, not the behavior of the last word. 2. css/css-text/hyphens/hyphens-auto-inline-010.html This test requires "guidelines" to be hyphenated, but the Minikin engine does not hyphenate this word. Replace it with "regulation", which is used in `hyphens-auto-010` above. TBR=yosin@chromium.org, tkent@chromium.org Bug: 1022415 Change-Id: I9e0abafa618cd03a4989df668ea49308408e81a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483724Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819127}
-
Shengfa Lin authored
Capitalize does not work well for unicode in the middle of a word. Patch Selenium atoms code regular expression to handle this case Bug: chromedriver:3611 Change-Id: I99dc7cbfef6af7db9590ad2e9e4d94e5bd765d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430768Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#819126}
-
cfredric authored
This makes the expectations more declarative, and makes it easier to express more complicated invariants. Note that in the previous implementation, kV8Screen_Height_AttributeGetter was listed twice among the expected keys, but the test did not verify that the |metrics| map contained two such keys (not that that is possible). |IsSupersetOf| is built on the idea of a multiset, so it does support checking for repeated expected elements. Change-Id: Ia2d617ed826b023bd67f5352e7094fd1136a6e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480964Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#819125}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/browser/renderer_host. Bug: 1113033 Change-Id: Idd9eb8b885f092cc0c30792b1efc9d6a040bc1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472342 Commit-Queue: Norman Rosas <normando@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819124}
-
Robert Ogden authored
This is redundant, but will help direct changes to the right reviewer. Change-Id: Ic4e92f3364d503bbe66864011efc249065592df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488704Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#819123}
-
Gang Wu authored
This reverts commit 987fb106. Reason for revert: crbug.com/1140670 this CL make org.chromium.chrome.browser.sync.ManageSyncSettingsTest#testTrustedVaultKeyRetrieval flaky on Lollipop Phone Tester Original change's description: > [Android] Don't subclass ChromeActivityTestRule in SyncTestRule > > Removes subclassing of ChromeActivityTestRule in SyncTestRule. This > subclassing meant that every test using SyncTestRule would start > ChromeActivity before starting the test. This was producing several > issues: > 1. It's hard and confusing to use SyncTestRule in tests that start > other activity types: FRE tests, bookmark tests, settings tests. > 2. It makes tests longer. > 3. It might make tests flaky. > > Some tests need ChromeActivity to be started, so this CL adds a bunch of > explicit ChromeTabbedActivityTestRule fields along with calls to > startMainActivityOnBlankPage. > > This CL also fixes and cleans up FirstRunTest. Tests will be enabled in > a separate CL (in case they're still flaky). > > Bug: 616456, 1135990 > Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818891} TBR=treib@chromium.org,bsazonov@chromium.org Change-Id: I5182024c7f07cb2bf038f4baf18833073474b751 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 616456 Bug: 1135990 Bug: 1140670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488344 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819122}
-
Rafael Cintron authored
gfx::GpuFenceHandle already has a notion of a null handle on all supported platforms. Hence, we don't need to have the corresponding mojo fields also be nullable. Bug: 1131616 Change-Id: Ie31775da704aefd26da41516455d397b67c67a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485629Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819121}
-
Gang Wu authored
This reverts commit 9cad3c10. Reason for revert: test still flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=FirstRunTest Original change's description: > [Signin][Android] Re-enable FirstRunTest > > Enables FirstRunTest that was fixed in https://crrev.com/c/2450291. > Enabling is done in a separate CL to simplify the revert in case these > tests are still flaky. > > Bug: 616456 > Change-Id: I289ccf035a22835b38917680fd74fb8ce9b3e761 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487104 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818931} TBR=treib@chromium.org,bsazonov@chromium.org Change-Id: I568904663d59c88976e55285d30a2d9805a36b0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 616456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488343Reviewed-by:
-
Willie Koomson authored
This change implements ArcMetricsService::ReportAppKill, which is called by the guest to report lmkd and OOM kills. These are passed on to MemoryKillsMonitor, which manages the corresponding UMA metrics. BUG=b:165194376 TEST=atest lmkd_unit_test; monitor Chrome log file to verify that MemoryKillsMonitor has received kill events. Change-Id: I55f1800856388e248a29de0478bb983d3f87a4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463770 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819119}
-
Toby Huang authored
FamilyUserMetricsProvider currently causes a crash in guest mode. This CL fixes the crash and categorizes guest users into the other bucket. This CL also restructures the FamilyUserMetricsProvider to an observer-based approach that improves stability and avoids unnecessary work by caching results. Bug: 1137352,1103077 Change-Id: Ie421861970f6b26def1cf7390bd89480081bcab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476897Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819118}
-
Maggie Chen authored
Damages from render passes with pixel-moving filters are now added to |surface_damage_rect_list_| in SurfaceAggregator::ProcessOverlayDamageList() Because pixel moving filters are not supported in hardware overlays. overlays on Windows are skipped if any pixel-moving filters is enabled. Bug:1064390, 1117235 Change-Id: Ifbb697ffe95b21da0327ecc4a1d10c1b4374b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452249 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#819117}
-
Xiyuan Xia authored
Bug: 1127644 Change-Id: I09de59f1ea6c53f240480e967ddb31c8ffbc904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487839Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819116}
-
Pranav Batra authored
Bug: 1138145 Test: tast run -buildbundle pita <DUT> printer.* Change-Id: Id27fd480de1ff3b65c0680e2d8021764fde1c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469374Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Pranav Batra <batrapranav@chromium.org> Cr-Commit-Position: refs/heads/master@{#819115}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/common. Bug: 1113033 Change-Id: Ieb6348a46a003f72e8a272bf80180b1649aa0ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472340Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#819114}
-
Kyle Horimoto authored
(1) features::kWebUIDarkMode. A base::Feature for this functionality already existed, but it was not part of chrome://flags and was difficult to enable for Chrome OS users. This CL adds an entry to chrome://flags on Chrome OS. (2) blink::features::kForceWebContentsDarkMode. This flag was present in non-Chrome OS builds but was disabled on Chrome OS due to https://crbug.com/1011696. This CL enables the flag for Chrome OS but does not enable any variants/experiments for this platform. Change-Id: Ie907255a95c09f3be70bd91f2eb850ca68a08c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486660Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819113}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/arc. Bug: 1113033 Change-Id: I561520fccfe728311edd65e770b52b608ecafaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472423Reviewed-by:
-
Koji Ishii authored
This patch adds hyphenation dictionaries necessary for |web_tests| to |data_deps| of |blink_web_tests_support_data|. The dictionaries were added to |blink_platform_unittests| in r818929 crrev.com/c/2483725 but |web_tests| needs to add it to |//BUILD.gn|. Also updates |WebTestContentBrowserClient| to use the directory, and update |TestExpectations|. Bug: 1139950 Change-Id: Ibf20385ad133e523d420fd39ea2f9ed54bd6cd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487020Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
-
bttk authored
Prevent NullPointerException after destroy() was called. Bug: 1140333 Fixed: 1139100 Change-Id: I3a8cd6117bf9a01e8c43d98d44798db59da9f0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481289 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819110}
-
Renjie Tang authored
Change-Id: Ia6df5a2ab8689d946652ff0945461f2d72692eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486562Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819109}
-
Gordon Seto authored
Screenshots: https://screenshot.googleplex.com/3FZ8v9G68ciNaBv.png https://screenshot.googleplex.com/8JZjZ2vYWB4fNAF.png https://screenshot.googleplex.com/kj6ecX2LXmUETHc.png https://screenshot.googleplex.com/9ehmffRYvQznfM8.png https://screenshot.googleplex.com/5JxoZNqQGPAFfWR.png Bug: 1093185 Change-Id: Ib2bb4b04c6a627a5fd107f7d8a352f22c7e7a996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453445Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#819108}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I0644c5b7dc043f7d6f04450c580d7116b9eccbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487687 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#819107}
-
Ben Pastene authored
This suite takes up ~75% of the current pool. So crrev.com/i/3351483 moves that many bots from the VM pool into chromium.tests. Will land that at the same time as this. Bug: 1132206 Change-Id: Iead4e4d571ee0ae95e005df080a9d6b1df3a4159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487783Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819106}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/34a2680533d9..5504d2fb5434 $ git log 34a268053..5504d2fb5 --date=short --no-merges --format='%ad %ae %s' 2020-10-20 vasilvv Replace QUICHE_ARRAYSIZE with ABSL_ARRAYSIZE. 2020-10-20 nharper Disable some tests in Chrome to unblock BoringSSL roll 2020-10-20 vasilvv Replace QUICHE_ARRAYSIZE with ABSL_ARRAYSIZE. 2020-10-20 vasilvv Replace QUICHE_ARRAYSIZE with ABSL_ARRAYSIZE. 2020-10-19 dschinazi Deprecate quic_prober_uses_length_prefixed_connection_ids 2020-10-19 vasilvv Replace QUICHE_ARRAYSIZE with ABSL_ARRAYSIZE. 2020-10-19 renjietang Delete the code used to record failed to serialize packet locations. 2020-10-19 mattm Close Quic connections on AEAD integrity limit of received packets that fail authentication. 2020-10-19 quiche-dev Internal QUICHE change 2020-10-19 mattm Add QuicConnectionVisitorInterface::OnKeyUpdate upcall. 2020-10-19 mattm Add KeyUpdateReason enum to KeyUpdate call & OnKeyUpdate callbacks. 2020-10-19 mattm Update Quic AES confidentiality limits for 2^11 max packet size in updated draft. 2020-10-19 haoyuewang Add kAFF2 enabling the sending of AckFrequencyFrame upon handshake completion. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ica78be4af7f8f329f2946edc4bf6d917dab0c781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485587 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#819105}
-
Yulun Wu authored
This CL removes the misnomer search_box_color_. It's setter and getter functions are never used. its only use is in search_box_view_base.cc where it is used to set the placeholder text color. Bug: 1139873 Change-Id: I2e05ae8c077dc2370aa28d5de518acbb69808f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488600Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819104}
-
Peter Kotwicz authored
BUG=1137380 Change-Id: Ib1f8c60f598b001c51904767daf36ede0d1a349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481248Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819103}
-
Kurt Catti-Schmidt (SCHMIDT) authored
The last several big GridNG changes fixed most of the crashes, so this change updates the TestExpectations entries to more accurately represent where we stand. Entries marked [ Pass ] were also removed. Bug: 1045599 Change-Id: I04a127f01665579b9945543256708e8f6ab7910c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486484 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819102}
-
Dave Tapuska authored
Remove unnecessary includes before widget_messages.h is removed. BUG=1097816 Change-Id: Id343d2e62ac6056588a254ffcfad23dd7aec04dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488005Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819101}
-
Chan Li authored
Disable resultdb for cros_browser_sanity_test and chrome_all_tast_tests. Also in this CL, disable resultdb for missed content_shell_crash_test. Bug: 1135909, 1140593 Change-Id: I5ba0864b9b5a3d680ca5e4e7db3cfe60d9622933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488089Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e874380d..5c5a7978 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I018b5cb9be63485fdbd2aa952b4c52e1ee0f0637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488362Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819099}
-
George Steel authored
These are considered separate primitive types for interpolation and using the same type tag for them in cc was causing incorrect interpolation from skewX to skewY, which should trigger matrix interpolation of transform lists and not interpolate as skew. Bug: 1131252 Change-Id: If313be7edeaae5ad18c4c02028f66eae0bc0b925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482282 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#819098}
-
Oriol Brufau authored
r815289 fixed a performance regression affecting deeply nested grids. This patch adds a perf test to cover that case. Locally it measures a performance improvement of +37,324.2% when applying r815289. Bug: 1136474 Change-Id: I2dfd731cfb4d571146e256bb97d6e33146a7039b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488480Reviewed-by:
-
Alex Gough authored
NtQuerySymbolicLinkObject length and UNICODE_STRING lengths are bytes not characters. This lead to target_path.Buffer being overallocated and luckily zero-initialized until in some contexts it wasn't, causing the sync tests to fail as they tried to look up an object with a valid name followed by garbage. Bug: 1139088 Change-Id: I0b7744a8f6d47e52f9909e895abfb0fe6a799716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485344 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819096}
-
Sammie Quon authored
Some cros windows have a transform applied to them when they're closed. When reopened they are placed where the transformed window was. The widget bounds saving uses Window::GetBoundsInScreen which returns bounds that are affected by the transform on the window. This CL alters that. Test: added test Bug: 1109161 Change-Id: Ia577b2372fa78be4cbf1ae4fbe2236fca615dd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373660 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819095}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c49da0b5192d..82f373c0d713 2020-10-20 johnstiles@google.com Wrap built-in symbol tables when an IRNode is cloned. 2020-10-20 johnstiles@google.com Fix typo in class name. 2020-10-20 robertphillips@google.com Make GrFillRectOp::onPrePrepareDraws also call base class' version 2020-10-20 adlai@google.com Reland "Remove GrContext" 2020-10-20 robertphillips@google.com Rename some of GrThreadSafeCache's member variables 2020-10-20 abarth@google.com [fuchsia] Migrate to new zx::vmar::map method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: I6d86a87ccb5421b03aa0f43cc3ba7b29b390ed51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487808Reviewed-by:
-
Daniel Cheng authored
Bug: 974061 Change-Id: Ifb85f9981d7d4c03481c1f78bd753d434fb5938a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487692Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819093}
-
Ana SollanoKim authored
Previously, grid items were placed according to document order in PlaceGridItems() in the following change: https://chromium-review.googlesource.com/c/chromium/src/+/2369673. Now that the computed grid item positions are available from https://chromium-review.googlesource.com/c/chromium/src/+/2404110, the function was refactored to use the final specified/resolved positions instead of document order. Furthermore, out of flow items are now being filtered out and stored in the vector out_of_flow_items_. The look up/calculation for the absolute and static positioned offset remains a TODO for now. Bug: 1045599 Change-Id: Ia3ad951983798d6b34f13ef80850736dd374aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444451 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
-
Francois Beaufort authored
This CL removes previous adjustments made to fix GMSCore API face detection results. This is not needed anymore as GMSCore API has been improved a lot and results are now similar to Android Face API. See screenshots at https://crbug.com/1107675#c6 Change-Id: I19fa99fe73163a778a7fba41194d0ddf2021e74a Bug: 1107675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478663Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#819091}
-
Rune Lillesveen authored
This was removed from the spec per resolution[1] and incompatible with never media queries. Improves interop with Gecko which have not seen any issues with the different serialization. Removed fast/media test which is covered by existing wpt tests. [1] https://github.com/w3c/csswg-drafts/issues/5627#issuecomment-712475204 Bug: 1138859 Change-Id: I1483008c81df90f8277dcad7e90c8036c5cc019b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478992Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819090}
-
tby authored
We're launching this experiment, and we'll merge this flag change back to M87. Bug: 1068851 Change-Id: Ic35ff2f6632f075c902137911fc82733c8daec04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485353Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
