- 12 Mar, 2020 40 commits
-
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: I23fb1ad19251bae8e1917b6089b3cb75385e74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097031 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749576}
-
David authored
This cl also * adds the id of the MediaApp into chromium (will need it for metrics later) * adds a test parameterized test (since SystemWebAppManagerBrowserTest is now paramterized), currently expects the inverse. Bug: b/144886504, 877898, 1054195 Change-Id: I1d862b04d47092e45ad08415b707612a1e5464fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082659 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749575}
-
Viktor Semeniuk authored
This change allows adding new entities to the bottom of the compromised credentials list. Special sorting applied. Also, deleted elements are removed from the list. Bug: 1047726 Change-Id: I3af45a94670091b61cf517d0637877f9f852901b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094983 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749574}
-
Noel Gordon authored
Wheel events over the drop-down menu (a <dialog>) can cause directory tree to show vertical scrollbars even though the user cannot possibly interact with the directory tree (they are in a <dialog> element). Do not draw directory tree scrollbars in this case - if the drop-down is open, post that state to the <html> element so CSS can detect, and block tree overflow behavior. Bug: 1035691 Change-Id: Id40017a1b4ff576e4b16efc22e661e3169710e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098169Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1743144ab839..7bb74c4299b8 git log 1743144ab839..7bb74c4299b8 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 43a5bd0c..5309fd86 (470 commits) 2020-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c5b3cbdb4502..2e5bd9b1e658 (10 commits) Created with: gclient setdep -r src/third_party/skia@7bb74c4299b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I55730253e1595162be0a8b8804197620ebcb3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/276dc290d7ce..ee9e28d54f35 git log 276dc290d7ce..ee9e28d54f35 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@ee9e28d54f35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I40c1008d83d11043cfb93eaf2a7066fbdedb6c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100082Reviewed-by:
-
Mikel Astiz authored
Tests can be simplified if TestBookmarkClient offers support for constructing the managed bookmarks folder, since it's not supposed to be constructed in an arbitrary fashion anyway. Bug: 1060311 Change-Id: I388daca001474fab2b0810d3a581b3a36e5f78ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096963 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The function is not used and can be trivially removed. Bug: 1060311 Change-Id: I24966e362e71ae5cc1a68e8af63e547a2f4ea5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098075Reviewed-by:
-
Omer Katz authored
Bug: 1060756 Change-Id: I1dc1e252e5d3a0b4dea15ae463e61e420eb39406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098904Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749568}
-
Wez authored
The NetworkChangeNotifierFuchsia.* tests were being run with a testing::InSequence instance active, causing EXPECT_CALL()s to be verified with strict ordering. NotifyNetworkChangeOnInitialIPChange is the only test that has an ordering expectation, so move the InSequence inside that test. Also fix the test to specify expectations on the observers before causing them to be called, as required by GMock. Bug: 1060566 Change-Id: I7a03cdba154b070a95bc05b08737418fcbfc5841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098078 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749567}
-
Yutaka Hirano authored
Bug: 887967 Change-Id: I1352c4a1f4dccc294c6765e609da8c9e92c6f90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098190Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749566}
-
Kuo Jen Wei authored
Bug: 1059191 Test: tast run <DUT> CCAUI* Test: See if the multi fps UI hidden on device with 30, 60 fps capability builtin camera. Change-Id: I1f2037ba871089a4e7d106cb101cff0631eb8a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098188Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#749565}
-
Kent Tamura authored
Also moves cached_state_for_active_selection_ to ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Ie32cdf5eb9cba2daf7031b20dc71a9ca907d92e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098191 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749564}
-
Wei Lee authored
Fake camera only output stream in 20 fps. This CL makes CCA work with fake camera. Bug: b/150004607 Test: Run CCA with fake camera and CCA works normally Change-Id: I7d69083108f974a440ffa27f0fa14c344b471dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098189Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 829084, 848607 Change-Id: I903141366d7fbda98f795840264f1c58c911d230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094383Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#749562}
-
Yuki Shiino authored
Gives a better name than "Impl" and "Blink(Value)". V8 object and Blink object are called "wrapper" and "wrappable" respectively. C.f. ScriptWrappable. Bug: 839389 Change-Id: I9bec47bf5db5f7c46d73dfea92c11fcaf5d65c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098136Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#749561}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/866726ef..c1fd0b36 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id5e6b16deedaf906701490a211b6ab77a49d3f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749560}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4044.31-1583145468-benchmark-82.0.4079.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2e8592cb0e75712e9ca383b5f732a03491878503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100228Reviewed-by:
-
Zain Afzal authored
This is because the media app attempts to use the spread operator on the class which, due to the typescript compilation step which targets ES5, doesn't handle the class instance correctly. Bug: 996088 Change-Id: Idfb4e00aa29c40864fecf7d5ee777d470f40566d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098192Reviewed-by:
-
Ye Kuang authored
Because go's "check" subcommand doesn't generate isolated file, the '-s' flag is dropped. This is fine because Go isolate doesn't consume isolated file at all. More details in crbug.com/1059668. #Benchmark Benchmark is done using the "archive" subcommand. Note that the first invocation will upload to isolate-server, which we want to *exclude*. So the results were taken from the second invocation. ##blink_web_tests: * PY: 1m15s~1m40s (python tools/swarming_client/isolate.py archive -i out/Release/blink_web_tests.isolate -s out/Release/blink_web_tests.isolated -I https://isolateserver.appspot.com) * GO: ~8s (tools/luci-go/isolate archive -i out/Release/blink_web_tests.isolate -s out/Release/blink_web_tests.isolated -I https://isolateserver.appspot.com) ##browsers_tests: * PY: 31s * GO: 3s Bug: 1059167 Change-Id: Idffb6c33e2482c2829f54c56e753623f26997a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094482 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#749557}
-
Yuki Shiino authored
Adds IdlType.effective_annotations, which supports multi-layered extended attributes. For example, given the following IDL fragments, typedef [ExtAttr1] long NewLong; void f([ExtAttr2] NewLong arg); arg.idl_type.effective_annotations returns [ExtAttr1, ExtAttr2] while arg.idl_type.extended_attributes returns [ExtAttr1] only. c.f. https://crbug.com/1058762 Bug: 839389 Change-Id: I49cdd82dfa0b8c3468610ffce6458eec963d9148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096408Reviewed-by:
-
Luciano Pacheco authored
No-try: true Bug: 1002395 Change-Id: I3ded1615a2a0709a496b6fd64fce91c169fb6b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100170 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Change-Id: I1e6dd0bcfb375f518c8386a261c20ded2c17da04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099347 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#749554}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94794ec0383c..a0e10db6f8d6 Created with: gclient setdep -r src-internal@a0e10db6f8d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052382 Tbr: jbudorick@google.com Change-Id: Id4241db64f17cad5e52409f40737e4914de45891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749553}
-
Shakti Sahu authored
This CL creates MVC structure for the query tiles coordinator. The layout and styling will be added in later CLs. Bug: 1060910, 1060913 Change-Id: Icb90403dd6786b269172415bb54b1e79694ed9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091947 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#749552}
-
Anand K. Mistry authored
When an SMB share is mounted that requires credentials (eg. a password-protected share added by enterprise policy), the user will be prompted to enter those credentials when the share is accessed. Ideally, this occurs when the user explicitly accesses the share, such as when the user browses the share. However, the directory tree attempts to access the share on startup in order to build the tree and render expand icons. This results in the user being shown a credentials dialog for the SMB share every time they open the Files App. Preventing the directory tree from accessing the share before the user has navigated to it, prevents the credentials dialog from showing until the user actually tries to access the share. Bug: 1060061 Change-Id: I5a0743cd2608b07455d145c2a1ec5a446737b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094849Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#749551}
-
Alex Danilo authored
This reverts commit 2bbea72b. Reason for revert: caused regression shown in crbug.com/1060527 Original change's description: > Files app: Force focus out of <body> > > When the element has the focus is hidden/removed/disabled the browser > moves the focus to <body>, in this situation user doesn't have any > visual clue where is the focus. To fix this we move the focus from > <body> to file list which is the default element when opening Files app. > > Use "focusin" and "focusout" in the <body> element, because these two > events bubble from any body's child element, whereas "focus" event > doesn't. In the event handler we use requestIdleCallback() to give a > chance for any synchronous code to finish and potentially set the focus > somewhere else other than <body>. > > Test: browser_tests --gtest_filter="*tabindexFocusBody*" > Bug: 1059137,957413 > Change-Id: I9563294a3b6c541cf6bd2bba03470041bc8af41b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089444 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Auto-Submit: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748090} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059137, 957413, 1060527 Change-Id: I52e68555b814172d532202631269c676ec9c15ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100050 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
To annotate explicitly that |controllee_map_| wouldn't be modified outside ServiceWorkerVersion. This CL doesn't change behavior. Bug: 1059494 Change-Id: Ib6fb0484044ed8177a6eca8dc9568f3cd2653cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098185Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749549}
-
Yoav Weiss authored
This aligns the implementation with PR#79 [1], by adding both a JS API and a Client Hint header that expose the browser's full version, and removing Sec-CH-UA exposing the full version as a result of an opt-in. [1] https://github.com/WICG/ua-client-hints/pull/79 Change-Id: Idb48b4ab17e5f80e2ecb950a7a3be63aa8099e0e Bug: 1041883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093472 Auto-Submit: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#749548}
-
Alexey Baskakov authored
WebAppInstallManager::InstallBookmarkAppFromSync will be a special method to support online compatibility with bookmark apps. Let's use InstallWebAppsAfterSync to test: 1) TwoConcurrentInstallsAreRunInOrder 2) InstallManagerDestroyed cases. These tests are not about InstallBookmarkAppFromSync directly, they test internal WebAppInstallManager queue of tasks and a lifetime. That's why it's okay to change them. As a result, all WebAppInstallManager unit tests pass even if kDesktopPWAsWithoutExtensions is enabled by default. Note: web_app_install_manager_unittest.cc works as if kDesktopPWAsWithoutExtensions is enabled: it has a BMO registry in its test fixture. Bug: 1020037 Change-Id: I4b0d008e023ee2d60cf56aad9cc0270bb17f747d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094921 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5082df1cf53e..1743144ab839 git log 5082df1cf53e..1743144ab839 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 16ae92a4ee52..7e857092052e (6 commits) Created with: gclient setdep -r src/third_party/skia@1743144ab839 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I35392df422b0b755151801f0f522817be32f40f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100078Reviewed-by:
-
nancy authored
When the app is paused, AppServiceProxy updates the app pause status at time(1), then shows the pause dialog. When the user closes the pause app dialog, AppServiceProxy notifies the publisher to pause the app at time(2). However, if the publisher received the app state change requests from the app platform during time(1) and time(2), publisher updates the app pause status to unpause, because the publisher doesn't know the app is paused: Paused(by AppServiceProxy) -> Unpaused(by publishers) This could cause the inconsistent status, and AppService could still launch the paused app. Modify the app pause status updating process, and move it from AppServiceProxy to publishers. Modify AppServiceProxy to use pending_pause_requests_ to record the paused app information. Once the publisher updates the pause status, the app can be removed from pending_pause_requests_. Modify the app launch checking. If the app is list in pending_pause_requests_ or the app status is paused, the app can't be launched. Update the browser tests to close the app pause dialog, then check the pause status. BUG=1059317 Change-Id: Ia783f61f289950721007e879e63c3f3cf0ade867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094376 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Samuel Huang authored
Previously SuperSize-archive focuses on section sizes and largely ignores section addresses. As a result, "** ELF Section" symbols all have address of 0. This CL refactors archive.py so that |section_range| (2-tuple of address and size) become a primary object of interest, and replaces widespread |section_size| usage. Details: * linker_map_parser.py: Changes to store and return section ranges. * Requires test output update. * archive.py: Extensive changes to use ranges throughout. * Add _ExtendSectionRange() helper. * _AddUnattributedSectionSymbols(): Add "** ELF Section" symbols in section name order, to make later sorting more predictable. * Not changed: CreateSectionSizesAndSymbols() params, to maintain .size format compatibility. "** ELF Section:" symbols can now have non-0 addresse (and better sort order). This required update of integration_test.py expected outputs. Other changes: * Add dbg.py to aid debugging (compatible with Python 3). Change-Id: Ife5a695a4d3d75a6c67dabae5de91c9bb9618100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099466Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#749544}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7dad03fb178..484bb8a03b97 git log a7dad03fb178..484bb8a03b97 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3bc28c82..96fc083e (749350:749472) Created with: gclient setdep -r src/third_party/webrtc@484bb8a03b97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I04421ad6f864cab388e171348952eeaf5bf53411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100086Reviewed-by:
-
Abigail Klein authored
Introduce a new elide behavior TRUNCATE_HEAD in which multiline text in a label is truncated at the beginning of the string. This will be used to display the last two lines of captions for the live caption feature. Captions received from the captioning service may be longer than two lines. So, the determination of what the last two lines to be shown should happen during the displaying of the text in the label. Bug: 1055150 Change-Id: If3c447ac50c29a3e2f7467af9ceeb668fcd01ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090501 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749542}
-
Jiewei Qian authored
This CL adds support so File Handling origin trial can be used for System Web Apps. Under the hood, SystemWebAppManager force enables file handlers after Apps are installed (in on_apps_synchronized event). FileHandlerManager treats force enabled file handling origin trial to never expire (technically, it expires at the max time that can be persisted in preferences). Fixed: 1045297 Change-Id: Iaa55601c3ecbe37c543beb1ee6f495b62fac6617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093959 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Noel Gordon authored
After mitigation CL:2098140 lands, the breadcrumb flexbox layout starts to work as expected: it can flex. Add min-widths, pads to tune the flex eliding ... best we can, given we have no spec at all for this. No breadcrumb folder tooltip mentioned in the spec either. Bug: 1035691 Change-Id: I3fa47a1ffe5daf90a3cc8dfd741ec370117fd3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098168Reviewed-by:
-
Hirokazu Honda authored
V4L2IP sets plane length to the area of coded size and offset. This is wrong if the width of coded_size is different from the stride of the underlying buffer. This CL corrects it by setting to the size of GpuMemoryBufferPlane. Bug: None Test: ip_test --gtest_filter=NV12* on kukui Change-Id: I3e49e6ecd2442e00b8d6705cfb3e333efad0a9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096427Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749539}
-
Koji Ishii authored
Following bot results are included. 1665 1668 1672 1673 1674 1675 1676 1677 1678 1679 1681 1683 1684 1685 1686 1688 1689 1690 24 lines were removed and 30 lines were deflaked by consecutive results since 1672. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iad2d61b2fdbed5b2b0a0a485e7866c0cfeb4df72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094904Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749538}
-
Johann authored
Also iwyu <utility>. Clears git cl lint warnings. Change-Id: I039424a37b54f7b6358232d6de5ed1836fa1ef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098162Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
