- 13 Jul, 2018 40 commits
-
-
Aldo Culquicondor authored
The VR keyboard doesn't take content space, so we don't need to wait for a window resize to do the auto-scroll to the focused view. We add a new parameter to the result receiver to indicate this. Bug: 831368 Change-Id: I3d965ef9ffec8288ca2f6acc91c5f4fda8fc23f6 Reviewed-on: https://chromium-review.googlesource.com/1127928Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575009}
-
rbpotter authored
If the preset options contain a zero width or height page size, computing the fit to page width or height will result in a division by zero and these values will be undefined. Use 0.0f, indicating an unknown/unavailable fit to page scaling, in this case. Bug: 859230 Change-Id: Ib5b36786da9ba82b1ba1642a5d9ff9c086342fee Reviewed-on: https://chromium-review.googlesource.com/1135785Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575008}
-
Roger McFarlane authored
This CL removes the AutofillRestrictUnownedFieldsToFormlessCheckout (shich has now gone to Stable-Exp) and adds the AutofillSmallFormSupport field trial config (which is going to Beta-Exp). These field trials cannot co-exist (in either fieldtrial_testing_config.json or on a single given channel) because they both control the AutofillRestrictUnownedFieldsToFormlessCheckout feature flag. Bug: 824834 Change-Id: I955db8113da9d15f176c2a8e8aae5bfc72eba1bd Reviewed-on: https://chromium-review.googlesource.com/1076310Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#575007}
-
Peter K. Lee authored
Finally, the last step of removing from UserFeedback Provider API. Submit this after all other downstream CLs have been submitted. Bug: 847329 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1c8fb9fdf5e9b3f65e959577a563e9f7311d93e6 Reviewed-on: https://chromium-review.googlesource.com/1132542Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#575006}
-
Michael Thiessen authored
De-duplicates usage of mDonSucceeded and mEnterVrOnStartup. Removes a bunch of dead code and unused variables. Change-Id: I85f9c38dbb1e9c9cd6bbdf404bd9f51c418f8e70 Reviewed-on: https://chromium-review.googlesource.com/1136580Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575005}
-
Andrey Kosyakov authored
We don't want stray web contents being present. Change-Id: I29f243e83c7379add99b75e6c7baa7bfbf530c6e Reviewed-on: https://chromium-review.googlesource.com/1135991 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575004}
-
mark a. foltz authored
This change removes the typemap from media_router::mojom::RouteMessage to content::PresentationConnectionMessage, in preparation for removing content::PresentationConnectionMessage entirely in a subsequent change [*]. The Media Router now uses media_router::mojom::RouteMessagePtr to pass around media route messages, which is move-only and required updating the API for MediaRouterMojoImpl. This in turn required updating many unit tests. Eventually, RouteMessage, RouteMessageObserver, and BrowserPresentationConnectionProxy will be removed when a PresentationConnection can be passed directly through the Media Router. * https://chromium-review.googlesource.com/c/chromium/src/+/1123175 Bug: 817903 Change-Id: I1f33a86fa3ed2cd1c00e370ce432a095bf21d3bd Reviewed-on: https://chromium-review.googlesource.com/1123649Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575003}
-
Chris Harrelson authored
This is unnecessary, because once these frames become unthrottled they will update their layout, including frame rects. Change-Id: I9f58575b58d5e6e7ced6d11391a3d3f628365feb Reviewed-on: https://chromium-review.googlesource.com/1134505 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#575002}
-
Chris Sharp authored
Change-Id: I4442f2e2a9136409831793a396c05150e7607684 Reviewed-on: https://chromium-review.googlesource.com/1136387 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575001}
-
Tessa Nijssen authored
WebContents::Replace() replaces the current text selection with a given string. Currently, SuggestedTextTouchBarController replaces the current user selection when a suggestion is chosen from the touch bar. SuggestedTextTouchBarController now calculates a range that encompasses the word in which the cursor resides. If the cursor is not in or at the end of a word, the range representing the editing word starts at the cursor position and has length 0. When a suggestion is chosen from the touch bar, the selection within the textfield is modified to encompass the word currently being edited (which may be only a cursor position) and then WebContents::Replace() is called to replace the selection. A unit test was written to test that editingWordFromText:cursorPosition: properly calculates the range encompassing the current editing word for various combinations of word and non-word characters. Some parameter types were changed to reduce the number of conversions from base::string16 to NSString and vice versa. Previously, WebContentsTextObserver::DidChangeTextSelection() took a base::string16 as a parameter. It would then convert that input to NSString and pass it to webContentsTextSelectionChanged:range: which would then call editingWordRangeFromText:cursorPosition: which would then convert the NSString back to a base::string16. The call to BreakIterator::Init() was moved out of a DCHECK because DCHECKs are stripped for release builds and the call to Init() should not be removed. Bug: 717553 Change-Id: I367093e13129609c7238bdb9125bbd69a3910f0c Reviewed-on: https://chromium-review.googlesource.com/1130232Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#575000}
-
Amirhossein Simjour authored
Fix typo in calculation of AnchoredPopupWindow's width. Bug: 862594 Change-Id: I0f79ca75c1d3c003d24dcba835fb6925b8d1dab5 Reviewed-on: https://chromium-review.googlesource.com/1136723Reviewed-by:
-
Bret Sepulveda authored
Their size is now consistent with buttons. Bug: 822803, 822074 Change-Id: I26742d82262efb0c2329fdcb313126ad681965ea Reviewed-on: https://chromium-review.googlesource.com/1136061Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574998}
-
Kurt Horimoto authored
When attempting to update the read status of a section, exit editing mode before early returning if that section does not exist. Bug: 863006 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32a0d80a3d16d7bdb0606cedbaf20401df67a640 Reviewed-on: https://chromium-review.googlesource.com/1136022Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574997}
-
Doug Turner authored
TBR=jam@chromium.org Bug: 844973 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2fa684a39ddb01c582173d6955fa264792c779ea Reviewed-on: https://chromium-review.googlesource.com/1136718 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#574996}
-
Nico Weber authored
It no longer does anything that remove_from can't do. No behavior change. Bug: 843511 Change-Id: I74d3e52d7a9d00271baad9203d72ba7efc777a64 Reviewed-on: https://chromium-review.googlesource.com/1136646Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574995}
-
Michael Thiessen authored
No functional changes - we haven't hit the deleted code path in many months and it's no longer relevant now that we don't exit VR when paused. Change-Id: I1131de9f43675d000c366e7174dacae6e300c7d8 Reviewed-on: https://chromium-review.googlesource.com/1135824Reviewed-by:
-
Chris Harrelson authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2c8e14fae22b1fe5d8aec77cf7e203f839972100 Reviewed-on: https://chromium-review.googlesource.com/1135705Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574993}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/589fda45ed12..0b17b7db7523 git log 589fda45ed12..0b17b7db7523 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 treehugger-gerrit@google.com Merge "trace_processor: Fixed small issues from http://aosp/706904" 2018-07-13 lalitm@google.com Merge "perfetto: add trace processor library to expose to external clients" 2018-07-12 lalitm@google.com perfetto: add trace processor library to expose to external clients 2018-07-11 taylori@google.com trace_processor: Fixed small issues from http://aosp/706904 Created with: gclient setdep -r src/third_party/perfetto@0b17b7db7523 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: Idcd7423a61d4580113e6776d9545be537f318a41 Reviewed-on: https://chromium-review.googlesource.com/1136731 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574992}
-
apacible authored
Change-Id: Id3aef7827d87ab415ccb83b85f678dbe2ea28e99 Reviewed-on: https://chromium-review.googlesource.com/1135356Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#574991}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab13ebac. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21203 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I1289268cce80499b7c9ca3bd34730d7d03b01a7e Reviewed-on: https://chromium-review.googlesource.com/1136590 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574990}
-
Nico Weber authored
These sections have been around since the json files started being autogenerated. Not all _apk targets have key_removal sections, and the ones that do have different bots listed there. Omitting args probably isn't important, so don't do it. Bug: 843511 Change-Id: I42c2e0bb03d28d850bb447c62e21df62ed33eafd Reviewed-on: https://chromium-review.googlesource.com/1136516Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cc291365934..210610261006 git log 0cc291365934..210610261006 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Use angle::Result error handling. 2018-07-13 jmadill@chromium.org Add gl::ErrorSet and angle::Result. Created with: gclient setdep -r src/third_party/angle@210610261006 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie5622320e955bea3a724e263dfd212f32db36dcf Reviewed-on: https://chromium-review.googlesource.com/1136732Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574988}
-
Ian Kilpatrick authored
The UseCounter at parse time is relatively high (0.09% of page loads): https://www.chromestatus.com/metrics/feature/timeline/popularity/924 However the parser typically over-estimates these things so added a layout time UseCounter. This should have no side-effects. Change-Id: Icaa5f0603cf6b6b21494df10a88463ecaf4c6b0f Reviewed-on: https://chromium-review.googlesource.com/1136713Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#574987}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7651c1611e6c..ed1205ae20b2 git log 7651c1611e6c..ed1205ae20b2 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 robertphillips@google.com Make GrRenderTargetOpList::purgeOpsWithUninstantiatedProxies match the GrTextureOpList version 2018-07-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 523c5e3122ed..0cc291365934 (1 commits) 2018-07-13 bungeman@google.com Improve SkTestFontMgr. 2018-07-13 robertphillips@google.com Add bullet proofing to image_subset GM for TSAN failures Created with: gclient setdep -r src/third_party/skia@ed1205ae20b2 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I4b4796ce9c67e6946ee80731b5c30560c96b3a13 Reviewed-on: https://chromium-review.googlesource.com/1136733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574986}
-
Charlie Harrison authored
content_settings::Observers are not robust enough for metrics capture. A few problems: 1. It is impossible to tell if a setting change is meaningful (e.g. BLOCK -> BLOCK vs BLOCK -> ALLOW) 2. Some WebUIs trigger duplicate calls into observers If crbug.com/706061 is fixed, we can probably re-add some of this code. In the meantime, I will add a metric or two to the Android Preference UI, where we really need it and can log what we care about directly. This CL also cleans up and versions the SubresourceFilter.Actions histogram, which has a bunch of deprecated / not useful buckets. TBR=msw@chromium.org Bug: 823415 Change-Id: If2d42520b226b21b6a8e875876d733ea32656b11 Reviewed-on: https://chromium-review.googlesource.com/1081370 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574985}
-
Sheng-Hao Tsao authored
This CL adds cameraMediaConsolidated as one of the preference key value pairs that can be set through chromeosInfoPrivate API. The preference is useful for determining which camera app (Chrome camera app or Google camera app) to open when users click the camera icon. cameraMediaConsolidated preference Bug: 861952 Test: Chrome extension can call chromeosInfoPrivate.set() to set Change-Id: I8960734d5bb44712a86c7998081c91e750d963cd Reviewed-on: https://chromium-review.googlesource.com/1130543 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574984}
-
Sandra Sun authored
This reverts commit 0fc70abb. This patch increases the no-animation wait time to reduce flakiness. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Correctly initialize and test SnapContainerData in cc." > > This reverts commit 37061f87. > > Reason for revert: > The layout tests added by this CL is failing on the CL: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 > > Original change's description: > > Correctly initialize and test SnapContainerData in cc. > > > > This patch initializes the rect_ field in SnapContainerData in copy > > constructor and move constructor. Fixing a snapping issue in the > > composited pages. > > > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > > test suite so that they are tested with the composited cases. > > > > snap-at-user-scroll-end-manual-automation.js calls > > mouseClickInTarget() of pointerevent_common_input.js. That method > > invokes programmatic scrolls. The test was written before programmatic > > scroll snapping was implemented so it worked at that time. However, > > with programmatic scroll snapping implemented, it will always snap > > in mouseClickIntarget() and cannot test whether the user scroll snaps. > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > > to avoid invoking programmatic scrolls in the test. > > > > This patch also checks nullptr for layout_box in > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > > > Bug: 862406, 862571 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > > Reviewed-on: https://chromium-review.googlesource.com/1132386 > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#574781} > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1136171 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574825} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org Change-Id: I85550f6f01b2466d8ceb03e44c15253079a5059c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136613 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#574983}
-
Jared Saul authored
Bug: 848955 Change-Id: Id591e9c5a5a54a8a4745758067746272c5dcae4b Reviewed-on: https://chromium-review.googlesource.com/1134178 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#574982}
-
Tiger Oakes authored
Previously percentages and symbol counts were misreported in diff mode, as the values did not match up with the total size. Percentages are now calculated based on the total delta of bytes changed, and the pie chart has an outer ring to indicate if that type of symbol reduced or increased. Counts have been updated to be more accurate now that we have small symbol buckets. A new property has been added to the data file that indicated how many symbols a symbol represents. Most symbols omit this key and default to 1 instead. Buckets indicate how many symbols they represent. Removed dex methods have a negative count to indicate they were removed, fixing the method count mode in diff mode. Bug: 847599 Change-Id: I20073dc20b89481733aaaa319f3b4966217c6096 Reviewed-on: https://chromium-review.googlesource.com/1135698 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574981}
-
Ryan Daum authored
Adds a new flag 'enable-top-drag-gesture' which must be explicitly enabled to turn on the top-drag gesture. Bug: internal b/111427398 Test: manual Change-Id: I5127db35a6eb418bddebf31939cea51240ddeaf2 Reviewed-on: https://chromium-review.googlesource.com/1136644 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#574980}
-
Devlin authored
This reverts commit fa48bec9. Reason for revert: The new CHECK() is crashing, so it seems there is more to be cleaned up. We need to investigate further. Original change's description: > Extensions: Remove temporary cleanup code from crbug.com/558299 > > In the past, there was a bug where some themes incorrectly got synced > into the EXTENSIONS data type, so we added cleanup code to remove the > bad data. That was long ago and all bad data should be long gone now, > so let's get rid of the cleanup code. > > Bug: none > Change-Id: I53fcc8ecb208e9fce6565cda70ec57cc960f9b6c > Reviewed-on: https://chromium-review.googlesource.com/1124680 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572255} TBR=rdevlin.cronin@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: If10997927100f17c505eb83221770c47e4e04b7e Reviewed-on: https://chromium-review.googlesource.com/1136614Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574979}
-
Justin Cohen authored
Bug: 863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I864b2c054563e3b49f7ef87c4d2e85423c04e338 Reviewed-on: https://chromium-review.googlesource.com/1136669 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Min Chen authored
Bug: 847587 Change-Id: Ibdebd9fbe6a66d323d0e309815424270efd53ad2 Reviewed-on: https://chromium-review.googlesource.com/1132608 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#574977}
-
mark a. foltz authored
Media route descriptions are not intended to be used as part of a larger string. This change brings the ChromeOS system tray strings in line with the current set of media route descriptions and avoids strings that start with "Casting Casting". Before/after screenshots: https://drive.google.com/drive/folders/1yPo-Gx_a2D6OGAQM715DU7vthKl2fH1o?usp=sharing Bug: 837394 Change-Id: Iac4a443a361ad3fd457059f6b4588ab2edc4ecda Reviewed-on: https://chromium-review.googlesource.com/1128330Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574976}
-
Kim Paulhamus authored
TBR: tkent@chromium.org Bug: 863462 Change-Id: Ibbfbf97219e2f3515f8a93f11f8c2d406d53ecd7 Reviewed-on: https://chromium-review.googlesource.com/1136727Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574975}
-
Min Qin authored
BUG=826998 Change-Id: If087340df35a26ee81f119e2470c96b5521df412 Reviewed-on: https://chromium-review.googlesource.com/1136659Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574974}
-
Gabriel Marin authored
This is a reland of 615e0342 Fixed tcmalloc include path in file //base/debug/profiler.cc, which is used when enable_profiling = true. Original change's description: > tcmalloc: Move existing tcmalloc files under gperftools-2.0. > > Move existing tcmalloc files, both vendor and chromium, under gperftools-2.0 > in preparation for upreving tcmalloc to the most recent gperftools version. > > This CL did: > > # Create a gerftools-2.0 folder. > mkdir gperftools-2.0 > > # Move vendor/ and chromium/ under the new folder. > git mv vendor gperftools-2.0/vendor > git mv chromium gperftools-2.0/chromium > > # Update //base/allocator/BUILD.gn to have tcmalloc_dir point to > # //third_party/tcmalloc/gperftools-2.0/chromium/src. > # Update addr2line-pdb sources in tcmalloc/BUILD.gn. > # Update include paths in files under //base/process and //base/allocator. > > This is old code that uses currently banned functions. > NOPRESUBMIT=true > > BUG=724399,b:70905156 > > Change-Id: I498a6edda48e178bbacfb41e30f75e9e96e336fc > Reviewed-on: https://chromium-review.googlesource.com/1130670 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Gabriel Marin <gmx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574346} This is old code that uses currently banned functions. NOPRESUBMIT=true Bug: 724399, b:70905156 Change-Id: Icb15af2017e7d7e1e41322df6f17be54af71c528 Reviewed-on: https://chromium-review.googlesource.com/1135672Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#574973}
-
David Black authored
Known issue: Assistant UI should relaunch after successful opt in. See bug for demo. Bug: b:110986528 Change-Id: Icc1a2c2e00b630af37eda338dfb1a2acee4cc094 Reviewed-on: https://chromium-review.googlesource.com/1135788 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574972}
-
Tiger Oakes authored
When a method has the @UiThread annotation, a call to ThreadUtils.assertOnUiThread will be injected at the start of the method. Similarily, @WorkerThread adds a call to ThreadUtils.assertOnBackgroundThread. This allows for easily asserting that a method can only be used on the UI or worker threads. Bug: 842695 Change-Id: Ic53b5d06d6b0581a81f1dcce72b46e7ab42313c0 Reviewed-on: https://chromium-review.googlesource.com/1070592Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#574971}
-
Kim Paulhamus authored
TBR: ellyjones@chromium.org Bug: 863296 Change-Id: Idf257bcc95b35aceaaa2288f50d6f7cc9cf72f12 Reviewed-on: https://chromium-review.googlesource.com/1136719Reviewed-by:
-
