GitLab

This reverts commit b2a16218.

Reason for revert: Consistent failure on Linux ASAN build.

Original change's description:
> Use last committed origin to track active content with cert errors
> 
> This is a speculative fix for a test flake that I can't reproduce
> locally or on trybots.
> 
> Previously, when a page loaded an active subresource with a cert error,
> we were using the *visible* navigation entry to compute the
> origin to mark as insecure. My theory is that the visible navigation
> entry might not correspond to the document that actually loaded the
> subresource. In the flaky test, we load a page with a cert error, and
> then navigate back. The page with a cert error triggers a favicon
> request (we treat favicons as active subresources even though they are
> just images), and I think (?) it's possible that this insecure favicon
> resource will be processed by SSLManager after the back navigation has
> changed the visible entry, therefore marking the page we're going back
> to as insecure even though it shouldn't be affected.
> 
> This speculative fix drops the code that computes an origin from the
> visible navigation entry and passes that into SSLManager (and also
> drops a couple obsolete TODOs alongside it). Instead, we look at the
> committed entry's origin and mark that origin as insecure.
> 
> Bug: 638576
> Change-Id: Ief60adf121261a7021bf5be6c196d5c065b06663
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218545
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Carlos IL <carlosil@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775122}

TBR=alexmos@chromium.org,estark@chromium.org,carlosil@chromium.org

Change-Id: I8042062ebdc136988b7a4e5eb095845cfab9bc38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1091308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230773Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775141}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I06c19d931309c96c9b480f89f043d10a3444d82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231000Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775140}

Adds the Credential Provider Entitlement at the app level.

Bug: 1044639
Change-Id: Iabdf3084ed457b4cce2e604a32a4c1f671d4ed35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209073Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775139}

Just assume the feature is always enabled on Chrome OS.

Bug: 1010663
Change-Id: I562d18a782dc8ba0e938698697f3beeccf2919d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229317Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775138}

Callers only ever passed MOJO_DEADLINE_INFINITE.

Bug: 973213
Change-Id: I4c62b48b424e91dcb21ea9bb0afa13e4deb6ba29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229458Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775137}

This CL applies mojo::PendingRemote and mojo::Remote to
uses of ScreenCaptureSessionNotifier interface.

Bug: 955171
Change-Id: I4e37dd66399b988b67f7fe7a60ff0628b284c839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224481Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: J Kardatzke <jkardatzke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775136}

Moving input handling into blink (from content) requires some additional
typemaps.

BUG=1073560

Change-Id: I5f58dbd11905a3195be1d31f442a963b8f0034f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226312Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775135}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1feb578b5252..93c0a8991c77

2020-06-04 bpastene@chromium.org cros_test: Let cros_build_lib quote SSH commands itself.
2020-06-04 kramasub@google.com dedede: Apply the flashing sequence to C2D2 and CCD
2020-06-04 seanabraham@chromium.org image: allow image_to_vm.sh to use --disk_layout arg
2020-06-04 chrome-bot@chromium.org Update config settings by config-updater.
2020-06-03 mmortensen@google.com BuildAPI: update packages.testMockCall for GetBuilderMetadata.
2020-06-03 stevenjb@chromium.org deploy_chrome: Fix logging level after verbosity cleanup
2020-06-03 chrome-bot@chromium.org Update config settings by config-updater.
2020-06-03 navil@google.com cbuildbot: DebugSymbolsStage separate generate and upload logic.
2020-06-03 seanabraham@chromium.org cros_branch: fail tool unless user acks deprecation warning
2020-06-02 chrome-bot@chromium.org Update config settings by config-updater.
2020-06-02 bpastene@chromium.org remote_access: When building the SSH cmd string, wrap the cmd in quotes.
2020-06-02 bpastene@chromium.org cros_chrome_sdk: Print duration of SDK fetches when using --no-shell.
2020-06-02 dhanyaganesh@chromium.org Remove redundant board entries in chromite
2020-06-02 cjmcdonald@chromium.org cros_build_lib: Hide `cros_build_lib.run` in test backtraces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: 1090956
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I4422f5b2a7e007aa104a161959edf3ed8ece5092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231242Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775134}

Change-Id: I72deba54f44bceeae2e3780efb5ea94ded86ed6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230920Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775133}

See also https://docs.google.com/document/d/1yixj-sTbcpZjZvWjytERfJ4ZnEyuntC67qgp9oyBeIU

Change-Id: Ib6b6e59b2013c004d1e5e43c05c1cc97b489e66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191121Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775132}

Extend the expiry of Extensions.ActiveScriptController.DeniedExtensions
and Extensions.ActiveScriptController.PermittedExtensions to 2021-06.

Bug: 1088769
Change-Id: I480a3c84dc4ca69981290b3abf7b01f28374d236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229240Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775131}

This particular condition can happen due to some failures
committing data, as sort of pointed out by the fuzzer,
and it already had recovery code right after the DCHECK

Bug: 1086727
Change-Id: I80fc64c651f87231e1ae476a01ec3bf34f36e77a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227230
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775130}

This CL jsut splits the processing for a DelayNode into separate
routines to handle a-rate and k-rate processing.

This is a first step at vectorizing delay node.

No functional changes.

Bug: 1087071
Change-Id: Ia12bad0748e608eb4e20bd86b07b7bd4f1e54c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227335Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775129}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8436fb411921..80ae9afc70f7

2020-06-04 jacktfranklin@chromium.org Don't split out test setup files in Karma.
2020-06-04 bmeurer@chromium.org [wasm] Properly terminate the wasmparser worker.
2020-06-04 mathias@chromium.org Support custom CSS properties with a whitespace token value
2020-06-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1071432
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I369dcca3dfa251098ea140f038c2f1ad3065cd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230892Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775128}

Call -teardownUI when the scene disconnects. There's even a few comments
in SceneController saying this should happen, but we never added a call.

Bug: none
Change-Id: If8994dd387a3216411401f4d82eeca24b05fe792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231063
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775127}

This is a reland of 50b3e1fd

Reason: fixed branded build @
https://chromium-review.googlesource.com/c/chromium/src/+/2229839

Original change's description:
> [base] Remove implicit-destination PostTask
>
> No TaskTraits implcitly meant base::ThreadPool. The migration away
> from this paradigm is complete (task APIs v3 is bringing explicit
> API-as-destination). Remove this right away before we're ready to
> completely remove post_task.h to avoid the addition of new callers
> without an explicit destination.
>
> Bug: 968047, 1026641
> Change-Id: I54d04872498d340cfd8ec02aa88b3e9cba1a7547
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225541
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#774758}

TBR=skyostil@chromium.org

Bug: 968047, 1026641
Change-Id: Id2a909c9513b17856f01ef843fab0c6abf2cd448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229838Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775126}

Disable flaky #testTabSwitcherModeNotTriggeredWithinThreshold_NTP
and #testTabSwitcherModeTriggeredWithinThreshold_NTP on P+.

BUG=1091268
TBR=wychen@chromium.org

Change-Id: I2cbe842cfb2e63c39904d2e9479590e793541f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230921Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775125}

Modify the existing web platform test opening-handshake/005.html to send
the response header and the close frame in the same packet. This
verifies that Chrome passes the close data to JavaScript correctly in
this case.

This increases the coverage of the existing test, so there's no need to
retain the old behaviour.

Also remove the timeout expectations for this test, and make sure it
doesn't timeout on failure.

Closed: 1090210
Change-Id: I327c55d1517615511d6d71e1b464d5d3dc03b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228252
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775124}

Please see bug for details.

TBR=andruud@chromium.org

Bug: 1090087
Change-Id: Ib2eaea4c2667ff0caa5db161563cdac0063543d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231278Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775123}

This is a speculative fix for a test flake that I can't reproduce
locally or on trybots.

Previously, when a page loaded an active subresource with a cert error,
we were using the *visible* navigation entry to compute the
origin to mark as insecure. My theory is that the visible navigation
entry might not correspond to the document that actually loaded the
subresource. In the flaky test, we load a page with a cert error, and
then navigate back. The page with a cert error triggers a favicon
request (we treat favicons as active subresources even though they are
just images), and I think (?) it's possible that this insecure favicon
resource will be processed by SSLManager after the back navigation has
changed the visible entry, therefore marking the page we're going back
to as insecure even though it shouldn't be affected.

This speculative fix drops the code that computes an origin from the
visible navigation entry and passes that into SSLManager (and also
drops a couple obsolete TODOs alongside it). Instead, we look at the
committed entry's origin and mark that origin as insecure.

Bug: 638576
Change-Id: Ief60adf121261a7021bf5be6c196d5c065b06663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218545Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775122}

When a pattern (with a transparent background) is used to fill or stroke
a rect, the ShadowBlur is incorrectly applied to the rect mask instead
of the pattern itself.

This is fixed by setting the last param of BaseRenderingContext2D::
Draw() to kNonOpaqueImage when the rect is drawn with a pattern.

Bug: 1020183
Change-Id: I62ae4e298185eb5b7699c2dbf4b9ad962939e464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219416Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Teresa Kang <teresakang@google.com>
Cr-Commit-Position: refs/heads/master@{#775121}

The test is also flaky on marshmallow:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygwELEgVGbGFrZSJ4Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLmNhcmRzLnByb21vLkhvbWVwYWdlUHJvbW9UZXN0I3Rlc3REaXNtaXNzX1N3aXBlVG9EaXNtaXNzDA&show_all_occurrences=1

TBR=wenyufu@chromium.org

Bug: 1084756, 1087334
Change-Id: I0679386eed77113ea4a7f00691b9c55b5718e61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230322Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775120}

GitHub Node ID isn't unique to a taskcluster run. Instead, I suspect node id changes when Taskcluster changes status (from running to complete); see this example https://screenshot.googleplex.com/38i7BVticvY. Gerrit SHA numbers are always present in the PR description, unless a CL is merged; if so, the SHA in the comment is `Latest`

As a result of this change, at most one comment is made per patchset.

Bug: 1027618
Change-Id: I8c6c2006831db65cfe257a65faa01f1d33d75437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225295Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Auto-Submit: Kyle Ju <kyleju@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775119}

Add missing ScopedPaintState for the table row when painting table
section background behind cells, in case that the table row has
PaintOffsetTranslation needing paint offset adjustment.

Bug: 1091016
Change-Id: I82203cf2bd5392bed2cc74806e04780e708804b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229586Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775118}

Bug: 1090968
Change-Id: I68626875b43a825ab29c1ed6f054c16d80693776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229426
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775117}

Parsing of text-decoration-thickness was added in [1], use the parsed
value in text decoration thickness painting.

Add a WPT ref test that compares text-decoration-thickness value from a
variable font (keyword value 'from-font' for text-decoration-thickness)
with the identical rendering achieved by using a static font with thick
and thin underline metadata.

Add a second WPT ref test that compares a fixed
text-decoration-thickness value to the from-font values of a font with
thick and thin underlines.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2178888

Bug: 785230
Change-Id: I626a321a38c77e106215b640dcf85c20f7a0ad93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218119
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775116}

Reland the change to extra header handling with the actual behaviour
change behind a disabled-by-default base::Feature. UMA metrics are
collected even when the feature is disabled, simulating what would have
happened had the feature been enabled, so we can better gauge the
compatibility impact on applications.

Bug: 1038002
Change-Id: I3d722060cc4526a14adac076bbf4eec0a0992b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229420
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775115}

Bug: 1091004
Change-Id: I2c9d50bb508764f7b4237182000b1cfceab91f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229366Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775114}

Covered by existing_user_controller observer.

Bug: none
Test: LoginScreenGuestButtonPolicyTest.*
Change-Id: I9d99a05b5b6e1ac7de08a848a426caafb79c9bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231059
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775113}

This reverts commit d1832592.

Reason for revert: Broke src-internal rolls

Original change's description:
> Move most .pydeps file to be validated by chromium-presubmit
> 
> Bug: None
> Change-Id: I7f3289980e7fbebf1719098b9e6edd2d47b11c3f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229998
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775092}

TBR=agrieve@chromium.org,mheikal@chromium.org

Change-Id: I1992b115088497b7e0bd3a3ca9400a3d0ba962d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1091265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231259Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775112}

The test is also flaky on other platforms:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3BvaW50ZXJldmVudHMvcG9pbnRlcmV2ZW50X2NvYWxlc2NlZF9ldmVudHNfYXR0cmlidXRlcy5odG1sDA

TBR=lanwei@chromium.org

Bug: 1059645
Change-Id: I8563223533cd6445166be5d073f96b3ae013ee56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230321Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775111}

Bug: 1087929
Change-Id: Icc494291dc1bb611c6522dc725e3267efe4fdaa2
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219283
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775110}

PolicyParserMessageBuffer has been used in parsing of document policy.

It is planned to use it to replace |Vector<String>* messages| to gather
messages in feature policy parser as well.

Change-Id: Ia0a12305059acd524fe47afba733ee6537b7eb32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209816Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#775109}

This validates that the service provider set in a Connector policy is
recognized and includes the corresponding URL into settings.

Bug: 1069049, 1069048
Change-Id: I0486261ae2d329e6f743147eaea88906ff1a64ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220471Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775108}

NOTRY=true
TBR=kbr@chromium.org

BUG=angleproject:4684,angleproject:3930

Change-Id: I6582e6c495626e586d6eeb2ad2912e50320933e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230762Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775107}

We are planning to use ephemeral profiles to implement this method
in the future, but their creation is async. OTR profiles which are
currently used have synchronous creation, which is why this method
was synchronous so far.

This CL updates the implementation to be async, but does not yet
make any other changes. In later CLs we will plumb through the
callback to the async ephemeral profile creation.

Doc for context:
https://docs.google.com/document/d/1fnTD_smbp5vzWTLAuXagVsqm_C5607DPbKcfx6KbCTY

Bug: 1086935
Change-Id: I19c72bd002574ba8e6c810f3fff25d974e1f852e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230461Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775106}

Add _java_resource_types, _java_library_types, and _java_leaf_types.
These types, together with "group", define all existing invoker.type
values for all java targets. Since leaf types like android_apk are not
used as dependencies for other java targets, all java targets in deps
trees can be defined as either resources, libraries, or groups.

Naming conventions have also been improved. Now java targets must match
_java_resource_patterns if the target is a resource target. Otherwise,
it must match _java_library_patterns if the target is a library target.
Group targets can match either of those, but should prefer matching
_java_library_patterns since they are treated as library targets in the
java_group template.

Thus, target filtering is now simplified. To filter for resource targets
, simply use _java_resource_patterns. To filter for library targets, use
_java_library_patterns and ignore the ones that also match
_java_resource_patterns. To filter for any java target, use
_java_target_patterns, which is a simple concatenation of the other two
lists of patterns.

The assert in write_build_config has been updated to enforce naming
schemes accordingly. This enables assumptions about library and resource
targets such as __header, __impl, and the newly added __assetres, which
is defined on library targets to be its transitive list of all resource
target deps.

Now compile_resources targets can filter their deps so that they only
depend on transitive resource deps. This allows compile_resources to
not depend on java library targets, and unblocks header generation for
apk targets. Previously an apk's __header target would depend on
compile_resources to finish, while the compile_resources target would
depend on the rest of the java library dependencies (not headers),
completely removing any benefit of header compilation for apk targets.

Original CL: https://crrev.com/c/2220585

Fixed:
- Turns out compile_resources depends on the android sdk, and that was
  either supplied directly (in the case of android_apk_or_module) or it
  was supplied by its java dependencies (in the case of junit_binary).
- This dependency was broken by replacing java library deps with their
  corresponding __assetres deps.
- Fixed by explicitly specifying android_sdk_dep just like
  build_config_dep.
- Added comments for both of these explicit *_dep variables.

Bug: 1090812
Change-Id: I57c63ff805c4e27ff6b47bc69c0a6954b0b681c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231178
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775105}

These colors are for the CrOS Print Preview printer status icons to
indicate the printer's current status.

Bug: 1059607
Change-Id: I8c5ebd95aba2154b30b9435ceb1c3ec974c4dec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227904
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775104}

The WebSocketStream origin trial has ended, and we are not planning to
run another origin trial. Remove the client-side configuration.

BUG=983030

Change-Id: I41fcc1ea793467407429d7afa1a73fba1fcc9910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228376Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775103}

* Extend to 2021-01-01
* Transfer (or extend) ownership to raleksandrov@

Fixed: 1088741, 1088740
Change-Id: Ib304c5c6c908f8cd1dbee9e904b840b1d58af86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225900
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#775102}