- 18 Aug, 2020 40 commits
-
-
Tommy Li authored
This reverts commit 1b2b4828. Reason for revert: I think this is causing ongoing flakiness: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel?limit=200 OobeInteractiveUITest.SimpleEndToEnd https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRgsSBUZsYWtlIjtjaHJvbWl1bUBicm93c2VyX3Rlc3RzQE9vYmVJbnRlcmFjdGl2ZVVJVGVzdC5TaW1wbGVFbmRUb0VuZAw Original change's description: > Reland "Oobe: enable child specific signin feature" > > This is a reland of e771c29c > > Original change's description: > > Oobe: enable child specific signin feature > > > > Bug: 1101318 > > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Yunke Zhou <yunkez@google.com> > > Cr-Commit-Position: refs/heads/master@{#798671} > > Bug: 1101318 > Change-Id: I73f8f871c4063b0b8f3718eeb974881728071ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360061 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#799026} TBR=xiyuan@chromium.org,antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I54a2c5fac3fd9257c24d840da37a8718209fb373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363650Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799339}
-
Lei Zhang authored
- Reorder overrides that are incorrectly grouped. - Separate a non-overridden method from the overrides group. - Reorder an enum declaration and mention why it is public. Change-Id: I9d359631c8e8be21780a656866a91fac6e62d3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363634Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799338}
-
Ryan Hansberry authored
(This is reland of crrev.com/c/2322166. It was reverted because of a race access of |[receive|send]_stream_| in [Receive|Send]More() immediately after the stream was reset during [Input|Output]Stream::Close(). This is addressed by posting stream watcher teardown to the dedicated IO sequence. The original CL is in Patchset 1, and the fix is in Patchset 2.) Implement a concrete location::nearby::api::BluetoothSocket, created via a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly implemented BluetoothClassicMedium::ConnectToService(). Nearby Connections uses this BluetoothSocket to communicate with a remote device. At a high-level, it first exchanges frames to encrypt the connection, then delegates to its caller (e.g., Nearby Share) to authenticate the connection, and finally expects its caller to send and receive application-level messages. The following precautions are taken to handle untrusted bytes received from remote devices: * Nearby Connections (including the code being added in this CL) is hosted in a Nearby utility process. * Whenever Nearby Connections provides bytes received from a remote device to its caller, even after it has been authenticated, the caller must not trust those bytes, and is responsible for first passing those bytes through the trusted NearbyDecoder interface (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same Nearby utility process. api::BluetoothSocket is a synchronous interface, so this implementation consumes the synchronous signatures of bluetooth::mojom::Socket methods. api::BluetoothSocket's subclasses are also synchronous interfaces, but the Mojo DataPipes they consume only provide asynchronous interfaces. This is reconciled by blocking on the caller thread when waiting (via a mojo::SimpleWatcher) for the DataPipes to become readable or writable (this is expected by the callers of api::BluetoothSocket's subclasses). Mojo DataPipe operations are handled on a separate task runner so that blocking on the calling thread will not deadlock. Please see design doc go/nearby-chrome-bt for more details. Bug: b:154849033, b:158848873 Change-Id: Ie00b18b6675c00e32c47a979f23b5d434941ba6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356271 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:James Vecore <vecore@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799337}
-
George Steel authored
Add logic to distinguish between transitions which should (base computed style changes) and shouldn't be cancelled when transition is completely unset (as the default is all 0s). Currently, both are still cancelled, the same as the old behaviour, but the histogram kCSSTransitionCancelledByRemovingStyle is now only incremented when transitions are cancelled incorrectly. Add WPT for not cancelling transitions then unsetting transition property, fix web_tests to cancel transitions by setting transition to none instead of unsetting. Bug: 934700 Change-Id: Iaf4bf324e6e2bd6ca22a66fd8ae2320620a874dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363173Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799336}
-
Peter Boström authored
Bug: 1102894, 1106422 Change-Id: I10d0b758c92760f42a1d8493bc594dabf01d7586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360906 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799335}
-
David Bienvenu authored
Also make more methods const and miscellaneous cleanup. No functional changes. Change-Id: I92004b1cdcdee52673eb71d52b6d54689d50d85b Bug: 1010217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363072 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799334}
-
Daniel Hosseinian authored
This reverts commit fd6ef652. Reason for revert: This change broke linux-lacros-tester-rel Original change's description: > Add "Save to Drive" deprecation warning under destination select > > Add a deprecation warning message for the "Save to Drive" destination > under the destination select. > > Screenshot of change: https://imgur.com/ix1GjIB > > Bug: 1112581 > Change-Id: Icecc4e90e97f0e4faae0ceca32e19fe10a5de51f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353555 > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799230} TBR=rbpotter@chromium.org,dhoss@chromium.org Change-Id: I67e541e2ec150dcac2b2de8a075b506201f35c58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363700Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#799333}
-
Chong Gu authored
Bug: 1058255 Change-Id: Ib01d1967799e93b2c94352060fa4eaefc974602a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363689 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799332}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/552d3e3d5ee9..577fc0c395d8 2020-08-18 jasonlon@google.com Moved Asynchronicity From Java to C++ for AndroidVoip Demo App If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1995bc073a694869f60b50470c1b6d50173d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799331}
-
Shahbaz Youssefi authored
ANGLE exposes a new extension built on top of EXT_external_objects, namely ANGLE_external_objects_flags. This extension, exposing ANGLE_memory_object_flags, introduces new entry points for texture import similar to those defined in EXT_memory_object. These functions take the VkImageCreateFlags and VkImageUsageFlags values used to create a Vulkan image, instead of assuming all usage bits are specified. This is an optimization particularly on ARM (e.g. some Fuchsia devices) where specifying VK_IMAGE_USAGE_STORAGE_BIT is detrimental to performance as it disables framebuffer compression. Bug: fuchsia:52759 Change-Id: I6068cc2e0f41cc6a16fc31d535ff269b669d0d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340182Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799330}
-
wutao authored
Restrict the ambient mode flag to only Chromium builds and the Canary/Dev channels. Bug: b/148692733 Test: manual Change-Id: I2554d6d1d07b57eafc079722e188cf079031d3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361284 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799329}
-
Yuke Liao authored
This CL does 2 things: 1. Disable two more flaky browser test. 2. Refactor the test filters to use wildcard instead listing all tests. Bug: 1111979 Change-Id: I2c69416c3c7d59e0ae14c3ff715cd082df268a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363395 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Li Lin authored
This CL update the strings for reauth and add user. Follow up CLs will update the strings for other use cases. Bug: 921142 Test: unit tests Change-Id: Ib6c1daa363bdd6e901e1f5842bd274c4b6d85e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347003 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799327}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d0f7dea2a59..0795384a7997 2020-08-18 treehugger-gerrit@google.com Merge "Add size_bytes field to MemoryNode message." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a57e2054cdef162b39cb429b2be6e022e4df7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363475Reviewed-by:
-
Zhaoliang Ma authored
memcpy is used to copy src a plane to the dst plane, this CL replaces it with libyuv::CopyPlane. Bug: None Change-Id: I6508e2bfecd24e71504d0495ec9f9b5ad8a5b402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360507 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799325}
-
Andrew Grieve authored
This reverts commit 9117519e. Reason for revert: Leaving pie config alone Original change's description: > Revert "Restore CQ coverage for proguard, errorprone and lint" > > This reverts commit 5e31951c. > > Reason for revert: Broke monochrome_apk_checker on android-pie-arm64-rel > > Original change's description: > > Restore CQ coverage for proguard, errorprone and lint > > > > * Removes these from android-pie-arm64-rel (currently offline). > > * Adds proguard to android-marshmallow-arm64-rel > > * Adds errorprone & lint to android-lollipop-arm-rel > > > > Spread across two different bots to share the load. > > > > Bug: 1111436 > > Change-Id: Ieac924ccae06aa4bc01b52bf795d1a174616a799 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342575 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796688} > > TBR=agrieve@chromium.org,bpastene@chromium.org,mheikal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1111436, 1115164 > Change-Id: I81ee42d31410176e157be2edced7b5eb4fb25025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354449 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797720} TBR=agrieve@chromium.org,bpastene@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111436, 1115164 Change-Id: Ia9e5d81821a9b3cbf9b52f2363f1fc38037e06e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359508 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799324}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: If57ab1625e934ed165e9ec94951927dbaaf6be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359368 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799323}
-
K. Moon authored
Makes PDFiumTestBase::GetPDFiumPageForTest() slightly simpler to use: 1. Eliminates returning nullptr, relying on preconditions instead 2. Switches to mutable reference parameters to prevent null pointers 3. Adds a const overload when a mutable PDFiumPage isn't needed These changes were prompted by an observation in crrev.com/c/2067743: GetPDFiumPageForTest() should never fail if the page index is within range. Pages may not have loaded completely, but the PDFiumPage entry always exists. Change-Id: If1758135b059b40dff2c863b8476d7274bc11e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360983Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic2436ca9db6337a31f2e8ebc67b6eda96f41e3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363420Reviewed-by:
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Iae5bf16707ac1176ffdd5503d9c8a573495523b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357756Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#799320}
-
Oksana Zhuravlova authored
This is a reland of ebc935dc Original change's description: > [tools/perf] Add app and device usage to WebView power metric > > Since webview_power_usage.sql now calculates app power usage and total > device power usage, this change updates the corresponding tbmv3 metric > to output these values. > > Bug: b/159154163 > Change-Id: Ia0f788e357837e056ed04b1bd252f9a26d2d07de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354834 > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798739} Bug: b/159154163 Change-Id: I7ff60a3a009e74d0ab244f7ab83e66840fc4c712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360419Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#799319}
-
wutao authored
This patch configs the dev channel to use testing server. But users can overwrite it with a flag. Bug: b/148692733 Test: manual Change-Id: I967281bc1421c37d9c1ff74a0815d6a6da570da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342134 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f74415e2f74..cbfd396756c6 2020-08-18 sugoi@google.com Control Flow Integrity (cfi) fix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116053 Tbr: swiftshader-team+autoroll@google.com Change-Id: I45e2a4d8fbc2eb5eaa615db6ffba21d47ce79c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363332Reviewed-by:
-
Michael Crouse authored
Privacy doc: https://docs.google.com/document/d/133SsQTd3L5ryQaI-q1rZsh6EeTsE_HxDFlthjlXi4CU/edit?ts=5f3c1ca0# Bug: 1117645 Change-Id: Ifc3229de5e19cc78269cd6e6c3ae2d4ae1f1c11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363693Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#799316}
-
Steven Bennetts authored
Chrome OS sets the Error state when a network disconnects, e.g. during suspend. This causes the UI to show the configuration UI instead of attempting a connection when the network is connected to. This addresses that issue by recognizing a new kErrorDisconnect state (that only occurs during a non user initiated disconnect), and ignoring the error when attempting a connection. BUG=1112814 Change-Id: I2220395d4035495182a6b0f25fcc0313ae2e1750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350315 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#799315}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d5044cd209a6..9d0f7dea2a59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I79d0df129775dd5fd3d4b0ae597a0b7325bf6003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363001Reviewed-by:
-
Gayane Petrosyan authored
This CL also adds fragment identifier to the url that was ommited before. Bug: 1102382 Change-Id: I175c409cef5a90a3e8e2958c66a90e779dbad0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363347Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#799313}
-
Filip Gorski authored
Change-Id: I81effcfed2342a4a5eaddcbefb4a4581ecc744ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363167Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#799312}
-
Daniel Classon authored
Change the remove restricted user button to use dom-if instead of hidden. Relevant to deep linking as its easier to deep link to visible buttons if hidden buttons aren't rendered. Bug: 1084154 Change-Id: I831dc8f69ab00ffc51771a327b2fdf8ea47ab559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363551Reviewed-by:
-
phillis authored
WebAppInstallFinalizer::OnFallbackInstallFinalized is not used anymore, remove it and mark the metric as obsolete. Bug: None Change-Id: I7bdb18a1b8a137669c0554e59faf1a839471e0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350327Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799310}
-
James Cook authored
Rename LoginPerformer::IsUserWhitelisted() to IsUserAllowlisted(). I didn't call this IsUserAllowed() because there might be other reasons a user isn't allowed to log in. This ends up affecting a bunch of impl classes in //chrome/browser/chromeos Bug: 1097644 Change-Id: I30a44761e62b9277deed1469189f2b3b2b8bce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363633 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Mason Freed authored
There is already some debug output available for origin trials, which can be enabled with: % chrome --vmodule=origin_trial_context=1 --enable-logging=stderr This CL adds a bit more human-readable debug output, plus it adds the appropriate flags to the documentation, so it is easier to find. TL/DR now: % chrome --vmodule=trial_token=2,origin_trial_context=1 --enable-logging=stderr Change-Id: I27d08055f460287e02531886593c696e700bbe3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347385Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799308}
-
Lei Shi authored
When converting nodes into NodeGroup, we check each word one by one. If the word is out of the bound of its parent, we replace the word with equal length space characters. The resulted text have the same length of the original text, and TTS will ignore overflow texts as they are empty now. Bug: 775659 Change-Id: Iec3a296344b1c522ec255d56bfcbf51a68d50f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342127Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#799307}
-
Robert Ogden authored
Bug: 1115259 Change-Id: I3e352ce08e93609e047f13f519dede7f9f7296ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358035Reviewed-by:
-
Takumi Fujimoto authored
Currently the feature is exposed only to allowlisted origins. This CL adds a flag to chrome://flags that will allow developers to test the feature on non-allowlisted origins. Bug: 1111916, b/162437760 Change-Id: I9a702f3560b9414b572de2a6544704cc092b7a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342114 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799305}
-
David Trainor authored
Change the config to refer to the beta configuration. Bug: 1108002 Change-Id: I54df3a07cd40695a7f8fcac42784e7c999265962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360606 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#799304}
-
Filip Gorski authored
Switches the default state of the flag to enabled. Deletes OmniboxSuggestionsRecyclerView from fieldtrial testing config. Bug: 1075602 Change-Id: I38efb6702eb253a316a756c99af9cf53e5858d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362091Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6a272ffee65..9d0f7dea2a59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5dabe0f1a816c43df5f4d157c368b97c8c849af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363000Reviewed-by:
-
Etienne Pierre-doray authored
Concurrency checks gives bogus worker_count values since https://chromium-review.googlesource.com/c/chromium/src/+/2304972 The thread that just returned from worker task will still count as active. This can cause races that will trigger dcheck. This could be fixed probably by tweaking worker_count similar to https://chromium-review.googlesource.com/c/chromium/src/+/2355297 Since this is dcheck-only code that adds significant complexity however, it makes more sense to strip the code: - dcheck can trigger in valid use cases - The issues that the dcheck will catch would also cause Join to never return. This should be easy enough to detect without the dcheck. Bug: 1114823 Change-Id: I1181ba7f530cf81624f578ed0f324849ad930e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363074 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#799301}
-
Caitlin Fischer authored
This change paves the way for limiting the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Bug: 1094303 Change-Id: Ib5b094e1fa9aa1e508d9b8f14886d69ce18cbfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363076Reviewed-by:
-
