GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d729403c..aa40d639

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib1bf7d3883ecb84dd36fdf5c59a3362aa9d730c0
Reviewed-on: https://chromium-review.googlesource.com/1150400Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577999}

This change has two main effects. First, this allows for the
CoreOobeHandler to decide whether or not the powerwash dialog should be
shown (e.g. due to being enterprise enrolled). Second, this seems to fix
the race between the Gaia screen init and the powerwash dialog when the
user hits CTRL+ALT+SHIFT+R early on.

This CL also adds a unit test to ensure that the powerwash shortcut
sends a mojo call to the browser thread.

Bug: 837501
Change-Id: I345e4c4f5be7ecb64b6d7605101e93feb2fc3bbf
Reviewed-on: https://chromium-review.googlesource.com/1148646Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577998}

This includes some partial conversion to base::Value in onc_utils.cc,
as part of a long term effort to convert network config and ONC code
to non deprecated base::Value patterns.

Bug: 651157
Change-Id: Ic0456f9221fedaf95a78ce670af9f4be4bc95ad1
Reviewed-on: https://chromium-review.googlesource.com/1144196
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577997}

Now with more OOP! Class structure is:

RemoteTest
   | --- GTestTest
   | --- BrowserSanityTest

Doesn't add anything new. Just splits out sanity-test and gtest-test
logic into their own classes (and resuses what it can in a parent class)

I'm planning on making some changes to how GTests are launched in the
VM. This'll make that easier.

I'm also thinking about reusing some logic in here when running hardware
tests. This will make that easier as well.

Bug: 732531, 866062
Change-Id: I80a6e29c657b1db6c7911cb873c64be094c9b5ef
Reviewed-on: https://chromium-review.googlesource.com/1145796Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577996}

https://android.googlesource.com/platform/external/perfetto.git/+log/b1589ae6be41..f13e3a8e7b0e


git log b1589ae6be41..f13e3a8e7b0e --date=short --no-merges --format='%ad %ae %s'
2018-07-25 hjd@google.com Create strongly typed frontend/controller objects


Created with:
  gclient setdep -r src/third_party/perfetto@f13e3a8e7b0e

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I534c2d021e6fb4d8045fa6c86c8e251bff324a0b
Reviewed-on: https://chromium-review.googlesource.com/1150051
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577995}

UKM updates the per-WebContents source id during WebContentsObserver callbacks.
VR fires UKM events during WebContentsObserver callbacks.  Navigation events
may get fired to VR or UKM first, so we may get stale ids.

BUG=866633

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iaf99f70b0defecd34156d64526ecd329f2315876
Reviewed-on: https://chromium-review.googlesource.com/1147504Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577994}

DataPipe's members are producer_handle and consumer_handle, and not producer
and consumer. This is a minor CL to update the references.

TBR=rockot@chromium.org

Change-Id: Ia2dc6686ecd83d5e587a4b33b73599180090b642
Reviewed-on: https://chromium-review.googlesource.com/1150429
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577993}

also fixes an issue that DownloadDBImpl could be null for incognito downloads

BUG=842245

Change-Id: I1688b6ad15c400a27d6877b60f149c7eee181794
Reviewed-on: https://chromium-review.googlesource.com/1147604
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577992}

Bug: 862445
Test: Run NetworkScreenTest, NetworkScreenUnittest and wizard_controller_browsertests
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9e71b2b4d179127113b11c4aade14597519565fd
Reviewed-on: https://chromium-review.googlesource.com/1139586
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577991}

Update run_performance_tests.py to use '--story-shard-begin-index' and '--story-shard-end-index' flags

Bug:866095
Change-Id: I92c07d23a98910fa0840811fe45f2daa8b2ba8a1

TBR=perezju@chromium.org, eyaich@chromium.org

# Bypass unrelated PRESUBMIT lint error

No-Presubmit: true
Change-Id: I92c07d23a98910fa0840811fe45f2daa8b2ba8a1
Reviewed-on: https://chromium-review.googlesource.com/1150420
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#577990}

chrome://heapcorruptioncrash/ to crash a child renderer process.
chrome://inducebrowserheapcorruption/ to crash a browser process.

BUG=865632

Change-Id: I69caa1c80cd1775f416d656312222b9b4856f682
Reviewed-on: https://chromium-review.googlesource.com/1129628
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577989}

Bug: 865063
Change-Id: Ic1a85aaaf1874f6b1d4538463a7968a1d9a6be85
Reviewed-on: https://chromium-review.googlesource.com/1145303
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577988}

When loading splash_icon.xml on Android P, scaling doesn't occur until
after the image is drawn. As a result, if we try to show a lower DPI image
such as the mdpi icon, the Bitmap#getWidth/Bitmap#getHeight values will
only return the original image size on Android P. What we actually want is
the scaled image size. To do so we use
Bitmap#getScaledWidth/Bitmap#getScaledHeight which return the scaled image
size in pixels. This wasn't a problem on O and earlier since this scaling
occurred when the bitmap was loaded into memory (prior to rendering).

Bug: 819755
Change-Id: I86ad9466d653d4d8501a8c672925b2ba86819d8d
Reviewed-on: https://chromium-review.googlesource.com/1148815Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577987}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I81267ffbc163da945528f5a22a0e3cf9530c84e0
Reviewed-on: https://chromium-review.googlesource.com/1150455Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577986}

Since DeviceOrientationData class has all the information from
device::OrientationData, and DeviceOrientationEventPump is now in blink,
DeviceOrientationData is now passed to DeviceOrientationDispatcher.
device::OrientationData will be removed in a subsequent change.

Bug: 861923
Change-Id: If1cb812502f85dd46011398a54f45bba2353044d
Reviewed-on: https://chromium-review.googlesource.com/1142459Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577985}

When in-progress DB is enabled, DownloadHistory will wait for in-progress
DB to load first before loading its own downloads.
If a download item exists in both DB, then onDownloadCreated() will be called
before DownloadHistory load the same item.
As a result, when LoadHistoryDownloads() is called, the OnDownloadCreated()
reentrance call will not happen for that download.
This causes the DownloadHistoryData::PERSISTED to not get set.
And later on when the download is deleted, it will be skipped by DownloadHistory, thus showing inconsistent result.

This CL fixes the problem by explicitly adding the
DownloadHistoryData::PERSISTED after each item is loaded in
LoadHistoryDownload() call.

BUG=842245

Change-Id: Id15762e46992644e11d6c9bfd46ead39bb64b13b
Reviewed-on: https://chromium-review.googlesource.com/1145865Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577984}

Bug: 832938
Change-Id: Ibfe28802ae133cc5391eea1b6788067e13468856
Reviewed-on: https://chromium-review.googlesource.com/1141155
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577983}

Tests affected:
external/wpt/workers/modules/dedicated-worker-import-data-url.any.worker.html
external/wpt/workers/modules/dedicated-worker-import.any.worker.html

TBR: kolos
Bug: 867532
Change-Id: I0f3cb769341cfa4beb5766866e36ad5260e49157
Reviewed-on: https://chromium-review.googlesource.com/1150418Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577982}

No functionality is changed in this CL.

Bug: None
Change-Id: Ib9a935b7a2b15254f21e79f996c28c5ff5e17895
Reviewed-on: https://chromium-review.googlesource.com/1149611
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577981}

Those files are said to be ChromeOS only, putting all of them
into _chromeos.cc files and removing others. _ozone, _win, and
_x11 are actually referring to _mus, but they won't be used since
the feature isn't enabled on those platforms.

Bug: 867078
Test: build passes
Change-Id: I76e7285fce7aac7c229a7cbe8668c5f654276178
Reviewed-on: https://chromium-review.googlesource.com/1149186
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577980}

https://aomedia.googlesource.com/aom.git/+log/88e4b0a4ee32..0415f2e501a2

$ git log 88e4b0a4e..0415f2e50 --date=short --no-merges --format='%ad %ae %s'
2018-07-23 yaowu Fix a MSVC compiler warning
2018-07-23 wtc Add ATTRIBUTE_PACKED to some enum types.
2018-07-20 jzern decoder.h: rm unused dec_is_ref_frame_buf
2018-07-20 jzern warped_motion.[hc]: rm unused project_points_affine
2018-07-20 jzern txb_common.h: rm unused get_nz_count
2018-07-20 jzern scan.h: rm unused get_coef_context
2018-07-20 jzern quant_common.[hc]: rm unused av1_qindex_from_ac_Q3
2018-07-20 jzern onyxc_int.h: rm unused mi_(rows|cols)_aligned_to_sb
2018-07-20 jzern mv.h: rm unused mv_has_subpel
2018-07-20 jzern blockd.h: rm transpose_*
2018-07-20 jzern av1_txfm.h: rm dead av1_rotate* code
2018-06-29 huisu Add a ML model to prune horz4 and vert4 partitions
2018-07-20 wtc OBU_FRAME type requires show_existing_frame == 0.
2018-07-20 ddvfinite Fix Valgrind error from WRAP_AVX2/ConvolveTest.Copy
2018-07-19 wtc Skip a copy of the frame header in the bit buffer.
2018-07-19 binpengsmail Speedup InterpFilterParams
2018-07-19 wtc Document how to call setjmp() correctly.
2018-07-20 wtc Revert "Save the first frame header in pbi->frame_header."
2018-07-19 urvang Move film_grain_params_present to SequenceHeader.
2018-07-19 urvang Revert "highbd_dc_pred_rect: Assert on valid only"
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=jzern@chromium.org

Bug: 866698
Change-Id: Ie5aeb939055300e70b105edd6de10fc9360af0e8
Reviewed-on: https://chromium-review.googlesource.com/1148699Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Urvang Joshi <urvang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577979}

Using wpt-import in Chromium b1dda104.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21738

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=lukebjerring

No-Export: true
Change-Id: I5a4a6ce18e8b5718088aa40d409b05f6d389e60d
Reviewed-on: https://chromium-review.googlesource.com/1150294
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577978}

Bug: 857514
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6ca7211bcf811b57fb03f5fe275c6c2600e654ee
Reviewed-on: https://chromium-review.googlesource.com/1142384Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577977}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0592cfa91913901c7937f221ecdd9b129bad9806
Reviewed-on: https://chromium-review.googlesource.com/1150440Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577976}

Bug: 866860
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I321613158bac990345f01e46e34153eb84091411
Reviewed-on: https://chromium-review.googlesource.com/1148588Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577975}

Bug: 854704
Change-Id: If201f772e7afeb646d619b7917f0f1e134e9edca
Reviewed-on: https://chromium-review.googlesource.com/1149154Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577974}

Bug: 866988
Change-Id: I91084c1f34049d1b4aafdc2f1095ac30efe45fea
Reviewed-on: https://chromium-review.googlesource.com/1148702Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577973}

Bug: 863557
Change-Id: I84e913d238dedf278b070afd9f3c79674373fc44
Reviewed-on: https://chromium-review.googlesource.com/1150290Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577972}

Bug: 866354, 820046, 833797
Change-Id: Ib2b56a59fd9d5a7d2cc9b013a875f5d29b05b5e0
Reviewed-on: https://chromium-review.googlesource.com/1150166
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577971}

https://webrtc.googlesource.com/src.git/+log/e71d1bb7fc22..7f5175a4552d


git log e71d1bb7fc22..7f5175a4552d --date=short --no-merges --format='%ad %ae %s'
2018-07-25 peah@webrtc.org AEC3: Corrected the filter adjustment during analog gain changes
2018-07-25 nisse@webrtc.org Delete root header file typedef.h.
2018-07-25 titovartem@webrtc.org Move sigslot to proper third_party directory
2018-07-25 buildbot@webrtc.org Roll chromium_revision deb63e97..f2569c57 (577752:577860)


Created with:
  gclient setdep -r src/third_party/webrtc@7f5175a4552d

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:867373,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic9e3aaf5ed93f9a14cea51a76a0a6658e859d3a2
Reviewed-on: https://chromium-review.googlesource.com/1150300Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577970}

This reverts commit 568cc6a9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> MSE: refactor mp4 AnnexB validation to also report keyframe-ness
> 
> In preparation for logging when there appears to be a mismatch between
> MSE MP4 keyframe metadata and the encoded video bitstream's keyframe
> metadata, this change incorporates basic analysis of the latter as part
> of the existing Annex-B bitstream validation for MSE MP4 video.
> 
> Note that mp4::BitstreamConverter::AnalysisResult contains
> base::Optional<bool> for each of conformance and keyframe-ness fields.
> If a field doesn't have a value, that portion of the result was not
> analyzed.
> 
> Note that keyframe analysis is implemented only for AVC currently, but
> even that is skipped if the frame is detected as non-conformant before
> enough indications of whether or not it is a keyframe are detected.
> Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis,
> since such was either skipped or not yet implemented previously,
> respectively.
> 
> A subsequent CL will use the newly reported MSE MP4 video bitstream
> converter's keyframe analysis results, if that analysis was done, in
> reporting to chrome://media-internals when the bitstream keyframe-ness
> mismatches that of the mp4 container for a coded frame.
> 
> BUG=860420,584384
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I169c7774070ad232c86658bcd7803160323993ad
> Reviewed-on: https://chromium-review.googlesource.com/1144456
> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Sergey Volk <servolk@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577717}

TBR=wolenetz@chromium.org,sandersd@chromium.org,servolk@chromium.org

Change-Id: If4d14f0cb6fb0779255b9d7eb3d5b2b8c20e5be1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860420, 584384
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1150244Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577969}

This reverts commit 61697367.

Reason for revert: crbug.com/867520

Original change's description:
> MSE: Log when MP4 keyframe-ness mismatches the compressed media
> 
> Logs to chrome://media-internals when the container's keyframe metadata
> for a frame mismatches the contents of that frame (if the latter was
> determined by the respective bitstream converter's Analyze()
> implementation, of whom only AVC currently does any keyframe analysis).
> 
> BUG=860420,584384
> TEST=Repro crbug 860420 shows logs, new MP4StreamParserTest.AVC_Key* and media
> 
> Change-Id: Ic87eab8726ad76b36b569df08ab2212b267008c2
> Reviewed-on: https://chromium-review.googlesource.com/1149153
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577751}

TBR=wolenetz@chromium.org,sandersd@chromium.org

Change-Id: I8437af99f24bf04910ad56931a9e91f960a59469
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860420, 584384
Reviewed-on: https://chromium-review.googlesource.com/1150243Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577968}

The short circuit skips WebStateImpl->OnTitleChanged() incorrectly on
back/forward navigation because although the title in the navigation
item doesn't need changing, the visible navigation item has changed.

This only affects navigating to native content from web content because
web state title for web content is updated separately in
|-webViewTitleDidChange|.

Bug: 864601
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifd74f87aff0276394def154a8410b3dd1ce6c1c8
Reviewed-on: https://chromium-review.googlesource.com/1148693
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577967}

It wasn't showing up for dialogs on background tabs (broken in
r520759). This fixes that and adds a test.

BUG=860185
Signed-off-by: Avi Drissman <avi@chromium.org>
Change-Id: I70ddec77e987dff727a5189e810aad5c3fc589de
Reviewed-on: https://chromium-review.googlesource.com/1147705Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577966}

The application state is always treated as foreground. This is to check if
the android x86 crashes reduce.

Bug: 865373
Change-Id: I6e3ee471b4c775b719d0dce9d5ac9ac0ee1e724d
Reviewed-on: https://chromium-review.googlesource.com/1149513Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577965}

Pass Isolate* through to StringObject::New, String::Concat,
Value::ToString and StackTrace::GetFrame as the non-Isolate forms are
deprecated.

Change-Id: Ib064eb3beba9493ba67e679118a6369c22cb92cb
Reviewed-on: https://chromium-review.googlesource.com/1150030Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577964}

Bug: 867511
Change-Id: I893a4d7b56d0ba4a14f54bb2fa59c33b51283316
Reviewed-on: https://chromium-review.googlesource.com/1150097Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577963}

ThreatDetails is a ref counted object, and its first reference can be
made by base::BindRepeating through ThreadDetails::StartCollection.
The ref count is released when the callback instance is destroyed.

As the RepeatingCallback instance created in StartCollection is
destroyed after the scope out, `new ThreatDetails` may have returned
a stale pointer.

This CL moves the problematic StartCollection() call out of the
constructor to avoid touching the ref count before its first proper
reference is made.

Bug: 866456
Change-Id: I82b83b9bb30cdc95cff60e3e22e79f0af17645a2
Reviewed-on: https://chromium-review.googlesource.com/1149777Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577962}

The first reference to ResourceRequestDetectorClient instance used to be made by
base::Bind in its constructor, and posted to another thread. If the PostTask call
failed, or the posted task ran immediately after the other thread, the RRDC instance
may destroyed before the construction is completed.

Though this does not actually causes a crash, as no one use the result of
`new ResourceRequestDetectorClient`, this hits an assertion that being added as
a false positive case.

This CL adds ResourceRequestDetectorClient::Start, and makes the constructor
private to ensure no one touches the fragile way.

Also, this converts legacy base::Callback to base::OnceCallback, as a drive-by.

Bug: 866456
Change-Id: Ifb3d8136f03e2e233cf4b0b2b0ee070db6b3093d
Reviewed-on: https://chromium-review.googlesource.com/1149779Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577961}

Code should use the scoped retain/release classes.

BUG=none

Change-Id: I0c538d7ae64127bba9b783fd08584f3164dc949d
Reviewed-on: https://chromium-review.googlesource.com/1148476
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577960}