- 03 Aug, 2017 40 commits
-
-
Tsuyoshi Horo authored
This reverts commit 293a6765. Reason for revert: I think this CL caused telemetry_unittests failures. BUG:751967 Original change's description: > Roll SwiftShader 4d3efed..8aa0768 > > https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..8aa0768 > > BUG= > > TBR=kbr@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: I1f88e9213f4387e38b4b9d1059d7ee9a419d755f > Reviewed-on: https://chromium-review.googlesource.com/599015 > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491572} TBR=sugoi@chromium.org,kbr@chromium.org Change-Id: If0463d4bc1a2036feb1317a04c910dc33891755a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel, linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/599174Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491673}
-
Khushal authored
The GPU cache expects an unref for an empty decode as well (returned in the case of a decode failure). Bug: 751444 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3875f20a5d5126ae0277520bb032f22eb4e0779 Reviewed-on: https://chromium-review.googlesource.com/598488Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#491672}
-
Chandan Padhi authored
If the requesting renderer is not allowed access to the given origin, browser reports GenerateStream and OpenDevice failures to the renderer. This CL also adds a OnDeviceOpenFailed() method MediaStreamDispatcher mojom interface, equivalent to legacy MediaStreamMsg_DeviceOpenFailed IPC message. Bug: 742682 Change-Id: I6ff2516dd22281cf4c1fad40b56257352f2bdec7 Reviewed-on: https://chromium-review.googlesource.com/597475 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491671}
-
Alexandre Courbot authored
This reverts commit dd536442. Reason for revert: prevents Chrome to start on ChromeOS/Eve, as evidenced by git bisect. Original change's description: > Remove unnecessary SetUpContext usage > > It's no longer necessary to use SetUpContext to compensate for > individual field accessors being called twice, as they are no > longer called twice. > > This removes all such uses of SetUpContext/TearDownContext. > > BUG=None > > Change-Id: I1162f095bc40fd73b2f06323c4f78ed5025e0ee6 > Reviewed-on: https://chromium-review.googlesource.com/596497 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491488} TBR=sky@chromium.org,dcheng@chromium.org,jam@chromium.org,rockot@chromium.org Change-Id: I98675b0de0477babfb46ab568c9e20fd127a9365 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/598760Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491670}
-
Tsuyoshi Horo authored
This reverts commit 3553b1fe. Reason for revert: Caused browser_tests failures. * ProcessMemoryMetricsEmitterTest.FetchDuringTrace * ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics * ProcessMemoryMetricsEmitterTest.FetchThreeTimes Bug:751948 Original change's description: > Enable Finch Trial Test for MacV2Sandbox. > > Bug: 749839 > Change-Id: Ie95fc3c6574377e278474c1709b7270847016b44 > Reviewed-on: https://chromium-review.googlesource.com/596422 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491576} TBR=jwd@chromium.org,kerrnel@chromium.org Change-Id: I6e96580d4e0cd7f2d810187a9f4864748e9997d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/599173Reviewed-by:
-
Raymes Khoury authored
In https://codereview.chromium.org/2969393002 per-file OWNERS were added for PermissionContextBase subclasses, as they would benefit from approval by permissions owners. In https://codereview.chromium.org/2791623004/#msg148 jochen raised the concern that set no-parent would interfere with large-scale refactorings. Remove set no-parent declarations for now until we figure out what the best way forward is. Change-Id: I13b0fdec6b259e5db3bebf9dda425497b885af6f Tbr: jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/598662 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491668}
-
Yoshifumi Inoue authored
This patch introduces |SelectionForUndoStep| to hold selection for undo/redo instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for improving code health. Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|. After this patch, we use |SelectionForUndoStep| to hold selection at command execution and change |EndingVisibleSelection()| to compute visible selection before we used. This patch looks large, but most of them are replacing |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep| instead of updated |VisibleSelection|. Essential part of this change is * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in |SelectionInUndoStep| * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than |FrameSelection|. * "SelectionInUndoStep.{cpp.h}": The implementation * "UndoStep.{cpp,h}": holding staring and ending seleciton in |SelectionInUndoStep| Just for reference, there is another attempt in the patch: - http://crrev.com/2457523004: Introduce SelectionForUndoStep - http://crrev.com/c/582724 Introduce SelectionForUndoStep [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and extent positions by using layout tree. Once layout tree is updated, e.g. by DOM change or style change, |VisibleSelection| may not be canonicalized. In other words, once we get |VisibleSelection|, it is valid only until layout tree updated. Bug: 747795 Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb Reviewed-on: https://chromium-review.googlesource.com/588874 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491667}
-
Timothy Loh authored
Change-Id: I7725654a919fa77f2a83199775cba2efeb1dcbb3 Reviewed-on: https://chromium-review.googlesource.com/599172Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491666}
-
Alexander Alekseev authored
Bug: 705566 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I664ac7f84cf422e7a1947566b6fe23a47c576bb1 Reviewed-on: https://chromium-review.googlesource.com/598509Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#491665}
-
Tsuyoshi Horo authored
This reverts commit 24f0eb87. Reason for revert: net_unittests fails on msan bot NtlmClientTest.Type2MessageWithTargetName NtlmClientTest.NoTargetNameOverflowFromLength https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/3002 Original change's description: > Add a functionally equivalent NTLMv1 implementation. > > - Replacement NTLMv1 implementation. > - In preparation for new NTLMv2 implementation. > - Passes all unit tests and has the same behavior. > - Adds fuzzer for NtlmClient. > - Code is still not live. > > BUG=chromium:22532 > TEST=All unit tests pass. > > Change-Id: Idae533312805d21d49943fd634d54af3a93a7c00 > Reviewed-on: https://chromium-review.googlesource.com/598307 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491611} TBR=rsleevi@chromium.org,mmenke@chromium.org,zentaro@google.com,asanka@chromium.org Change-Id: I21057e6a0cc43aca6249153debe47e3630df82c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:22532 Reviewed-on: https://chromium-review.googlesource.com/599140Reviewed-by:
-
Xiangjun Zhang authored
Bug: 714717 Change-Id: If707c50a569b1c9ebbed6568c2a6631e55bc1e95 Reviewed-on: https://chromium-review.googlesource.com/584632 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#491663}
-
Tsuyoshi Horo authored
This reverts commit aecc33fc. Reason for revert: BookmarkAppUrlRedirectorBrowserTest.InAppNavigation fails BUG:751958 Original change's description: > desktop-pwas: Open Bookmark app when link is within scope > > The DesktopPWAWindowing feature must be on in order for this to work. > > Makes it so that, once a user has installed a Bookmark App for a website, all > navigations to that website will open the installed Bookmark App. This includes > typing the address in the omnibox, clicking any links to an in-scope url, and > opening any links to an in-scope url from the context menu. Future patches > will change some of these so that the result is more intuitive. > > For example, if the user has installed https://www.foo.com through > "Add to shelf" and the site's manifest defines scope as "/scope" and then the > user visits https://www.foo.com/scope/test.html, a new app window to > https://www.foo.com/scope/test.html will open. If the user > navigated to https://www.foo.com/index.html, we would not open a new app > window since the address is not in-scope as defined by the site's manifest. > > Three changes: > > 1. Use 'scope' in the site's manifest to create a url handler for > the bookmark app. > 2. Allow Hosted Apps that are Bookmark apps to use url handlers. > This means that any non-bookmark hosted app that has url handlers > will fail to load. > 3. When handling a url that a Bookmark app could handle open the > the bookmark app with the specified url. > > Bug: 740783 > Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 > Reviewed-on: https://chromium-review.googlesource.com/566199 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491644} TBR=benwells@chromium.org,calamity@chromium.org,mgiuca@chromium.org,ortuno@chromium.org,skym@chromium.org,jochen@chromium.org Change-Id: I5e4bf4899d56fd2ffc1755b6cd5db0aa9c0c02d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740783 Reviewed-on: https://chromium-review.googlesource.com/599090Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b4fee4d5d471..d1a8458e6390 $ git log b4fee4d5d..d1a8458e6 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 thestig Avoid a redundant header offset check in CPDF_Parser. 2017-08-02 hnakashima Replace CFX_ByteTextBuf with ostringstream in cfx_psrenderer.cpp. 2017-08-02 hnakashima Replace CFX_ByteTextBuf from cpdf_security_handler.cpp with std::vector 2017-08-02 rharrison Remove unused FromUnicode method 2017-08-02 art-snake Unify parsing of cross refs v4 2017-08-02 rharrison Remove parameter from GetID 2017-08-02 rharrison Remove support for out of bounds params in Delete Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I633fc2cb7101cc1fcb0f8dc57be00c8f54f3c55c Reviewed-on: https://chromium-review.googlesource.com/599392 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491661}
-
Yoshifumi Inoue authored
This patch moves |is_handle_visible_| to |FrameSelection| from |SelectionTemplate| since handle visibility is used only for setting |FrameSelection|, hence it is a redundant member variable of |SelectionTemplate|. Bug: 742093 Change-Id: I3add4da3844fb40be34dcb4d4b46b5fa6fed1d7e Reviewed-on: https://chromium-review.googlesource.com/595389 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491660}
-
Tsuyoshi Horo authored
Bug: 751906 Change-Id: I7f43cc71da5557ebf396280cf295f76ed04e9e91 TBR: chenwilliam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/599138Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/45ad6a02..43bd6d3f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ia552de41f9306dcbeefc8beb04a48252db18df00 Reviewed-on: https://chromium-review.googlesource.com/599157Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491658}
-
Tsuyoshi Horo authored
TBR: reillyg@chromium.org Bug: 751955 Change-Id: Iac23c3c3df62e4dbccaaf80192297dbbb52a48e8 Reviewed-on: https://chromium-review.googlesource.com/599137Reviewed-by:
-
Michael Moss authored
This reverts commit b567cf95. Reason for revert: breaking official.continuous builders BUG=751954 Original change's description: > Add a "buildbucket" subcommand to mb. > > This subcommand prints the trybot configuration in the > buildbucket.config format expected by gerrit. This should hopefully > make it a little easier to maintain the buildbucket.config file. > > Bug: > Change-Id: I7d956efb6c08128ae0ceaa6b68bcc9001296549c > Reviewed-on: https://chromium-review.googlesource.com/568666 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491647} TBR=agable@chromium.org,dpranke@chromium.org,pcc@chromium.org Change-Id: I2cc5f086b9787723337795c3c2323c3bafdc89f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/599393Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491656}
-
Christopher Cameron authored
This logic was incorrectly inverted. Bug: 735613 Change-Id: Ib07302612c02e860c006f0cc2e9929a04f5de009 Reviewed-on: https://chromium-review.googlesource.com/596710 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#491655}
-
Michael Montvelishsky authored
This reverts commit a34be8ec. Reason for revert: http://eureka-internal-review.git/c/81685 Original change's description: > Make audio frame chunk_size a factor of 4 > > BUG=internal b/63390317 > > Change-Id: Ia1c11717aea70bdda8e5542fea89b0e7c7c0a46b > Reviewed-on: https://chromium-review.googlesource.com/588470 > Reviewed-by: Le-Chun Wu <lcwu@chromium.org> > Commit-Queue: Michael Montvelishsky <mont@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490290} TBR=lcwu@chromium.org,slan@chromium.org,halliwell@chromium.org,wzhong@chromium.org,jyw@chromium.org,kmackay@chromium.org,bshaya@google.com,alokp@chromium.org,mont@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/63390317 Change-Id: I09c7154a5f065e320ca440583aebbd3495c6cc33 Reviewed-on: https://chromium-review.googlesource.com/598387Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#491654}
-
Patti authored
Make the Site Details web UI update permission values when they change without needing to reload the Site Details page. Manual test - With #enable-site-details on, open https://permission.site. Open the Page Info bubble, click "Site settings", and drag the Site Details tab out into a new window so that the https://permission.site and the Site Details windows are viewable at the same time. On https://permission.site, open the Page Info bubble and change a permission there. It should automatically update to show the same permission in the Site Details page. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1b28afbed3317a7ac43ada1d8ca02424137b50d Reviewed-on: https://chromium-review.googlesource.com/595299 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491653}
-
Tsuyoshi Horo authored
TBR: chenwilliam@chromium.org,dgozman@chromium.org Bug: 751906 Change-Id: I44c2496307f32343b5120884ed58a9b4e0933722 Reviewed-on: https://chromium-review.googlesource.com/599135Reviewed-by:
-
Matt Falkenhagen authored
Bug: 748416 Change-Id: I37d13c799e61fff05bc75675a888ce2630995aa0 Reviewed-on: https://chromium-review.googlesource.com/597576 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491651}
-
Eliot Courtney authored
We had tried filtering noisy ARC processes out, using their ProcessState. However, ideally the task manager should summarise the total resource usage and not completely hide processes. Further, there were some hard to resolve issues about processes that ought to definitely be shown being hidden (see linked bug for context). So, until we have a better solution for noisy ARC processes, remove this filter. BUG=738651 Change-Id: Icf9d246e053185af5c5d7b20f90245fcd169ecc8 Reviewed-on: https://chromium-review.googlesource.com/582265Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491650}
-
Tsuyoshi Horo authored
This reverts commit 433d6917. Reason for revert: Metrics related tests are failing. See crbug.com/751948 BUG:751948 Original change's description: > Make MetricsLog not need a PrefService. > > Move system profile persistence to MetricsService. > > Bug: > Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0 > Reviewed-on: https://chromium-review.googlesource.com/592689 > Commit-Queue: Steven Holte <holte@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491573} TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org Change-Id: Id9e35a2388566faf7681cddd34fdab9b83db0e03 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/599089Reviewed-by:
-
Kent Tamura authored
NOTRY=true Bug: 746157 Change-Id: If1a8d3ecfa0101f6a8d432c658f676089830203c Reviewed-on: https://chromium-review.googlesource.com/599270Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491648}
-
Peter Collingbourne authored
This subcommand prints the trybot configuration in the buildbucket.config format expected by gerrit. This should hopefully make it a little easier to maintain the buildbucket.config file. Bug: Change-Id: I7d956efb6c08128ae0ceaa6b68bcc9001296549c Reviewed-on: https://chromium-review.googlesource.com/568666Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#491647}
-
Eric Karl authored
Because Skia blacklists MSAA on Intel GPUs independently from Chrome, we can end up in situations on dual-GPU Macs where CC thinks that MSAA is available while Skia has it blacklisted. In order to avoid these situations, we will blacklist MSAA for both GPUs (on the Chrome side) if we want to blacklist either. Bug: 749438, 751919 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I537ef3286f1a83330c58ae8e43e7133752575509 Reviewed-on: https://chromium-review.googlesource.com/599224Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#491646}
-
Michael Giuffrida authored
AppWindowClient::Set sets the global AppWindowClient. Unit tests sometimes call it more than once, e.g. when multiple BrowserProcesses are created. Currently, each additional call silently returns instead of changing g_client. Even Set(nullptr) does nothing. Normally, this is fine: only tests should call it more than once, and usually it's called with the same value anyway (because BrowserProcess and TestingBrowserProcess both use the global ChromeAppWindowClient singleton). Some tests do create and destroy unique AppWindowClients, like ones in app_shell_unittest. This CL allows g_client to be changed to nullptr and then to a new value. Otherwise, since these tests run sequentially in the same process, g_client may point to freed memory. This will become an issue as we add more tests here. Bug: 751242 Change-Id: I1bfa8f12f1fbbd5e086ae3c033e038b93c5a18ce Reviewed-on: https://chromium-review.googlesource.com/593052 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491645}
-
Giovanni Ortuño Urquidi authored
The DesktopPWAWindowing feature must be on in order for this to work. Makes it so that, once a user has installed a Bookmark App for a website, all navigations to that website will open the installed Bookmark App. This includes typing the address in the omnibox, clicking any links to an in-scope url, and opening any links to an in-scope url from the context menu. Future patches will change some of these so that the result is more intuitive. For example, if the user has installed https://www.foo.com through "Add to shelf" and the site's manifest defines scope as "/scope" and then the user visits https://www.foo.com/scope/test.html, a new app window to https://www.foo.com/scope/test.html will open. If the user navigated to https://www.foo.com/index.html, we would not open a new app window since the address is not in-scope as defined by the site's manifest. Three changes: 1. Use 'scope' in the site's manifest to create a url handler for the bookmark app. 2. Allow Hosted Apps that are Bookmark apps to use url handlers. This means that any non-bookmark hosted app that has url handlers will fail to load. 3. When handling a url that a Bookmark app could handle open the the bookmark app with the specified url. Bug: 740783 Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 Reviewed-on: https://chromium-review.googlesource.com/566199Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#491644}
-
Randy Smith authored
SetCanonicalCookie pathway (used to just be enforced via SetCookieWithOptions()). Discovered in writing tests for the cookie service, so using that bug. Bug: 721395 Change-Id: I6d8b0e44e99063200de6f5983d0049af4efd2bc6 Reviewed-on: https://chromium-review.googlesource.com/581797Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#491643}
-
Yoshifumi Inoue authored
This patch gets rid of redundant equality checks of |Start()| and |End()| of |VisibleSelectionTemplate| from |EqualSelectionsAlgorithm()| for improving code health. Change-Id: I0fd5949f8356b0527fa5e67426818434efedbee1 Reviewed-on: https://chromium-review.googlesource.com/597510Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/747d3ecd..45ad6a02 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I23411f423fa4dd71b4171930f65540c5416351ad Reviewed-on: https://chromium-review.googlesource.com/599155Reviewed-by:
-
Eric Roman authored
Bug: 634443 Change-Id: If3c5536cf0dba79a14f092f9dafb701668f6c46a Reviewed-on: https://chromium-review.googlesource.com/599327 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#491640}
-
Alex Newcomer authored
Added a closing animation for the peeking launcher. It lives in AppListPresenterImpl because we use the callback function for the animation. The animations for all state changes will be in AppListView once we move ui/app_list into ash/app_list. (I made a note in 733662 for this). bug=748190 Change-Id: I2e2e885306f2005aa3bf54470420a6aada99a3b6 Reviewed-on: https://chromium-review.googlesource.com/588083 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491639}
-
Mitsuru Oshima authored
* This locks the compositor and prevent updating while waiting for the rotated frame. * Timeout is currently a bit longer than I deal because Android seems to generate unnecessary frames that uses old bounds. I'll look into the issue separately. Bug: b/62140863 Test: Manual. 1) Apply Android side patch: https://googleplex-android-review.git.corp.google.com/#/c/2548263/ 2) Login & start ARC++ app that can rotate 3) Switch to tablet mode and tilt the device. Change-Id: Ifb1427365cc524d69cf3b84c446fe108ca9e7a46 Reviewed-on: https://chromium-review.googlesource.com/572391 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491638}
-
Matt Giuca authored
Adds image_platform.h which declares these methods. The existing platform-specific implementations for iOS and macOS remain in image_ios.mm and image_mac.mm, respectively. The generic implementations are moved to image_generic.cc. This change makes it more obvious what's going on and moves some code into anonymous namespace, and out of ifdefs. Bug: 745355 Change-Id: Id40677dc1e11a0d8b6fc4db5cd22565fd7533660 Reviewed-on: https://chromium-review.googlesource.com/574994Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#491637}
-
Yuly Novikov authored
conformance/extensions/oes-texture-half-float-with-video.html on Win7 Debug NVIDIA D3D11 passthrough BUG=751849 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb623f457fca5937b8c82943f60ee87f7353febb Reviewed-on: https://chromium-review.googlesource.com/599451 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491636}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c8c5d6b714f8..2857b6b6c858 $ git log c8c5d6b71..2857b6b6c --date=short --no-merges --format='%ad %ae %s' 2017-08-02 benjhayden Format chart ticks using units. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If6f91f0429c723869a69f80a6928548558895f83 Reviewed-on: https://chromium-review.googlesource.com/599215 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491635}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f12d84275cfa..255607f094da $ git log f12d84275..255607f09 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 mtklein 8-bit hacking 2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 6c58b0620..a0bcc50be (2 commits) Created with: roll-dep src/third_party/skia BUG=750813 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I93ac33e9029b8ae6540dc545d28b4d53c986890b Reviewed-on: https://chromium-review.googlesource.com/598511Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491634}
-
