GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/038b9b33775b..b7260027e661

2020-07-23 brgoddar@microsoft.com Grid: Display grid line names in the overlay
2020-07-23 jalyn@microsoft.com Only show Network datagrid focus when keyboard-focused
2020-07-23 szuend@chromium.org Revert "Fix path escaping"
2020-07-23 aerotwist@chromium.org List formatter_worker_entrypoint and acorn.mjs in GRD
2020-07-23 mathias@chromium.org Integrate client variations parser
2020-07-23 jacktfranklin@chromium.org Use local `tsc` for cross-referencing script.
2020-07-23 mathias@chromium.org Revert "Integrate client variations parser"
2020-07-23 fawazm@google.com [WebAuthn] Customize authenticator name
2020-07-23 mathias@chromium.org Integrate client variations parser
2020-07-23 aerotwist@chromium.org Adds more cases for TS/GN cross-reference
2020-07-23 aerotwist@chromium.org Adds cross reference script
2020-07-23 leese@chromium.org Fix path escaping

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1034663,chromium:1094436,chromium:1098701,chromium:1100385,chromium:1103854,chromium:1107859
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7378411ad2b464575c7cca04b65ec98841b7874d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316988Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791407}

This CL lands a tiny fix in the DisplayChangeObserver's: we should only
fill in the HDR DisplayColorSpaces if the monitor actually supports it.
I just stumbled upon it while debugging the next CL in the chain.

Bug: 958166
Change-Id: I3ee41501c04b692e12e1e96959a0d6cbf3c7489b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317815
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791406}

Extend PinBackend to support the PIN auto submit functionality.

PIN auto submit just exposes the user's PIN length in local state
when its enabled. Normal users are prompted with a dialog in Settings
for their PIN. After checking that the PIN is correct, the length is
exposed. Managed users who cannot control the feature have their PIN
lengths collected upon a successful authentication attempt.

A new method - SetPinAutoSubmitEnabled - was added to allow Chrome OS
Settings to control the functionality directly. The basic operations
in PinBackend (Set, Remove, TryAuthenticate) were extended so that
they now call PIN auto submit subroutines to do additional steps that
are necessary for the new functionality. These methods were named
PinAutosubmitOnSet, PinAutosubmitOnRemove and PinAutosubmitOnTryAuth.

In order to extract the PIN length upon a successful authentication
attempt, the call to Cryptohome is now calling the new method
'OnCryptohomeAuthenticationResponse' first, instead of the
original caller.

All of the PIN auto submit subroutines are guarded by the feature
flag, which is disabled by default.

Unit tests were added to cover all the possible user flows.

Design Document
- https://goto.google.com/chromeos-oac-pin-authentication-refinements

Bug: 1107367, 1107367
Change-Id: Ie770727c73c9abece174a10fd8c618575f849b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306258
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791405}

chops recently updated the depot_tools input_api, which makes this
possible.

input_api.DEFAULT_ALLOW_LIST -> input_api.DEFAULT_FILES_TO_CHECK
input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP

For named parameters:
white_list/whitelist -> files_to_check
black_list/blacklist -> files_to_skip

Bug: 1098562
Change-Id: Ie023436a9f86e130a09d214a75c53b6bf97b4a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317770
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791404}

Since we're about to launch version 4 to Stable, set it as the default.
This CL also updates a few tests that implicitly use the default model
version.

Fixed: 1054056
Change-Id: Icb2d781279ac132019ab9bd6d433dbb627490713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316335
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791403}

Based on discussions here[1], it isn't obvious why |display_private_|
should be null checked before use. Adding a comment here from this
discussion should make this clearer.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2259015/21/ui/compositor/compositor.cc#774

Bug: 1107926
Change-Id: I5109c72bb6223a4b79ab1706a9dffe08d6a23299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315091Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791402}

We were making too strong of assumptions about widget vs. view
lifetimes, leading to crashes.

This CL loosens those assumptions (correctly) since we only have a weak
pointer to the widget.

Bug: 1108762
Change-Id: I5eddfe7f5e9dc4e4f51c3caf35056fc2dc388989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316445
Auto-Submit: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791401}

They were crashing under ASAN because the
accessibilityNotifiesWhenDestroyed selector was being
called when the object was already detached and it was
trying to access an internal field of the object. To be
safe, just remove the code that logs the role.

Bug: 1094915, 1006842
Change-Id: I234bf43d4d6d91adbca6a26bcb72bf56478c8a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314133Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791400}

Roll Chrome Win32 PGO profile from chrome-win32-master-1595383207-383ffdc8ec941b58d960256b6aec4daee6f9b86f.profdata to chrome-win32-master-1595505150-4b6923c63ca1fabc99171826cfe4658bec498e66.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I0f465681e4d1770fb5c0b9b017228be1111ddf54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316277Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791399}

Bug: 1095283
Change-Id: Ia2cea7a5dbdf1326e417ac77c02de676b30537b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310776
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791398}

BUG=1108460

Change-Id: Ib980a52cb155a32eeaa2412dfb70e496c1bf24c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315088
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791397}

This CL moves the inbound ("Finalize") half of Trust Tokens operation
execution before URLLoader opens its response pipe.

Requests configured for Trust Tokens operations execute outbound
("Begin") and inbound ("Finalize") halves of their Trust Tokens
operation against their request and response headers. The intended
behavior when either half fails is to fail the request altogether.
Currently, due to a bug, requests whose inbound ("Finalize") Trust
Tokens operation halves fail can still report a success to the renderer.
This is because URLLoader::OnResponseStarted opens a request's response
data pipe before executing the request's inbound Trust Tokens operation
half. Later, in URLLoader::NotifyCompleted, the loader sees that the
pipe is open and reports a completed response to the loader's client,
before seeing that there is a failure status and reporting the error.
This means that the client will always see a successful response before
sending the error; the effect of this is that fetch(..., trustToken)
will resolve with a success instead of rejecting with a DOMException in
cases where the request fails on the inbound half of its Trust Tokens
operation.

This CL fixes the issue by moving the inbound half of the Trust Tokens
operation before the data pipe is opened, so that the data pipe will not
open if the inbound half of the Trust Tokens operation fails.

Fixed: 1105696
Change-Id: Icf80e0f2d8d8231ec1c2854087c7afa023422c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303677Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791396}

We can't use const LayoutObject* throughout, because sometimes we do
call non-const methods, for example to scroll a LayoutObject in
response to an accessibility action.

What this change does is make it so that to create a new
AXObject from a LayoutObject*, you need a non-const pointer,
but to just retrieve an existing AXObject, it's okay if you just
have a const LayoutObject*. I think that logically makes sense.

This is a pure refactoring that shouldn't have any side effects.
I'm making this change because it will make landing a future change
I'm working on a bit easier.

Bug: 1109081
Change-Id: Ic03525b4faee20e7d8c7d3cb9c6141281036a982
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315822
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791395}

This CL converts base::Callback (and corresponding calls to base::Bind)
to either base::OnceCallback or base::RepeatingCallback. In general
a base::OnceCallback is preferred since that's a stronger API
guarantee, so I've tried my best to use that where I think its safe.

Bug: 1007815
Change-Id: Ia750b88fd0260248dda3aa6adffefb5a91e7a277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309562Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#791394}

Moves GoogleServicesManager.onMainActivityStart and the corresponding
ApplicationStateListener to SigninHelper. The remaining part of
GoogleServicesManager will be merged into SigninManager in subsequent
CLs.

Bug: 1107942
Change-Id: Ia4acd5ff1cb9d466e34144f9d000b413324f0854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310491Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791393}

Removed TS_SS_TRANSITORY while querying for status as it was causing
issues in Japanese IME which makes it behave like it is running on
notepad. We now support Korean reconversion so removed the TODO as
well. I also checked the bug for which this fix was originally made
and verified that it no longer reproduces after removing this flag.

Bug: 148355

Change-Id: I0bf1358319b38b1e3f0dba17d9da2b3b679dae45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317805Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Reviewed-by: Siye Liu <siliu@microsoft.com>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791392}

This CL is to add enterprise enrollment shelf button in the OOBE flow. This button should only be visible in UserCreationScreen.

Bug: 1101318
Change-Id: I0c68a51dc1d06a56460cef9d6096e72b8bd814c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303438Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#791391}

https://quiche.googlesource.com/quiche.git/+log/8b6881bd2a9b..eede82b9b785

$ git log 8b6881bd2..eede82b9b --date=short --no-merges --format='%ad %ae %s'
2020-07-23 nharper Add more code_count macros to debug enabling tls resumption
2020-07-23 renjietang Introduce QuicSession::PerformActionsOnActiveStreams().
2020-07-23 haoyuewang Remove ack_decimation_with_reordering mode, fast_ack_after_quiescence option, and related connection options in quic received packet manager.  protected by gfe2_reloadable_flag_quic_remove_unused_ack_options.
2020-07-23 fayang Deflake e2e test because of spurious loss detected.
2020-07-22 renjietang In QUIC, prevent applications from looking up stream_map_ directly.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I66ca99fe8a34de680696e72fd967a1d3762b5e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317032
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791390}

This change implements
FakePrinterConfigCache::ConsumeFetchRequestFor(), which allows us to
write tests in which many things happen on-sequence before the server
has a chance to respond to an outstanding Fetch().

Bug: chromium:888189
Test: autoninja ... chrome{,os_unittests}
Change-Id: I747e43e3765ca2862a7274f9356ef95b76b99df6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303042
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791389}

Bug: 1108556
Change-Id: I8d5100d313727aeee2adfa5a63bab599446114a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318314
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791388}

Since permission delegation is enabled by default and the flag is soon
to be entirely removed, this CL removes specific notification permission
logic that pre-dates permission delegation.

The CL should be a no-op except for file origins which currently have
issues in the permission architecture (see towards the end of
crbug.com/444047).

Bug: 995457
Change-Id: I9d502b4ffbb18789b07ef5c336714aba5c05157f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315692Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791387}

std::move() has no effect when the parameter is const - there's no way
to move data from such values elsewhere.

Bug: none
Change-Id: I218443e50cae37c731ec59efc3cf69029e325e72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318665
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791386}

After clangd moved its generated index files from .clangd/index to
.cache/clangd/index[1], 3 separate CLs added .cache entries to the
.gitignore. Remove duplicate entries so that we only keep one entry.

[1]: https://github.com/llvm/llvm-project/commit/9b55bc4d1197aedd76b0f4e04270265cb74cd0b8

Change-Id: I8cb9cda444f5230001df03949c4ee3bc89b7b58e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315763Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791385}

Doodle resizing fixed for new FlexNG by
e00c3fec.

Fixed: 1062484
Change-Id: I02a0c1ced27b609cbd4547dbedd46055d4354c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315637
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791384}

Crashes in WebEngine are reported as FuchsiaWebEngine, and crashes in
CastRunner are reported as FuchsiaCastRunner.
The version is also reported. The channel is the empty string for now.

Bug: 1050339
Test: While the components are running, run `fx bugreport`. Then verify the mapping is registered in the bugreport's inspect.json at crash_reports.cmx > fidl > crash_register > mappings.
Change-Id: I86ffc4c0c1af19f9f34a462ee7fce77068cbded1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315796Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791383}

This is a follow-up to [1] that fixes one compilation issue and also
renames the classes and files so they would match the purpose better.

No changes to functionality are intended.

[1] https://crrev.com/c/2289772

Bug: 990756
Change-Id: Ifffe052bff2d6bfcad81ce5fe38e6e5ad37dcb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317185
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791382}

Some callers (in bigger, more complicated code and tests) rely on
StringToDouble's "return non-zero with failure" best-effort behavior
when the number has a unit suffix.

Change-Id: I7ac38fec189e8193895547664ddc09c071e1bdc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310370
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791381}

Add metric value for kUpdateSkipped.

BUG=chromium:1086956
TEST=None

Change-Id: I864a5ae1aaec0b4936ceba4416ca16b5031e1fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314807Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Andrew Lassalle <andrewlassalle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791380}

Change-Id: Icf8641dc2aed3f8111ef417f078867e832da24ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316409
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: John Pham <johnp@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791379}

Currently, when developing lacros-chrome on a ChromeOS device, passing
new arguments requires rebuilding ash-chrome. With this CL, the new flag
--lacros-chrome-additional-args can be used to pass flags from
ash-chrome directly to lacros-chrome. This means that developers can
modify /etc/chrome_dev.conf to pass flags to lacros-chrome without
rebuilding ash-chrome.

Bug: 1107936
Change-Id: I81d1d51451dce0e256c8c5d5d8e94016b4defa79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316812
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791378}

This change prevents code from creating RenderProcessHostImpl objects
that will reference a BrowserContext that is in the process of shutting
down. Since RPHI's reference to a BrowserContext is a raw pointer it is
easy to accidentally introduce a potential use after free if an RPHI is
created as the BrowserContext is shutting down. The goal of the CHECK
is to help detect code that might be trying to create RPHIs at
inappropriate times.

Also added logic to avoid creating a spare RPHI for BrowserContexts that
are in the process of shutting down. This should help mitigate crashes
that we are seeing where destruction of the spare appears to be
referencing a BrowserContext that has already been destroyed. Added a
DWOC on this path to help us detect potentially problematic callers.

Bug: 1099998 1038844
Change-Id: I9a02e6f9cf19394a990afe3ca41f7d370ff3e2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317827Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791377}

Adding FirstRunAppRestrictionInfo to check if any app restriction exists
when first run is necessary. This helper class aims to fire an async
background task to fetch the restriction information, and respond to
callback that queues for that information.

This CL also adds a timing metrics
Enterprise.FirstRun.AppRestrictionLoadTime. On local build, the estimate
avg is about 13 ms.

Bug: 1103476, 1106812
Change-Id: I4013bb9b36ea8b649c39252aef542db0dfdc4786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289210
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791376}

Adds a ripple definition specific to Incognito and changes where the
selectable background is applied to DecoratedSuggestionView and action
buttons.

We logically have 3 possible sources of selection colors now:
* Device light theme based
* Device dark theme based
* Incognito based (very similar to dark theme, but does not leak
  attributes).

To better manage the 3 possible states this patch introduces
OmniboxTheme with values { LIGHT_MODE, DARK_MODE, INCOGNITO }.

To better resolve attribute values for the OmniboxTheme, this patch
introduces OmniboxResourceProvider.

All changes appropriately update USE_DARK_COLORS model property to
OMNIBOX_THEME.

Bug: 1103291
Change-Id: I14f276274b25b6afa51ed7fbc3661a5437c5b1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288074
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#791375}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I8e04a7cbf86db06bc70db63e67ca226beb489968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316249Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791374}

The server now supports the correct value
of AppType.

Bug: 1044139, b/161836372
Change-Id: I61736c827a02e3079a7fe781f9bfda8ded4115af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317000
Auto-Submit: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791373}

Bug: 1096834
Change-Id: I45f1e5cff11df4c889619f32cff00ed292440a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318845Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791372}

Roll Chrome Mac PGO profile from chrome-mac-master-1595560196-304c2c3cd13e1a2835ed6d3cda951db2ffc9e342.profdata to chrome-mac-master-1595634856-273b35e9c5e7a1fe88efc52ccb79b7a01140c642.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I44855b7b16bdc100b15b10acd1a93c4d9078fb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791371}

Stop unit test FileEnumerator::GetInfoDotDot from failing on Windows.
The unit test is showing a real bug in Windows, but it's not one we can
fix, so skip the check on Windows.

Fixed: chromium:1108304

Change-Id: Ibf0efa1a18fbd6c9a8008425eb7192f6a5e665a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314816
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791370}

The function CreateGlobalMenuBar() is only used in a block guarded by
defined(USE_DBUS_MENU), so the function definition should be guarded by
the same flag.

Change-Id: I4df2786b0e3dacd29bf4869575c5caf6bea01cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316128
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791369}

* Use temps to replace repeated expressions.
* Change name to make clear that it's not always the warning icon.
* Return ImageModel so callers can use the size; this fixes a bug where
  callsites used the wrong size in cases where the "help or error icon"
  would have been painted.  This removes GetWarningIconSize().

This does not yet fix a couple of behavioral oddities around the
selection of icons and colors (didn't want to mix noticeable behavior
changes with cleanup).  I will do that in a subsequent CL.

Bug: none
Change-Id: I44d5e56ea3729b2bc7c6498cbf32f342068ad77e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315218
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791368}