GitLab

This change moves the LevelDBScopes implementation from content/browser
to componenets/services/storage.

Other than the file moves (and associated macro, include, and export
updates), this change:
* Deletes the BarrierBuilder in lieu of having an anonymous version in
  the unittests file directly.
* Moves the scopes lock range test for IndexedDB-specific lock ranges
  to indexed_db_unittest, as that is where the test should go.

R: rockot@google.com
Bug: 1015212
Change-Id: Ied21b955b903d06621798091771a46d4f3e47854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895863Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711903}

TBR=govind@chromium.org

Change-Id: I545c54194a85de91756881e42b67d2d6cd70428e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895972Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711902}

This DCHECK was first added in
http://crrev.com/19b1b85cd5c3227697d348a39cec89ddf5980690

But the code in question could be run as root, in the case when
curtain-mode is false. The host only aborts running as root if curtain
mode is enabled. The host service explicitly runs in both "Aqua" and
"LoginWindow" contexts, as specified in the launchd agent's plist.

Instead, this CL skips the permission-checks when host runs as root.

Change-Id: Idf07719d0780f3627290e96710c36d0fe98e8f7a
Bug: 1020739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896122
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711901}

Bug: 1010217
Change-Id: Iaa1d73bfec3522db08d04bedeb59603e16c8ffe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895857
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711900}

This adds time of profiling done, duration, title, icon.
Also it includes new event when buffer was committed.
In addition tracing is automatically stopped on active tracing window is
gone to simplify reading testing results.

TEST=Locally
BUG=b/143532713

Change-Id: I6b9fa7ba2a1628172949c856e7be7ef984505e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894040Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711899}

MRFileDialog's delegate (MediaRouterViewsUI) may get deleted before
MRFileDialog if the Cast dialog somehow gets closed before the file
selection dialog does. Use a WeakPtr to prevent crashes in this scenario.

Bug: 1019925
Change-Id: Ibcc6e9f8297e5a40777acb87767e127afe04d197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894970Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711898}

Remove unused variable after issue 1536474
(commit 0f755b17)

|status_label_| is used instead |status_text_|.

Change-Id: I56ce991f5e88dbfe8957f920c26a4a1249b69676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893254Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711897}

https://chromium.googlesource.com/catapult.git/+log/840ecb38c04e..f5eca592259a

git log 840ecb38c04e..f5eca592259a --date=short --no-merges --format='%ad %ae %s'
2019-11-01 dproy@chromium.org Update reference binaries

Created with:
  gclient setdep -r src/third_party/catapult@f5eca592259a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: None
Change-Id: I114100b2f64bdea199ed76ab7f4288e829888e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895874Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711896}

https://chromium.googlesource.com/angle/angle.git/+log/fe26bae45243..422ebad20adb

git log fe26bae45243..422ebad20adb --date=short --no-merges --format='%ad %ae %s'
2019-11-01 jmadill@chromium.org Fix ANGLE_get_image cube map handling.
2019-11-01 shrekshao@google.com Reorder BaseVertexBaseInstance draw calls parameters

Created with:
  gclient setdep -r src/third_party/angle@422ebad20adb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:891861
Change-Id: I0da4784fbcc34806630a1f9ee3e0ac97682fe2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895940Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711895}

They're failing on every run

R=crouleau@chromium.org

Bug: chromium:1013295, dawn:208, dawn:254
Change-Id: I77ef362f798ccde18023d3744c8c3a06e13708dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895114Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711894}

CL:1800725 changed FidoRequestHandlerBase's |notify_observer_callback_|
barrier to block on each of the discoveries sending DiscoveryStarted()
before reporting transport availability to the UI layer. However, on a
machine with BLE available but powered off, FidoBleDiscoveryBase will
never invoke DiscoveryStarted() until the adapter is powered on.
Powering on the adapter is triggered by the UI after receiving the
transport availability callback. Hence, with a powered-off BLE adapter,
on requests instantiating the BLE discovery transport availability
callback was never invoked, and as a result the UI never appeared.

As it happens, the DiscoveryStarted() callback is rather redundant
anyway. It's important for the platform discoveries (TouchID, Windows)
as a way of ensuring their authenticators are added to the request
handler, before signaling transport availability to the UI. But for
Bluetooth specifically, there is a separate callback for determining
Bluetooth availability and power status that the barrier waits on.
Nothing the Bluetooth discovery does actually requires the UI to block.

Therefore, this change modifies FidoBleDiscoveryBase to invoke
DiscoveryStarted() right after enumerating Bluetooth adapters. As a side
effect, the boolean |success| argument to DiscoveryStarted() now only
signals whether the discovery found an adapter, whereas previously it
also indicated e.g. whether caBLE advertising succeeded. But that
doesn't really seem to matter since that argument is only ever consumed
in unit tests anyway.

Fixed: 1018416
Change-Id: I33549a24b1c399fee61374e44f5478f10d9db71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881974Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#711893}

This CL converts PeerConnectionTracker away from string,
to use WTF::String.

Note that there is still left over std::string when it is
needed to interface with libwebrtc.

Other classes got minimally changed to adapt to the changes
needed for PeerConnectionTracker, but will have their own conversion
round next.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I94c05b7d7830bba16e05a3fb7b2bfb8c063ab61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880961
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711892}

See crbug.com/1019139#c8 for this change's motivation.

See https://chromium-review.googlesource.com/c/catapult/+/1894511
for catapult-side change.

This change will be followed up with another change
restricts the exit code to 111 completely (That can't
be done until catapult side change lands, and that
change can't land until this one does.)

Bug: 1019139
Change-Id: If0243e792282cfcbcbeb2a943648efd7916e1d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893823
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711891}

Ensuring that users don't get a WebAuthn opt-in promo while in incognito mode.
This also avoids a browser crash if a user attempts to downstream incognito.

Bug: 949269
Change-Id: I2b4af11a8bb1d8df115f0748d30d8785a99cfacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894291
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#711890}

This is called when the page uses window.open, or an anchor with an
href=blank.

BUG=none
TEST=none (will be covered via instrumentation test)

Change-Id: I0e0b1aeb776f1eb4712295bcd790c357dcf0a047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894673
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711889}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab7bec343496..c39a77883d7b

git log ab7bec343496..c39a77883d7b --date=short --no-merges --format='%ad %ae %s'
2019-11-01 iannucci@chromium.org [gclient] Reset to parent commit with rebase_patch_ref=False instead of master.

Created with:
  gclient setdep -r src/third_party/depot_tools@c39a77883d7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: Ifc638852ad10a622c64d6052e597c2236586e286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895917Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711888}

crrev.com/c/1713826 flipped slashes from / to \ so that clang-cl
commands could be copy/paste run on Windows. While investigating a
recent compiler bug I had the need to copy/paste run linker commands on
Windows and realized that I hadn't flipped those slashes. This change
finishes the job, for lib/link commands, tested with component and
non-component builds of base.


Change-Id: If5570ab3093b42908bebab9944cde82da31a055d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894094
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711887}

This is a reland of 856b8913

The iOS issue was resolved by 9124e345
and a corresponding internal CL.

Original change's description:
> Limit GN visibility of libxml for security audit control.
>
> This splits the libxml_utils helper classes into xml_reader and
> xml_writer targets. The xml_writer can be safely used from any target.
> The xml_reader has strictly limited visibility to locations that are
> audited by the Security Team. Direct access to the libxml target is now
> also limited.
>
> Bug: 699306
> Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711536}

Tbr: thakis@chromium.org
Tbr: davidben@chromium.org
Tbr: rohitrao@chromium.org
Bug: 699306
Change-Id: I633309f7efc3c920b97dced173607d73dc48d991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894877
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711886}

Bug: 1020609
Change-Id: I84fb6c13ca3ab0d3002853b17772775a7ff3eb54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895968Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711885}

- For input and generated PDFs, validate all the page sizes.
- Set the page size / printable area to 72 DPI, which is what the
  PdfNupConverterClient normally receives.

Bug: 1004529
Change-Id: I615b014c08332a55c395f06352424fe1c96a4601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895071
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711884}

Currently markers are assigned a mostly empty style, it just inherits
from the list item and has some customizations like `display`.

This patch makes them use the style of the ::marker pseudo-element.
The inheritance is also from the list item, and the customizations are
applied afterwards.

The change only affects markers originated by real elements. Markers
originated by ::before or ::after pseudo-elements should get the styles
from ::before::marker or ::after::marker, but this will be addressed in
a follow-up patch.

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html
TEST=external/wpt/css/css-pseudo/marker-color.html
TEST=external/wpt/css/css-pseudo/marker-font-properties.html

Change-Id: Ide2fbc344e4732257044ebd3e7966906af21c434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893265Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711883}

This CL helps to calculate the hotseat's state based on the app list's
visibility when the chromevox is enabled. If the app list shows,
it ensures that the hotseat's state is kShown instead of kExtended.

Bug: 1020417
Change-Id: I2354af512939c91bbcf707115ab9882856c6c78a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893961Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711882}

Fix cases where the focus was lost when navigating back from
 - chrome://settings/content/serialPorts
 - chrome://settings/content/all

Bug: None
Change-Id: Ibbd149272593264131787bae1df9106e8de60b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894832
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jordy Greenblatt <jordynass@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711881}

This DCHECK made sense earlier when we wiped out the list if the
preview type was no longer enabled. Issue 986888 fixed that
and now this DCHECK triggers incorrectly on debug builds.

Change-Id: I99fe1444f54617b4e3717005130bd3375c99651d
Bug: 986888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892434Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711880}

Bug: 1014585
Change-Id: I786a8ca77bf0195463af9b560b59a82eb5ad217c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888192
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711879}

Switch to base::JSONReader::Read() and also modernize base::Value usage
in the modified functions.

Bug: 925165
Change-Id: Ie0062059b2ab1a1c28e4bd658074d6ce9bd658ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894312
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711878}

This is a reland of 38f657d5

Original change's description:
> Convert extensions to use the URLResponseHead mojom types.
> 
> Bug: 984550
> Change-Id: I885fc575b49c4049b83b17cc4c2248daf2525b4e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876974
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709596}

Bug: 984550
Change-Id: I7876e758de65f6a5e0ff2af5954c738fa951343f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891149Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711877}

From https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZVGcxnB8fbou/files/MCEJu8Y2hyDScU0HXgbgxLFDny2Xg0-sdc8
The padding below menu should be 12dp(padding below icon) + 24dp(icon height) + 8dp(padding between menu and icon)

Bug: 1011061
Change-Id: I30b9c5efbef46b071fbdf3fda831b098aac043c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894050Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711876}

This reverts commit a72a5f6b.

Reason for revert: After a discussion with Torne and Changwan, we feel it is less meaningful to put a restriction there. Hence the revert.

Original change's description:
> [JJI] Add validation for jsObjectName
> 
> Since we are not using jsObjectName until the next navigation, it will
> only until then we could tell if the parameter is valid or not, if it
> is not valid, the injection will fail sliently. We want to provide a
> early exception for developer to know if the object name is valid or
> not.
> 
> Since it is hard for us to valid the full set of the allowed JavaScript
> variable name, we limited the scope to a manageable subset of it.
> 
> Bug: 918065
> Change-Id: I74909768fc9695e6d33302d880eb211a4b250c62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894181
> Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
> Reviewed-by: Changwan Ryu <changwan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711795}

TBR=torne@chromium.org,changwan@chromium.org,ctzsm@chromium.org

Change-Id: Ic86d9b1681f7c806e085679b75cb713cc3b6a5c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896048Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711875}

PrintControllerTestCase tests are unconditionally disabled. I looked into
enabling them by rewriting them using XCUITest. It turned out that
XCUITestElements do not give access to the actions on the Activity
Services menu.

Deleting tests since they are not serving any purpose.

Bug: 990947
Change-Id: Ie17efff877e67ab2b1b3feb9e13bd9962e008976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894612Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711874}

https://swiftshader.googlesource.com/SwiftShader.git/+log/855e8b1bc29d..aaa64b76c0b4

git log 855e8b1bc29d..aaa64b76c0b4 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 amaiorano@google.com Modify Blitter to implement FunctionT
2019-11-01 amaiorano@google.com Modify SetupRoutine to implement FunctionT
2019-11-01 amaiorano@google.com Modify PixelRoutine to implement FunctionT
2019-11-01 amaiorano@google.com Modify VertexRoutine to implement FunctionT
2019-11-01 amaiorano@google.com ReactorUnitTests: use FunctionT
2019-11-01 amaiorano@google.com Reactor: add type-safe FunctionT and RoutineT

Created with:
  gclient setdep -r src/third_party/swiftshader@aaa64b76c0b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561
Change-Id: Idffec085f5c466a7cea070c82320656bcc0b87b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895875Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711873}

When moving Network Service off of Service Manager, the in-process
NetworkService object instance changed to never be destroyed. Some tests
expect the destruction to happen by the time BrowserMain is done.

This change ensures that we destroy the NetworkService instance before
full browser shutdown is complete.

Bug: 1016880
Change-Id: I71436d21bb66e3a318f7143d16c8bb3b0d546df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894018Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#711872}

Adds documentation about each check that is run and how to fix it if it
fails as well as some general information about the links the trybot
outputs.

Change-Id: Iaa7507161707b392d2a56c2851a61d2cec09b4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894622
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711871}

https://quiche.googlesource.com/quiche.git/+log/f2c4e3ef544b..4c908f06d53c

$ git log f2c4e3ef5..4c908f06d --date=short --no-merges --format='%ad %ae %s'
2019-11-01 fayang gfe-relnote: Do not add peer_max_ack_delay if an immediate ACK is expected when calculating PTO timeout. Protected by existing gfe2_reloadable_flag_quic_enable_pto.
2019-11-01 bnc Simplify ConstructMisFramedEncryptedPacket() signature.
2019-10-31 nharper gfe-relnote: Swap order of operations in TlsClientHandshaker::FinishHandshake. Protected by --quic_supports_tls_handshake
2019-10-31 fayang gfe-relnote: Use PTO_RETRANSMISSION instead of PROBE_RETRANSMISSION for PTO retransmission. Also populate transport connection stats for debugging purpose. Protected by existing gfe2_reloadable_flag_quic_enable_pto.
2019-10-31 ianswett Convert kDefaultMaxCongestionWindowPackets to a flag.
2019-10-31 fkastenholz Change GetMinStreamSize API to use size_t, rather than uint16_t avoiding truncation
2019-10-31 bnc Use QpackEncoder::InstructionWithValues to refactor QpackInstructionEncoder interface.

Created with:
  roll-dep src/net/third_party/quiche/src

R=rch@chromium.org

Change-Id: I3358f06b7faa27a7c80d282c36ec7df5e6d0cdc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895895Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711870}

The filtered (by dimensions) pool for ToTiOS* has one bot
 that is on Mac 10.13 (build227-m9), causing infra failures.
 Binding ToTiOS* bots to min required os version (10.14)
 until all bots have been upgraded.

Change-Id: I42902d6f880dff1c7d2b245e65c3ff339e645d29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894306Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711869}

This is a reland of f0ecb909.

Previously, the original commit was reverted to land another CL and push
the shell apk immediately. There was nothing wrong with the original CL.
Since the other CL was landed and pushed, we can now reland this CL.

Original change's description:
> [Android WebAPK] Link to a shortcuts file from the manifest.
>
> Instructions for enabling Android shortcuts:
> https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts
>
> This is the first step for enabling shortcuts. The server will populate
> shortcuts.xml depending on the Manifest shortcuts provided (and also
> generate additional string resource files).

> Bug: 1010471
> Change-Id: I2e0a6118a22869766e4b5e849dabc6533cd2d306
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864805
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707889}

Bug: 1010471
Change-Id: Idb2c09bc6d259766f79f837bf8de9a9e2278933b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895856Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Henry Jian <hzjian@google.com>
Cr-Commit-Position: refs/heads/master@{#711868}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41eccb9d43eb..029ba5a777d6


Created with:
  gclient setdep -r src-internal@029ba5a777d6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1018879,chromium:1018879,chromium:1018879,chromium:None,chromium:1018879,chromium:None
Change-Id: I4f70d937b966f9dae7ad8ea8c98500db71515ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895878Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711867}

See the recorded video:
https://drive.google.com/file/d/0B5I0jFeLxqIiRldva1VIaVJPNWRrUXlfUmtXOV9zdEFmVDZR/view?usp=sharing

Bug: 1016547
Change-Id: Ifb8c85dbda12b1fa7088d37beda6b8279b8ea6e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881811Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711866}

Previously, the update check version is 109. From 109 to 116,
we added a few bug fixes. We'd like to bump the version to
include those fixes for updates.

Bug: 977173
Change-Id: I95c06658753d4fcb66b772be8c8d934dffcf5d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895955Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Henry Jian <hzjian@google.com>
Cr-Commit-Position: refs/heads/master@{#711865}

Plumb through FileInfo to the renderer, and populate the returned File
object with the correct value.

BUG=1018945

Change-Id: Ic11d819ea83be49df831bbda37519779be0b8781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891463Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711864}