- 07 Jun, 2019 40 commits
-
-
Ehsan Karamad authored
Many MimeHandlerView browser tests were failing on ChromeOS debug bots most likely due to the old network path (kNetworkService disabled). This CL enables all those tests on ChromeOS. Bug: 949565 Change-Id: I3d9ca747fea2f54d71a88484f72e7b6b55df4a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650041Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#667341}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452f5badf421..80de3a4af4b8 git log 452f5badf421..80de3a4af4b8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@80de3a4af4b8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifde52a8a611cb550359eb6a575ca1a316a5cfb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667340}
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoop in /chrome/browser/chromeos/extensions/file_manager MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=joelhockey@chromium.org Change-Id: Ie1df92f584a7ee5cce3f3fd2b91db6bd00fa709c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649678 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#667339}
-
Wez authored
Content is typically rendered into a surface by the GPU process, and displayed into a window owned by the Browser process. In the Scenic Ozone platform this was implemented using import/export Nodes connecting the GPU & Browser. Content rendered to a ScenicSurface by the GPU process is now exported for display by a ScenicWindow via a nested View. Bug: WEB-50 Test: Manually verified that web content still renders. :D Change-Id: I3ba58c8fe509a2595ce0dd10e496701b0ebc2b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649181 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#667338}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a8ae579f7a8f..208d3132e6e8 git log a8ae579f7a8f..208d3132e6e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 stevenperron@google.com Cast __LINE__ to size_t (#2661) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@208d3132e6e8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Iba460d820d42dc863a00a8136f45d664902eb403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648882Reviewed-by:
-
Jeffrey Kardatzke authored
This is a reland of 869062d9 The prior CL failed in the MSAN tests, so this updates dummy_histogram.cc so that it sets the passed in values so they do not end up uninitialized. Original change's description: > Add browsertest for complete process of sending feedback report > > This adds a new browsertest which adds a hook into the feedback uploader > to catch it right before it does the actual report upload. This ensures > that clicking on the button to send a feedback report actually results > in the report getting queued to be sent. This covers a regression case > which is in crbug.com/954563. > > Bug: 955039, 954563 > Test: Browser tests pass, fail if prior regression was put back > Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666036} Bug: 955039, 954563 Change-Id: I8291ece23b01299677924a680de8877cc4675ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649304Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#667336}
-
Siddhartha S authored
IPC messages sometimes show up under wrong bucket since the original task that posted is empty. This will ensure that we can differentiate between messages sent by the channel itself, vs the messages sent by untracked tasks. Change-Id: I6b6410959c2040b55e519f5c26b8081d61fa22c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641807Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#667335}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/acf7d24d0187..3c76b8aa36fa git log acf7d24d0187..3c76b8aa36fa --date=short --no-merges --format='%ad %ae %s' 2019-06-07 zoddicus@users.noreply.github.com Re-introduce SetShaderModel for backwards compatibility (#675) 2019-06-07 zoddicus@users.noreply.github.com Refactor dup'd arg handling functions into a single location (#660) 2019-06-07 zoddicus@users.noreply.github.com Update Dockerfile to use Python 3 (#668) 2019-06-07 zoddicus@users.noreply.github.com Add details of spvc to README.md (#661) 2019-06-07 zoddicus@users.noreply.github.com Change TODO(name) to TODO(bug issue#) for spvc files (#658) 2019-06-07 riko_ophorst@hotmail.com Fixing duplicate absolute install paths when using Visual Studio generators (#639) 2019-06-07 zoddicus@users.noreply.github.com Add in missing flags to pass more of the spirv-cross tests (#664) Created with: gclient setdep -r src/third_party/shaderc/src@3c76b8aa36fa The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Idaf4a038c82ee89b347c322295aa1e51e61e4e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650363Reviewed-by:
-
Aleks Totic authored
This one is tough to reproduce, I could not come up with a simple case that fails in content_shell. It depends on not setting NeedsLayout for the entire document. Bug has the simplest reproducible case I could come up with attached. In the debugger, I was able to reproduce the bug. The root cause was that after rotating the device, abspos element ytp-large-play-button got its position from NGBlockNode::Layout, which ran NGBlockNode::RunLegacyLayout, which incorrectly got the layout_result out of the cache. The fix is to make RunLegacyLayout OOF aware. Bug: 970171 Change-Id: Ic799bb93cf99c7fc908db81a09c7dc0788bd741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649086Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#667333}
-
Alison Maher authored
This change adds support for the forced-colors media query and adds forced colors to settings. The logic for updating forced colors from its default state based on the OS has not yet been implemented. Spec: https://drafts.csswg.org/mediaqueries-5/#forced-colors Bug: 970285 Change-Id: I634b4abeec22f2d166648948f290fff8f4229478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643650Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#667332}
-
Dan Beam authored
This changes the implementation around how dark mode is queried in CSS. Bug: 965811 Change-Id: I6d45507907364cdccdeeb4273562e4f81664f74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626350 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#667331}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: Idff267c6a5a3e2534a5d0ffab9676aa64e78fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644783 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#667330}
-
sczs authored
I've created the directory and have been involved in every contribution to it so far. Bug: 911864 Change-Id: I6a40424094d7f73eab46c48f20423da8614db46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648910Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#667329}
-
Pavol Marko authored
Wait for network policy application to actually finish before signaling that it's done. Network policy application is only finished when the changes sent to shill have been pulled back from shill and are now reflected in NetworkState objects. This is important because code evaluating e.g. the OnlyAllowPolicyNetworksToAutoConnect policy uses NetworkState objects to decide whether a network is policy-managed or not. Bug: 936677, 943102 Test: browsertest will be added in a follow-up CL to keep this small. Change-Id: I734bc75eb8422e934b20cb592ca3fc5c211779b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539839 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667328}
-
Mandy Chen authored
Accessibility strings in front_end/accessibility/AccessibilityStrings.js are not localized. They are displayed in Elements pane -> Accessiblity pane -> Computed Properties. See https://imgur.com/HtE1ZhP. I wrap them in ls`` and add them to accessibility_strings.grdp file with descriptions. Description of a 'name' string: Accessibility attribute name that appears under the Computed Properties section in the Accessibility pane of the Elements pane Description of a 'description' string: Tooltip text that appears when hovering over the '<name>' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane Bug: 941561 Change-Id: I655760c02ee31ef4e22385c9dc003fd4152c93c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648332 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#667327}
-
Philip Rogers authored
There are two dirty bits for whether TransformTree::UpdateLocalTransform needs to be called: TransformNode::needs_local_transform_update, and TransformTree::needs_update. If the transform tree does not need an update, we skip calling TransformTree::UpdateLocalTransform. This patch DCHECKS that no transform node needs an update if we are skipping TransformTree::UpdateLocalTransform due to the tree not needing an update. Bug: 864567 Change-Id: Ib43ce23d8715c1cf802aaefb8e4068ce24fd07b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650120 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#667326}
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 766678 Change-Id: I59de40f915421970b5da834ac2240c733581d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636057 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667325}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Ib442b6c9be98b8b2967a8517512d3fe972460ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649707Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#667324}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1faba755ff77..1e364a244234 git log 1faba755ff77..1e364a244234 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 dhoss@chromium.org Adds test coverage for PSOP_ROUND and PSOP_TRUNCATE in CPDF_PSEngine 2019-06-07 thestig@chromium.org Change CPDF_TextRenderer methods to pass options by reference. 2019-06-07 asweintraub@google.com Fix bug-prone patterns found by ClangTidy 2019-06-07 thestig@chromium.org Clean up CQuartz2D. 2019-06-07 thestig@chromium.org Change DrawDeviceText() call stack to pass matrix by reference. 2019-06-07 asweintraub@google.com Fix ClangTidy - Performance findings in pdfium. 2019-06-07 thestig@chromium.org Replace empty span checks with ASSERTs in CCodec_JpegModule. 2019-06-07 tsepez@chromium.org Move CPDF_OCContext from fpdfapi/render to fpdfapi/page. Created with: gclient setdep -r src/third_party/pdfium@1e364a244234 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ie6e542d5cc3dd8cd1821dcd934cc0f09f38c78cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649651Reviewed-by:
-
Vlad Tsyrklevich authored
Wild pointer accesses that unintentionally access the GWP-ASan region and cause a false-positive report are far more prevalent on 32-bit than 64-bit because the address space is smaller. One of the leading causes of false positive reports on 64-bit is when the OS maps the GWP-ASan region into the lower 32-bits. Provide a hint to mmap/VirtualAlloc to map the GWP-ASan region above the first 32-bits of address space. Bug: 969146 Change-Id: I04a436808290e4d8674af8e2cf2484d1ed8ee470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648694 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#667322}
-
Vladimir Levin authored
This patch moves the ref-qualified member functions section to the whitelisted section, with advice to use it sparingly since it may be poorly understood. R=kylechar@chromium.org, danakj@chromium.org, pkasting@chromium.org Change-Id: Ic9400af6a940d3f68c10cca617eb94ad161385ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649733Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#667321}
-
Cathy Li authored
Bug: 971323 Change-Id: Iabdccb8e835bae9b32a2435d6eb31e15ec2aa213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646552Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#667320}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96e0999f..05e98a6e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee37d2a4d8b50bdabd0223ca1d3e493a4137b2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649312Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667319}
-
Chris Harrelson authored
If an acquire, update or commit resolver is not needed, then there is no need to observe lifecycle updates, because the lock is guaranteed to be quiescent (either unlocked or quiescent locked). Bug: 968928 Change-Id: I68b1d233879f313fa83e7be0a244b52f10d44fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647617Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#667318}
-
Kurt Horimoto authored
This CL adds the classes to support showing JS prompts via OverlayPresenter, and adds the prompt coordinator to the OverlayModality::kWebContentArea supported classes list. Bug: 941745 Change-Id: I15743a8489d59cd3667812667f51abe2561af1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639030 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 790202 Change-Id: Ic4151e8512cff6343961351b87e9b5266f5d96ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650223 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#667316}
-
Pavel Yatsuk authored
This CL: - Adds in-product help feature and registers it in different places mentioned in https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement/ - Adjusts Toolbar related code to expose experimental button view - Implements logic in IdentityDiscController to display a help bubble. Screenshot: http://screen/TBTUGhdFo1J BUG=958982 R=twellington@chromium.org Change-Id: I0ce947df8d2f3aaab3179115da6ef5481d08672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649135 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#667315}
-
Ilya Nikolaevskiy authored
These histrograms are still needed, because these metrics are important to measure video performance of WebRTC. They may not be actively used right now but this is because we currently don't run any relevant experiments. It's won't be the case in the future. Bug: 970011,969980 Change-Id: Ib119ae50b6d1b4a2494121fed8226a38a1c44cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645214Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#667314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28a5a4344adf..53ae936b8447 git log 28a5a4344adf..53ae936b8447 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 bungeman@google.com Make rasterallocator test a bit better. 2019-06-07 jlavrova@google.com Build fix 2019-06-07 brianosman@google.com Interpreter: Refactor interface and lifetime management 2019-06-07 mtklein@google.com fold through SKSL_USE_STD_STRING 2019-06-07 mtklein@google.com free skvx from its Skia shackles Created with: gclient setdep -r src/third_party/skia@53ae936b8447 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I29a482b09008c18b28d07c43ce63277157fd8a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649462Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 969798 Change-Id: I29817e2f28a6e6169a1286df33379c3b946df6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641722Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667312}
-
Kelvin Jiang authored
The observer code was introduced in crrev.com/c/1139048 to detect rule changes. However it seems that these observers were applicable only for previous declarative APIs and not the declarative net request API, where they remain unused. Bug: 971455 Change-Id: Ie6a1c38d2ed11f9ce999f41c3b553fe0ad4e1a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648819 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667311}
-
Erik Chen authored
We never use hermetic xcode on iOS. Change-Id: Id0a7655415e60453479caf5a9581ccf5077c2d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650321Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667310}
-
Bryan McQuade authored
Previously, we used the PaintLayer's LayoutObject. Xianzhu pointed out that there can be cases where a LayoutObject does not have its own PaintLayer, and that we should instead use the PropertyTreeState directly associated with the currently painting object. Change-Id: I4daf0d1f03507ca45f3e78bf2d3f93b4b6848efd Bug: 971639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644939Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#667309}
-
yilkal authored
Bug: 967931 Change-Id: I302a4eb12ff69c117c0254fdc86d1a2323231180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647454Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#667308}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I626bf0e6850dac73c35b31536313958f72bd5734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650361Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=hansberry@chromium.org Change-Id: I3659594870f528f8fa4523aeace161c246614ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649372 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667306}
-
Yi Xu authored
Change-Id: Iabcb3d7c34f20376d02df420ef0baa4649d94219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645676 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667305}
-
Ryan Hansberry authored
EasyUnlockServiceSignin assumes that it is called in a signin context, but in this particular codepath, ExistingUserController was calling it in a multi-signin context. In that multi-signin context, the EasyUnlockServiceSignin object being grabbed was already shut down, with deleted members -- its use caused a segfault. This CL makes that assumption clear and only uses EasyUnlockServiceSignin in a signin context. Also add check in EasyUnlockServiceSignIn::IsEnabled() that |pref_manager| is valid. Bug: 971202 Fix: 971202 Change-Id: Iccc86faaef74ac882bda34fbdde5e5c26394ceea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648674 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c5c8ab626d5..452f5badf421 git log 4c5c8ab626d5..452f5badf421 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@452f5badf421 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8febc0266c502bd7f60fa82df5757095d8132159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650042Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
The thumbnails shown in the Grid Tab Switcher (GTS) were decoded from the ETC1 format, downsampled, and then transferred through the JNI boundary. This is not the most efficient way. This CL introduces JPEG thumbnails, which would be saved at the same time ETC1 thumbnails are saved, if GTS is enabled. The GTS would directly read and decode the JPEG files from the Java side. Bug: 971939 Change-Id: Iaf21ea2170afbb7b0385570459f4566715786ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648963Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667302}
-
