- 10 Oct, 2020 23 commits
-
-
Fabrice de Gans-Riberi authored
* Kill the Session after 10s of no activity in the audio or video stream. * Kill the Session after 5s if no offer message is received. * Fix reporting of messages from unknown namespaces in the Cast Streaming MessagePort. Bug: 1087528, 1087528 Change-Id: I69b44bea3b142e7cf12c32106a279ef37710c56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451525Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#815876}
-
Curt Clemens authored
ReceiveObserver originally had an OnIncomingTransfer method that was called when a transfer update occurred with status kAwaitingLocalConfirmation. Instead, all transfer updates are sent to the mojo interface to facilitate future work. Test: unit_tests, browser_tests Change-Id: I7f57db1b67ccb6fc9c3337419ca236a492d0c53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453914 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815875}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I06a90eb08ee7445e11f30409420ea5e1bef50aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459266Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815874}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dc612511e7b..cdf1ab1f8288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lukasza@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093386 Tbr: lukasza@google.com Change-Id: I72bf3937791d0fddc635fa9329683e983a81dd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463792Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815873}
-
Bo Liu authored
Add an API that allows client to declare the action mode items it wants to override. When overridden, the selected text is passed to the client and whatever the default action in weblayer does not happen. Currently only support search and share since they are always enabled. Bug: b/159070012 Change-Id: Ibabc253a9d990fbf4c1746fd402068df4aeafff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463989Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815872}
-
Lukasz Anforowicz authored
ExtensionURLLoaderFactory's and CastExtensionURLLoaderFactory's lifetime cannot exceed the lifetime of the associated BrowserContext. This CL should fix https://crbug.com/1136214 and is likely to also fix https://crbug.com/1134050. Fixed: 1136214 Bug: 1134050 Change-Id: I06b0c17ebe308ec86f0341c7fa7b7bbdc1ffde4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461222 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#815871}
-
Devlin Cronin authored
There are two main ctors for URLPattern - one takes valid schemes and is used with the Parse() method (which handles failure) - one that takes schemes and a string pattern, and assumes parsing must succeed The latter currently has a NOTREACHED() and an error log. Upgrade this to a DCHECK, since it should never, ever be hit (especially following the identifying case for crbug.com/856948). This should - hopefully - help ensure that no new cases are introduced, and flush out any other cases that may exist. Bug: 856948 Change-Id: I1982d10e92c72d1d8ca6da03644072a73a0c7580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450707Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815870}
-
Shannon Chen authored
Enable point scanning using the point scanning button in the Switch Access menu. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: I5cdc94dec29870fbda276f01ff77124442922393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461721Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Shannon Chen <shannc@google.com> Cr-Commit-Position: refs/heads/master@{#815869}
-
Kyle Horimoto authored
This KeyedService is responsible for generating dependencies to provide to the Nearby Connections utility process. Code is based off of the existing nearby_process_manager.cc file; the only changes are that we only fetch the Bluetooth adapter once and that we re-organize this code to be a KeyedService since it is based on the Profile. Bug: 1130069 Change-Id: I9c1efd2ff93e9a9aadba5c363d0af37097ab5e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454388 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Daniel Classon authored
Adds a metric for the kAddAccount setting on the People Page. It records the number of the account the user was trying to add, e.g. a sample of 3 on the histogram means the user attempted to add a 3rd account. Bug: 1133553 Change-Id: I8befd66ce2ce78f1c07e6c5afb4f4a5fcb8ae09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454492 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
I looked at other js-based tests and couldn't find a way to disable only on a single platform (it seems that the flakiness is specific to ChromeOS). Note that most of the changes in this CL comes from |git cl format --js chrome/browser/resources|. Bug: 1136991 Change-Id: Ib292732483b5f1d88f0a5b919c66eb484646f31b Tbr: anastasi@chromium.org Tbr: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463928Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#815866}
-
Moe Ahmadi authored
Fixed: 1136649 Change-Id: Ie48f7b52c40fd040a23b16c63ec0bb970c8585b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463804 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815865}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/daef088d069f..e21911cc1c77 2020-10-09 tsepez@chromium.org Make _TIFFBuiltinCODECS be const data. 2020-10-09 thestig@chromium.org Simplify struct TbConvertAdditional. 2020-10-09 thestig@chromium.org Avoid relocations in struct BarCodeInfo. 2020-10-09 tsepez@chromium.org Add pdfium::span::front() and back() 2020-10-09 tsepez@chromium.org Move CFXA_MapModule to CFXJSE_MapModule and add tests 2020-10-09 nigi@chromium.org Disable some Windows-only embedder tests which fail with Skia/SkiaPaths. 2020-10-09 nigi@chromium.org Update Skia/SkiaPaths embedder tests' macOS expected results. 2020-10-08 tsepez@chromium.org Move XFA_ATTRIBUTE_CALLBACK from fxjs/ to xfa/ directory 2020-10-08 tsepez@chromium.org Add some missing const in CFXJSE_Context 2020-10-08 tsepez@chromium.org Completely re-implement CFXA_MapModule data storage 2020-10-08 thestig@chromium.org Make more XFA attribute data truly read-only. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I49f4770debd38906e694eab2014de1aab0e63575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815864}
-
Fabrice de Gans-Riberi authored
This leaves the fuchsia-namespaced versions of the constants and function of the call for out-of-tree callers. Bug: 1073821 Change-Id: I305fe5b84a00656fe83a5da1d92ce782e65cbd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429810 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#815863}
-
Sunny Sachanandani authored
Test suppressions for tests added in https://crrev.com/c/2432207 that fail because of existing bugs. TBR=kainino@chromium.org Bug: 1132381, 1132375 Change-Id: I10bb564ae4729a199bcea80c444d8b1b7f8e2e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463805Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#815862}
-
Chan Li authored
Revert "Reland "Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30%"" This reverts commit 99db6496. Reason for revert: Found 2 more issues, disable the experiment for now. Original change's description: > Reland "Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30%" > > This is a reland of 6bcf1a99 > > Original change's description: > > Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30% > > > > Bug: 1108016 > > Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Chan Li <chanli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815450} > > Bug: 1108016 > Change-Id: I257a1f13a7cefe4c95e0a93d9ba87b57b19c716f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463102 > Auto-Submit: Chan Li <chanli@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815483} TBR=chanli@chromium.org,tikuta@chromium.org Change-Id: I435ca3e7d459cdfe0ae4edbc29acb671570632f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464239Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815861}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9879d106b95..cd2eebd327e3 2020-10-09 ericlaw@microsoft.com NetLogViewer: Show Capture Mode in Import view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057773 Tbr: sadrul@google.com Change-Id: Ic0fdabc37a77b2970e655e4b59fcad34c0b8c174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463790Reviewed-by:
-
Shakti Sahu authored
This test was disabled three years back due to flakiness of ChromeActivityTestRule.loadUrl. Since then a lot has changed, and possibly this test isn't flaky any more since tons of test use that method. Reenabling this test and will keep watching if flakiness returns. Bug: 786237 Change-Id: I9601394c0fb88617d252e61cf3d8d9d0f8b4da3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463571Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815859}
-
Shakti Sahu authored
Instrumentation#invokeContextMenuAction apparently doesn't work when the view isn't focused. Using a different method to invoke the context menu fixes the case. Bug: 1133545 Change-Id: I335d8ceb61202cc9eaab1c70a05a590a4f54fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463460Reviewed-by:
-
Yuwei Huang authored
This reverts commit dbe36b16. Reason for revert: Seems to be causing crbug.com/1137042 Original change's description: > Add remoting Linux debug symbols to the upload list > > This CL attempts to make the official build bot upload remoting debug > symbols, so that we can use them to decipher stack traces coming from an > official build remoting Linux host. > > Bug: 1136663 > Change-Id: I5669140b3b63399d521644de3b8524def6092560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462547 > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815701} TBR=jamiewalch@chromium.org,mmoss@chromium.org,yuweih@chromium.org Change-Id: I03037ed6f2de46a6be20647a9319e89084eb2f99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463813Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#815857}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815983783a76..109c355900d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a0cf944ee387d59d4f4913b63f0854476ba1330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463898Reviewed-by:
-
Alex Gough authored
These are opened FLAG_READ. https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_process_host_impl.cc;drc=da8e399b1f509d29565224190204860b22c9062b;l=5202 Bug: 1130762 Change-Id: I5db1b78def792ff1ad6f801789e775101312ee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461051Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#815855}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7563a4878789..61003cde7688 2020-10-09 csmartdalton@google.com Add support for WEBGL_multi_draw_instanced_base_vertex_base_instance 2020-10-09 bsalomon@google.com VulkanWindowContext uses sample-able swap VkImages when available. 2020-10-09 kjlubick@google.com [canvaskit] Add job to compile GMTests js/wasm 2020-10-09 jvanverth@google.com Use push constants cap in Metal. 2020-10-09 brianosman@google.com Reorganization of IR generator's API and interaction with compiler 2020-10-09 egdaniel@google.com Don't set vk sampler on desc set if using immutable samplers. 2020-10-09 jmbetancourt@google.com Fix SkottieView demo app by handling branching issues 2020-10-09 jmbetancourt@google.com update DEPS to point at oboe commit that fixes parsing library 2020-10-09 brianosman@google.com In SPIRVCodeGenerator, use the Program's ModifiersPool 2020-10-09 csmartdalton@google.com Simplify the inflection/rotation finding math for stroke tessellation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I33ad56ae7ab2faf57b4df6b97c298766b9b30a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464109Reviewed-by:
-
- 09 Oct, 2020 17 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0ad07c924552..815983783a76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I23bb843521c7b110bd61e5dd8fc7132b846f9e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463991Reviewed-by:
-
Elly Fong-Jones authored
This test: a) Predates Aura b) Has been disabled since 2011 c) Doesn't compile any more because it was #if 0'd out in 2016 Even if it did still compile, it wouldn't work - it requires multiple real native widgets and control over their activation, which won't work in a unit test. Bug: None Change-Id: I52e23cfe2f6e3cd441591180be0e8971c3075106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463604 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815852}
-
Roberto Moura authored
Open a new tab when the user taps the New Tab button cell. Extend the GridViewControllerDelegate protocol to tell the delegate when a new tab is opened. Bug: 1127604, 1135329 Change-Id: If35f357df1c6a5f8eb9b181e76fb78ca241e0656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449994 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815851}
-
Fabrice de Gans-Riberi authored
This renames the class FuchsiaIntlProfileWatcher. Bug: 1073821 Change-Id: I13a5eb3bd71de69b00e447742400d26f3877755d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431732 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#815850}
-
Xianzhu Wang authored
This is extracted from crrev.com/c/2459866. Remove recording_source.UpdateDisplayItemList() which caused crash when the same DisplayItemList is updated more than once. The call is not necessary for the benchmark. TBR=pdr@chromium.org,vmpstr@chromium.org Bug: 922642 Change-Id: Iad8754bf82e6d51215bb0a2c7c18bd6f6904f5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462231Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815849}
-
Dale Curtis authored
Per meet statistics, it's actually more expensive than software decoding. R=liberato Bug: 1136495 Change-Id: I56e7e459c53b38a0fa65b8a7606e28ed27dcc300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463964Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815848}
-
Devlin Cronin authored
For browser actions, certain properties are persisted, while others are not. (By contrast, page actions do not persist any properties). Since we're introducing the generic "action" key, we need to provide defined behavior for persistence. In this case, we default to *not* persisting values. This is consistent across properties (unlike browser action), and it is easier to add in support later if we evaluate that it would be worthwhile. Add a browsertest that covers both browser action values and the new "action" values. Bug: 1110156, 893373 Change-Id: Icc4472599e52e0309cab0b3704ea9394865787de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439975Reviewed-by:
-
Tommy Li authored
This CL just adds the flag for the WebUI Omnibox Popup to about:flags a.k.a. chrome://flags. This also fixes a trivial crash when the flag is on, as we haven't paid much engineering effort to this flag recently. I fixed the crash with this too, as otherwise, users who turn this flag on won't be able to easily access chrome://flags to turn it off! Bug: 1046561 Change-Id: Ie458c14b3e56d647d413d57325a26653a906e858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463747 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#815846}
-
Cattalyya Nuengsigkapian authored
Opens an image editor, an Essential App's Backlight from an edit button in a screenshot notification. Important Note: the edit button is only available for image screen capturing but not video. Testing: - Screen recording showing that edit button open the screenshot image in Backlight https://bugs.chromium.org/p/chromium/issues/attachment?aid=469945&signed_aid=7kntFxv5qL2TWN8JYNxQ4Q==&inline=1 Bug: 1135247 Change-Id: Ia9f48cd82021b96fc3bbda8f140e90477b1a0152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457306 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#815845}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff7913204ce2..294729f33cbf 2020-10-09 danilchap@webrtc.org Support layer skipping in full svc structures with 3 temporal layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd877ef5a7e98f3fd9197ef35eb52df63408a5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464103Reviewed-by:
-
Miriam Zimmerman authored
Also, fix height calculation of the dialog (otherwise, this change would cause the buttons to scroll partially out of the visible area). BUG=chromium:1107910 TEST=deployed to chromebook, verified that label was present and read \ by ChromeVox Change-Id: I1d9d1dd37bc98a684b13ded643970692ed7e2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461725 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
Bug: b:168817491 Change-Id: I4269b354c686613cc172b2e5ffdac6acd27ab780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464008 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815842}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad8eb02a. With Chromium commits locally applied on WPT: 57f68063 "Remove anonymous box from details/summary shadow dom" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources lanwei@chromium.org: external/wpt/infrastructure/testdriver/actions NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Iebb18b125fc314652ec232fa623f7ceeb425456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463373Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815841}
-
minch authored
Update on the spec. Bug: 1128755 Change-Id: I62a9cf60f33f3bc9c162cdb1aad68a811a2c4e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464046Reviewed-by:
-
Reilly Grant authored
This change makes a number of bugs impossible by removing the "closed" state from SerialPortImpl and BluetoothSerialPortImpl. Instead of calling GetPort() to get a mojo::Remote<SerialPort> the OpenPort() message combines the operation of connecting a pipe to the implementation of the SerialPort interface with establishing a connection to the serial port itself. This fixes issue 1121774 by making it an invalid state for the SerialPort implementation to stick around if the connection failed. The USB Mojo interface solves this problem with the more complex UsbDeviceClient interface. I think the solution in this patch is better. Bug: 1121774 Change-Id: Ic33256a3d193f70490e207ba9c97277c74323018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459693 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#815839}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iccb3e247ee296850052bd5c0f3958ed5442ac8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464105Reviewed-by:
-
Travis Skare authored
Functionality will follow in crrev 2380212. For enterprise users: Enterprises may enable the feature, or enable did-you-mean without checks, as they know their machines' path to DNS servers. For non-enterprise users: Adds a feature to roll out a new default-off behavior. A heurisitic-based approach for non-enterprise users will follow, though likely in a future milestone. Bug: 1090985, 1090985 Change-Id: Icc7dff576cc503d6ffab23be38c1faea8cf22993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443689Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
