GitLab

These mostly match what's currently available in WebView class itself.
The implementation in WebView will be removed.

BUG=

Review URL: https://codereview.chromium.org/1022993002

Cr-Commit-Position: refs/heads/master@{#321452}

This class will report to UMA the Android kernel version and the level of kernel
support for seccomp-bpf sandboxing.

BUG=468455

Review URL: https://codereview.chromium.org/1018953004

Cr-Commit-Position: refs/heads/master@{#321451}

While the recent fixes to the pointer lock code have helped, we still have problems when we move the cursor near
the bounds of the content window. The pointer lock code in RWHVA detects that and forces a move to the center of
the window via a SetCursorPos operation. The expectation here is that we would see a mouse move message with the
location specified by SetCursorPos which would ignore.

With fractional scale factors like 1.25/1.5, etc it turns out that the conversions of the mouse messages from pixel
to DPI and vice versa causes us to end up with messages which are off by 1 or 2 px which causes us to miss the move
to center event in the locked mode. The renderer sees the message and bounces the cursor back to the center leading
to erratic behavior.

Proposed fix is to add an allowance of 2 for the mouse event x and y coordinates if we are waiting for the move to
center event.

BUG=411634
TEST=As described in the bug. Please try a clockwise and anticlockwise mouse rotation with device scales set to 1.25/
1.5, etc.

Review URL: https://codereview.chromium.org/1005213003

Cr-Commit-Position: refs/heads/master@{#321450}

TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/1021873002

Cr-Commit-Position: refs/heads/master@{#321449}

This is a rather cosmetic change: INFO log level is used to print test summaries. This CL makes the script log one summary instead of 2 consecutive ones. These logs end up in a spreadsheet, and having one line (as opposed to 2) per test is easier to process for statistics.

R=engedy@chromium.org
BUG=468245

Review URL: https://codereview.chromium.org/1023673005

Cr-Commit-Position: refs/heads/master@{#321448}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5553bed..6c1b338

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1005873004

Cr-Commit-Position: refs/heads/master@{#321447}

Before DirectWrite, default monospace font was Courier New but while
adding support for DirectWrite, it is switched to Consolas which lacks
Arabic glyphs. This is to improve the situation.

BUG=466754

Review URL: https://codereview.chromium.org/1013653002

Cr-Commit-Position: refs/heads/master@{#321446}

R=rvargas@chromium.org
BUG=468631

Review URL: https://codereview.chromium.org/1022863002

Cr-Commit-Position: refs/heads/master@{#321445}

Review URL: https://codereview.chromium.org/1002493005

Cr-Commit-Position: refs/heads/master@{#321444}

If an XHR has succeeded and the form that the user was typing in has now
disappeared either by no longer being visible or being removed from the DOM,
prompt to save.

BUG=464891

Review URL: https://codereview.chromium.org/1012853002

Cr-Commit-Position: refs/heads/master@{#321443}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a2bf336a..c18bc92e

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1003363004

Cr-Commit-Position: refs/heads/master@{#321442}

This patch fixes a build break in ozone-wayland.

BUG=None

Review URL: https://codereview.chromium.org/1015323002

Cr-Commit-Position: refs/heads/master@{#321441}

The flag was added to allow us test the mode with display item cache
enabled or disabled. It seems that we haven't been using it for some
time, so perhaps it's time to remove it and always enable the cache.

This is the chromium side change paired with the blink side change
https://codereview.chromium.org/1018053003/.

This is a revert of content/renderer/gpu/render_widget_compositor.cc
in https://codereview.chromium.org/913163004.

TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1012383005

Cr-Commit-Position: refs/heads/master@{#321440}

BUG=467633

Review URL: https://codereview.chromium.org/1006753003

Cr-Commit-Position: refs/heads/master@{#321439}

I believe this will unblock a required migration in our signing
infrastructure.

BUG=none
R=garykac@chromium.org

Review URL: https://codereview.chromium.org/1020823003

Cr-Commit-Position: refs/heads/master@{#321438}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/22ac63e..68da64b

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1019893003

Cr-Commit-Position: refs/heads/master@{#321437}

Due to a bug in a recent refactoring, the script would log an error to the
console, but would still set the success exit code, 0.

BUG=468523
TEST=Try to submit a CL with invalid formatting, the presubmit script should block submission.
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1019123003

Cr-Commit-Position: refs/heads/master@{#321436}

Optimization: 2 is /O2, not /Os.  (The old comment contradicted the comments
in the FavorSizeOrSpeed section further below.)

BUG=none

Review URL: https://codereview.chromium.org/1020943002

Cr-Commit-Position: refs/heads/master@{#321435}

This patch adds all of the priority rects we use in tilings to tracing.

R=enne
BUG=468813

Review URL: https://codereview.chromium.org/1019353002

Cr-Commit-Position: refs/heads/master@{#321434}

Not needed: On 32-bit builds, warnings-as-errors are disabled globally. On
64-bit builds, nothing warns, including 3rd-party code.

BUG=82385

Review URL: https://codereview.chromium.org/1011383007

Cr-Commit-Position: refs/heads/master@{#321433}

Show the details panel when file manager is first opened...on an import location. Adjust width and position of details panel to avoid line-wrapping main line.

BUG=464562
TEST=manual

TBR=fukino  // for minor CSS tweaks

Review URL: https://codereview.chromium.org/1019833003

Cr-Commit-Position: refs/heads/master@{#321432}

Guest is a primary user when logged in, so my previous
fix hiding the checkbox was unnecessary. The checkbox
should work and currently does work.

This reverts commit ae8d1b4f.

BUG=448551
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/1020763002

Cr-Commit-Position: refs/heads/master@{#321431}

Move all trace_event related build files in their own
gyp / gn target under base/trace_event.
This should allow easier maintenance of tracing code.

BUG=

Review URL: https://codereview.chromium.org/1014923002

Cr-Commit-Position: refs/heads/master@{#321430}

kEnhancedBookmarksExperiment is used by android intrumentation tests to
force enhanced bookmark feature to be enabled.
https://codereview.chromium.org/1009673002 introduced a regression that
the even if the flag is set to be true, it does not take effect. This CL
fixes it.

BUG=468106

Review URL: https://codereview.chromium.org/1017913002

Cr-Commit-Position: refs/heads/master@{#321429}

Previously, if the viewport ever moved farther than the skewport limits
in a single frame, the skewport math would break.  It would first
intersect with the max skewport (becoming empty) and then unioning with
the viewport (becoming the viewport).  By moving the union first, it
prevents this empty condition, leaving a valid skewport in the right
direction.

This addresses a case where prepainting wasn't happening when it should
have.

BUG=446645

Review URL: https://codereview.chromium.org/1021663002

Cr-Commit-Position: refs/heads/master@{#321428}

Reuse was disabled in #317499 because CrOS corruption rates were spiking and
were too close to the stable branch point to gather more history.  Re-enabling
to allow monitoring in dev/beta channels with the hope that the rise we saw on
CrOS was normal fluctuations and unrelated to this change.

BUG=460568

Review URL: https://codereview.chromium.org/1023773003

Cr-Commit-Position: refs/heads/master@{#321427}

Original CL reverted here: https://codereview.chromium.org/1013003002/

Nothing has changed from that CL above. We are relanding after Oshima
prevented marking events created from the same native event as "repeat"
in this CL https://codereview.chromium.org/1017323002/

Menus used to block detecting user activity. The fix works by making the
UserActivityDetector a PlatformEventObserver rather than an
EventHandler.
Also made sure that PlatformEventSource has an instance in
ozone_platform_test.cc

TBR=sadrul@chromium.org,spang@chromium.org,oshima@chromium.org,jamescook@chromium.org
BUG=462735
TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.*

Review URL: https://codereview.chromium.org/1024583003

Cr-Commit-Position: refs/heads/master@{#321426}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3ef71e3..5553bed

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1023633004

Cr-Commit-Position: refs/heads/master@{#321425}

- Extends Channel to PostMessageChannel to switch saml_injected.js to
  use postMessage instead of extension messaging API when used with the
  new Authenticator;
- Port Saml logic in main.js and background.js into saml_handler.js to
  be used with the new Authenticator;
- Hook up confirm/verify password flow etc with new Authenticator;

BUG=461505

Review URL: https://codereview.chromium.org/1004753004

Cr-Commit-Position: refs/heads/master@{#321424}

If on a MacOS machine, iossim and Chromium.app are built than we can
launch and use them for running tests.

BUG=468565

Review URL: https://codereview.chromium.org/1015313002

Cr-Commit-Position: refs/heads/master@{#321423}

R=inferno@chromium.org,tsepez@chromium.org
BUG=450268
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1025483002

Cr-Commit-Position: refs/heads/master@{#321422}

The NotificationMessageFilter still receives a number of IPC messages on
the UI thread. It is possible that the IPC message gets handled after
the profile has been shut down, so make sure that this isn't the case
by verifying that the RenderProcessHost still exists.

BUG=457590

Review URL: https://codereview.chromium.org/1023633003

Cr-Commit-Position: refs/heads/master@{#321421}

BUG=468762

Review URL: https://codereview.chromium.org/1024473003

Cr-Commit-Position: refs/heads/master@{#321420}

This CL moves key injection logic setRemapKey() and injectKeyCombination() into
the plugin layer.

With this change, we no longer need to pass the default remap keys from the
ApplicationDelegate through the SessionConnector to the DesktopConnectedView
in order to setup a key remapping.

Instead, we can simply call plugin.setRemapKeys('a->b,b->c') on the delegate.

BUG=465878

Review URL: https://codereview.chromium.org/1022473004

Cr-Commit-Position: refs/heads/master@{#321419}

R=brianderson@chromium.org

Review URL: https://codereview.chromium.org/1024593002

Cr-Commit-Position: refs/heads/master@{#321418}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e13200..22ac63e

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1020893003

Cr-Commit-Position: refs/heads/master@{#321417}

This is a formatting change, simplifying the existing code. No
functional change intended.

Also simplified how the DisplayState::selected_mode is populated when
parsing the displays.

BUG=none

Review URL: https://codereview.chromium.org/1026443002

Cr-Commit-Position: refs/heads/master@{#321416}

This change alters the functionality of getObjectAttr slightly: it no
longer accepts null or Array objects as "object" values.  I made this
change because the type checking code seems designed to mirror the
semantics of JSON, where each value belongs to exactly one of the
following categories: array, boolean, number, null, object, or string.

This change also changes the type of values thrown from strings to Error objects so that there are more likely to be useful stack traces when an error occurs.

BUG=

Review URL: https://codereview.chromium.org/1015553003

Cr-Commit-Position: refs/heads/master@{#321415}

Fix for a crasher in the browser seen while dispatching mouse enter or mouse exit messages via the root view.

Based on a number of crash dumps I looked at starting from M40 onwards, the crash occurs in the RootView::NotifyEnterExitOfDescendant function while dereferencing a NULL view parameter.

The parameter passed as the view, is the mouse_move_handler_ member which is checked for validity before calling this
function. However the disassembly in the crash dump clearly suggests that the parameter passed on the stack is NULL.

Looking at the code the only way that could happen if we end up in a nested invocation to the root view, which could
potentially happen in the context of a modal loop. I could not repro that hypothesis however.

Given that this is a browser crash and seems to be occurring frequently enough, I think this warrants a NULL check
for the mouse_move_handler_ before calling the RootView::NotifyEnterExitOfDescendant function.

I added a CHECK for the view parameter in the NotifyEnterExitOfDescendant  function in case there are additional callsites
added in the future.

BUG=467356
TEST=No test at the moment as I could not verify the hypothesis with actions in the UI.

Review URL: https://codereview.chromium.org/996103009

Cr-Commit-Position: refs/heads/master@{#321414}

Fix a mistake I made in http://crrev.com/1003853004.
Before that CL, the "More tools" submenu was incorrectly using IDC_ZOOM_MENU
command, and I fixed that. But then I incorrectly added checks for
IDC_MORE_TOOLS_MENU wherever it was checking for IDC_ZOOM_MINUS, causing this
incorrect spacing bug. This removes those checks, but we still need a check
to make sure it is enabled, because when it was incorrectly using IDC_ZOOM_MENU,
it was getting enabled by BrowserCommandController.

BUG=468644

Review URL: https://codereview.chromium.org/1016413002

Cr-Commit-Position: refs/heads/master@{#321413}