- 08 Jul, 2020 27 commits
-
-
Robert Sesek authored
These were missed by the awk script I ran initially. GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I0cf1677e1054f2ffcb54660820fba61d1c3590a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278363Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786093}
-
Jeffrey Cohen authored
This enables the the image_editor to construct a ShareParam. Bug: 1093365 Change-Id: If1e06d0fea433628540db5d52c73c237f61a4526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285357Reviewed-by:
Travis Skare <skare@google.com> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786092}
-
Nate Chapin authored
We appear to crash in HTMLTrackElement::CanLoadUrl if GetExecutionContext() returns nullptr, so early-exit in that case. Bug: 1102668 Change-Id: I43f0008eefe5d12b63d69c42d0fd341fe0e2f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284390 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#786091}
-
Hesen Zhang authored
- Add InternalsUIMessageHandler as observer. - Inject Logger to TileServiceImpl. - Inject LogSink into TileServiceScheduler and ping the observer. - Set scheduler as LogSource. Bug: 1066556 Change-Id: I6fdf79da6dea82327af5be1aa1b79a6cbee9926d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264934 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786090}
-
Jason Lin authored
This CL updates the icons we use for Plugin VM for the shelf, launcher, installer, uninstall notification, settings page, and task manager. The icons for the file manager will be in a separate CL. Bug: b:151096611,1073795 Change-Id: Ib7ea9d496a773cc5fee091adf07bcac27d591ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264191Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#786089}
-
Maggie Chen authored
Set different timeout values for systems with number of process >8, >4, and <=4 on Windows. Bug: 949839 Change-Id: Id7cf8661df77c5496b3575d5603a2617382b62e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282781Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786088}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1ca4c7cd49a..faef2531ecbb 2020-07-07 rsavitski@google.com Merge changes I461fa63a,I3c67b7b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4816d94e3798d63d136251c7c36e88b77003b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786087}
-
Ghazale Hosseinabadi authored
In this CL, we add a check in IsCommandIdVisible in order to call HasVisibleItems only if submenu_model is not null. Bug: 1101726 Change-Id: I248daaeca3ac67777c00020c81d7f08e2433fae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285388Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#786086}
-
Darwin Huang authored
This reverts commit b988cfa5. Reason for revert: per https://crbug.com/1102947#c4, this was already fixed a day earlier, in https://crbug.com/1100152 Original change's description: > Sheriff: Disable Flaky FilesAppBrowserTests in TabletMode. > > Flaky tests include: (FileDisplay|QuickView)/FilesAppBrowserTest.Test/(fileDisplayDrive|openQuickView|fileDisplayDownloads)_TabletMode. > > Flake occurrences can be viewed at https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyOgsSBUZsYWtlIi9jaHJvbWl1bUBicm93c2VyX3Rlc3RzQEZpbGVzQXBwQnJvd3NlclRlc3QuVGVzdAw > > TBR: lucmult@chromium.org > Bug: 1102947 > Change-Id: Id39ff39a94e955f0a513b7e5ddceef264846beae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285298 > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786050} TBR=lucmult@chromium.org,huangdarwin@chromium.org Change-Id: I5cb75418c2be74a1ad4dda713376ece9e66de164 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286190Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786085}
-
Yuly Novikov authored
TBR=kbr Bug: 1099978 Change-Id: I796e2b069946d75328b7fe63483b07b18bafa882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285355Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#786084}
-
Travis Skare authored
Bug: 1088012 Change-Id: I5f09de4fb703864e13af8b67f6f4f130735f82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238491 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#786083}
-
Ahmed Fakhry authored
When a window is dragged to overview by gesture dragging from shelf, tablet mode can end before the drag ends, at which point The homescreen window is closed, and we can't use it to get the SplitViewController. This CL reworks ShouldShowHomeScreen() to fix the crash, and do only the next checks if the previous ones failed. BUG=1101143 TEST=Manually by exiting tablet mode while dragging a window from shelf. Change-Id: I6a58e1c7caa6ebccc45d47cbfa27136891cfee9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285609Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#786082}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I1de34595f2a7eede058244293cfd0a7db4b0e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285295Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786081}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f612d485..e078f1d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I39539b15015b66b9ab620124965e2f6af14a3ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786080}
-
Yury Khmel authored
This handles new style of applying ids to async events. TEST=Locally BUG=b:150030838 BUG=b:160024571 Change-Id: I7ac4ab3241cd04201ae8c7800102bfa43c7df499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285506Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#786079}
-
Jonathan Freed authored
For the histograms that are important for the Feed, we are extending the expiration date and taking over ownership. Bug: 1089067, 1089069, 1089076, 1089079, 1089080, 1089084, 1089089, 1089091, 1089095, 1089104, 1089105, 1089107, 1089704, 1089705 Change-Id: Ia2de4dcda552b2270915961d587ef95f3095e378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284135Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#786078}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3bb512bc9f62..0f35b042e02e $ git log 3bb512bc9..0f35b042e --date=short --no-merges --format='%ad %ae %s' 2020-07-06 david [build] Really fix multi and C++ builds. 2020-07-06 david [build] Fix multi and C++ builds. 2020-07-06 wl [psaux] Improve `t1_decoder_parse_metrics' (#58646). 2020-07-02 david [build] Improve visibility support of library function names. 2020-07-02 david [build] Split off more stuff from `ftconfig.h'. 2020-07-02 david [build] Move mac support code to `mac-support.h'. 2020-07-02 david [build] Put integer type definitions into `integer-types.h'. 2020-07-02 david [build] Rename `build/unix/ftconfig.in' to `ftconfig.h.in'. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Due to changes in how FreeType is including it's own headers (moving from FT_HEADER_H to <freetype/header.h> it is necessary when overriding headers to use the same folder structure as freetype's include/ directory. As a result the customized configuration headers are moved to include/freetype-custom/freetype/config and the roll-freetype.sh roll script is updated to point to the new locations of these headers. Bug: skia:10472 Change-Id: I889e2ed0d8dc54987e7f9c6372b2d72e8703e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283962 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786077}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForPointInInlineBox()| to call |NGInlineCursor::PositionForPoint()| for |closest_child_after| like it does fro |closest_child_before| to make hit test on left edge of RTL inline element to pass the test[1]. This patch also changes |NGFragmentItem::PositionForPointInText()| to avoid calculating position for items of |IsGeneratedText()|, e.g. ::before/::after. This is follow-up of the CL[2] which introduces calling |PositionForPoint()| for |closest_child_before|. [1] editing/selection/caret-at-bidi-boundary.html [2] http://crrev.com/c/2104812 [NGFragmentItem] Fix hit test on position:relative inline element Bug: 707656 Change-Id: I8aca51af66a7d1885b7b7c2627cd7f4131b37c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282721 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786076}
-
Chege Gitau authored
To convert from screen coordinates to the normalized absolute coordinates dimensions used by SendInput, the scaling factor should be (65536.0 / screen_dimension). Previously, we used (65535.0 / (screen_dimension - 1)). Although the difference between these two factors is small, the discrepancy becomes more prominent when it's multiplied out. This discrepancy may lead to the computed absolute coordinates being off by a pixel or two depending on the resolution of the screen in question. Change-Id: Id305abc6ddf904ffbbb07dc740c655ac1be3cf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278347Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Chege Gitau <dagitau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786075}
-
Sam Bowen authored
This will be used in Kaleidoscope to match against providers returned from the API. Providers with matching origins will be considered high watch time, and we will suggest them to the user. Change-Id: Ic1181dde499ad39094442bd555a1b3b541f5ca2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277091Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#786074}
-
Hidehiko Abe authored
Bug: None Test: Build Change-Id: I98fdd4ac735dd1cf4e107cc6bb85570ae2114ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284845Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#786073}
-
Maxime Charland authored
Bug: 1098328 Change-Id: I56d1d821da8824258d4b84ef6e50ef805402a622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274777 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#786072}
-
nancylingwang@google.com authored
Design doc: go/appservice-adaptive-icon The related ARC icon interfaces are modified/added to use the new structure RawIconPngData, and call AppService interfaces to decode/encode the icon. The ARC side CL number is 12024464, which has use the new OnTaskDescriptionUpdated interface. And we can't call both the new and old task update interfaces, that could cause updating twice for the icon on the windows, so we have to select 1(the new one) to use in the code. Once the ARC side CL is submitted, the change on the Chromium side will be change to use the new interface as soon as possible. TODO: Add some test cases for adaptive icons and implement the new interfaces for FakeAppInstance. Note: Below 2 files will be deleted soon. They are modified to pass the build: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc BUG=1083331 Change-Id: I8daaa1643dd20c6038d685863c8f6e71c3948c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251600Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4d60f807dbd..bb61fe324575 2020-07-07 jvanverth@google.com Hoist up submit for resolves 2020-07-07 brianosman@google.com Always use Skia's Vulkan headers when compiling particles module 2020-07-07 jvanverth@google.com Add D3D support for MSAA 2020-07-07 brianosman@google.com Remove GrCoordTransform entirely 2020-07-07 johnstiles@google.com Add support for an inputFP in SkMixerColorFilter::asFragmentProcessor. 2020-07-07 herb@google.com use SkTInternalLList in SubRun 2020-07-07 johnstiles@google.com Update GrConfigConversionEffect to use an input FP. 2020-07-07 herb@google.com consolidate text op creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I965c7f981b5233a59460d54d3c206a1d372b5320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786070}
-
Jeffrey Cohen authored
Bug: 1093374 Change-Id: Ifbce5ef6720b7bc449167ab2a3b5471d20625596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283925Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786069}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I083906f5cb2f899814511707a639da591a711182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285177Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786068}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/de4aedaec33c..a1cee8dc919d $ git log de4aedaec..a1cee8dc9 --date=short --no-merges --format='%ad %ae %s' 2020-07-06 marpan vp9: Update last_q for dropped frames 2020-07-06 marpan vp9: Fix to use last_q for resize check 2020-06-30 bsreerenj vp9-svc: Fix the bitrate control for spatial svc 2020-06-29 jzern add CONTRIBUTING.md 2020-06-24 jinbo-hf vp8,vpx_dsp:[loongson] fix specification of instruction name Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I878d5932fb02f144392739671ac67750eddb8755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285163Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#786067}
-
- 07 Jul, 2020 13 commits
-
-
Jonah Chin authored
The goal is to remove GetSkImage() from PaintImage since when texture backed, this API may incur the cost of a GPU to CPU readback. By using GetSkImageInfo() for image metadata, we can avoid expensive calls to GetSkImage(). This change replaces some of the remaining callers of GetSkImage(). More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: Id7b3d8e779784d9790a43b922f4470234b17795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242653 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786066}
-
Oriol Brufau authored
This patch fixes legacy list markers so that they are autosized even if their 'content' property is set to something different than 'normal'. Bug: 457718 TEST=fast/text-autosizing/list-marker-numbered-with-content-and-autosizing.html Change-Id: I32360a2868b41cfd4d055b3b7efcd73fb9b5adee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258732 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786065}
-
Anupam Snigdha authored
This change fixes the issue on touch devices where the narrator sets focus into an editable element and expect the VK to come up on double tap. Here the touch/gesture events are handled by the narrator and thus the events are not delivered to Chromium. This results in a pointer type as "unknown" in |RenderWidgetHostViewAura| so it fails the check where we decide to call the system API to display the VK. Here if we are getting a text input state update which is of type something other than none, there is a focused accessibility node, and |show_ime_if_needed| flag is set, then we can call the system API to show the VK. Bug: 1100390 Change-Id: I4c13474b4b4655f506429a724b3648efb81fec74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274865Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786064}
-
Chris Harrelson authored
Since fixed and sticky positioned elements are always composited, this will be correct. This removes one dependency on compositing state. Bug: 1100711 Change-Id: I310b25cff1dd7ead16e6fa4b95e12ed7a3de255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280588 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786063}
-
Sharon Yang authored
Add a check to make sure the content directory handle list size doesn't exceed the 16 bit handle-id space. Test: web_engine_unittests Bug: 1073176 Change-Id: I0a90f5bcca35a3c0e29e605bda9c6439092d3d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283556 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786062}
-
Xing Liu authored
This CL adds a wrapper of DownloadLaterDialogCoordinator, and use it to implement the change button flow in download home. Bug: 1102230,1078454 Change-Id: I16d3499ad3b491b50fbde2e0f88dfe80a3623fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281091 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#786061}
-
Clark DuVall authored
This also ended up touching some of //device/bluetooth. Bug: 834319, 1007786 Change-Id: Iebcf042a74af77d3aac2cce8afb4fc4d2af9d831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285450 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786060}
-
Marijn Kruisselbrink authored
https://github.com/WICG/native-file-system/issues/194 suggests there might be something weird going here, so add assertions to the tests to make sure locked has the value we expect it to have. Change-Id: Ia13251aeeb16734047a2f5abe7e61d7fd4bbeb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285293 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786059}
-
Ted Choc authored
For simple boolean equality checks, this converts those to the Callable<Boolean> syntax, for all other checks, these are converted to Criteria.checkThat(...); BUG=1071247 Change-Id: I87aa7296e3c71d7ad0c7eb26c20109a1e788e91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285255Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786058}
-
Carlos Knippschild authored
Changes to other AndroidX libraries where generated automatically by the fetch_all.py script. Bug: 1102962 Change-Id: I1cbb8b28d24d64ff4620659987b6e92a6a66af19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283413Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786057}
-
Evan Stade authored
in /chrome/android/feed This CL was uploaded by git cl split. R=harringtond@chromium.org Bug: 1071603 Change-Id: I0297bc1e20b546cf42085c766c00e8448c2a6b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285492 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#786056}
-
Lijin Shen authored
On partner foldable phones, when the secondary display is off, there is only one targetable displays and only #onDisplayChanged is called. This CL tries to merge tabs #onDisplayChanged as well. Bug: 1088202 Change-Id: Id21960b40bceb4b04fce7a2718c0e33bee0f4920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272131Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#786055}
-
Mark Pearson authored
This is pushed back to the same date as the other copy/copy histograms in https://chromium-review.googlesource.com/c/chromium/src/+/2276218 Bug: 1102476 Change-Id: I4dfb295ca08eb1c3310c12e2ff56a6623b01b3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285175 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#786054}
-