- 08 Jun, 2018 40 commits
-
-
Ken Rockot authored
As a replacement for the EDK peer connection API, this CL adds a notion of isolated Mojo invitations by supporting a new flag on MojoSendInvitation and MojoAcceptInvitation. Isolated invitations allow two processes to communicate via Mojo without joining each others' process graph. A follow-up change will convert all uses of PeerConnection to the new API. Bug: 844763 Change-Id: I5966f83c4077da28bce8b2b3224d4f4efe9a4c3d Reviewed-on: https://chromium-review.googlesource.com/1090233 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565595}
-
Friedrich Horschig authored
This reverts commit 1eea870b. Reason for revert: Consistent failures on Mac10.10 Tests in BrowserWindowTouchBarUnitTest.BackForwardCommandUpdate BrowserWindowTouchBarUnitTest.TouchBarItems BrowserWindowTouchBarUnitTest.ReloadOrStopTouchBarIte since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32927 which introduced this change. Original change's description: > Remove Cocoa Dependency from BrowserWindowTouchBar > > To make the BrowserWindowTouchBar available to MacViews, > modify the class so that it no longer depends on Cocoa > code to receive updates for the touch bar item states. > > This CL converts BookmarkTabHelperDelegate to > BookmarkTabHelperObserver so that BrowserWindowTouchBar > can observe the current web contents for starred changes. > > Overview CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1086867 > > Bug: 841714 > Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9 > Reviewed-on: https://chromium-review.googlesource.com/1090315 > Commit-Queue: Sarah Chan <spqchan@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565570} TBR=ellyjones@chromium.org,spqchan@chromium.org Change-Id: Ib94fb94b70fbbd103ea73c570577e728e4e96b2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841714 Reviewed-on: https://chromium-review.googlesource.com/1092538Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565594}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Fix new usages introduced after https://crrev.com/c/1085459. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I39d3cb4d63a2df8918fe5640231209916544ec31 Reviewed-on: https://chromium-review.googlesource.com/1090911Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565593}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Change-Id: I29af785c8768b5d738ed80aff0724f0d71df5434 Reviewed-on: https://chromium-review.googlesource.com/1090913Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565592}
-
Philipp Hancke authored
adds a pc.close() to all RTCPeerConnections in promise_test and async_test. This is codemod-powered by this: https://github.com/fippo/webrtc-codemods/blob/e844b2467cbb76a231c113366b2451cf248f53bc/wpt-rtcpeerconnection-no-helpers BUG=836871 Change-Id: Iee84ef938bf477a55612b6012c6de464c6aea55b Reviewed-on: https://chromium-review.googlesource.com/1049983 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#565591}
-
Sasha Morrissey authored
Create TestEntryCapabilities and store it in TestEntryInfo, which will store the capabilities for a file or folder entry. This is pre-work to support capabilities in browser tests. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9708217333bdd775b6e75b94697b6002db244aca Reviewed-on: https://chromium-review.googlesource.com/1081771 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#565590}
-
Michael Lippautz authored
Bug: chromium:840789 Change-Id: I03c307038cb5c2a6bdea1d821e347128e5368125 Reviewed-on: https://chromium-review.googlesource.com/1092216 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565589}
-
Hitoshi Yoshida authored
The way to handle '_' in identifier is described Web IDL spec. We don't need a confusing comment as if it comes from our IDL compiler implementation. https://heycam.github.io/webidl/#idl-names Bug: 820353 Change-Id: Iba6c851daa6ae0dc6d690b220a5c757d507e4dc7 Reviewed-on: https://chromium-review.googlesource.com/1092217Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#565588}
-
Dominic Battre authored
This CL enables the PasswordRequirementsSpecFetcherImpl to deal with interleaved requests: For example during browser startup there may be may lookups to the same destination that are triggered before the server can respond. This CL ensures that only one request is sent per destination. Bug: 846694 Change-Id: If1a8df39b2f32945f7fb6eb24374d0db2f1de8e9 Reviewed-on: https://chromium-review.googlesource.com/1090715 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#565587}
-
Olivier Robin authored
Starting main controller creates some WebStateListObservers. Overriding tab models after that will randomly crash as some observer keep a zombie version of the webStateList. Reverse the order of these steps in URLOpenerUnittests Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida7fe67d39ee9724a9946eea8220ea4f7a21cf21 Reviewed-on: https://chromium-review.googlesource.com/1090849 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#565586}
-
Ramin Halavati authored
win-annotator-rel is failing as it cannot build all of the build targets for network traffic annotation tests on Windows. The set is reduced to Chrome binary and will be increased later to cover all required targets. Bug: 844014 Change-Id: I9826e977717ec3789e1bab68eb8e0310c9359827 TBR: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1090927Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#565585}
-
Colin Blundell authored
One of IdentityProvider's clients' use cases is to fetch access tokens for the active account. IdentityProvider currently provides no explicit mechanism for this, instead letting clients directly interact with the underlying OAuth2TokenService instance via GetTokenService(). However, it's necessary to decouple IdentityProvider from OAuth2TokenService at an interface level in order to allow for porting ProfileIdentityProvider to be backed by IdentityManager. This CL adds an explicit interface for clients of IdentityProvider to request access tokens for the active account. This interface is currently implemented directly in IdentityProvider itself, as it is common to ProfileIdentityProvider and DeviceIdentityProvider. Before porting ProfileIdentityProvider to be backed by IdentityManager we will move this implementation out into those two derived classes, temporarily duplicating it. However, we will only do that when we are just at the point of porting ProfileIdentityProvider away from using ProfileOAuth2TokenService. Bug: 809452 Change-Id: I402af0cb19b5e0057edc3870ca2a8f564f4f8e10 Reviewed-on: https://chromium-review.googlesource.com/1089051Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#565584}
-
Friedrich Horschig authored
This reverts commit 6a0b1fb9. Reason for revert: Is it possible that with this fix an unconditional initialization became an occasional uninitialized use? Details: Consistent failues on Linux ChromiumOS MSan Tests of Service/GLES2DecoderTest.CreateAbstractTexture since the first build with this CL: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7503 FindIt also suspected this CL to be the cause with 91% chance. Original change's description: > Fixed |service_id| for validating decoder's AbstractTextures. > > For some reason, we were setting the service ID to 1 unconditionally > when creating an AbstractTexture in the validating decoder. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I809e1aa2c23d6bebe999dae7abd70eb4cbfba719 > Reviewed-on: https://chromium-review.googlesource.com/1091647 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565483} TBR=liberato@chromium.org,piman@chromium.org Change-Id: I3675c3b89959cc2799a5123c6a6173f64d0c70ad No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1092570Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565583}
-
Yves Gerey authored
*-dbg packages are deprecated in favor of *-dbgsym (cf https://wiki.debian.org/AutomaticDebugPackages) Some *-dbg packages may have conflicting version requirements, which would cause the script to abort. That's another good reason to favor -dbgsym version. R=dpranke@chromium.org the fix to all libraries via refactorization (50 lines saved). BTW, this leads to more debug-symbols packages to be detected and installed. NB: it has already been fixed for libglib2 and libpixman, but this extends Change-Id: I13f252b05ab95fb17eb8851d3b5a2b1b7a7d6295 Reviewed-on: https://chromium-review.googlesource.com/1080607Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#565582}
-
Matthew Cary authored
This extends VideoFrame to be able to use the new shared memory API. It does not remove support for the legacy API, so that clients can be migrated individually. Bug: 849207 Change-Id: Ibd80588c57bf65143dd249edd8d2b4ef620c9132 Reviewed-on: https://chromium-review.googlesource.com/1084485Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#565581}
-
Mirko Bonadei authored
We recently discovered DCHECK errors when WebRTC was rolling into Chromium, but they should have been caught by the chromium.webrtc.fyi waterfall. Using dcheck_always_on in chromium.webrtc.fyi seems a good idea to reduce this kind of failures. Bug: None Change-Id: Ibab78987f83cbacf2583c2a081b28082171c105b Reviewed-on: https://chromium-review.googlesource.com/1065733 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#565580}
-
Wez authored
This is required to allow us to roll to a Fuchsia SDK revision with the new paths, update Chromium dependencies, and then this extra path will be removed. TBR: sergeyu Change-Id: Ib4c7b8f874a8fdc5bbac85f0cd7c06e505002829 Reviewed-on: https://chromium-review.googlesource.com/1092312Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565579}
-
Rune Lillesveen authored
Change-Id: Iabd0565de1e044290a444e734a6d79ccb1c20faa Reviewed-on: https://chromium-review.googlesource.com/1092490Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#565578}
-
Yunfan Chen authored
This change overrides the bounds change reason to be snapped over drag_move. Otherwise, when drag a window into snapped mode, the drag to reposition reason will override the snap reason for bound change. The server will then send the incorrect reason to ARC++ side. With this change, ARC++ N and P will correctly turn into snapped mode when drag a window to side. Bug: 848626 Change-Id: I0174ea36166ad378f2ba6d935d3ab32b5ece98ae Reviewed-on: https://chromium-review.googlesource.com/1084574 Commit-Queue: Yunfan Chen <yunfanc@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#565577}
-
Friedrich Horschig authored
This reverts commit 738c6fa6. Reason for revert: Failed Linux Chromium OS ASan LSan Tests (1) every time since being enabled. First bad build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27807 Original change's description: > Enable NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks on ChromeOS. > > The test failed because rendering the NTP was blocked on loading > machine statistics, which was done from a TaskPriority::BACKGROUND > task. The priority of that task was changed to > TaskPriority::USER_BLOCKING in > https://chromium-review.googlesource.com/c/chromium/src/+/1082608, so > the test can be enabled. > > The test is still disabled when Mash is enabled, because the > non-empty paint signal isn't fired in this case (even when background > tasks aren't disabled). > > Bug: 831835 > Change-Id: Ie847b152b057883f62bef060c6294a427980c838 > Reviewed-on: https://chromium-review.googlesource.com/1082609 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565421} TBR=avi@chromium.org,fdoray@chromium.org Change-Id: I7f045845726b0075c639f4708ff183a741d60a1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831835 Reviewed-on: https://chromium-review.googlesource.com/1092530Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565576}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c06e11..e4d73cb git log 1c06e11..e4d73cb --date=short --no-merges --format='%ad %ae %s' 2018-06-08 rharrison@chromium.org Update comments in SUPPRESSIONS for xfa_specific Created with: gclient setdep -r src/third_party/pdfium@e4d73cb The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibb595c2cec9bf8824aa3c1b93f43e67fa9fe0989 Reviewed-on: https://chromium-review.googlesource.com/1092100Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565575}
-
Maksim Sisov authored
Make sure forward declaration is not used to just avoid declaring dependencies in the common/BUILD.gn. That is, DrmDevice is a drm platform's class, which shouldn't be known by the ozone/common. To fix this, return GbmDeviceLinux instead and add AsGbmDeviceLinux method to the DrmDevice class to return downcasted pointer to self, and move ScanoutBufferGenerator to drm/gpu as long as it's not needed by the Wayland with dmabuf approach at this stage. Bug: 820047 Change-Id: I25703db41234275e0c0cb5aaefe0e61964a50e83 Reviewed-on: https://chromium-review.googlesource.com/1088690Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#565574}
-
Hitoshi Yoshida authored
Web IDL spec allows hyphen since August 2014. https://heycam.github.io/webidl/#idl-grammar This CL follows the update. Bug: None Change-Id: I695eed71417b524755b980f3efed5107bc7d29bf Reviewed-on: https://chromium-review.googlesource.com/1092219Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#565573}
-
Xiaohan Wang authored
These tests are flaky on this bot. Disable them for now so that we do not block the CQ. Bug: 793426 Test: Disable tests Change-Id: I12cd105bd2c57a44156a04e33f1a456f4492a996 Reviewed-on: https://chromium-review.googlesource.com/1092311Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565572}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d993e197..739f5abc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7260a9a26406022cdfd1e4c0908da26996e391f3 Reviewed-on: https://chromium-review.googlesource.com/1091952Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#565571}
-
spqchan authored
To make the BrowserWindowTouchBar available to MacViews, modify the class so that it no longer depends on Cocoa code to receive updates for the touch bar item states. This CL converts BookmarkTabHelperDelegate to BookmarkTabHelperObserver so that BrowserWindowTouchBar can observe the current web contents for starred changes. Overview CL: https://chromium-review.googlesource.com/c/chromium/src/+/1086867 Bug: 841714 Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9 Reviewed-on: https://chromium-review.googlesource.com/1090315 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565570}
-
Lei Zhang authored
Change-Id: I022e4dcfa9bf34de7c48241f3c2e225b6b15c7dc Reviewed-on: https://chromium-review.googlesource.com/1087517 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565569}
-
Sasha Morrissey authored
Add OWNERS in file://ui/file_manager/OWNERS to drive_internals page, since this is mainly used for debugging issues with the Drive Sync engine which is primarly used by the file manager. Bug: 845065 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iff904ccc44c163621f620fa930e838697f4f8f1e Reviewed-on: https://chromium-review.googlesource.com/1075837Reviewed-by:
Satoru Takabayashi <satorux@google.com> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#565568}
-
sangwoo.ko authored
When dragging ends, an animation for tabs runs. If ideal bounds for tabs changes when the animation is running, We should restart animation with newly calculated bounds. Bug: 848016 Change-Id: I1b5fff8d3bcd02fbe2d39f847c77e9c5df3c01c2 Reviewed-on: https://chromium-review.googlesource.com/1084521 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565567}
-
Pavel Feldman authored
Change-Id: I4af521482afdd48a2ca1c1f07496e38a297f7770 Reviewed-on: https://chromium-review.googlesource.com/1092104Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565566}
-
Lei Zhang authored
They have no overrides. Change-Id: I8bb69c0a0d09f45d29db480d23f665fad6c02a4f Reviewed-on: https://chromium-review.googlesource.com/1090232 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565565}
-
Bence Béky authored
Do not fail gracefully in WebSocketStreamRequestImpl::PerformUpgrade(). This reverts https://crrev.com/c/1070327, which was only landed so that crash is temporarily suppressed on Beta and Stable. This CL will cause crashes in WebSocketStreamRequestImpl::PerformUpgrade() or in other places, which then can be investigated by the usual means (peppering more CHECKs in the code, code inspections, etc.) and the underlying cause can be solved. Bug: 850183 Change-Id: I7b7b8a1d1b37d0881cc68bfac278c45f38bbaae8 Reviewed-on: https://chromium-review.googlesource.com/1091134 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#565564}
-
Keishi Hattori authored
Calling CompleteSweep from SetGCState can cause confusion as to when a lazy sweep finishes. Refactors CompleteSweep out of SetGCState and moves it to its callers. Change-Id: I0512c642da92800f07a0b8eab9abb0a2668a51aa Reviewed-on: https://chromium-review.googlesource.com/1090526 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565563}
-
Yoichi Osato authored
This patch rewrites the layout test with selection_test inside contenteditable. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iff922bbff0dd0835a9e648c32a1ef6b67e404660 Reviewed-on: https://chromium-review.googlesource.com/1086822 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565562}
-
Amos Lim authored
Group overrides and match function definitions and declartions order. Change QueryPolicy to take an int argument instead of a net::CertStatus. Bug: 840045 Change-Id: I6aa960015ffc2f81ab73957c2e14451143e6f8df Reviewed-on: https://chromium-review.googlesource.com/1065955Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#565561}
-
Amos Lim authored
This CL moves the audio-specific files from //content/renderer/media to //content/renderer/media/audio. No new code, just moving files. $ mkdir audio $ git mv audio_* audio $ git mv mock_audio_* audio $ git mv mojo_audio_* audio $ tools/git/mass-rename.py NOPRESUBMIT=true Bug: 739232 Change-Id: Ifadc4b5c0b2b4518405112d47614832684b8b7a8 Reviewed-on: https://chromium-review.googlesource.com/1036824 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#565560}
-
Sadrul Habib Chowdhury authored
Only SCROLL_UPDATE and FIRST_SCROLL_UPDATE components currently have non-zero component ids. However, these component-ids are never used for any purpose. So use zero as the component-id for these components. This allows for the following cleanups: . RenderWidgetHostLatencyTracker no longer needs latency_component_id_. . Rename RenderWidgetHostImpl::GetLatencyComponentId() to a clearer name: GetFrameSinkIdForSnapshot(). BUG=849729 Change-Id: I7fea87d5cf1b06c580b6738816ffeb893063b1fb Reviewed-on: https://chromium-review.googlesource.com/1089715 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#565559}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ic4063923607a16b369741c1cb43fcdc1aad583d9 Reviewed-on: https://chromium-review.googlesource.com/1092430Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#565558}
-
Michael Lippautz authored
Bug: chromium:840789 Change-Id: Ic73ce15ac2057d4ed6fec89d3fc74c8bf32909ae Reviewed-on: https://chromium-review.googlesource.com/1092210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565557}
-
Stefan Zager authored
Prior to this patch, a rect-based hit test took as parameters a center point and four padding values for top, right, bottom, and left padding. Theoretically, a rect-based hit test might have asymmetric padding, but in practice, this never happens in the code (i.e., it's always true that top-padding == bottom-padding and left-padding == right-padding). Additionally, point-based hit tests used the same call path as rect-based hit tests (with zero padding), which made the code hard to follow. Finally, there was a bug in the rect-based hit test implementation: point-based hit tests always create a one-pixel rect with the hit test point at top left and width=height=1. Because rect-based hit tests used the same code path, the hit test rect was always erroneously expanded by one pixel to the right and one pixel down. This patch makes an explicit distinction between point-based and rect-based hit tests; it gets rid of center-point-and-padding in favor of a simple rect; and it fixes the one-pixel-padding bug. BUG=827639 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I11e49da328080c03da2e1662cbcc0317ab409740 Reviewed-on: https://chromium-review.googlesource.com/1081331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#565556}
-