- 27 Aug, 2019 40 commits
-
-
Jacques Chen authored
-Change protocol.json to be Brotli compressed by grit -Have protocol.json be decompressed by GetDataResourceBytes -Remove brotli.gni that is no longer used Bug: 826858 Change-Id: I2c49715f85508f494a57d65b09ada446c2efefec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728183 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690865}
-
Maggie Chen authored
Some of the functions are allowed to run only on the watchdog thread or the watched GPU thread. DCHECKs are added to these functions to make sure multi-threading is running correctly. For those functions that can run on any threads, no DCHECK is added. Bug: 949839 Change-Id: If451934db201d8544a427c007995900361663768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773436Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690864}
-
Wei Li authored
Since we fetch survey content from a remote server, we have to handle situations such as no internet or slow connections etc. To work around all such problems, this CL creates the web dialog and preload the survey content before showing user the bubble banner. We only show the bubble banner after we already retrieve the survey content. The pros of this approach include 1) avoid handling offline and slow loading scenarios; 2) fast UI -- the dialog will immediately show up once user consents. BUG=979530,996542 Change-Id: I7163c1fd06a479460d4705458c880f5e17ce1b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745710 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#690863}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c81d94fa362..14a9be448e01 git log 5c81d94fa362..14a9be448e01 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 ianelliott@google.com Vulkan: Enable the official GLES1 conformance tests 2019-08-27 geofflang@chromium.org GL: Check for errors around GL calls. Created with: gclient setdep -r src/third_party/angle@14a9be448e01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ifda512ef345a5fa008d2bc83cf834b0971dec55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690862}
-
Caleb Rouleau authored
R=charliea@chromium.org, hypan@google.com, perezju@chromium.org, rmhasan@google.com Change-Id: I24aef52de209c1c482c7bfb16f86f2d1b0facd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769541 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#690861}
-
Kurt Catti-Schmidt authored
The crash for this bug is in ui::AXPlatformNodeBase::GetData, however the actual issue is that the node is nullptr due to it being out of range from the parent nodes children array. I traced this back to the parent's cached unignored child count being incorrect. This happens when node_id_to_clear is set - the node is cleared, but the parent's unignored cached values are not cleared. This change simply adds logic to add the parent node to the list of nodes to update their unignored cache. This logic is identical to what happens when the ignored state changes a few lines below. Bug: 974435 Change-Id: I5392eff3cd31900739bff1f40a31edf7d84e9882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769109 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#690860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44bd29a3b068..70768f4a8e10 git log 44bd29a3b068..70768f4a8e10 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 sprang@webrtc.org Remove usage of StorageType enum Created with: gclient setdep -r src/third_party/webrtc@70768f4a8e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If4447a9addb65ade6398738d72babe5b0c99b62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773445Reviewed-by:
-
Kevin Ellis authored
This memory leak should have been caught by WPT tests for getAnimations but these tests are currently broken. Next step, fix getAnimations tests or add equivalent tests to ensure that this memory leak does not reappear. Bug: 997076, 996640 Change-Id: I0ed5e7c4ceea8d8629c16ecf72d80c3ee598742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773536Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#690858}
-
Adam Langley authored
By using vector/span<uint8_t> APIs (rather than std::string-based APIs) for encryption and decryption, we can save some copies when processing caBLE messages. Change-Id: Ib4cff22b0825ed1658d870474b9a02e9603ca69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756950 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#690857}
-
Eric Orth authored
Various cleanups to simplify things in preparation to convert config-change listening to SystemDnsConfigChangeNotifier: *Now that we always have a DnsClient from the start, as long as defined(ENABLE_BUILT_IN_DNS), moved a bunch of DnsClient-specific properties including ownership of the DnsConfig and overrides into DnsClient itself. Figure anything we can move out of the overcomplicated HostResolverManager is an improvement. *Removed assumptions that NetworkChangeNotifier would hold a base config, mostly only reading from NCN on change notifications or on init (essentially the times SystemDnsConfigChangeNotifier will give the manager a config). *Removed a bunch of unnecessary abstractions for updating and reading configuration and secondary state based on the configuration. Most of these have become less necessary and more overcomplicated in all the recent code churn. More code now more directly updates or reads config as necessary. *Removed some test methods for reading/modifying config now that testing code can always interact with a mocked DnsClient or soon SystemDnsConfigChangeNotifier. Bug: 971411 Change-Id: Ia74580c40c6b399da2ab848a4b05854f5f232e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742305 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690856}
-
enne authored
This reverts commit 3cd3ad22. Reason for revert: causes black squares on ui layers that lie about opaqueness Original change's description: > cc: don't allow transparent quads for opaque layers > > This is a DCHECK + workaround for issue 988590. > > https://chromium-review.googlesource.com/c/chromium/src/+/1749703 > solves root of the problem, and will avoid this DCHECK for > this particular content. > > Bug: 988590 > Change-Id: I0e66ba388c11bbc3805ead42343d7fe7af7a79da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752873 > Commit-Queue: enne <enne@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689250} TBR=enne@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988590,997583 Change-Id: Id5cb90d22b3b5bf070a8223d90a5fa30f958f12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773207Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690855}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c445c7d5c87b..674ee74e88d7 git log c445c7d5c87b..674ee74e88d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 egdaniel@google.com Make sure we use clear load op on GrOpsTask as often as possible. 2019-08-27 michaelludwig@google.com Fix subset errors in blur, matrix, and morphology filters 2019-08-27 senorblanco@chromium.org Dawn: use Skia's copy of vulkan headers. 2019-08-27 senorblanco@chromium.org Add spirv-cross to DEPS. Created with: gclient setdep -r src/third_party/skia@674ee74e88d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I60516dbc444f7e86d1f0ab4812af671bdb54567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771663Reviewed-by:
-
Morten Stenshorne authored
This switches the column balancing pass over to being block fragmented, so that we get the contents split into content runs, separated by forced breaks only. Previously we pretended that we weren't fragmented. This CL shouldn't affect correctness, but it will improve performance when there are forced breaks, as a taller initial balanced block-size will result in fewer layout passes. Added another unit test anyway, just to improve coverage (it also passed without this CL). The new perf test changes from 7 runs per second to 240 runs per second with this CL (when LayoutNGBlockFragmentation is enabled). The logic is mostly taken from ColumnBalancer in the legacy layout engine. Because of this change, we'll now detect when we're in a nested fragmentation context also when balancing, and therefore bail and fail another nested column balancing tests. We don't support column balancing in a nested fragmentation context yet. Bug: 829028 Change-Id: Ibc65feb6da01d8d99de5b38eaf787633a5153cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771957 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#690853}
-
Marijn Kruisselbrink authored
The test often times out on the waterfall. Tbr: chcunningham@chromium.org Change-Id: I47cc2c795f0ff4163e952d1cce971388b7a67760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773524Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690852}
-
Sophie Yang authored
This change replaces all of the text navigation actions on the main menu with the ‘Move cursor’ action. When ‘Move cursor’ is selected, a submenu is opened with all of the text navigation actions. Test: With emulated Chrome OS on Linux and both the Switch Access and improved text input command line flags enabled (--enable-experimental-accessibility-switch-access and --enable-experimental-accessibility-switch-access-text), manually verified that when the ‘Move cursor’ action is selected in the main menu for an editable text node, the main menu is replaced in the panel by the text navigation submenu. When the back button is selected while in the text navigation submenu, the submenu is replaced in the panel by the main menu, and when the back button is selected while in the main menu, the menu exits and the panel disappears. See go/cros-switch-menu-redesign for more information. Bug: 994256 Change-Id: I4e0a4f45c082d40b164f13ca56ca5de0067181ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772301Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Sophie Yang <sophyang@google.com> Cr-Commit-Position: refs/heads/master@{#690851}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1c6c1a6. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iecad6b387f7942ab92371625a9e80533e2f5e3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772087Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690850}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ad424d601e2..db16ee85fb52 git log 7ad424d601e2..db16ee85fb52 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 malets@yandex-team.ru Wrap results.output_dir in os.path.realpath() in json_3_output_formatter.ResultsAsDict. Created with: gclient setdep -r src/third_party/catapult@db16ee85fb52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:996105 Change-Id: I07ee94eb281e13f5f30c2fb5c477a747f278e7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773443Reviewed-by:
-
Thomas Guilbert authored
This CL allows the Renderer process to request a LearningTaskController from the Browser process. The MediaMetricsProvider is used as a bridge between the Renderer and the Browser process. It binds the incoming mojo request to a MojoLearningTaskControllerService. The service in turn forwards calls to a LTC owned by the appropriate BrowserContext's LearningSession. Bug: 994831 Change-Id: Ib2e3e35500da858688de0d49f3989968730b86ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764791Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#690848}
-
Erik Chen authored
Change-Id: I619dda7a91016698a4d3f0b5a3bbda00decf781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772088 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690847}
-
Piotr Bialecki authored
Minor refactor for too-long variable names, obsolete comment cleanup. Refactor XRPlaneSpace into XRObjectSpace that can be used by XRPlane and XRAnchor. Refactor allocating TransformationMatrix in XRPlane - it's not necessary to allocate it when it's being updated. Adjust the code to account for the fact that anchor objects can be created in an uninitialized state as the anchor creation API is promise-based and the objects will be surfaced to JS prior to RAF callback that will update them. Surface XRAnchor set from XRFrame (returns same result as XRSession). Both XRAnchor and XRPlane objects internally know their ID (it will be needed for anchor creation). Adjust anchor creation stubs to take XRRigidTransform - XRPose does not have an app-exposed constructor in JS. Bug: 992029 Change-Id: I8313f15b5943535f10da627191a231581a7758ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769697Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#690846}
-
Nick Burris authored
If we parse a TextFragmentAnchor but don't find a match, we should fallback to matching the element anchor, if there is one. Example: https://spaceplace.nasa.gov/blue-sky/en/#similar##targetText=notamatch Bug: 992522 Change-Id: Ie6dd2a4f5b35a612d563a3acb81392df756ce1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746210 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690845}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f4081b4ef9b..73c58302fc9e Created with: gclient setdep -r src-internal@73c58302fc9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7c8f778c63dbd515361fe692a8d182735f57da62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773442Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690844}
-
Nico Weber authored
GN grew a string_replace() function we can use here. No behavior change. Bug: none Change-Id: Ic06e6aa40f4507047bc3cff143af84bc8a99c777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773538Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690843}
-
gogerald authored
Before: https://drive.google.com/file/d/1A89i4BC32cSpzCuhW2jmhQR0OQKa73WO/view?usp=sharing https://drive.google.com/file/d/16jQU90GJZxdKXhG8Vhdzp4U1tELQtJ62/view?usp=sharing After: https://drive.google.com/file/d/17CHZtgW-ygZ7lFcHftGOkjBuWeuwu6Ds/view?usp=sharing https://drive.google.com/file/d/1X8T4OE9e4MlX0CmA7tXKWuc6s6LwbiYI/view?usp=sharing It visually aligns the first Tab in the Tabs carousel with the explore surface cards. It also makes the Tabs carousel use the entire device width when scroll is needed. Screenshots confirmed by UX designer. Bug: 996381 Change-Id: Ic9d65b5eac6f771140b44f0562e3e1e9452f3cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768865 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#690842}
-
liberato@chromium.org authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/0f36d36f4973..d7ba23c23434 $ git log 0f36d36f4..d7ba23c23 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 liberato Fail matroska parsing with an error rather than assert. Created with: roll-dep src/third_party/ffmpeg Bug: 996523 TBR: wolenetz@chromium.org Change-Id: I8f43d0aebfa23d5608333fa5446660cc7ab3bd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773342Reviewed-by:
-
Sophie Chang authored
This will record the last decision made during a navigation for each type and target. Bug: 969558 Change-Id: Ifdfebd7e349e491e52c30aa3190bc4e1d8f3436f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762982 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#690840}
-
Andrei Chulkov authored
The text is usually the most important part of the illustration dialogs. However, the image takes up most of the space in landscape or multi-window mode, making it impossible to read the text on many devices. This CL implements hiding the illustration in cases where there isn't enough vertical space to show it. Bug: 983445 Change-Id: I990d1beb2d89bedd9b0d135a8de614de471a1a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761601 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#690839}
-
Regan Hsu authored
Change-Id: I8065f48aefce80816914aa7b73f219a9e2eead6e Bug: 987659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773444Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690838}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: Iea605992b365560bc44a1527251f04a981cce123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772546Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690837}
-
chrome://bookmarksHector Carmona authored
Screenshots in bug. Bug: 910412 Change-Id: I89b3355c430a911f4f4fa7691c815846e3fd65e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761522 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#690836}
-
Lev Rumyantsev authored
Bug: None Test: None Change-Id: Ife43b9b735044d9eabde1ca5574d252c919f5691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768828Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Simplifies tab restore by copying from NoTouchActivity, which has the same persistence model (currently) as WebappActivity. This also simplifies the stale directory cleanup to only clean up more recent sources of stale directories. This could lead stale directories to stick around when updating from very old versions of Chrome, but these directories should be small regardless. Also deletes some unused webApk UMA constants, and deletes the unused histogram generation code in NoTouchActivity for tab restore. Bug: 525785 Change-Id: I615542e2f28a147ecd5403b04b61b749f3e737ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769313 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#690834}
-
rbpotter authored
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1744521 by dpapad@ Autogenerate Polymer 3 version of cr-icon-button, add closure target, and autogenerate and run its automated tests. Bug: 965770 Change-Id: I060066de84d419379b1cd248d3ea0fa43c2e100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772371Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#690833}
-
Sigurdur Asgeirsson authored
This takes care of GraphImpl as well as BrowserChildProcessWatcher. Additional CLs upcoming for more of the same. Bug: 966840 Change-Id: I1b38f0f941722aeee7f615db5061ce58d0260578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771178 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#690832}
-
Joel Hockey authored
Bug: 998192 Change-Id: Ia123dfe2a2ba1fcad117de3aab540806b1d0d1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772940 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#690831}
-
Antonio Rivera authored
Currently there are two nearly-identical declarations/definitions of MonotonicClockNow: one in MediaPipelineBackendForMixer, and one in internal chromecast code. With this change, we can use the same function for both use cases to avoid repeated code. Test: cast_audio_backend_unittests pass Bug: b/139928913 Change-Id: Ibe2216b92a0a8f6529297c7ffe35220cad871046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771053Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Antonio Rivera <antoniori@google.com> Auto-Submit: Antonio Rivera <antoniori@google.com> Cr-Commit-Position: refs/heads/master@{#690830}
-
Bailey Berro authored
For guest users, don't show the extraneous horizontal separator. Bug: 986246 Change-Id: Ifa1fb57e260cf754c6eb398986175ce1bd4f9122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771051Reviewed-by:
-
Nico Weber authored
Bug: angleproject:3827 Change-Id: Ib8a743d77700db2a91e3f7b4a3bd9f81ebb28f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773184 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#690828}
-
Steven Bennetts authored
Bug: 853953 Change-Id: I25c0b40b23936d8c89790153f97d135780035026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769548 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690827}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/3de7170b31c5..6c73c33b7d8c $ git log 3de7170b3..6c73c33b7 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 renjietang No longer send SETTINGS in gQUIC. 2019-08-26 fayang gfe-relnote: In TLS client handshaker, call OnHandshakeComplete when handshake is finished. Protected by existing FLAGS_quic_supports_tls_handshake. 2019-08-26 bnc Remove VersionUsesQpack() TODO. 2019-08-26 zhongyi Always create and destroy a single client in the creation of the QuicClientTest to ensure persistent sockets for certificate verifiers are opened before testing. 2019-08-26 bnc gfe-relnote: Deprecate gfe2_reloadable_flag_quic_avoid_empty_frame_after_empty_headers. 2019-08-26 fkastenholz Save all data from received IETF Connection Close frames 2019-08-24 ianswett gfe-relnote: Do not enable version 99 unless gfe2_reloadable_flag_quic_use_parse_public_header is also enabled. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I71b64773eb6640f78dba6b43cf864070127998f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772294 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690826}
-
