GitLab

BUG=474876

Review URL: https://codereview.chromium.org/1064393002

Cr-Commit-Position: refs/heads/master@{#324373}

Both cmake310_Linux.tgz and cmake310_Darwin.tgz exist now.
I'll remove the poorly named cmake310.tgz when this has landed.

BUG=452726

Review URL: https://codereview.chromium.org/1073673002

Cr-Commit-Position: refs/heads/master@{#324372}

The header is included for __NR_SYSCALL_BASE and __ARM_NR_BASE.
Some toolchain (in particular, PNaCl toolchain) does not provide
asm/unistd.h (so that neither __NR_SYSCALL_BASE nor __ARM_NR_BASE
is provided).
This CL removes the dependency to asm/unistd.h from linux_syscall_ranges.h,
instead define the values if necessary.

Also, this CL removes the include from syscall.cc, too, which is
unused.

TEST=Ran bots.
BUG=358465

Review URL: https://codereview.chromium.org/1071653002

Cr-Commit-Position: refs/heads/master@{#324371}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a0219f1..35f5576

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1068243004

Cr-Commit-Position: refs/heads/master@{#324370}

This is safe to do because the custom action is only executed if the startup type was already auto at the beginning of the installation.

BUG=472887

Review URL: https://codereview.chromium.org/1071013002

Cr-Commit-Position: refs/heads/master@{#324369}

BUG=473077

Review URL: https://codereview.chromium.org/1072643002

Cr-Commit-Position: refs/heads/master@{#324368}

BUG=474701

Review URL: https://codereview.chromium.org/1078523002

Cr-Commit-Position: refs/heads/master@{#324367}

This is a retry CL for https://codereview.chromium.org/1024583003/ with
a slight change.

UserActivityDetector used to be an EventHandler triggered when the pre-
target event handlers are triggered. When a menu is present, the
MenuEventDispatcher doesn't trigger pre-target handlers and hence user
activity is not detected.
With this change the UserActivityDetector is made a PlatformEventObserver
to make sure it's always triggered.

R=sadrul@chromium.org, jamescook@chromium.org
BUG=462735
TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.*

Review URL: https://codereview.chromium.org/1074543002

Cr-Commit-Position: refs/heads/master@{#324366}

sql::Connection::Delete() covers associated journal files.

BUG=none

Review URL: https://codereview.chromium.org/1064523002

Cr-Commit-Position: refs/heads/master@{#324365}

Symlinks aren't very common on Windows anyway.

BUG=467287

Review URL: https://codereview.chromium.org/1069853004

Cr-Commit-Position: refs/heads/master@{#324364}

Note: You can still launch and test using either --force-immersive command line or by pressing Shift+F11 magic key just after launching chrome through shortcut.

BUG=470227
R=cpu,ananta

Review URL: https://codereview.chromium.org/1015533014

Cr-Commit-Position: refs/heads/master@{#324363}

current NO_RESOURCE_IDENTIFIER usage is aganinst style guidelines.
Made a class in content_settings.h and using function to get std::string()
To get rid of NO_RESOURCE_IDENTIFIER.
Now no need to add content_settings_provider.h in places like
desktop_notification_profile_util.cc and other places.

BUG=399592

Review URL: https://codereview.chromium.org/1034143002

Cr-Commit-Position: refs/heads/master@{#324362}

Running this example is consistently failing under host mac
build and occasionally failing on linux as well.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
BUG=475255

Review URL: https://codereview.chromium.org/1076573004

Cr-Commit-Position: refs/heads/master@{#324361}

Refactored web_app::ShortcutInfo so it is always passed via a scoped_ptr
(always having exactly one owner). This allows it to be safely passed
between threads without having a data race on the favicon image's
reference count.

Removed TSan suppression on ImageFamily.

BUG=364006

Review URL: https://codereview.chromium.org/1038573002

Cr-Commit-Position: refs/heads/master@{#324360}

HSTS/HPKP headers should only be parsed when the host is not an IP
address. This change requires fixing the HSTS/HPKP tests to use
localhost test server URLs instead of 127.0.0.1, with a corresponding
cert.

BUG=456712

Committed: https://crrev.com/8488b5886ccec4820578905acd42f95cf42f5b17
Cr-Commit-Position: refs/heads/master@{#323913}

Review URL: https://codereview.chromium.org/1059303002

Cr-Commit-Position: refs/heads/master@{#324359}

The metrics don't have much to do with prerender. Move them out into a
dedicated file.

BUG=none

Review URL: https://codereview.chromium.org/1051463003

Cr-Commit-Position: refs/heads/master@{#324358}

The java ViewAndroid class was only surving two purposes:

1) Implement content::PowerSaveBlocker with anchor views.
This is only used from content, and is mostly implemented
in content already, so just move the entire implementation
to content PowerSaveBlocker without going through a ui
layer interface.

2) Hold the ViewAndroidDelegate. Just have the native class
hold this object directly instead.

Other required changes:
* Updated to one anchor view per PowerSaveBlocker instead
  one per ContentViewCore and keeping a count.
* PowerSaveBlockerImpl::Delegate is made a
  WebContentsObserver to observer WebContents destruction.
* Removed an instrumentation test that's no longer
  relevant.

BUG=469803

Review URL: https://codereview.chromium.org/1041823004

Cr-Commit-Position: refs/heads/master@{#324357}

In  "cc: Only send a BeginMainFrame inside an BeginImplFrame."
https://codereview.chromium.org/798323003/ a commit can only occur inside an
impl frame - this means BeginFrames are *needed* if we want to commit.

We also want to proactively request BeginFrames if a commit is pending (for
performance), but it is not actually required.

BUG=346230

Review URL: https://codereview.chromium.org/792803008

Cr-Commit-Position: refs/heads/master@{#324356}

BUG=101717

Review URL: https://codereview.chromium.org/1066203003

Cr-Commit-Position: refs/heads/master@{#324355}

Currently, remoting.Clipboard is exposed as a global, such that it can hook
events across different files, e.g. remoting.js, client_plugin_impl.js, application.js

This CL moves clean up the file by:
1. Only create an instance of the clipboard when a session is connected.  This removes
   the startSession() method on the clipboard.
2. Hook all events (copy/paste/focus changes) from within remoting.clipboard, which
   eliminates the need to have a global and effectively makes all its methods private.
3. Style cleanups, use single quotes for strings, make sure private variables are
   post-fixed with underscores.

BUG=475317

Review URL: https://codereview.chromium.org/1078563002

Cr-Commit-Position: refs/heads/master@{#324354}

ShowSigninScreenForCreds is used to automatically fill-in sign-in
forms and submit it. WebviewLoginTest.Basic does that manually
thus should not call it. Otherwise, /_/embedded/signin/challenge
is called multiple times with wrong email (empty) and could trigger
FakeGaia failures.

BUG=472095

Review URL: https://codereview.chromium.org/1069423004

Cr-Commit-Position: refs/heads/master@{#324353}

BUG=441441
TEST=build/android/test_runner.py gtest -s components_unittests --gtest_filter=HistogramManager*

Review URL: https://codereview.chromium.org/1075503002

Cr-Commit-Position: refs/heads/master@{#324352}

Discrete layouts will have a matching channel layout, but may have
any number of channels. We were incorrectly skipping the channel
mixer setup based only on layout.

BUG=473688
TEST=new unittest.

Review URL: https://codereview.chromium.org/1070923002

Cr-Commit-Position: refs/heads/master@{#324351}

BUG=456354

Review URL: https://codereview.chromium.org/1068933003

Cr-Commit-Position: refs/heads/master@{#324350}

Ensure that the Windows system font information and the scrollbar metrics are synced with the ViewMsg_SetRendererPrefs IPC

The patch to sync the font and scrollbar metrics from the browser to the renderer was sending these values only during
RenderView creation and not along with the ViewMsg_SetRendererPrefs IPC which caused scrollbars to disappear and other bad
things.

BUG=474871

Review URL: https://codereview.chromium.org/1069683006

Cr-Commit-Position: refs/heads/master@{#324349}

Also reenabled appcontainer for renderer and fixed policy use after free case.

BUG=468922,473715
R=cpu,jschuh@chromium.org, wfh

Review URL: https://codereview.chromium.org/1058373003

Cr-Commit-Position: refs/heads/master@{#324348}

Remove some redundant number_(0) initializers.

Also, for IndexedDBKey, use number_ for both number and date type
to save memory.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1071683002

Cr-Commit-Position: refs/heads/master@{#324347}

Adding tests for diagonal scrolling to telemetry.

BUG=466867

Review URL: https://codereview.chromium.org/999243003

Cr-Commit-Position: refs/heads/master@{#324346}

BUG=451527
R=mfoltz@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/1040773002

Cr-Commit-Position: refs/heads/master@{#324345}

This patch adds two entreis to rappor.xml for Web Components usage.
Blink CL is at:
https://codereview.chromium.org/986583002/
Chromium CL is at:
https://codereview.chromium.org/1014543003/

BUG=461671

Review URL: https://codereview.chromium.org/1071463003

Cr-Commit-Position: refs/heads/master@{#324344}

The recipes need the ability to parse the test results. Adding
support for the json-results-file option so we can tell what junit
tests failed in the infra recipes.

BUG=

Review URL: https://codereview.chromium.org/1062403004

Cr-Commit-Position: refs/heads/master@{#324343}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b9a14f..b06aa90

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1076513004

Cr-Commit-Position: refs/heads/master@{#324342}

This CL moves cross-process postMessage plumbing from RenderView
to RenderFrame:

- The renderer-to-browser RouteMessageEvent message is now sent
  through RenderFrameProxy rather than a swapped-out RenderView.

- The bulk of WebContentsImpl::RouteMessageEvent is moved into
  RenderFrameProxyHost::RouteMessageEvent.  Unfortunately, we still
  need to call up to WebContents for dealing with <webview> and
  on-demand creation of swapped-out RVs for the opener chain.  This
  will be cleaned up as part of https://crbug.com/225940.

- the browser-to-renderer PostMessageEvent message is now handled in
  RenderFrameImpl::OnPostMessageEvent, instead of RenderViewImpl.

These changes make it possible to send messages between cross-process
subframes when in --site-per-process mode.  This is exercised in a new
test, SitePerProcessBrowserTest.SubframePostMessage.  More work will
be needed to support postMessages involving subframes in cross-process
openers (see https://crbug.com/225940 and https://crbug.com/423587).

With this change, the RFHM::SupportCrossProcessPostMessage test now
works in --site-per-process mode, so it is enabled on the Site
Isolation FYI bots.

BUG=389721
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1046933005

Cr-Commit-Position: refs/heads/master@{#324341}

Adds a colored title area. When the title is set, it will be exposed
with a simple animation.

Including the title in the original html is still supported.

Fixes some issues with margins and line spacing.

Review URL: https://codereview.chromium.org/1060623002

Cr-Commit-Position: refs/heads/master@{#324340}

For details see the STL Breaking Changes (VS14 CTP1) section of:
http://blogs.msdn.com/b/vcblog/archive/2014/06/06/
c-14-stl-features-fixes-and-breaking-changes-in-
visual-studio-14-ctp1.aspx

In particular:
"The Standard has always forbidden containers of const elements...
...elements must be Assignable, which const T isn't."

Error message is:
error C2338: The C++ Standard forbids containers of const
elements because allocator<const T> is ill-formed.

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1066213002

Cr-Commit-Position: refs/heads/master@{#324339}

I noticed while doing some refactoring elsewhere that observer_ was not
being initialized and so early calls to OnDevicesChanged could branch on
an uninitialized value and crash.

Review URL: https://codereview.chromium.org/1075593003

Cr-Commit-Position: refs/heads/master@{#324338}

This not working was preventing certain corruption-testing tests from
being written.

Also modified Does{Table,Index,Column}Exist() to reflect that these
names are _not_ case sensitive.  It is not possible to have distinct
tables [Foo] and [foo].

BUG=none

Review URL: https://codereview.chromium.org/1069313004

Cr-Commit-Position: refs/heads/master@{#324337}

This has the advantage of making cancellation of requests an O(1) operation rather than O(NumRequestsPerJob).

BUG=455366

Review URL: https://codereview.chromium.org/1075563002

Cr-Commit-Position: refs/heads/master@{#324336}

This allows handles created on the exe (or any other module) to be properly tracked.

BUG=472362

Review URL: https://codereview.chromium.org/1045513004

Cr-Commit-Position: refs/heads/master@{#324335}

Clients should now include webrtc/video_frame.h which is the right
header for I420VideoFrame type, i420_video_frame.h is just a pass
through header include.

This should help fix pbos' TODO in the WebRTC repo and allow us to land
https://webrtc-codereview.appspot.com/46819004/.

BUG=None
R=tommi@chromium.org

Review URL: https://codereview.chromium.org/1067823002

Cr-Commit-Position: refs/heads/master@{#324334}