- 03 Feb, 2020 40 commits
-
-
Kenichi Ishibashi authored
The reference was tentatively added to move some code from ServiceWorkerStorage to ServiceWorkerRegistry but it isn't needed any more. Bug: 1039200 Change-Id: I59ac327e120bfd82d87c3c81b95d6da3d629dd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035230 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737715}
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. This CL superseeds the current in-flight CL https://crrev.com/c/2022642 which will be abandoned. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737714}
-
Nazerke authored
This CL modernizes the BadgePopupMenuCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates showcase coordinator for Badge Popup Menu Coordinator. Bug: 1029346 Change-Id: Ib683cdb45452b90412e953a4c9a25495ef2389f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033161Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#737713}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fed0dda178e6..326c900efd28 git log fed0dda178e6..326c900efd28 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bd4b3a888fca..e85fe4c3cc9f (3 commits) 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 79b36b640692..41a7302e9c62 (3 commits) Created with: gclient setdep -r src/third_party/angle@326c900efd28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iac9e6d7bbcf7ddc98031b792ff80a948552ad8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737712}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e6ae2798c52..3610dd0daf0f git log 7e6ae2798c52..3610dd0daf0f --date=short --first-parent --format='%ad %ae %s' 2020-02-03 bmeurer@chromium.org [karma-tests] Add unit tests for StringOutputStream. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3610dd0daf0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ida574cd6f54b514bc0efc91aca1536f6bdc2f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737711}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5bec61a84538f758f48027e76ab428f48f2be953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737710}
-
Owen Min authored
In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock secured flag now check if user has password on Windows. The code behavior matches SecureConnect native host: 291830502 Bug: 1047785 Change-Id: Iffc94d9cf179f85f353b8d245b90f5dd759c4bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031703 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737709}
-
Marc Treib authored
TBR=yaoxia@chromium.org Bug: 1047921 Change-Id: I5883ab91335fb7faa0a7ee45d93b5535b2cca794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033513Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737708}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibead71c45e5608fa4692174a01a84c117834fca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033050 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737707}
-
Kenichi Ishibashi authored
NewResourceId() is going to be asyc and it wouldn't be trivial to use a test util, CreateServiceWorkerRegistrationAndVersion, which runs synchronously. Since users of this util function don't require actual ID assignments, we can make call sites to pass pseudo resource IDs. This CL changes CreateServiceWorkerRegistrationAndVersion() to take a ID instead of using NewResourceId(). Bug: 1046335 Change-Id: I78ed239b652b0ba6ac09ab808566a0d199e8110a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032449 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737706}
-
sandromaggi authored
Our test card expired after January 2020. Bug: 1048074 Change-Id: I65a604154c2eb05c036c85440f51f533f48f1ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033768 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737705}
-
Rune Lillesveen authored
Whether we mark a node for kLocalStyleChange or kSubtreeStyleChange is essential information. Change-Id: I08241b3b319d11d0244bc10f458fb2a47ebf2359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033245 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737704}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64e691680849..0d9543d525ec Created with: gclient setdep -r src-internal@0d9543d525ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie2bcc97cfcd06c2c0d61fda99004e0f509eb1e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737703}
-
Guido Urdaneta authored
This reverts commit 80d89eb4. Reason for revert: The TSAN failure is a more general failure affected lots of test. It's not specific to this test. Once the general problem is fixed, this test should stop flaking. Original change's description: > Disable flaky WebRtcMediaRecorderTest.StartAndDataAvailable on TSAN > > Bug: 1043828 > Change-Id: I41db446ceec894c06b15c40a673f290f8ba2e533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030886 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736876} TBR=guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043828 Change-Id: Ib06dd710488a087ab24c409691107c7c1360dfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033767Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737702}
-
Yuki Shiino authored
As a preparation of https://crrev.com/c/1996111 , relaxes the return type of ScriptWrappable::Wrap from v8::Local<v8::Object> to v8::Local<v8::Value> so that it can return v8::Null in addition to v8::Object. Change-Id: I453c405d62f4deef8bcf3bddcc59aa80a56c46d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032552Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737701}
-
Luciano Pacheco authored
Bug: 992821 Change-Id: I7a4be8b64b4ba410b24e73a00add654d8e91f418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029473 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737700}
-
Guido Urdaneta authored
This reverts commit 3a45f157. Reason for revert: This ASAN/TSAN failure is a more general failure not specific to this test. Re-enabling, since the issue should be fixed when the more general problem is fixed. Original change's description: > Disable flaky WebRtcMediaRecorderTest.ResumeAndDataAvailable on TSAN/ASAN > > Bug: 1045381 > Change-Id: I285a44d32d47522786b1676b708b0723f336295b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031144 > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736883} TBR=guidou@chromium.org,marinaciocea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045381 Change-Id: I02b5189bfbd2bcceb9ad8f01cda5c70b86146ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035370Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737699}
-
Matt Falkenhagen authored
It is failing on the builders. Bug: 1048074 Change-Id: I7c88b0cc43ff5be0229d3d06a7e8e488c75b879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032633Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737698}
-
Kenichi Ishibashi authored
There were three ScheduleDeleteAndStartOver() calls in ServiceWorkerStorage which we couldn't simply move to ServiceWorkerRegistry as these are callbacks of internal operations. This CL replaces these ScheduleDeleteAndStartOver() with Disable() and makes ServiceWorkerRegistry schedule a recovery process when the next public operation is performed (the next operation will fail because the storage is disabled, then the registry tries to recover). This slightly changes the existing behavior but I don't think this change has a real world impact given that the low error rates of storage. Bug: 1039200 Change-Id: Iec112cf6690de4d68c3498282736a5f564924d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034385 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#737697}
-
Kenichi Ishibashi authored
This method puts resource id assignment and response writer creation together so that call sites don't have to assign a resource id explicitly for new resources. See the linked bug for the context of this change. Bug: 1046335 Change-Id: Id8e282ad57af99ce3833cc2285d6b3057ac2da43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032631 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737696}
-
Yuki Shiino authored
Change-Id: Iffccaa069401f150ed6772a94eec0a52693db416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032761Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737695}
-
Yuki Shiino authored
- Turn ArrayBufferView into a built-in type (was a union of all typed arrays) - Remove flattened_member_types_in_original_order (turned out that there was no need to flatten unions) Bug: 839389 Change-Id: I1a6eecf217b1d8021b6e7b5b520500f43c57fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032695Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737694}
-
Luciano Pacheco authored
Resize the icons in the file list from 16x16 to 20x20 and overwrite all icons for new style. Check mark and folder icons use mask-image to follow the font color: Folder has to be the same grey, instead of its black color and check mark has to switch from blue to grey when it doesn't have the focus. When the file list is in the multi-select mode (body.check-select) background and image mask are reset so they aren't visible behind the check mark icon. Bug: 992821 Change-Id: I9314e4b0f93778e046c0fa746a55bfcb8e516340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029558 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737693}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b016536ab1f..6ce875a55578 git log 0b016536ab1f..6ce875a55578 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 dberris@google.com Remove old change-detection algorithm Created with: gclient setdep -r src/third_party/catapult@6ce875a55578 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:922256 Tbr: crouleau@chromium.org Change-Id: Ieaf9fdea60769516f3076dfc9c50ad4c068d7631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737692}
-
Yuki Shiino authored
Change-Id: Ib3a6919256829e10f660317ef0970540e6088e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032653Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737691}
-
Luciano Pacheco authored
Implements layout/sizing, colors (background, font and borders) for rows in the file list. Hide image which was displayed when the folder is empty, as per discussion with our PM. Disable the animation for thumbnail, because during the transition to show the "check select" icon it was showing both check-select icon and the thumbnail, which is visually unpleasant/junky. Reset the font-size for the whole body to 13px as verbally agreed with our designer. Bug: 992821 Change-Id: I02870761dd7a844d6a07a70d2aee792df061acc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026533Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#737690}
-
Simon Zünd authored
The NodeURL web test got ported to Karma in https://crrev.com/c/2030776. This makes the web test obsolete and this CL removes it. R=tvanderlippe@chromium.org Bug: chromium:1032561 Change-Id: Ic9554075599a1ab56b3e50f4a8304dd35ea10148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033148Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49a53d684aff..fed0dda178e6 git log 49a53d684aff..fed0dda178e6 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 cclao@google.com Remove getIndexRange call from ValidateDrawRangeElements Created with: gclient setdep -r src/third_party/angle@fed0dda178e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I2dfcee9a884811435aba126e24374537e0da6e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737688}
-
Jinsuk Kim authored
This CL gives animation (alpha) effect to the 'Open in a New Tab' button on preview tab header when sliding up/down the panel. Bug: 1047889 Change-Id: I28504f8fd89d8cfe67d5523bdd5e2f186000cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032458 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#737687}
-
Jason Lin authored
This CL imposes restrictions on the username in crostini installer to ensure the username conforms with linux convention and does not conflict with other default users. If the username is invalid, an error message will be shown and the install button will be disabled. The CL also adds new browser tests for this feature. Since the flag crostini-username is turned on for all installer browser tests now, existing browser tests are modified to click the "next" button to go into the configuration page before clicking the "install" button. Bug: 1016195 Test: browsertest; manual test with flag crostini-username flag on Change-Id: I546e0c56a3a41defb2de3e224992cebf5824dabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032485 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#737686}
-
Kenichi Ishibashi authored
This CL moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage::DidPurgeUncommittedResourceIds() to ServiceWorkerRegistry so that we can reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. As side-effects, this CL moves DoomUncommittedResource() and adds PurgeResources(set<resource_id>). Bug: 1039200 Change-Id: I711978412b2b4260055e11831d343e14b1288dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032444Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/250c550f9220..64e691680849 Created with: gclient setdep -r src-internal@64e691680849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2e857005e762271f1dd4e1ad76954e670465e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737684}
-
Rachel Sugrono authored
Enclose |cr-dialog-container| in a <dialog> (delete-confirm-dialog) to ensure that tab index always remains within the <cr-dialog>. Also stop keydown event propagation to stop them passing out of the <dialog> for the same reasons. Implement the functions |showModalElement| and |doneCallback| to show and close the <dialog>, respectively. Minor: Change parameter type from HTMLElement to Element on the FilesConfirmDialog interface. Bug: 803259 Change-Id: Iea2482c017804e873e0ab0f23b8d7bfe2ba3ca1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033012 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737683}
-
Patrick Monette authored
The WorkerTaskProvider's responsibility is now to track existing profiles and let the PerProfileWorkerTaskTracker track the running workers and create the tasks. This avoids keeping track of the ServiceWorkerContext that each service worker is associated with. Bug: 1041093 Change-Id: Ie0cd4c7f46c84c2f9a8c96d10afef8440abc63a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994178Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#737682}
-
Nico Weber authored
No behavior change. Bug: 1031169 Change-Id: I1e7f4afcd4fb779d0d0aab5de5a9f2827cb6766e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033365 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737681}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1e316ff39e7..9e8d8c4830c1 git log f1e316ff39e7..9e8d8c4830c1 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e196bc85ac2d..49a53d684aff (18 commits) 2020-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79b36b640692..41a7302e9c62 (3 commits) Created with: gclient setdep -r src/third_party/skia@9e8d8c4830c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ibbe87c717b01c4f827ed07283d69a703ac74b92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035085Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737680}
-
Yuki Shiino authored
This is a reland of c1f6f104 The build failure of release branches (canary, etc.) should be fixed with https://crrev.com/c/2029405 . This is a reland of the original patch with no change. Original change's description: > bind-gen: Build generated IDL enumeration in prod > > Builds the bindings of IDL enumeration generated with the new > bindings generator in prod, despite that the bindings is not > yet used. This patch makes it available for real use. > > Bug: 839389 > Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736356} Bug: 839389 Change-Id: I577dc9e7f2a488585f0c10785fd8fb216df33ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030351Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737679}
-
Hirokazu Honda authored
This introduces VideoDecoder using libgav1 decoder. The VideoDecoder is neither enabled nor compiled by default. Adding enable_libgav1_video_decoder to gn args is needed to compile, and adding --enable-features=Gav1VideoDecoder to chrome option is needed to enable the VideoDecoder on chrome. The performance differences between Dav1dVideoDecoder and Gav1VideoDecoder on kevin are below. 1080p@30 | CPU usage(%) | Drop frame rate(%) Dav1d | 64.0 | 33.7 Gav1 | 60.4 | 39.0 720p@30 | CPU usage(%) | Drop frame rate(%) Dav1d | 40.52 | 0.0 Gav1 | 35.85 | 0.0 720p@60 | CPU usage(%) | Drop frame rate(%) Dav1d | 55.50 | 24.8 Gav1 | 43.7 | 48.45 Bug: 1026522 Test: Play av1 videos on kevin (ChromeOS ARM) and confirmed Libgav1VD was used. Change-Id: I24a83932936f775c364761c88b14c42a29537417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936445 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737678}
-
Takashi Toyoshima authored
The current logic has an exception not to throttle the kHigh priority requests even if the request is marked as kThrottleable. However, this exception makes the per-frame maximum limit useless, and make requests result in failure for hitting the network service resource limit. This patch enforces the normal limit even for the kHigh requests for both throttling policies. But still kHigh requests can escape from the tight throttling. Bug: 1046882 Change-Id: I4e167fdb667f9adc90604fa1d65fc4cd6e650c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028886Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737677}
-
Rachel Sugrono authored
Bug: 803259 Change-Id: Icf222cbcc0712532a58809b2cd327ee20955ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033062Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#737676}
-